c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2025-05-01 14:35:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

libzfs: run_process: don't leak fd on reopen failure

Browse Source 
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12082
This commit is contained in:
наб 2021-05-19 14:32:15 +02:00 committed by Brian Behlendorf
parent 7c20ceebdd
commit 5da6353987
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/libzfs/libzfs_util.c
View File

@ -849,8 +849,10 @@ libzfs_read_stdout_from_fd(int fd, char **lines[])
char **tmp_lines = NULL, **tmp; char **tmp_lines = NULL, **tmp;
fp = fdopen(fd, "r"); fp = fdopen(fd, "r");
if (fp == NULL) if (fp == NULL) {
close(fd);
return (0); return (0);
}
while (getline(&line, &len, fp) != -1) { while (getline(&line, &len, fp) != -1) {
tmp = realloc(tmp_lines, sizeof (*tmp_lines) * (lines_cnt + 1)); tmp = realloc(tmp_lines, sizeof (*tmp_lines) * (lines_cnt + 1));
if (tmp == NULL) { if (tmp == NULL) {