mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-12-25 18:59:33 +03:00
Linux 6.5 compat: replace generic_file_splice_read with filemap_splice_read
The generic_file_splice_read function was removed in Linux 6.5 in favor of filemap_splice_read. Add an autoconf test for filemap_splice_read and use it if it is found as the handler for .splice_read in the file_operations struct. Additionally, ITER_PIPE was removed in 6.5. This change removes the ITER_* macros that OpenZFS doesn't use from being tested in config/kernel-vfs-iov_iter.m4. The removal of ITER_PIPE was causing the test to fail, which also affected the code responsible for setting the .splice_read handler, above. That behavior caused run-time panics on Linux 6.5. Reviewed-by: Brian Atkinson <batkinson@lanl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Coleman Kane <ckane@colemankane.org> Closes #15155
This commit is contained in:
parent
31a4673c05
commit
5a22de144a
25
config/kernel-filemap-splice-read.m4
Normal file
25
config/kernel-filemap-splice-read.m4
Normal file
@ -0,0 +1,25 @@
|
|||||||
|
AC_DEFUN([ZFS_AC_KERNEL_SRC_FILEMAP_SPLICE_READ], [
|
||||||
|
dnl #
|
||||||
|
dnl # Kernel 6.5 - generic_file_splice_read was removed in favor
|
||||||
|
dnl # of filemap_splice_read for the .splice_read member of the
|
||||||
|
dnl # file_operations struct.
|
||||||
|
dnl #
|
||||||
|
ZFS_LINUX_TEST_SRC([has_filemap_splice_read], [
|
||||||
|
#include <linux/fs.h>
|
||||||
|
|
||||||
|
struct file_operations fops __attribute__((unused)) = {
|
||||||
|
.splice_read = filemap_splice_read,
|
||||||
|
};
|
||||||
|
],[])
|
||||||
|
])
|
||||||
|
|
||||||
|
AC_DEFUN([ZFS_AC_KERNEL_FILEMAP_SPLICE_READ], [
|
||||||
|
AC_MSG_CHECKING([whether filemap_splice_read() exists])
|
||||||
|
ZFS_LINUX_TEST_RESULT([has_filemap_splice_read], [
|
||||||
|
AC_MSG_RESULT(yes)
|
||||||
|
AC_DEFINE(HAVE_FILEMAP_SPLICE_READ, 1,
|
||||||
|
[filemap_splice_read exists])
|
||||||
|
],[
|
||||||
|
AC_MSG_RESULT(no)
|
||||||
|
])
|
||||||
|
])
|
@ -6,8 +6,7 @@ AC_DEFUN([ZFS_AC_KERNEL_SRC_VFS_IOV_ITER], [
|
|||||||
#include <linux/fs.h>
|
#include <linux/fs.h>
|
||||||
#include <linux/uio.h>
|
#include <linux/uio.h>
|
||||||
],[
|
],[
|
||||||
int type __attribute__ ((unused)) =
|
int type __attribute__ ((unused)) = ITER_KVEC;
|
||||||
ITER_IOVEC | ITER_KVEC | ITER_BVEC | ITER_PIPE;
|
|
||||||
])
|
])
|
||||||
|
|
||||||
ZFS_LINUX_TEST_SRC([iov_iter_advance], [
|
ZFS_LINUX_TEST_SRC([iov_iter_advance], [
|
||||||
|
@ -161,6 +161,7 @@ AC_DEFUN([ZFS_AC_KERNEL_TEST_SRC], [
|
|||||||
ZFS_AC_KERNEL_SRC_WRITEPAGE_T
|
ZFS_AC_KERNEL_SRC_WRITEPAGE_T
|
||||||
ZFS_AC_KERNEL_SRC_RECLAIMED
|
ZFS_AC_KERNEL_SRC_RECLAIMED
|
||||||
ZFS_AC_KERNEL_SRC_REGISTER_SYSCTL_TABLE
|
ZFS_AC_KERNEL_SRC_REGISTER_SYSCTL_TABLE
|
||||||
|
ZFS_AC_KERNEL_SRC_FILEMAP_SPLICE_READ
|
||||||
case "$host_cpu" in
|
case "$host_cpu" in
|
||||||
powerpc*)
|
powerpc*)
|
||||||
ZFS_AC_KERNEL_SRC_CPU_HAS_FEATURE
|
ZFS_AC_KERNEL_SRC_CPU_HAS_FEATURE
|
||||||
@ -301,6 +302,7 @@ AC_DEFUN([ZFS_AC_KERNEL_TEST_RESULT], [
|
|||||||
ZFS_AC_KERNEL_WRITEPAGE_T
|
ZFS_AC_KERNEL_WRITEPAGE_T
|
||||||
ZFS_AC_KERNEL_RECLAIMED
|
ZFS_AC_KERNEL_RECLAIMED
|
||||||
ZFS_AC_KERNEL_REGISTER_SYSCTL_TABLE
|
ZFS_AC_KERNEL_REGISTER_SYSCTL_TABLE
|
||||||
|
ZFS_AC_KERNEL_FILEMAP_SPLICE_READ
|
||||||
case "$host_cpu" in
|
case "$host_cpu" in
|
||||||
powerpc*)
|
powerpc*)
|
||||||
ZFS_AC_KERNEL_CPU_HAS_FEATURE
|
ZFS_AC_KERNEL_CPU_HAS_FEATURE
|
||||||
|
@ -1323,7 +1323,11 @@ const struct file_operations zpl_file_operations = {
|
|||||||
.read_iter = zpl_iter_read,
|
.read_iter = zpl_iter_read,
|
||||||
.write_iter = zpl_iter_write,
|
.write_iter = zpl_iter_write,
|
||||||
#ifdef HAVE_VFS_IOV_ITER
|
#ifdef HAVE_VFS_IOV_ITER
|
||||||
|
#ifdef HAVE_FILEMAP_SPLICE_READ
|
||||||
|
.splice_read = filemap_splice_read,
|
||||||
|
#else
|
||||||
.splice_read = generic_file_splice_read,
|
.splice_read = generic_file_splice_read,
|
||||||
|
#endif
|
||||||
.splice_write = iter_file_splice_write,
|
.splice_write = iter_file_splice_write,
|
||||||
#endif
|
#endif
|
||||||
#else
|
#else
|
||||||
|
Loading…
Reference in New Issue
Block a user