c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2024-12-26 19:19:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix coverity defects: CID 155008

Browse Source 
CID 155008:  Resource leaks  (RESOURCE_LEAK)

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Gvozden Neskovic <neskovic@gmail.com>
Signed-off-by: cao.xuewen <cao.xuewen@zte.com.cn>
Closes #5500
This commit is contained in:
cao 2016-12-20 02:26:15 +08:00 committed by Brian Behlendorf
parent 6c01a4af2b
commit 58bf046ab3
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cmd/zpool/zpool_iter.c
View File

@ -360,6 +360,7 @@ for_each_vdev_run_cb(zpool_handle_t *zhp, nvlist_t *nv, void *cb_vcdl)
vdev_cmd_data_list_t *vcdl = cb_vcdl; vdev_cmd_data_list_t *vcdl = cb_vcdl;
vdev_cmd_data_t *data; vdev_cmd_data_t *data;
char *path = NULL; char *path = NULL;
char *vname = NULL;
int i, match = 0; int i, match = 0;
if (nvlist_lookup_string(nv, ZPOOL_CONFIG_PATH, &path) != 0) if (nvlist_lookup_string(nv, ZPOOL_CONFIG_PATH, &path) != 0)
@ -376,11 +377,13 @@ for_each_vdev_run_cb(zpool_handle_t *zhp, nvlist_t *nv, void *cb_vcdl)
/* Check for whitelisted vdevs here, if any */ /* Check for whitelisted vdevs here, if any */
for (i = 0; i < vcdl->vdev_names_count; i++) { for (i = 0; i < vcdl->vdev_names_count; i++) {
if (strcmp(vcdl->vdev_names[i], zpool_vdev_name(g_zfs, zhp, nv, vname = zpool_vdev_name(g_zfs, zhp, nv, vcdl->cb_name_flags);
vcdl->cb_name_flags)) == 0) { if (strcmp(vcdl->vdev_names[i], vname) == 0) {
free(vname);
match = 1; match = 1;
break; /* match */ break; /* match */
} }
free(vname);
} }
/* If we whitelisted vdevs, and this isn't one of them, then bail out */ /* If we whitelisted vdevs, and this isn't one of them, then bail out */