c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2026-05-22 18:40:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

Clarify comments in config/*.m4, vdev_geom.c, zfs_allow_*.ksh

Browse Source 
Rephrase comments to be more clear.

Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #10481
This commit is contained in:
Matthew Ahrens
2020-06-22 09:46:37 -07:00
committed by GitHub
parent 745ace3f24
commit 540493ba4f
6 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/zfs-tests/tests/functional/delegate/zfs_allow_007_pos.ksh
+3 -2
View File
@@ -66,7 +66,7 @@ log_must zfs create $childfs
log_must zfs create $grandchild
#
# Setting different permissions to the same set on two level.
# Setting different permissions to the same set on two levels.
# But only assign the user at one level.
#
log_must zfs allow -s @set $perms1 $ROOT_TESTFS
@@ -74,7 +74,8 @@ log_must zfs allow -s @set $perms2 $childfs
log_must zfs allow $STAFF1 @set $childfs
#
# Verify only perms2 is valid to user on the level which he was assigned.
# Verify that the user only has the permissions that they were assigned
# in each filesystem.
#
log_must verify_noperm $ROOT_TESTFS $perms1 $STAFF1
for fs in $childfs $grandchild ; do
tests/zfs-tests/tests/functional/delegate/zfs_allow_008_pos.ksh
+6 -6
View File
@@ -33,13 +33,13 @@
#
# DESCRIPTION:
# non-root user can allow any permissions which he is holding to
# other else user when it get 'allow' permission.
# A non-root user can use 'zfs allow' to delegate permissions that
# they have, if they also have the 'allow' permission.
#
# STRATEGY:
# 1. Set two set permissions to two datasets locally.
# 2. Verify the non-root user can allow permission if he has allow
# permission.
# 2. Verify the non-root user can use 'zfs allow' if they have
# 'allow' permission.
#
verify_runnable "both"
@@ -69,8 +69,8 @@ for dtst in $DATASETS ; do
log_must user_run $STAFF1 zfs allow -l $OTHER1 $perms1 $dtst
log_must verify_perm $dtst $perms1 $OTHER1
# $perms2 was not allow to $STAFF1, so he have no permission to
# delegate permission to other else.
# $perms2 was not allowed to $STAFF1, so they do not have
# permission to delegate permission to other users.
log_mustnot user_run $STAFF1 zfs allow $OTHER1 $perms2 $dtst
log_must verify_noperm $dtst $perms2 $OTHER1
done