From 4dad7d91e24875f077e26808fec900224e97dcb2 Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Tue, 7 Jan 2014 09:31:38 -0800 Subject: [PATCH] Remove unconditional sharetab update Removes the unconditional sharetab update when running any zfs command. This means the sharetab might become out of date if users are manually adding/removing shares with exportfs. But we shouldn't punish all callers to zfs in order to handle that unlikely case. In the unlikely event we observe issues because of this it can always be added back to just the share/unshare call paths where we need an up to date sharetab. Signed-off-by: Brian Behlendorf Signed-off-by: Turbo Fredriksson Signed-off-by: Chris Dunlop Issue #845 --- lib/libshare/libshare.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/lib/libshare/libshare.c b/lib/libshare/libshare.c index 6625a1b0c..ea59dcdbc 100644 --- a/lib/libshare/libshare.c +++ b/lib/libshare/libshare.c @@ -105,14 +105,6 @@ libshare_init(void) { libshare_nfs_init(); libshare_smb_init(); - - /* - * This bit causes /etc/dfs/sharetab to be updated before libzfs gets a - * chance to read that file; this is necessary because the sharetab file - * might be out of sync with the NFS kernel exports (e.g. due to reboots - * or users manually removing shares) - */ - sa_fini(sa_init(0)); } static void