From 411d327c676225ca7a208b61899124ad27327657 Mon Sep 17 00:00:00 2001 From: Richard Yao Date: Mon, 17 Oct 2022 12:37:31 -0400 Subject: [PATCH] Add defensive assertion to vdev_queue_aggregate() a6ccb36b948efed0eeee4fcf99fe4b5fb81ae1d5 had been intended to include this to silence Coverity reports, but this one was missed by mistake. Reviewed-by: Brian Behlendorf Signed-off-by: Richard Yao Closes #14043 --- module/zfs/vdev_queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/module/zfs/vdev_queue.c b/module/zfs/vdev_queue.c index f4e8d1427..d3777897e 100644 --- a/module/zfs/vdev_queue.c +++ b/module/zfs/vdev_queue.c @@ -725,6 +725,7 @@ vdev_queue_aggregate(vdev_queue_t *vq, zio_t *zio) * after our span is mandatory. */ dio = AVL_NEXT(t, last); + ASSERT3P(dio, !=, NULL); dio->io_flags &= ~ZIO_FLAG_OPTIONAL; } else { /* do not include the optional i/o */