c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2024-11-17 01:51:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use MAXPATHLEN instead of sizeof in snprintf

Browse Source 
This silences a GCC 4.8.0 warning by fixing a programming error
caught by static analysis:

../../cmd/ztest/ztest.c: In function ‘ztest_vdev_aux_add_remove’:
../../cmd/ztest/ztest.c:2584:33: error: argument to ‘sizeof’
  in ‘snprintf’ call is the same expression as the destination;
  did you mean to provide an explicit length?
  [-Werror=sizeof-pointer-memaccess]
  (void) snprintf(path, sizeof (path), ztest_aux_template,
                                 ^

Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #1480
This commit is contained in:
Richard Yao 2013-07-02 00:07:15 -04:00 committed by Brian Behlendorf
parent 29dee3ee9a
commit 3db3ff4a78
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/ztest/ztest.c
View File

@ -2581,7 +2581,7 @@ ztest_vdev_aux_add_remove(ztest_ds_t *zd, uint64_t id)
zs->zs_vdev_aux = 0; zs->zs_vdev_aux = 0;
for (;;) { for (;;) {
int c; int c;
(void) snprintf(path, sizeof (path), ztest_aux_template, (void) snprintf(path, MAXPATHLEN, ztest_aux_template,
ztest_opts.zo_dir, ztest_opts.zo_pool, aux, ztest_opts.zo_dir, ztest_opts.zo_pool, aux,
zs->zs_vdev_aux); zs->zs_vdev_aux);
for (c = 0; c < sav->sav_count; c++) for (c = 0; c < sav->sav_count; c++)