From 34d5a5fd03210d9efdd5966070df1f71c0dbef96 Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Fri, 13 Sep 2013 13:20:15 -0700 Subject: [PATCH] Fix zpl_mknod() return values The zpl_mknod() function was incorrectly negating its return value. This doesn't cause any problems in the success case, but it does prevent us from returning the correct error code for a failure. The implementation of this function is now consistent with all the other zpl_* functions. Signed-off-by: Brian Behlendorf Closes #1717 --- module/zfs/zpl_inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/zfs/zpl_inode.c b/module/zfs/zpl_inode.c index ab1fe6823..720d2d9fa 100644 --- a/module/zfs/zpl_inode.c +++ b/module/zfs/zpl_inode.c @@ -143,7 +143,7 @@ zpl_mknod(struct inode *dir, struct dentry *dentry, zpl_umode_t mode, crfree(cr); ASSERT3S(error, <=, 0); - return (-error); + return (error); } static int