c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2025-05-03 15:32:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use vmem_alloc() for zfs_ioc_pool_get_history()

Browse Source 
The default buffer size when requesting history is 128k.  This
is far to large for a kmem_alloc() so instead use the slower
vmem_alloc().  This path has no performance concerns and the
buffer is immediately free'd after its contents are copied to
the user space buffer.
This commit is contained in:
Brian Behlendorf 2011-05-06 09:59:52 -07:00
parent 3613204cd7
commit 34b84cb831
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
module/zfs/zfs_ioctl.c
View File

@ -1441,7 +1441,7 @@ zfs_ioc_pool_get_history(zfs_cmd_t *zc)
return (ENOTSUP); return (ENOTSUP);
} }
hist_buf = kmem_alloc(size, KM_SLEEP); hist_buf = vmem_alloc(size, KM_SLEEP);
if ((error = spa_history_get(spa, &zc->zc_history_offset, if ((error = spa_history_get(spa, &zc->zc_history_offset,
&zc->zc_history_len, hist_buf)) == 0) { &zc->zc_history_len, hist_buf)) == 0) {
error = ddi_copyout(hist_buf, error = ddi_copyout(hist_buf,
@ -1450,7 +1450,7 @@ zfs_ioc_pool_get_history(zfs_cmd_t *zc)
} }
spa_close(spa, FTAG); spa_close(spa, FTAG);
kmem_free(hist_buf, size); vmem_free(hist_buf, size);
return (error); return (error);
} }