From 33b4de513ee81c2a87e1b954a9544a5eec1f8f94 Mon Sep 17 00:00:00 2001 From: "Justin T. Gibbs" Date: Sat, 22 Nov 2014 19:14:24 -0800 Subject: [PATCH] Illumos 5311 - traverse_dnode may report success when it should not 5311 traverse_dnode may report success when it should not Reviewed by: Matthew Ahrens Reviewed by: Andriy Gapon Reviewed by: Will Andrews Approved by: Dan McDonald References: https://github.com/illumos/illumos-gate/commit/2a89c2c https://www.illumos.org/issues/5311 Ported by: DHE Signed-off-by: Brian Behlendorf Closes #2970 --- module/zfs/dmu_traverse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/zfs/dmu_traverse.c b/module/zfs/dmu_traverse.c index b090bc2fc..b5c1ec758 100644 --- a/module/zfs/dmu_traverse.c +++ b/module/zfs/dmu_traverse.c @@ -438,7 +438,7 @@ traverse_dnode(traverse_data_t *td, const dnode_phys_t *dnp, break; } - if (dnp->dn_flags & DNODE_FLAG_SPILL_BLKPTR) { + if (err == 0 && dnp->dn_flags & DNODE_FLAG_SPILL_BLKPTR) { SET_BOOKMARK(&czb, objset, object, 0, DMU_SPILL_BLKID); err = traverse_visitbp(td, dnp, &dnp->dn_spill, &czb); }