c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2026-05-27 04:32:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

zed: Ensure spare activation after kernel-initiated device removal

Browse Source 
In addition to hotplug events, the kernel may also mark a failing vdev
as REMOVED. This was observed in a customer report and reproduced by
forcing the NVMe host driver to disable the device after a failed reset
due to command timeout. In such cases, the spare was not activated
because the device had already transitioned to a REMOVED state before
zed processed the event.
To address this, explicitly attempt hot spare activation when the
kernel marks a device as REMOVED.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes #17187
This commit is contained in:
Ameer Hamza
2025-03-29 00:48:38 +05:00
committed by GitHub
parent dd2a46b5e6
commit 30cc2331f4
5 changed files with 46 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
module/zfs/zfs_fm.c
+16 -2
View File
@@ -1433,9 +1433,23 @@ zfs_post_common(spa_t *spa, vdev_t *vd, const char *type, const char *name,
* removal.
*/
void
zfs_post_remove(spa_t *spa, vdev_t *vd)
zfs_post_remove(spa_t *spa, vdev_t *vd, boolean_t by_kernel)
{
zfs_post_common(spa, vd, FM_RSRC_CLASS, FM_RESOURCE_REMOVED, NULL);
nvlist_t *aux = NULL;
if (by_kernel) {
/*
* Add optional supplemental keys to payload
*/
aux = fm_nvlist_create(NULL);
if (aux)
fnvlist_add_boolean(aux, "by_kernel");
}
zfs_post_common(spa, vd, FM_RSRC_CLASS, FM_RESOURCE_REMOVED, aux);
if (by_kernel && aux)
fm_nvlist_destroy(aux, FM_NVA_FREE);
}
/*