c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2025-01-14 12:10:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix divide by zero during indirect split damage

Browse Source 
This patch simply ensures that vdev_indirect_splits_damage()
cannot hit a divide by zero exception if a split has no
children with valid data. The normal reconstruction code
path in vdev_indirect_reconstruct_io_done() already has this
check.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #8086
This commit is contained in:
Tom Caputi 2018-11-07 18:44:56 -05:00 committed by Brian Behlendorf
parent fde25c0a87
commit 20eb30d08e
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
module/zfs/vdev_indirect.c
View File

@ -1587,6 +1587,8 @@ vdev_indirect_splits_enumerate_randomly(indirect_vsd_t *iv, zio_t *zio)
static int static int
vdev_indirect_splits_damage(indirect_vsd_t *iv, zio_t *zio) vdev_indirect_splits_damage(indirect_vsd_t *iv, zio_t *zio)
{ {
int error;
/* Presume all the copies are unique for initial selection. */ /* Presume all the copies are unique for initial selection. */
for (indirect_split_t *is = list_head(&iv->iv_splits); for (indirect_split_t *is = list_head(&iv->iv_splits);
is != NULL; is = list_next(&iv->iv_splits, is)) { is != NULL; is = list_next(&iv->iv_splits, is)) {
@ -1599,13 +1601,18 @@ vdev_indirect_splits_damage(indirect_vsd_t *iv, zio_t *zio)
list_insert_tail(&is->is_unique_child, ic); list_insert_tail(&is->is_unique_child, ic);
} }
} }
if (list_is_empty(&is->is_unique_child)) {
error = SET_ERROR(EIO);
goto out;
}
} }
/* /*
* Set each is_good_child to a randomly-selected child which * Set each is_good_child to a randomly-selected child which
* is known to contain validated data. * is known to contain validated data.
*/ */
int error = vdev_indirect_splits_enumerate_randomly(iv, zio); error = vdev_indirect_splits_enumerate_randomly(iv, zio);
if (error) if (error)
goto out; goto out;