c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2026-05-22 02:27:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

zvol: make calls to platform ops static

Browse Source 
There's no need to make the platform ops dynamic dispatch.

This change replaces the dynamic dispatch with static calls to the
platform-specific functions.
To avoid name collisions, prefix all platform-specific functions
with `zvol_os_`.
I actually find `zvol_..._os` slightly nicer to read in the calling
code, but having it as a prefix is useful.

Advantage:
- easier jump-to-definition / grepping
- potential benefits to static analysis
- better legibility

Future work: also prefix remaining `static` functions in zvol_os.c.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Christian Schwarz <christian.schwarz@nutanix.com>
Closes #12965
This commit is contained in:
Christian Schwarz
2022-02-07 19:24:38 +01:00
committed by GitHub
parent f2c5bc150e
commit 1dccfd7a38
4 changed files with 62 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/sys/zvol_impl.h
+8 -12
View File
@@ -93,17 +93,13 @@ void zvol_wait_close(zvol_state_t *zv);
/*
* platform dependent functions exported to platform independent code
*/
typedef struct zvol_platform_ops {
void (*zv_free)(zvol_state_t *);
void (*zv_rename_minor)(zvol_state_t *, const char *);
int (*zv_create_minor)(const char *);
int (*zv_update_volsize)(zvol_state_t *, uint64_t);
boolean_t (*zv_is_zvol)(const char *);
void (*zv_clear_private)(zvol_state_t *);
void (*zv_set_disk_ro)(zvol_state_t *, int flags);
void (*zv_set_capacity)(zvol_state_t *, uint64_t capacity);
} zvol_platform_ops_t;
void zvol_register_ops(const zvol_platform_ops_t *ops);
void zvol_os_free(zvol_state_t *zv);
void zvol_os_rename_minor(zvol_state_t *zv, const char *newname);
int zvol_os_create_minor(const char *name);
int zvol_os_update_volsize(zvol_state_t *zv, uint64_t volsize);
boolean_t zvol_os_is_zvol(const char *path);
void zvol_os_clear_private(zvol_state_t *zv);
void zvol_os_set_disk_ro(zvol_state_t *zv, int flags);
void zvol_os_set_capacity(zvol_state_t *zv, uint64_t capacity);
#endif