mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-12-26 19:19:32 +03:00
Fix uninitialized scalar value read regression in dmu_recv_begin()
da19d919a8
changed this in a way that
permits execution to reach `if (err == 0)` without initializing err.
This could randomly cause the sync task to not execute. We fix that by
initializing err to zero.
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reported-by: Coverity (CID-1535377)
Closes #14607
This commit is contained in:
parent
519851122b
commit
1c212d1b7c
@ -1223,7 +1223,7 @@ dmu_recv_begin(char *tofs, char *tosnap, dmu_replay_record_t *drr_begin,
|
|||||||
zfs_file_t *fp, offset_t *voffp)
|
zfs_file_t *fp, offset_t *voffp)
|
||||||
{
|
{
|
||||||
dmu_recv_begin_arg_t drba = { 0 };
|
dmu_recv_begin_arg_t drba = { 0 };
|
||||||
int err;
|
int err = 0;
|
||||||
|
|
||||||
memset(drc, 0, sizeof (dmu_recv_cookie_t));
|
memset(drc, 0, sizeof (dmu_recv_cookie_t));
|
||||||
drc->drc_drr_begin = drr_begin;
|
drc->drc_drr_begin = drr_begin;
|
||||||
|
Loading…
Reference in New Issue
Block a user