c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2025-10-26 18:05:04 +03:00
Code Issues Packages Projects Releases Wiki Activity

Coverity 9649, 9650, 9651: Uninit

Browse Source 
This check was originally added to detect double initializations
of mutex types (which it did find).  Unfortunately, Coverity is
right that there is a very small chance we could trigger the
assertion by accident because an uninitialized stack variable
happens to contain the mutex magic.  This is particularly unlikely
since we do poison the mutexs when destroyed but still possible.
Therefore I'm simply removing the assertion.
This commit is contained in:
Brian Behlendorf 2009-02-18 09:48:07 -08:00
parent bb01879ebe
commit 1315c88437
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
module/spl/spl-mutex.c
View File

@ -67,7 +67,6 @@ __spl_mutex_init(kmutex_t *mp, char *name, int type, void *ibc)
ASSERT(mp); ASSERT(mp);
ASSERT(name); ASSERT(name);
ASSERT(ibc == NULL); ASSERT(ibc == NULL);
ASSERT(mp->km_magic != KM_MAGIC); /* Never double init */
mp->km_name = NULL; mp->km_name = NULL;
mp->km_name_size = strlen(name) + 1; mp->km_name_size = strlen(name) + 1;