SLES10 Fixes (part 7)

- Initial SLES testing uncovered a long standing bug in the debug
  tracing.  The tcd_for_each() macro expected a NULL to terminate
  the trace_data[i] array but this was only ever true due to luck.
  All trace_data[] iterators are now properly capped by TCD_TYPE_MAX.
- SPLAT_MAJOR 229 conflicted with a 'hvc' device on my SLES system.
  Since this was always an arbitrary choice I picked something else.
- The HAVE_PGDAT_LIST case should set pgdat_list_addr to the value stored
  at the address of the memory location returned by kallsyms_lookup_name().
This commit is contained in:
Brian Behlendorf
2009-05-20 15:30:13 -07:00
parent 5232d256b4
commit 124ca8a5a9
4 changed files with 5 additions and 5 deletions
+1 -1
View File
@@ -1261,7 +1261,7 @@ trace_fini(void)
}
}
for (i = 0; trace_data[i] != NULL; i++) {
for (i = 0; i < TCD_TYPE_MAX && trace_data[i] != NULL; i++) {
kfree(trace_data[i]);
trace_data[i] = NULL;
}
+1 -1
View File
@@ -1847,7 +1847,7 @@ spl_kmem_init_kallsyms_lookup(void)
#else /* HAVE_PGDAT_HELPERS */
# ifndef HAVE_PGDAT_LIST
pgdat_list_addr = (struct pglist_data *)
pgdat_list_addr = *(struct pglist_data **)
spl_kallsyms_lookup_name("pgdat_list");
if (!pgdat_list_addr) {
printk(KERN_ERR "Error: Unknown symbol pgdat_list\n");