2010-05-29 00:45:14 +04:00
|
|
|
/*
|
|
|
|
* CDDL HEADER START
|
|
|
|
*
|
|
|
|
* The contents of this file are subject to the terms of the
|
|
|
|
* Common Development and Distribution License (the "License").
|
|
|
|
* You may not use this file except in compliance with the License.
|
|
|
|
*
|
|
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
2022-07-12 00:16:13 +03:00
|
|
|
* or https://opensource.org/licenses/CDDL-1.0.
|
2010-05-29 00:45:14 +04:00
|
|
|
* See the License for the specific language governing permissions
|
|
|
|
* and limitations under the License.
|
|
|
|
*
|
|
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
|
|
*
|
|
|
|
* CDDL HEADER END
|
|
|
|
*/
|
|
|
|
/*
|
|
|
|
* Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
|
2021-02-20 09:33:15 +03:00
|
|
|
* Copyright (c) 2011, 2021 by Delphix. All rights reserved.
|
2016-02-03 03:23:21 +03:00
|
|
|
* Copyright 2016 Gary Mills
|
2019-11-27 21:15:01 +03:00
|
|
|
* Copyright (c) 2017, 2019, Datto Inc. All rights reserved.
|
2020-09-04 20:39:58 +03:00
|
|
|
* Copyright (c) 2015, Nexenta Systems, Inc. All rights reserved.
|
2019-09-23 01:25:39 +03:00
|
|
|
* Copyright 2019 Joyent, Inc.
|
2010-05-29 00:45:14 +04:00
|
|
|
*/
|
|
|
|
|
|
|
|
#include <sys/dsl_scan.h>
|
|
|
|
#include <sys/dsl_pool.h>
|
|
|
|
#include <sys/dsl_dataset.h>
|
|
|
|
#include <sys/dsl_prop.h>
|
|
|
|
#include <sys/dsl_dir.h>
|
|
|
|
#include <sys/dsl_synctask.h>
|
|
|
|
#include <sys/dnode.h>
|
|
|
|
#include <sys/dmu_tx.h>
|
|
|
|
#include <sys/dmu_objset.h>
|
|
|
|
#include <sys/arc.h>
|
2023-01-25 01:05:45 +03:00
|
|
|
#include <sys/arc_impl.h>
|
2010-05-29 00:45:14 +04:00
|
|
|
#include <sys/zap.h>
|
|
|
|
#include <sys/zio.h>
|
|
|
|
#include <sys/zfs_context.h>
|
|
|
|
#include <sys/fs/zfs.h>
|
|
|
|
#include <sys/zfs_znode.h>
|
|
|
|
#include <sys/spa_impl.h>
|
|
|
|
#include <sys/vdev_impl.h>
|
|
|
|
#include <sys/zil_impl.h>
|
|
|
|
#include <sys/zio_checksum.h>
|
2023-03-10 22:59:53 +03:00
|
|
|
#include <sys/brt.h>
|
2010-05-29 00:45:14 +04:00
|
|
|
#include <sys/ddt.h>
|
|
|
|
#include <sys/sa.h>
|
|
|
|
#include <sys/sa_impl.h>
|
2012-12-14 03:24:15 +04:00
|
|
|
#include <sys/zfeature.h>
|
2016-07-22 18:52:49 +03:00
|
|
|
#include <sys/abd.h>
|
2017-11-16 04:27:01 +03:00
|
|
|
#include <sys/range_tree.h>
|
2021-12-17 23:35:28 +03:00
|
|
|
#include <sys/dbuf.h>
|
2010-05-29 00:45:14 +04:00
|
|
|
#ifdef _KERNEL
|
|
|
|
#include <sys/zfs_vfsops.h>
|
|
|
|
#endif
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* Grand theory statement on scan queue sorting
|
|
|
|
*
|
|
|
|
* Scanning is implemented by recursively traversing all indirection levels
|
|
|
|
* in an object and reading all blocks referenced from said objects. This
|
|
|
|
* results in us approximately traversing the object from lowest logical
|
|
|
|
* offset to the highest. For best performance, we would want the logical
|
|
|
|
* blocks to be physically contiguous. However, this is frequently not the
|
|
|
|
* case with pools given the allocation patterns of copy-on-write filesystems.
|
|
|
|
* So instead, we put the I/Os into a reordering queue and issue them in a
|
|
|
|
* way that will most benefit physical disks (LBA-order).
|
|
|
|
*
|
|
|
|
* Queue management:
|
|
|
|
*
|
|
|
|
* Ideally, we would want to scan all metadata and queue up all block I/O
|
|
|
|
* prior to starting to issue it, because that allows us to do an optimal
|
|
|
|
* sorting job. This can however consume large amounts of memory. Therefore
|
|
|
|
* we continuously monitor the size of the queues and constrain them to 5%
|
|
|
|
* (zfs_scan_mem_lim_fact) of physmem. If the queues grow larger than this
|
|
|
|
* limit, we clear out a few of the largest extents at the head of the queues
|
|
|
|
* to make room for more scanning. Hopefully, these extents will be fairly
|
|
|
|
* large and contiguous, allowing us to approach sequential I/O throughput
|
|
|
|
* even without a fully sorted tree.
|
|
|
|
*
|
|
|
|
* Metadata scanning takes place in dsl_scan_visit(), which is called from
|
|
|
|
* dsl_scan_sync() every spa_sync(). If we have either fully scanned all
|
|
|
|
* metadata on the pool, or we need to make room in memory because our
|
|
|
|
* queues are too large, dsl_scan_visit() is postponed and
|
|
|
|
* scan_io_queues_run() is called from dsl_scan_sync() instead. This implies
|
|
|
|
* that metadata scanning and queued I/O issuing are mutually exclusive. This
|
|
|
|
* allows us to provide maximum sequential I/O throughput for the majority of
|
|
|
|
* I/O's issued since sequential I/O performance is significantly negatively
|
|
|
|
* impacted if it is interleaved with random I/O.
|
|
|
|
*
|
|
|
|
* Implementation Notes
|
|
|
|
*
|
|
|
|
* One side effect of the queued scanning algorithm is that the scanning code
|
|
|
|
* needs to be notified whenever a block is freed. This is needed to allow
|
|
|
|
* the scanning code to remove these I/Os from the issuing queue. Additionally,
|
|
|
|
* we do not attempt to queue gang blocks to be issued sequentially since this
|
2018-03-29 04:30:44 +03:00
|
|
|
* is very hard to do and would have an extremely limited performance benefit.
|
2017-11-16 04:27:01 +03:00
|
|
|
* Instead, we simply issue gang I/Os as soon as we find them using the legacy
|
|
|
|
* algorithm.
|
|
|
|
*
|
|
|
|
* Backwards compatibility
|
|
|
|
*
|
|
|
|
* This new algorithm is backwards compatible with the legacy on-disk data
|
|
|
|
* structures (and therefore does not require a new feature flag).
|
|
|
|
* Periodically during scanning (see zfs_scan_checkpoint_intval), the scan
|
|
|
|
* will stop scanning metadata (in logical order) and wait for all outstanding
|
|
|
|
* sorted I/O to complete. Once this is done, we write out a checkpoint
|
|
|
|
* bookmark, indicating that we have scanned everything logically before it.
|
|
|
|
* If the pool is imported on a machine without the new sorting algorithm,
|
|
|
|
* the scan simply resumes from the last checkpoint using the legacy algorithm.
|
|
|
|
*/
|
|
|
|
|
2014-06-25 22:37:59 +04:00
|
|
|
typedef int (scan_cb_t)(dsl_pool_t *, const blkptr_t *,
|
|
|
|
const zbookmark_phys_t *);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
static scan_cb_t dsl_scan_scrub_cb;
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static int scan_ds_queue_compare(const void *a, const void *b);
|
|
|
|
static int scan_prefetch_queue_compare(const void *a, const void *b);
|
|
|
|
static void scan_ds_queue_clear(dsl_scan_t *scn);
|
2018-12-06 20:47:23 +03:00
|
|
|
static void scan_ds_prefetch_queue_clear(dsl_scan_t *scn);
|
2017-11-16 04:27:01 +03:00
|
|
|
static boolean_t scan_ds_queue_contains(dsl_scan_t *scn, uint64_t dsobj,
|
|
|
|
uint64_t *txg);
|
|
|
|
static void scan_ds_queue_insert(dsl_scan_t *scn, uint64_t dsobj, uint64_t txg);
|
|
|
|
static void scan_ds_queue_remove(dsl_scan_t *scn, uint64_t dsobj);
|
|
|
|
static void scan_ds_queue_sync(dsl_scan_t *scn, dmu_tx_t *tx);
|
2023-01-25 01:05:45 +03:00
|
|
|
static uint64_t dsl_scan_count_data_disks(spa_t *spa);
|
2021-12-17 23:35:28 +03:00
|
|
|
static void read_by_block_level(dsl_scan_t *scn, zbookmark_phys_t zb);
|
2017-11-16 04:27:01 +03:00
|
|
|
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
extern uint_t zfs_vdev_async_write_active_min_dirty_percent;
|
2022-06-28 21:23:31 +03:00
|
|
|
static int zfs_scan_blkstats = 0;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
2023-01-25 22:28:54 +03:00
|
|
|
/*
|
|
|
|
* 'zpool status' uses bytes processed per pass to report throughput and
|
|
|
|
* estimate time remaining. We define a pass to start when the scanning
|
|
|
|
* phase completes for a sequential resilver. Optionally, this value
|
|
|
|
* may be used to reset the pass statistics every N txgs to provide an
|
|
|
|
* estimated completion time based on currently observed performance.
|
|
|
|
*/
|
|
|
|
static uint_t zfs_scan_report_txgs = 0;
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* By default zfs will check to ensure it is not over the hard memory
|
|
|
|
* limit before each txg. If finer-grained control of this is needed
|
|
|
|
* this value can be set to 1 to enable checking before scanning each
|
|
|
|
* block.
|
|
|
|
*/
|
2022-01-15 02:37:55 +03:00
|
|
|
static int zfs_scan_strict_mem_lim = B_FALSE;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Maximum number of parallelly executed bytes per leaf vdev. We attempt
|
|
|
|
* to strike a balance here between keeping the vdev queues full of I/Os
|
|
|
|
* at all times and not overflowing the queues to cause long latency,
|
|
|
|
* which would cause long txg sync times. No matter what, we will not
|
|
|
|
* overload the drives with I/O, since that is protected by
|
|
|
|
* zfs_vdev_scrub_max_active.
|
|
|
|
*/
|
2023-01-25 01:05:45 +03:00
|
|
|
static uint64_t zfs_scan_vdev_limit = 16 << 20;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
static uint_t zfs_scan_issue_strategy = 0;
|
|
|
|
|
|
|
|
/* don't queue & sort zios, go direct */
|
|
|
|
static int zfs_scan_legacy = B_FALSE;
|
Cleanup: 64-bit kernel module parameters should use fixed width types
Various module parameters such as `zfs_arc_max` were originally
`uint64_t` on OpenSolaris/Illumos, but were changed to `unsigned long`
for Linux compatibility because Linux's kernel default module parameter
implementation did not support 64-bit types on 32-bit platforms. This
caused problems when porting OpenZFS to Windows because its LLP64 memory
model made `unsigned long` a 32-bit type on 64-bit, which created the
undesireable situation that parameters that should accept 64-bit values
could not on 64-bit Windows.
Upon inspection, it turns out that the Linux kernel module parameter
interface is extensible, such that we are allowed to define our own
types. Rather than maintaining the original type change via hacks to to
continue shrinking module parameters on 32-bit Linux, we implement
support for 64-bit module parameters on Linux.
After doing a review of all 64-bit kernel parameters (found via the man
page and also proposed changes by Andrew Innes), the kernel module
parameters fell into a few groups:
Parameters that were originally 64-bit on Illumos:
* dbuf_cache_max_bytes
* dbuf_metadata_cache_max_bytes
* l2arc_feed_min_ms
* l2arc_feed_secs
* l2arc_headroom
* l2arc_headroom_boost
* l2arc_write_boost
* l2arc_write_max
* metaslab_aliquot
* metaslab_force_ganging
* zfetch_array_rd_sz
* zfs_arc_max
* zfs_arc_meta_limit
* zfs_arc_meta_min
* zfs_arc_min
* zfs_async_block_max_blocks
* zfs_condense_max_obsolete_bytes
* zfs_condense_min_mapping_bytes
* zfs_deadman_checktime_ms
* zfs_deadman_synctime_ms
* zfs_initialize_chunk_size
* zfs_initialize_value
* zfs_lua_max_instrlimit
* zfs_lua_max_memlimit
* zil_slog_bulk
Parameters that were originally 32-bit on Illumos:
* zfs_per_txg_dirty_frees_percent
Parameters that were originally `ssize_t` on Illumos:
* zfs_immediate_write_sz
Note that `ssize_t` is `int32_t` on 32-bit and `int64_t` on 64-bit. It
has been upgraded to 64-bit.
Parameters that were `long`/`unsigned long` because of Linux/FreeBSD
influence:
* l2arc_rebuild_blocks_min_l2size
* zfs_key_max_salt_uses
* zfs_max_log_walking
* zfs_max_logsm_summary_length
* zfs_metaslab_max_size_cache_sec
* zfs_min_metaslabs_to_flush
* zfs_multihost_interval
* zfs_unflushed_log_block_max
* zfs_unflushed_log_block_min
* zfs_unflushed_log_block_pct
* zfs_unflushed_max_mem_amt
* zfs_unflushed_max_mem_ppm
New parameters that do not exist in Illumos:
* l2arc_trim_ahead
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_arc_sys_free
* zfs_deadman_ziotime_ms
* zfs_delete_blocks
* zfs_history_output_max
* zfs_livelist_max_entries
* zfs_max_async_dedup_frees
* zfs_max_nvlist_src_size
* zfs_rebuild_max_segment
* zfs_rebuild_vdev_limit
* zfs_unflushed_log_txg_max
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
* zfs_vnops_read_chunk_size
* zvol_max_discard_blocks
Rather than clutter the lists with commentary, the module parameters
that need comments are repeated below.
A few parameters were defined in Linux/FreeBSD specific code, where the
use of ulong/long is not an issue for portability, so we leave them
alone:
* zfs_delete_blocks
* zfs_key_max_salt_uses
* zvol_max_discard_blocks
The documentation for a few parameters was found to be incorrect:
* zfs_deadman_checktime_ms - incorrectly documented as int
* zfs_delete_blocks - not documented as Linux only
* zfs_history_output_max - incorrectly documented as int
* zfs_vnops_read_chunk_size - incorrectly documented as long
* zvol_max_discard_blocks - incorrectly documented as ulong
The documentation for these has been fixed, alongside the changes to
document the switch to fixed width types.
In addition, several kernel module parameters were percentages or held
ashift values, so being 64-bit never made sense for them. They have been
downgraded to 32-bit:
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_per_txg_dirty_frees_percent
* zfs_unflushed_log_block_pct
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
Of special note are `zfs_vdev_max_auto_ashift` and
`zfs_vdev_min_auto_ashift`, which were already defined as `uint64_t`,
and passed to the kernel as `ulong`. This is inherently buggy on big
endian 32-bit Linux, since the values would not be written to the
correct locations. 32-bit FreeBSD was unaffected because its sysctl code
correctly treated this as a `uint64_t`.
Lastly, a code comment suggests that `zfs_arc_sys_free` is
Linux-specific, but there is nothing to indicate to me that it is
Linux-specific. Nothing was done about that.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Original-patch-by: Andrew Innes <andrew.c12@gmail.com>
Original-patch-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13984
Closes #14004
2022-10-03 22:06:54 +03:00
|
|
|
static uint64_t zfs_scan_max_ext_gap = 2 << 20; /* in bytes */
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* fill_weight is non-tunable at runtime, so we copy it at module init from
|
|
|
|
* zfs_scan_fill_weight. Runtime adjustments to zfs_scan_fill_weight would
|
|
|
|
* break queue sorting.
|
|
|
|
*/
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
static uint_t zfs_scan_fill_weight = 3;
|
2017-11-16 04:27:01 +03:00
|
|
|
static uint64_t fill_weight;
|
|
|
|
|
|
|
|
/* See dsl_scan_should_clear() for details on the memory limit tunables */
|
2022-01-15 02:37:55 +03:00
|
|
|
static const uint64_t zfs_scan_mem_lim_min = 16 << 20; /* bytes */
|
|
|
|
static const uint64_t zfs_scan_mem_lim_soft_max = 128 << 20; /* bytes */
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
|
|
|
|
|
|
|
|
/* fraction of physmem */
|
|
|
|
static uint_t zfs_scan_mem_lim_fact = 20;
|
|
|
|
|
|
|
|
/* fraction of mem lim above */
|
|
|
|
static uint_t zfs_scan_mem_lim_soft_fact = 20;
|
|
|
|
|
|
|
|
/* minimum milliseconds to scrub per txg */
|
|
|
|
static uint_t zfs_scrub_min_time_ms = 1000;
|
|
|
|
|
|
|
|
/* minimum milliseconds to obsolete per txg */
|
|
|
|
static uint_t zfs_obsolete_min_time_ms = 500;
|
|
|
|
|
|
|
|
/* minimum milliseconds to free per txg */
|
|
|
|
static uint_t zfs_free_min_time_ms = 1000;
|
|
|
|
|
|
|
|
/* minimum milliseconds to resilver per txg */
|
|
|
|
static uint_t zfs_resilver_min_time_ms = 3000;
|
|
|
|
|
|
|
|
static uint_t zfs_scan_checkpoint_intval = 7200; /* in seconds */
|
2018-11-28 21:12:08 +03:00
|
|
|
int zfs_scan_suspend_progress = 0; /* set to prevent scans from progressing */
|
2022-01-15 02:37:55 +03:00
|
|
|
static int zfs_no_scrub_io = B_FALSE; /* set to disable scrub i/o */
|
|
|
|
static int zfs_no_scrub_prefetch = B_FALSE; /* set to disable scrub prefetch */
|
2023-07-03 05:32:53 +03:00
|
|
|
static const ddt_class_t zfs_scrub_ddt_class_max = DDT_CLASS_DUPLICATE;
|
2014-09-07 19:06:08 +04:00
|
|
|
/* max number of blocks to free in a single TXG */
|
Cleanup: 64-bit kernel module parameters should use fixed width types
Various module parameters such as `zfs_arc_max` were originally
`uint64_t` on OpenSolaris/Illumos, but were changed to `unsigned long`
for Linux compatibility because Linux's kernel default module parameter
implementation did not support 64-bit types on 32-bit platforms. This
caused problems when porting OpenZFS to Windows because its LLP64 memory
model made `unsigned long` a 32-bit type on 64-bit, which created the
undesireable situation that parameters that should accept 64-bit values
could not on 64-bit Windows.
Upon inspection, it turns out that the Linux kernel module parameter
interface is extensible, such that we are allowed to define our own
types. Rather than maintaining the original type change via hacks to to
continue shrinking module parameters on 32-bit Linux, we implement
support for 64-bit module parameters on Linux.
After doing a review of all 64-bit kernel parameters (found via the man
page and also proposed changes by Andrew Innes), the kernel module
parameters fell into a few groups:
Parameters that were originally 64-bit on Illumos:
* dbuf_cache_max_bytes
* dbuf_metadata_cache_max_bytes
* l2arc_feed_min_ms
* l2arc_feed_secs
* l2arc_headroom
* l2arc_headroom_boost
* l2arc_write_boost
* l2arc_write_max
* metaslab_aliquot
* metaslab_force_ganging
* zfetch_array_rd_sz
* zfs_arc_max
* zfs_arc_meta_limit
* zfs_arc_meta_min
* zfs_arc_min
* zfs_async_block_max_blocks
* zfs_condense_max_obsolete_bytes
* zfs_condense_min_mapping_bytes
* zfs_deadman_checktime_ms
* zfs_deadman_synctime_ms
* zfs_initialize_chunk_size
* zfs_initialize_value
* zfs_lua_max_instrlimit
* zfs_lua_max_memlimit
* zil_slog_bulk
Parameters that were originally 32-bit on Illumos:
* zfs_per_txg_dirty_frees_percent
Parameters that were originally `ssize_t` on Illumos:
* zfs_immediate_write_sz
Note that `ssize_t` is `int32_t` on 32-bit and `int64_t` on 64-bit. It
has been upgraded to 64-bit.
Parameters that were `long`/`unsigned long` because of Linux/FreeBSD
influence:
* l2arc_rebuild_blocks_min_l2size
* zfs_key_max_salt_uses
* zfs_max_log_walking
* zfs_max_logsm_summary_length
* zfs_metaslab_max_size_cache_sec
* zfs_min_metaslabs_to_flush
* zfs_multihost_interval
* zfs_unflushed_log_block_max
* zfs_unflushed_log_block_min
* zfs_unflushed_log_block_pct
* zfs_unflushed_max_mem_amt
* zfs_unflushed_max_mem_ppm
New parameters that do not exist in Illumos:
* l2arc_trim_ahead
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_arc_sys_free
* zfs_deadman_ziotime_ms
* zfs_delete_blocks
* zfs_history_output_max
* zfs_livelist_max_entries
* zfs_max_async_dedup_frees
* zfs_max_nvlist_src_size
* zfs_rebuild_max_segment
* zfs_rebuild_vdev_limit
* zfs_unflushed_log_txg_max
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
* zfs_vnops_read_chunk_size
* zvol_max_discard_blocks
Rather than clutter the lists with commentary, the module parameters
that need comments are repeated below.
A few parameters were defined in Linux/FreeBSD specific code, where the
use of ulong/long is not an issue for portability, so we leave them
alone:
* zfs_delete_blocks
* zfs_key_max_salt_uses
* zvol_max_discard_blocks
The documentation for a few parameters was found to be incorrect:
* zfs_deadman_checktime_ms - incorrectly documented as int
* zfs_delete_blocks - not documented as Linux only
* zfs_history_output_max - incorrectly documented as int
* zfs_vnops_read_chunk_size - incorrectly documented as long
* zvol_max_discard_blocks - incorrectly documented as ulong
The documentation for these has been fixed, alongside the changes to
document the switch to fixed width types.
In addition, several kernel module parameters were percentages or held
ashift values, so being 64-bit never made sense for them. They have been
downgraded to 32-bit:
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_per_txg_dirty_frees_percent
* zfs_unflushed_log_block_pct
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
Of special note are `zfs_vdev_max_auto_ashift` and
`zfs_vdev_min_auto_ashift`, which were already defined as `uint64_t`,
and passed to the kernel as `ulong`. This is inherently buggy on big
endian 32-bit Linux, since the values would not be written to the
correct locations. 32-bit FreeBSD was unaffected because its sysctl code
correctly treated this as a `uint64_t`.
Lastly, a code comment suggests that `zfs_arc_sys_free` is
Linux-specific, but there is nothing to indicate to me that it is
Linux-specific. Nothing was done about that.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Original-patch-by: Andrew Innes <andrew.c12@gmail.com>
Original-patch-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13984
Closes #14004
2022-10-03 22:06:54 +03:00
|
|
|
static uint64_t zfs_async_block_max_blocks = UINT64_MAX;
|
Remove limit on number of async zio_frees of non-dedup blocks
The module parameter zfs_async_block_max_blocks limits the number of
blocks that can be freed by the background freeing of filesystems and
snapshots (from "zfs destroy"), in one TXG. This is useful when freeing
dedup blocks, becuase each zio_free() of a dedup block can require an
i/o to read the relevant part of the dedup table (DDT), and will also
dirty that block.
zfs_async_block_max_blocks is set to 100,000 by default. For the more
typical case where dedup is not used, this can have a negative
performance impact on the rate of background freeing (from "zfs
destroy"). For example, with recordsize=8k, and TXG's syncing once
every 5 seconds, we can free only 160MB of data per second, which may be
much less than the rate we can write data.
This change increases zfs_async_block_max_blocks to be unlimited by
default. To address the dedup freeing issue, a new tunable is
introduced, zfs_max_async_dedup_frees, which limits the number of
zio_free()'s of dedup blocks done by background destroys, per txg. The
default is 100,000 free's (same as the old zfs_async_block_max_blocks
default).
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #10000
2020-02-14 19:39:46 +03:00
|
|
|
/* max number of dedup blocks to free in a single TXG */
|
Cleanup: 64-bit kernel module parameters should use fixed width types
Various module parameters such as `zfs_arc_max` were originally
`uint64_t` on OpenSolaris/Illumos, but were changed to `unsigned long`
for Linux compatibility because Linux's kernel default module parameter
implementation did not support 64-bit types on 32-bit platforms. This
caused problems when porting OpenZFS to Windows because its LLP64 memory
model made `unsigned long` a 32-bit type on 64-bit, which created the
undesireable situation that parameters that should accept 64-bit values
could not on 64-bit Windows.
Upon inspection, it turns out that the Linux kernel module parameter
interface is extensible, such that we are allowed to define our own
types. Rather than maintaining the original type change via hacks to to
continue shrinking module parameters on 32-bit Linux, we implement
support for 64-bit module parameters on Linux.
After doing a review of all 64-bit kernel parameters (found via the man
page and also proposed changes by Andrew Innes), the kernel module
parameters fell into a few groups:
Parameters that were originally 64-bit on Illumos:
* dbuf_cache_max_bytes
* dbuf_metadata_cache_max_bytes
* l2arc_feed_min_ms
* l2arc_feed_secs
* l2arc_headroom
* l2arc_headroom_boost
* l2arc_write_boost
* l2arc_write_max
* metaslab_aliquot
* metaslab_force_ganging
* zfetch_array_rd_sz
* zfs_arc_max
* zfs_arc_meta_limit
* zfs_arc_meta_min
* zfs_arc_min
* zfs_async_block_max_blocks
* zfs_condense_max_obsolete_bytes
* zfs_condense_min_mapping_bytes
* zfs_deadman_checktime_ms
* zfs_deadman_synctime_ms
* zfs_initialize_chunk_size
* zfs_initialize_value
* zfs_lua_max_instrlimit
* zfs_lua_max_memlimit
* zil_slog_bulk
Parameters that were originally 32-bit on Illumos:
* zfs_per_txg_dirty_frees_percent
Parameters that were originally `ssize_t` on Illumos:
* zfs_immediate_write_sz
Note that `ssize_t` is `int32_t` on 32-bit and `int64_t` on 64-bit. It
has been upgraded to 64-bit.
Parameters that were `long`/`unsigned long` because of Linux/FreeBSD
influence:
* l2arc_rebuild_blocks_min_l2size
* zfs_key_max_salt_uses
* zfs_max_log_walking
* zfs_max_logsm_summary_length
* zfs_metaslab_max_size_cache_sec
* zfs_min_metaslabs_to_flush
* zfs_multihost_interval
* zfs_unflushed_log_block_max
* zfs_unflushed_log_block_min
* zfs_unflushed_log_block_pct
* zfs_unflushed_max_mem_amt
* zfs_unflushed_max_mem_ppm
New parameters that do not exist in Illumos:
* l2arc_trim_ahead
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_arc_sys_free
* zfs_deadman_ziotime_ms
* zfs_delete_blocks
* zfs_history_output_max
* zfs_livelist_max_entries
* zfs_max_async_dedup_frees
* zfs_max_nvlist_src_size
* zfs_rebuild_max_segment
* zfs_rebuild_vdev_limit
* zfs_unflushed_log_txg_max
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
* zfs_vnops_read_chunk_size
* zvol_max_discard_blocks
Rather than clutter the lists with commentary, the module parameters
that need comments are repeated below.
A few parameters were defined in Linux/FreeBSD specific code, where the
use of ulong/long is not an issue for portability, so we leave them
alone:
* zfs_delete_blocks
* zfs_key_max_salt_uses
* zvol_max_discard_blocks
The documentation for a few parameters was found to be incorrect:
* zfs_deadman_checktime_ms - incorrectly documented as int
* zfs_delete_blocks - not documented as Linux only
* zfs_history_output_max - incorrectly documented as int
* zfs_vnops_read_chunk_size - incorrectly documented as long
* zvol_max_discard_blocks - incorrectly documented as ulong
The documentation for these has been fixed, alongside the changes to
document the switch to fixed width types.
In addition, several kernel module parameters were percentages or held
ashift values, so being 64-bit never made sense for them. They have been
downgraded to 32-bit:
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_per_txg_dirty_frees_percent
* zfs_unflushed_log_block_pct
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
Of special note are `zfs_vdev_max_auto_ashift` and
`zfs_vdev_min_auto_ashift`, which were already defined as `uint64_t`,
and passed to the kernel as `ulong`. This is inherently buggy on big
endian 32-bit Linux, since the values would not be written to the
correct locations. 32-bit FreeBSD was unaffected because its sysctl code
correctly treated this as a `uint64_t`.
Lastly, a code comment suggests that `zfs_arc_sys_free` is
Linux-specific, but there is nothing to indicate to me that it is
Linux-specific. Nothing was done about that.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Original-patch-by: Andrew Innes <andrew.c12@gmail.com>
Original-patch-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13984
Closes #14004
2022-10-03 22:06:54 +03:00
|
|
|
static uint64_t zfs_max_async_dedup_frees = 100000;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2022-01-15 02:37:55 +03:00
|
|
|
/* set to disable resilver deferring */
|
|
|
|
static int zfs_resilver_disable_defer = B_FALSE;
|
2018-10-19 07:06:18 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* We wait a few txgs after importing a pool to begin scanning so that
|
|
|
|
* the import / mounting code isn't held up by scrub / resilver IO.
|
|
|
|
* Unfortunately, it is a bit difficult to determine exactly how long
|
|
|
|
* this will take since userspace will trigger fs mounts asynchronously
|
|
|
|
* and the kernel will create zvol minors asynchronously. As a result,
|
|
|
|
* the value provided here is a bit arbitrary, but represents a
|
|
|
|
* reasonable estimate of how many txgs it will take to finish fully
|
|
|
|
* importing a pool
|
|
|
|
*/
|
|
|
|
#define SCAN_IMPORT_WAIT_TXGS 5
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
#define DSL_SCAN_IS_SCRUB_RESILVER(scn) \
|
|
|
|
((scn)->scn_phys.scn_func == POOL_SCAN_SCRUB || \
|
|
|
|
(scn)->scn_phys.scn_func == POOL_SCAN_RESILVER)
|
|
|
|
|
2016-01-23 03:41:02 +03:00
|
|
|
/*
|
|
|
|
* Enable/disable the processing of the free_bpobj object.
|
|
|
|
*/
|
2022-01-15 02:37:55 +03:00
|
|
|
static int zfs_free_bpobj_enabled = 1;
|
2016-01-23 03:41:02 +03:00
|
|
|
|
2021-12-17 23:35:28 +03:00
|
|
|
/* Error blocks to be scrubbed in one txg. */
|
2023-05-26 19:53:00 +03:00
|
|
|
static uint_t zfs_scrub_error_blocks_per_txg = 1 << 12;
|
2021-12-17 23:35:28 +03:00
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
/* the order has to match pool_scan_type */
|
|
|
|
static scan_cb_t *scan_funcs[POOL_SCAN_FUNCS] = {
|
|
|
|
NULL,
|
|
|
|
dsl_scan_scrub_cb, /* POOL_SCAN_SCRUB */
|
|
|
|
dsl_scan_scrub_cb, /* POOL_SCAN_RESILVER */
|
|
|
|
};
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/* In core node for the scn->scn_queue. Represents a dataset to be scanned */
|
|
|
|
typedef struct {
|
|
|
|
uint64_t sds_dsobj;
|
|
|
|
uint64_t sds_txg;
|
|
|
|
avl_node_t sds_node;
|
|
|
|
} scan_ds_t;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This controls what conditions are placed on dsl_scan_sync_state():
|
2022-06-24 19:50:37 +03:00
|
|
|
* SYNC_OPTIONAL) write out scn_phys iff scn_queues_pending == 0
|
|
|
|
* SYNC_MANDATORY) write out scn_phys always. scn_queues_pending must be 0.
|
|
|
|
* SYNC_CACHED) if scn_queues_pending == 0, write out scn_phys. Otherwise
|
2017-11-16 04:27:01 +03:00
|
|
|
* write out the scn_phys_cached version.
|
|
|
|
* See dsl_scan_sync_state for details.
|
|
|
|
*/
|
|
|
|
typedef enum {
|
|
|
|
SYNC_OPTIONAL,
|
|
|
|
SYNC_MANDATORY,
|
|
|
|
SYNC_CACHED
|
|
|
|
} state_sync_type_t;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This struct represents the minimum information needed to reconstruct a
|
|
|
|
* zio for sequential scanning. This is useful because many of these will
|
|
|
|
* accumulate in the sequential IO queues before being issued, so saving
|
|
|
|
* memory matters here.
|
|
|
|
*/
|
|
|
|
typedef struct scan_io {
|
|
|
|
/* fields from blkptr_t */
|
|
|
|
uint64_t sio_blk_prop;
|
|
|
|
uint64_t sio_phys_birth;
|
|
|
|
uint64_t sio_birth;
|
|
|
|
zio_cksum_t sio_cksum;
|
2019-03-16 00:14:31 +03:00
|
|
|
uint32_t sio_nr_dvas;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/* fields from zio_t */
|
2019-03-16 00:14:31 +03:00
|
|
|
uint32_t sio_flags;
|
2017-11-16 04:27:01 +03:00
|
|
|
zbookmark_phys_t sio_zb;
|
|
|
|
|
|
|
|
/* members for queue sorting */
|
|
|
|
union {
|
2019-03-16 00:14:31 +03:00
|
|
|
avl_node_t sio_addr_node; /* link into issuing queue */
|
2017-11-16 04:27:01 +03:00
|
|
|
list_node_t sio_list_node; /* link for issuing to disk */
|
|
|
|
} sio_nodes;
|
2019-03-16 00:14:31 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* There may be up to SPA_DVAS_PER_BP DVAs here from the bp,
|
|
|
|
* depending on how many were in the original bp. Only the
|
|
|
|
* first DVA is really used for sorting and issuing purposes.
|
|
|
|
* The other DVAs (if provided) simply exist so that the zio
|
|
|
|
* layer can find additional copies to repair from in the
|
|
|
|
* event of an error. This array must go at the end of the
|
|
|
|
* struct to allow this for the variable number of elements.
|
|
|
|
*/
|
2023-01-10 23:14:59 +03:00
|
|
|
dva_t sio_dva[];
|
2017-11-16 04:27:01 +03:00
|
|
|
} scan_io_t;
|
|
|
|
|
2019-03-16 00:14:31 +03:00
|
|
|
#define SIO_SET_OFFSET(sio, x) DVA_SET_OFFSET(&(sio)->sio_dva[0], x)
|
|
|
|
#define SIO_SET_ASIZE(sio, x) DVA_SET_ASIZE(&(sio)->sio_dva[0], x)
|
|
|
|
#define SIO_GET_OFFSET(sio) DVA_GET_OFFSET(&(sio)->sio_dva[0])
|
|
|
|
#define SIO_GET_ASIZE(sio) DVA_GET_ASIZE(&(sio)->sio_dva[0])
|
|
|
|
#define SIO_GET_END_OFFSET(sio) \
|
|
|
|
(SIO_GET_OFFSET(sio) + SIO_GET_ASIZE(sio))
|
|
|
|
#define SIO_GET_MUSED(sio) \
|
|
|
|
(sizeof (scan_io_t) + ((sio)->sio_nr_dvas * sizeof (dva_t)))
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
struct dsl_scan_io_queue {
|
|
|
|
dsl_scan_t *q_scn; /* associated dsl_scan_t */
|
|
|
|
vdev_t *q_vd; /* top-level vdev that this queue represents */
|
2022-06-16 00:25:08 +03:00
|
|
|
zio_t *q_zio; /* scn_zio_root child for waiting on IO */
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/* trees used for sorting I/Os and extents of I/Os */
|
|
|
|
range_tree_t *q_exts_by_addr;
|
2022-06-24 19:50:37 +03:00
|
|
|
zfs_btree_t q_exts_by_size;
|
2017-11-16 04:27:01 +03:00
|
|
|
avl_tree_t q_sios_by_addr;
|
2019-03-16 00:14:31 +03:00
|
|
|
uint64_t q_sio_memused;
|
2022-06-24 19:50:37 +03:00
|
|
|
uint64_t q_last_ext_addr;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/* members for zio rate limiting */
|
|
|
|
uint64_t q_maxinflight_bytes;
|
|
|
|
uint64_t q_inflight_bytes;
|
|
|
|
kcondvar_t q_zio_cv; /* used under vd->vdev_scan_io_queue_lock */
|
|
|
|
|
|
|
|
/* per txg statistics */
|
|
|
|
uint64_t q_total_seg_size_this_txg;
|
|
|
|
uint64_t q_segs_this_txg;
|
|
|
|
uint64_t q_total_zio_size_this_txg;
|
|
|
|
uint64_t q_zios_this_txg;
|
|
|
|
};
|
|
|
|
|
|
|
|
/* private data for dsl_scan_prefetch_cb() */
|
|
|
|
typedef struct scan_prefetch_ctx {
|
2018-09-26 20:29:26 +03:00
|
|
|
zfs_refcount_t spc_refcnt; /* refcount for memory management */
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_t *spc_scn; /* dsl_scan_t for the pool */
|
|
|
|
boolean_t spc_root; /* is this prefetch for an objset? */
|
|
|
|
uint8_t spc_indblkshift; /* dn_indblkshift of current dnode */
|
|
|
|
uint16_t spc_datablkszsec; /* dn_idatablkszsec of current dnode */
|
|
|
|
} scan_prefetch_ctx_t;
|
|
|
|
|
|
|
|
/* private data for dsl_scan_prefetch() */
|
|
|
|
typedef struct scan_prefetch_issue_ctx {
|
|
|
|
avl_node_t spic_avl_node; /* link into scn->scn_prefetch_queue */
|
|
|
|
scan_prefetch_ctx_t *spic_spc; /* spc for the callback */
|
|
|
|
blkptr_t spic_bp; /* bp to prefetch */
|
|
|
|
zbookmark_phys_t spic_zb; /* bookmark to prefetch */
|
|
|
|
} scan_prefetch_issue_ctx_t;
|
|
|
|
|
|
|
|
static void scan_exec_io(dsl_pool_t *dp, const blkptr_t *bp, int zio_flags,
|
|
|
|
const zbookmark_phys_t *zb, dsl_scan_io_queue_t *queue);
|
|
|
|
static void scan_io_queue_insert_impl(dsl_scan_io_queue_t *queue,
|
|
|
|
scan_io_t *sio);
|
|
|
|
|
|
|
|
static dsl_scan_io_queue_t *scan_io_queue_create(vdev_t *vd);
|
|
|
|
static void scan_io_queues_destroy(dsl_scan_t *scn);
|
|
|
|
|
2019-03-16 00:14:31 +03:00
|
|
|
static kmem_cache_t *sio_cache[SPA_DVAS_PER_BP];
|
|
|
|
|
|
|
|
/* sio->sio_nr_dvas must be set so we know which cache to free from */
|
|
|
|
static void
|
|
|
|
sio_free(scan_io_t *sio)
|
|
|
|
{
|
|
|
|
ASSERT3U(sio->sio_nr_dvas, >, 0);
|
|
|
|
ASSERT3U(sio->sio_nr_dvas, <=, SPA_DVAS_PER_BP);
|
|
|
|
|
|
|
|
kmem_cache_free(sio_cache[sio->sio_nr_dvas - 1], sio);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* It is up to the caller to set sio->sio_nr_dvas for freeing */
|
|
|
|
static scan_io_t *
|
|
|
|
sio_alloc(unsigned short nr_dvas)
|
|
|
|
{
|
|
|
|
ASSERT3U(nr_dvas, >, 0);
|
|
|
|
ASSERT3U(nr_dvas, <=, SPA_DVAS_PER_BP);
|
|
|
|
|
|
|
|
return (kmem_cache_alloc(sio_cache[nr_dvas - 1], KM_SLEEP));
|
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
void
|
|
|
|
scan_init(void)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* This is used in ext_size_compare() to weight segments
|
|
|
|
* based on how sparse they are. This cannot be changed
|
|
|
|
* mid-scan and the tree comparison functions don't currently
|
2018-03-29 04:30:44 +03:00
|
|
|
* have a mechanism for passing additional context to the
|
2017-11-16 04:27:01 +03:00
|
|
|
* compare functions. Thus we store this value globally and
|
2018-03-29 04:30:44 +03:00
|
|
|
* we only allow it to be set at module initialization time
|
2017-11-16 04:27:01 +03:00
|
|
|
*/
|
|
|
|
fill_weight = zfs_scan_fill_weight;
|
|
|
|
|
2019-03-16 00:14:31 +03:00
|
|
|
for (int i = 0; i < SPA_DVAS_PER_BP; i++) {
|
|
|
|
char name[36];
|
|
|
|
|
2020-06-07 21:42:12 +03:00
|
|
|
(void) snprintf(name, sizeof (name), "sio_cache_%d", i);
|
2019-03-16 00:14:31 +03:00
|
|
|
sio_cache[i] = kmem_cache_create(name,
|
|
|
|
(sizeof (scan_io_t) + ((i + 1) * sizeof (dva_t))),
|
|
|
|
0, NULL, NULL, NULL, NULL, NULL, 0);
|
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
scan_fini(void)
|
|
|
|
{
|
2019-03-16 00:14:31 +03:00
|
|
|
for (int i = 0; i < SPA_DVAS_PER_BP; i++) {
|
|
|
|
kmem_cache_destroy(sio_cache[i]);
|
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static inline boolean_t
|
|
|
|
dsl_scan_is_running(const dsl_scan_t *scn)
|
|
|
|
{
|
|
|
|
return (scn->scn_phys.scn_state == DSS_SCANNING);
|
|
|
|
}
|
|
|
|
|
|
|
|
boolean_t
|
|
|
|
dsl_scan_resilvering(dsl_pool_t *dp)
|
|
|
|
{
|
|
|
|
return (dsl_scan_is_running(dp->dp_scan) &&
|
|
|
|
dp->dp_scan->scn_phys.scn_func == POOL_SCAN_RESILVER);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void
|
2019-03-16 00:14:31 +03:00
|
|
|
sio2bp(const scan_io_t *sio, blkptr_t *bp)
|
2017-11-16 04:27:01 +03:00
|
|
|
{
|
2022-02-25 16:26:54 +03:00
|
|
|
memset(bp, 0, sizeof (*bp));
|
2017-11-16 04:27:01 +03:00
|
|
|
bp->blk_prop = sio->sio_blk_prop;
|
2024-03-26 01:01:54 +03:00
|
|
|
BP_SET_PHYSICAL_BIRTH(bp, sio->sio_phys_birth);
|
|
|
|
BP_SET_LOGICAL_BIRTH(bp, sio->sio_birth);
|
2017-11-16 04:27:01 +03:00
|
|
|
bp->blk_fill = 1; /* we always only work with data pointers */
|
|
|
|
bp->blk_cksum = sio->sio_cksum;
|
2019-03-16 00:14:31 +03:00
|
|
|
|
|
|
|
ASSERT3U(sio->sio_nr_dvas, >, 0);
|
|
|
|
ASSERT3U(sio->sio_nr_dvas, <=, SPA_DVAS_PER_BP);
|
|
|
|
|
2022-02-25 16:26:54 +03:00
|
|
|
memcpy(bp->blk_dva, sio->sio_dva, sio->sio_nr_dvas * sizeof (dva_t));
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static inline void
|
|
|
|
bp2sio(const blkptr_t *bp, scan_io_t *sio, int dva_i)
|
|
|
|
{
|
|
|
|
sio->sio_blk_prop = bp->blk_prop;
|
2024-03-26 01:01:54 +03:00
|
|
|
sio->sio_phys_birth = BP_GET_PHYSICAL_BIRTH(bp);
|
|
|
|
sio->sio_birth = BP_GET_LOGICAL_BIRTH(bp);
|
2017-11-16 04:27:01 +03:00
|
|
|
sio->sio_cksum = bp->blk_cksum;
|
2019-03-16 00:14:31 +03:00
|
|
|
sio->sio_nr_dvas = BP_GET_NDVAS(bp);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copy the DVAs to the sio. We need all copies of the block so
|
|
|
|
* that the self healing code can use the alternate copies if the
|
|
|
|
* first is corrupted. We want the DVA at index dva_i to be first
|
|
|
|
* in the sio since this is the primary one that we want to issue.
|
|
|
|
*/
|
|
|
|
for (int i = 0, j = dva_i; i < sio->sio_nr_dvas; i++, j++) {
|
|
|
|
sio->sio_dva[i] = bp->blk_dva[j % sio->sio_nr_dvas];
|
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
int
|
|
|
|
dsl_scan_init(dsl_pool_t *dp, uint64_t txg)
|
|
|
|
{
|
|
|
|
int err;
|
|
|
|
dsl_scan_t *scn;
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
uint64_t f;
|
|
|
|
|
|
|
|
scn = dp->dp_scan = kmem_zalloc(sizeof (dsl_scan_t), KM_SLEEP);
|
|
|
|
scn->scn_dp = dp;
|
|
|
|
|
2013-04-23 21:31:42 +04:00
|
|
|
/*
|
|
|
|
* It's possible that we're resuming a scan after a reboot so
|
|
|
|
* make sure that the scan_async_destroying flag is initialized
|
|
|
|
* appropriately.
|
|
|
|
*/
|
|
|
|
ASSERT(!scn->scn_async_destroying);
|
|
|
|
scn->scn_async_destroying = spa_feature_is_active(dp->dp_spa,
|
2013-10-08 21:13:05 +04:00
|
|
|
SPA_FEATURE_ASYNC_DESTROY);
|
2013-04-23 21:31:42 +04:00
|
|
|
|
2018-01-31 20:33:33 +03:00
|
|
|
/*
|
|
|
|
* Calculate the max number of in-flight bytes for pool-wide
|
2023-01-25 01:05:45 +03:00
|
|
|
* scanning operations (minimum 1MB, maximum 1/4 of arc_c_max).
|
|
|
|
* Limits for the issuing phase are done per top-level vdev and
|
|
|
|
* are handled separately.
|
2018-01-31 20:33:33 +03:00
|
|
|
*/
|
2023-01-25 01:05:45 +03:00
|
|
|
scn->scn_maxinflight_bytes = MIN(arc_c_max / 4, MAX(1ULL << 20,
|
|
|
|
zfs_scan_vdev_limit * dsl_scan_count_data_disks(spa)));
|
2018-01-31 20:33:33 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
avl_create(&scn->scn_queue, scan_ds_queue_compare, sizeof (scan_ds_t),
|
|
|
|
offsetof(scan_ds_t, sds_node));
|
2024-05-09 17:32:59 +03:00
|
|
|
mutex_init(&scn->scn_queue_lock, NULL, MUTEX_DEFAULT, NULL);
|
2017-11-16 04:27:01 +03:00
|
|
|
avl_create(&scn->scn_prefetch_queue, scan_prefetch_queue_compare,
|
|
|
|
sizeof (scan_prefetch_issue_ctx_t),
|
|
|
|
offsetof(scan_prefetch_issue_ctx_t, spic_avl_node));
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
err = zap_lookup(dp->dp_meta_objset, DMU_POOL_DIRECTORY_OBJECT,
|
|
|
|
"scrub_func", sizeof (uint64_t), 1, &f);
|
|
|
|
if (err == 0) {
|
|
|
|
/*
|
|
|
|
* There was an old-style scrub in progress. Restart a
|
|
|
|
* new-style scrub from the beginning.
|
|
|
|
*/
|
|
|
|
scn->scn_restart_txg = txg;
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("old-style scrub was in progress for %s; "
|
2010-05-29 00:45:14 +04:00
|
|
|
"restarting new-style scrub in txg %llu",
|
2021-10-27 02:24:14 +03:00
|
|
|
spa->spa_name,
|
2017-11-16 04:27:01 +03:00
|
|
|
(longlong_t)scn->scn_restart_txg);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Load the queue obj from the old location so that it
|
|
|
|
* can be freed by dsl_scan_done().
|
|
|
|
*/
|
|
|
|
(void) zap_lookup(dp->dp_meta_objset, DMU_POOL_DIRECTORY_OBJECT,
|
|
|
|
"scrub_queue", sizeof (uint64_t), 1,
|
|
|
|
&scn->scn_phys.scn_queue_obj);
|
|
|
|
} else {
|
2021-12-17 23:35:28 +03:00
|
|
|
err = zap_lookup(dp->dp_meta_objset, DMU_POOL_DIRECTORY_OBJECT,
|
|
|
|
DMU_POOL_ERRORSCRUB, sizeof (uint64_t),
|
|
|
|
ERRORSCRUB_PHYS_NUMINTS, &scn->errorscrub_phys);
|
|
|
|
|
|
|
|
if (err != 0 && err != ENOENT)
|
|
|
|
return (err);
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
err = zap_lookup(dp->dp_meta_objset, DMU_POOL_DIRECTORY_OBJECT,
|
|
|
|
DMU_POOL_SCAN, sizeof (uint64_t), SCAN_PHYS_NUMINTS,
|
|
|
|
&scn->scn_phys);
|
2021-12-17 23:35:28 +03:00
|
|
|
|
Add erratum for issue #2094
ZoL commit 1421c89 unintentionally changed the disk format in a forward-
compatible, but not backward compatible way. This was accomplished by
adding an entry to zbookmark_t, which is included in a couple of
on-disk structures. That lead to the creation of pools with incorrect
dsl_scan_phys_t objects that could only be imported by versions of ZoL
containing that commit. Such pools cannot be imported by other versions
of ZFS or past versions of ZoL.
The additional field has been removed by the previous commit. However,
affected pools must be imported and scrubbed using a version of ZoL with
this commit applied. This will return the pools to a state in which they
may be imported by other implementations.
The 'zpool import' or 'zpool status' command can be used to determine if
a pool is impacted. A message similar to one of the following means your
pool must be scrubbed to restore compatibility.
$ zpool import
pool: zol-0.6.2-173
id: 1165955789558693437
state: ONLINE
status: Errata #1 detected.
action: The pool can be imported using its name or numeric identifier,
however there is a compatibility issue which should be corrected
by running 'zpool scrub'
see: http://zfsonlinux.org/msg/ZFS-8000-ER
config:
...
$ zpool status
pool: zol-0.6.2-173
state: ONLINE
scan: pool compatibility issue detected.
see: https://github.com/zfsonlinux/zfs/issues/2094
action: To correct the issue run 'zpool scrub'.
config:
...
If there was an async destroy in progress 'zpool import' will prevent
the pool from being imported. Further advice on how to proceed will be
provided by the error message as follows.
$ zpool import
pool: zol-0.6.2-173
id: 1165955789558693437
state: ONLINE
status: Errata #2 detected.
action: The pool can not be imported with this version of ZFS due to an
active asynchronous destroy. Revert to an earlier version and
allow the destroy to complete before updating.
see: http://zfsonlinux.org/msg/ZFS-8000-ER
config:
...
Pools affected by the damaged dsl_scan_phys_t can be detected prior to
an upgrade by running the following command as root:
zdb -dddd poolname 1 | grep -P '^\t\tscan = ' | sed -e 's;scan = ;;' | wc -w
Note that `poolname` must be replaced with the name of the pool you wish
to check. A value of 25 indicates the dsl_scan_phys_t has been damaged.
A value of 24 indicates that the dsl_scan_phys_t is normal. A value of 0
indicates that there has never been a scrub run on the pool.
The regression caused by the change to zbookmark_t never made it into a
tagged release, Gentoo backports, Ubuntu, Debian, Fedora, or EPEL
stable respositorys. Only those using the HEAD version directly from
Github after the 0.6.2 but before the 0.6.3 tag are affected.
This patch does have one limitation that should be mentioned. It will not
detect errata #2 on a pool unless errata #1 is also present. It expected
this will not be a significant problem because pools impacted by errata #2
have a high probably of being impacted by errata #1.
End users can ensure they do no hit this unlikely case by waiting for all
asynchronous destroy operations to complete before updating ZoL. The
presence of any background destroys on any imported pools can be checked
by running `zpool get freeing` as root. This will display a non-zero
value for any pool with an active asynchronous destroy.
Lastly, it is expected that no user data has been lost as a result of
this erratum.
Original-patch-by: Tim Chase <tim@chase2k.com>
Reworked-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #2094
2014-02-21 08:28:33 +04:00
|
|
|
/*
|
|
|
|
* Detect if the pool contains the signature of #2094. If it
|
|
|
|
* does properly update the scn->scn_phys structure and notify
|
|
|
|
* the administrator by setting an errata for the pool.
|
|
|
|
*/
|
|
|
|
if (err == EOVERFLOW) {
|
|
|
|
uint64_t zaptmp[SCAN_PHYS_NUMINTS + 1];
|
|
|
|
VERIFY3S(SCAN_PHYS_NUMINTS, ==, 24);
|
|
|
|
VERIFY3S(offsetof(dsl_scan_phys_t, scn_flags), ==,
|
|
|
|
(23 * sizeof (uint64_t)));
|
|
|
|
|
|
|
|
err = zap_lookup(dp->dp_meta_objset,
|
|
|
|
DMU_POOL_DIRECTORY_OBJECT, DMU_POOL_SCAN,
|
|
|
|
sizeof (uint64_t), SCAN_PHYS_NUMINTS + 1, &zaptmp);
|
|
|
|
if (err == 0) {
|
|
|
|
uint64_t overflow = zaptmp[SCAN_PHYS_NUMINTS];
|
|
|
|
|
|
|
|
if (overflow & ~DSL_SCAN_FLAGS_MASK ||
|
|
|
|
scn->scn_async_destroying) {
|
|
|
|
spa->spa_errata =
|
|
|
|
ZPOOL_ERRATA_ZOL_2094_ASYNC_DESTROY;
|
2017-11-16 04:27:01 +03:00
|
|
|
return (EOVERFLOW);
|
Add erratum for issue #2094
ZoL commit 1421c89 unintentionally changed the disk format in a forward-
compatible, but not backward compatible way. This was accomplished by
adding an entry to zbookmark_t, which is included in a couple of
on-disk structures. That lead to the creation of pools with incorrect
dsl_scan_phys_t objects that could only be imported by versions of ZoL
containing that commit. Such pools cannot be imported by other versions
of ZFS or past versions of ZoL.
The additional field has been removed by the previous commit. However,
affected pools must be imported and scrubbed using a version of ZoL with
this commit applied. This will return the pools to a state in which they
may be imported by other implementations.
The 'zpool import' or 'zpool status' command can be used to determine if
a pool is impacted. A message similar to one of the following means your
pool must be scrubbed to restore compatibility.
$ zpool import
pool: zol-0.6.2-173
id: 1165955789558693437
state: ONLINE
status: Errata #1 detected.
action: The pool can be imported using its name or numeric identifier,
however there is a compatibility issue which should be corrected
by running 'zpool scrub'
see: http://zfsonlinux.org/msg/ZFS-8000-ER
config:
...
$ zpool status
pool: zol-0.6.2-173
state: ONLINE
scan: pool compatibility issue detected.
see: https://github.com/zfsonlinux/zfs/issues/2094
action: To correct the issue run 'zpool scrub'.
config:
...
If there was an async destroy in progress 'zpool import' will prevent
the pool from being imported. Further advice on how to proceed will be
provided by the error message as follows.
$ zpool import
pool: zol-0.6.2-173
id: 1165955789558693437
state: ONLINE
status: Errata #2 detected.
action: The pool can not be imported with this version of ZFS due to an
active asynchronous destroy. Revert to an earlier version and
allow the destroy to complete before updating.
see: http://zfsonlinux.org/msg/ZFS-8000-ER
config:
...
Pools affected by the damaged dsl_scan_phys_t can be detected prior to
an upgrade by running the following command as root:
zdb -dddd poolname 1 | grep -P '^\t\tscan = ' | sed -e 's;scan = ;;' | wc -w
Note that `poolname` must be replaced with the name of the pool you wish
to check. A value of 25 indicates the dsl_scan_phys_t has been damaged.
A value of 24 indicates that the dsl_scan_phys_t is normal. A value of 0
indicates that there has never been a scrub run on the pool.
The regression caused by the change to zbookmark_t never made it into a
tagged release, Gentoo backports, Ubuntu, Debian, Fedora, or EPEL
stable respositorys. Only those using the HEAD version directly from
Github after the 0.6.2 but before the 0.6.3 tag are affected.
This patch does have one limitation that should be mentioned. It will not
detect errata #2 on a pool unless errata #1 is also present. It expected
this will not be a significant problem because pools impacted by errata #2
have a high probably of being impacted by errata #1.
End users can ensure they do no hit this unlikely case by waiting for all
asynchronous destroy operations to complete before updating ZoL. The
presence of any background destroys on any imported pools can be checked
by running `zpool get freeing` as root. This will display a non-zero
value for any pool with an active asynchronous destroy.
Lastly, it is expected that no user data has been lost as a result of
this erratum.
Original-patch-by: Tim Chase <tim@chase2k.com>
Reworked-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #2094
2014-02-21 08:28:33 +04:00
|
|
|
}
|
|
|
|
|
2022-02-25 16:26:54 +03:00
|
|
|
memcpy(&scn->scn_phys, zaptmp,
|
Add erratum for issue #2094
ZoL commit 1421c89 unintentionally changed the disk format in a forward-
compatible, but not backward compatible way. This was accomplished by
adding an entry to zbookmark_t, which is included in a couple of
on-disk structures. That lead to the creation of pools with incorrect
dsl_scan_phys_t objects that could only be imported by versions of ZoL
containing that commit. Such pools cannot be imported by other versions
of ZFS or past versions of ZoL.
The additional field has been removed by the previous commit. However,
affected pools must be imported and scrubbed using a version of ZoL with
this commit applied. This will return the pools to a state in which they
may be imported by other implementations.
The 'zpool import' or 'zpool status' command can be used to determine if
a pool is impacted. A message similar to one of the following means your
pool must be scrubbed to restore compatibility.
$ zpool import
pool: zol-0.6.2-173
id: 1165955789558693437
state: ONLINE
status: Errata #1 detected.
action: The pool can be imported using its name or numeric identifier,
however there is a compatibility issue which should be corrected
by running 'zpool scrub'
see: http://zfsonlinux.org/msg/ZFS-8000-ER
config:
...
$ zpool status
pool: zol-0.6.2-173
state: ONLINE
scan: pool compatibility issue detected.
see: https://github.com/zfsonlinux/zfs/issues/2094
action: To correct the issue run 'zpool scrub'.
config:
...
If there was an async destroy in progress 'zpool import' will prevent
the pool from being imported. Further advice on how to proceed will be
provided by the error message as follows.
$ zpool import
pool: zol-0.6.2-173
id: 1165955789558693437
state: ONLINE
status: Errata #2 detected.
action: The pool can not be imported with this version of ZFS due to an
active asynchronous destroy. Revert to an earlier version and
allow the destroy to complete before updating.
see: http://zfsonlinux.org/msg/ZFS-8000-ER
config:
...
Pools affected by the damaged dsl_scan_phys_t can be detected prior to
an upgrade by running the following command as root:
zdb -dddd poolname 1 | grep -P '^\t\tscan = ' | sed -e 's;scan = ;;' | wc -w
Note that `poolname` must be replaced with the name of the pool you wish
to check. A value of 25 indicates the dsl_scan_phys_t has been damaged.
A value of 24 indicates that the dsl_scan_phys_t is normal. A value of 0
indicates that there has never been a scrub run on the pool.
The regression caused by the change to zbookmark_t never made it into a
tagged release, Gentoo backports, Ubuntu, Debian, Fedora, or EPEL
stable respositorys. Only those using the HEAD version directly from
Github after the 0.6.2 but before the 0.6.3 tag are affected.
This patch does have one limitation that should be mentioned. It will not
detect errata #2 on a pool unless errata #1 is also present. It expected
this will not be a significant problem because pools impacted by errata #2
have a high probably of being impacted by errata #1.
End users can ensure they do no hit this unlikely case by waiting for all
asynchronous destroy operations to complete before updating ZoL. The
presence of any background destroys on any imported pools can be checked
by running `zpool get freeing` as root. This will display a non-zero
value for any pool with an active asynchronous destroy.
Lastly, it is expected that no user data has been lost as a result of
this erratum.
Original-patch-by: Tim Chase <tim@chase2k.com>
Reworked-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #2094
2014-02-21 08:28:33 +04:00
|
|
|
SCAN_PHYS_NUMINTS * sizeof (uint64_t));
|
|
|
|
scn->scn_phys.scn_flags = overflow;
|
|
|
|
|
|
|
|
/* Required scrub already in progress. */
|
|
|
|
if (scn->scn_phys.scn_state == DSS_FINISHED ||
|
|
|
|
scn->scn_phys.scn_state == DSS_CANCELED)
|
|
|
|
spa->spa_errata =
|
|
|
|
ZPOOL_ERRATA_ZOL_2094_SCRUB;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
if (err == ENOENT)
|
|
|
|
return (0);
|
|
|
|
else if (err)
|
|
|
|
return (err);
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* We might be restarting after a reboot, so jump the issued
|
|
|
|
* counter to how far we've scanned. We know we're consistent
|
|
|
|
* up to here.
|
|
|
|
*/
|
Do not report bytes skipped by scan as issued.
Scan process may skip blocks based on their birth time, DVA, etc.
Traditionally those blocks were accounted as issued, that caused
reporting of hugely over-inflated numbers, having nothing to do
with actual disk I/O. This change utilizes never used field in
struct dsl_scan_phys to account such skipped bytes, allowing to
report how much data were actually scrubbed/resilvered and what
is the actual I/O speed. While formally it is an on-disk format
change, it should be compatible both ways, so should not need a
feature flag.
This should partially address the same issue as c85ac731a0e, but
from a different perspective, complementing it.
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Akash B <akash-b@hpe.com>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.
Closes #15007
2023-06-30 18:47:13 +03:00
|
|
|
scn->scn_issued_before_pass = scn->scn_phys.scn_examined -
|
|
|
|
scn->scn_phys.scn_skipped;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
if (dsl_scan_is_running(scn) &&
|
2010-05-29 00:45:14 +04:00
|
|
|
spa_prev_software_version(dp->dp_spa) < SPA_VERSION_SCAN) {
|
|
|
|
/*
|
|
|
|
* A new-type scrub was in progress on an old
|
|
|
|
* pool, and the pool was accessed by old
|
|
|
|
* software. Restart from the beginning, since
|
|
|
|
* the old software may have changed the pool in
|
|
|
|
* the meantime.
|
|
|
|
*/
|
|
|
|
scn->scn_restart_txg = txg;
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("new-style scrub for %s was modified "
|
2010-05-29 00:45:14 +04:00
|
|
|
"by old software; restarting in txg %llu",
|
2021-10-27 02:24:14 +03:00
|
|
|
spa->spa_name,
|
2017-11-16 04:27:01 +03:00
|
|
|
(longlong_t)scn->scn_restart_txg);
|
Resilver restarts unnecessarily when it encounters errors
When a resilver finishes, vdev_dtl_reassess is called to hopefully
excise DTL_MISSING (amongst other things). If there are errors during
the resilver, they are tracked in DTL_SCRUB, as spelled out in the
block comment in vdev.c. DTL_SCRUB is in-core only, so it can only
be used if the pool was online for the whole resilver. This state is
tracked with the spa_scrub_started flag, which only gets set when
the scan is initialized. Unfortunately, this flag gets cleared right
before vdev_dtl_reassess gets called, so if there are any errors
during the scan, DTL_MISSING will never get excised and the resilver
will just continually restart. This fix simply moves clearing that
flag until after the call to vdev_dtl_reasses.
In addition, if a pool is imported and already has scn_errors > 0,
this change will restart the resilver immediately instead of doing
the rest of the scan and then restarting it from the beginning. On
the other hand, if scn_errors == 0 at import, then no errors have
been encountered so far, so the spa_scrub_started flag can be safely
set.
A test has been added to verify that resilver does not restart when
relevant DTL's are available.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Paul Zuchowski <pzuchowski@datto.com>
Signed-off-by: John Poduska <jpoduska@datto.com>
Closes #10291
2020-05-13 20:54:27 +03:00
|
|
|
} else if (dsl_scan_resilvering(dp)) {
|
|
|
|
/*
|
|
|
|
* If a resilver is in progress and there are already
|
|
|
|
* errors, restart it instead of finishing this scan and
|
|
|
|
* then restarting it. If there haven't been any errors
|
|
|
|
* then remember that the incore DTL is valid.
|
|
|
|
*/
|
|
|
|
if (scn->scn_phys.scn_errors > 0) {
|
|
|
|
scn->scn_restart_txg = txg;
|
|
|
|
zfs_dbgmsg("resilver can't excise DTL_MISSING "
|
2021-10-27 02:24:14 +03:00
|
|
|
"when finished; restarting on %s in txg "
|
|
|
|
"%llu",
|
|
|
|
spa->spa_name,
|
Resilver restarts unnecessarily when it encounters errors
When a resilver finishes, vdev_dtl_reassess is called to hopefully
excise DTL_MISSING (amongst other things). If there are errors during
the resilver, they are tracked in DTL_SCRUB, as spelled out in the
block comment in vdev.c. DTL_SCRUB is in-core only, so it can only
be used if the pool was online for the whole resilver. This state is
tracked with the spa_scrub_started flag, which only gets set when
the scan is initialized. Unfortunately, this flag gets cleared right
before vdev_dtl_reassess gets called, so if there are any errors
during the scan, DTL_MISSING will never get excised and the resilver
will just continually restart. This fix simply moves clearing that
flag until after the call to vdev_dtl_reasses.
In addition, if a pool is imported and already has scn_errors > 0,
this change will restart the resilver immediately instead of doing
the rest of the scan and then restarting it from the beginning. On
the other hand, if scn_errors == 0 at import, then no errors have
been encountered so far, so the spa_scrub_started flag can be safely
set.
A test has been added to verify that resilver does not restart when
relevant DTL's are available.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Paul Zuchowski <pzuchowski@datto.com>
Signed-off-by: John Poduska <jpoduska@datto.com>
Closes #10291
2020-05-13 20:54:27 +03:00
|
|
|
(u_longlong_t)scn->scn_restart_txg);
|
|
|
|
} else {
|
|
|
|
/* it's safe to excise DTL when finished */
|
|
|
|
spa->spa_scrub_started = B_TRUE;
|
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-02-25 16:26:54 +03:00
|
|
|
memcpy(&scn->scn_phys_cached, &scn->scn_phys, sizeof (scn->scn_phys));
|
2018-10-23 22:17:18 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/* reload the queue into the in-core state */
|
|
|
|
if (scn->scn_phys.scn_queue_obj != 0) {
|
|
|
|
zap_cursor_t zc;
|
|
|
|
zap_attribute_t za;
|
|
|
|
|
|
|
|
for (zap_cursor_init(&zc, dp->dp_meta_objset,
|
|
|
|
scn->scn_phys.scn_queue_obj);
|
|
|
|
zap_cursor_retrieve(&zc, &za) == 0;
|
|
|
|
(void) zap_cursor_advance(&zc)) {
|
|
|
|
scan_ds_queue_insert(scn,
|
|
|
|
zfs_strtonum(za.za_name, NULL),
|
|
|
|
za.za_first_integer);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
zap_cursor_fini(&zc);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
spa_scan_stat_init(spa);
|
2023-01-25 22:28:54 +03:00
|
|
|
vdev_scan_stat_init(spa->spa_root_vdev);
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
dsl_scan_fini(dsl_pool_t *dp)
|
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
if (dp->dp_scan != NULL) {
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
|
|
|
|
if (scn->scn_taskq != NULL)
|
|
|
|
taskq_destroy(scn->scn_taskq);
|
2018-12-06 20:47:23 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_ds_queue_clear(scn);
|
|
|
|
avl_destroy(&scn->scn_queue);
|
2024-05-09 17:32:59 +03:00
|
|
|
mutex_destroy(&scn->scn_queue_lock);
|
2018-12-06 20:47:23 +03:00
|
|
|
scan_ds_prefetch_queue_clear(scn);
|
2017-11-16 04:27:01 +03:00
|
|
|
avl_destroy(&scn->scn_prefetch_queue);
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
kmem_free(dp->dp_scan, sizeof (dsl_scan_t));
|
|
|
|
dp->dp_scan = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static boolean_t
|
|
|
|
dsl_scan_restarting(dsl_scan_t *scn, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
return (scn->scn_restart_txg != 0 &&
|
|
|
|
scn->scn_restart_txg <= tx->tx_txg);
|
|
|
|
}
|
|
|
|
|
2019-11-27 21:15:01 +03:00
|
|
|
boolean_t
|
|
|
|
dsl_scan_resilver_scheduled(dsl_pool_t *dp)
|
|
|
|
{
|
|
|
|
return ((dp->dp_scan && dp->dp_scan->scn_restart_txg != 0) ||
|
|
|
|
(spa_async_tasks(dp->dp_spa) & SPA_ASYNC_RESILVER));
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
boolean_t
|
|
|
|
dsl_scan_scrubbing(const dsl_pool_t *dp)
|
|
|
|
{
|
|
|
|
dsl_scan_phys_t *scn_phys = &dp->dp_scan->scn_phys;
|
|
|
|
|
|
|
|
return (scn_phys->scn_state == DSS_SCANNING &&
|
|
|
|
scn_phys->scn_func == POOL_SCAN_SCRUB);
|
|
|
|
}
|
|
|
|
|
2021-12-17 23:35:28 +03:00
|
|
|
boolean_t
|
|
|
|
dsl_errorscrubbing(const dsl_pool_t *dp)
|
|
|
|
{
|
|
|
|
dsl_errorscrub_phys_t *errorscrub_phys = &dp->dp_scan->errorscrub_phys;
|
|
|
|
|
|
|
|
return (errorscrub_phys->dep_state == DSS_ERRORSCRUBBING &&
|
|
|
|
errorscrub_phys->dep_func == POOL_SCAN_ERRORSCRUB);
|
|
|
|
}
|
|
|
|
|
|
|
|
boolean_t
|
|
|
|
dsl_errorscrub_is_paused(const dsl_scan_t *scn)
|
|
|
|
{
|
|
|
|
return (dsl_errorscrubbing(scn->scn_dp) &&
|
|
|
|
scn->errorscrub_phys.dep_paused_flags);
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
boolean_t
|
|
|
|
dsl_scan_is_paused_scrub(const dsl_scan_t *scn)
|
|
|
|
{
|
|
|
|
return (dsl_scan_scrubbing(scn->scn_dp) &&
|
|
|
|
scn->scn_phys.scn_flags & DSF_SCRUB_PAUSED);
|
|
|
|
}
|
|
|
|
|
2021-12-17 23:35:28 +03:00
|
|
|
static void
|
|
|
|
dsl_errorscrub_sync_state(dsl_scan_t *scn, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
scn->errorscrub_phys.dep_cursor =
|
|
|
|
zap_cursor_serialize(&scn->errorscrub_cursor);
|
|
|
|
|
|
|
|
VERIFY0(zap_update(scn->scn_dp->dp_meta_objset,
|
|
|
|
DMU_POOL_DIRECTORY_OBJECT,
|
|
|
|
DMU_POOL_ERRORSCRUB, sizeof (uint64_t), ERRORSCRUB_PHYS_NUMINTS,
|
|
|
|
&scn->errorscrub_phys, tx));
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_errorscrub_setup_sync(void *arg, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
dsl_scan_t *scn = dmu_tx_pool(tx)->dp_scan;
|
|
|
|
pool_scan_func_t *funcp = arg;
|
|
|
|
dsl_pool_t *dp = scn->scn_dp;
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
|
|
|
|
ASSERT(!dsl_scan_is_running(scn));
|
|
|
|
ASSERT(!dsl_errorscrubbing(scn->scn_dp));
|
|
|
|
ASSERT(*funcp > POOL_SCAN_NONE && *funcp < POOL_SCAN_FUNCS);
|
|
|
|
|
|
|
|
memset(&scn->errorscrub_phys, 0, sizeof (scn->errorscrub_phys));
|
|
|
|
scn->errorscrub_phys.dep_func = *funcp;
|
|
|
|
scn->errorscrub_phys.dep_state = DSS_ERRORSCRUBBING;
|
|
|
|
scn->errorscrub_phys.dep_start_time = gethrestime_sec();
|
|
|
|
scn->errorscrub_phys.dep_to_examine = spa_get_last_errlog_size(spa);
|
|
|
|
scn->errorscrub_phys.dep_examined = 0;
|
|
|
|
scn->errorscrub_phys.dep_errors = 0;
|
|
|
|
scn->errorscrub_phys.dep_cursor = 0;
|
|
|
|
zap_cursor_init_serialized(&scn->errorscrub_cursor,
|
|
|
|
spa->spa_meta_objset, spa->spa_errlog_last,
|
|
|
|
scn->errorscrub_phys.dep_cursor);
|
|
|
|
|
|
|
|
vdev_config_dirty(spa->spa_root_vdev);
|
|
|
|
spa_event_notify(spa, NULL, NULL, ESC_ZFS_ERRORSCRUB_START);
|
|
|
|
|
|
|
|
dsl_errorscrub_sync_state(scn, tx);
|
|
|
|
|
|
|
|
spa_history_log_internal(spa, "error scrub setup", tx,
|
|
|
|
"func=%u mintxg=%u maxtxg=%llu",
|
|
|
|
*funcp, 0, (u_longlong_t)tx->tx_txg);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
dsl_errorscrub_setup_check(void *arg, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
(void) arg;
|
|
|
|
dsl_scan_t *scn = dmu_tx_pool(tx)->dp_scan;
|
|
|
|
|
|
|
|
if (dsl_scan_is_running(scn) || (dsl_errorscrubbing(scn->scn_dp))) {
|
|
|
|
return (SET_ERROR(EBUSY));
|
|
|
|
}
|
|
|
|
|
|
|
|
if (spa_get_last_errlog_size(scn->scn_dp->dp_spa) == 0) {
|
|
|
|
return (ECANCELED);
|
|
|
|
}
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* Writes out a persistent dsl_scan_phys_t record to the pool directory.
|
|
|
|
* Because we can be running in the block sorting algorithm, we do not always
|
|
|
|
* want to write out the record, only when it is "safe" to do so. This safety
|
|
|
|
* condition is achieved by making sure that the sorting queues are empty
|
2022-06-24 19:50:37 +03:00
|
|
|
* (scn_queues_pending == 0). When this condition is not true, the sync'd state
|
2017-11-16 04:27:01 +03:00
|
|
|
* is inconsistent with how much actual scanning progress has been made. The
|
|
|
|
* kind of sync to be performed is specified by the sync_type argument. If the
|
|
|
|
* sync is optional, we only sync if the queues are empty. If the sync is
|
|
|
|
* mandatory, we do a hard ASSERT to make sure that the queues are empty. The
|
|
|
|
* third possible state is a "cached" sync. This is done in response to:
|
|
|
|
* 1) The dataset that was in the last sync'd dsl_scan_phys_t having been
|
|
|
|
* destroyed, so we wouldn't be able to restart scanning from it.
|
|
|
|
* 2) The snapshot that was in the last sync'd dsl_scan_phys_t having been
|
|
|
|
* superseded by a newer snapshot.
|
|
|
|
* 3) The dataset that was in the last sync'd dsl_scan_phys_t having been
|
|
|
|
* swapped with its clone.
|
|
|
|
* In all cases, a cached sync simply rewrites the last record we've written,
|
|
|
|
* just slightly modified. For the modifications that are performed to the
|
|
|
|
* last written dsl_scan_phys_t, see dsl_scan_ds_destroyed,
|
|
|
|
* dsl_scan_ds_snapshotted and dsl_scan_ds_clone_swapped.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
dsl_scan_sync_state(dsl_scan_t *scn, dmu_tx_t *tx, state_sync_type_t sync_type)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
spa_t *spa = scn->scn_dp->dp_spa;
|
|
|
|
|
2022-06-24 19:50:37 +03:00
|
|
|
ASSERT(sync_type != SYNC_MANDATORY || scn->scn_queues_pending == 0);
|
|
|
|
if (scn->scn_queues_pending == 0) {
|
2017-11-16 04:27:01 +03:00
|
|
|
for (i = 0; i < spa->spa_root_vdev->vdev_children; i++) {
|
|
|
|
vdev_t *vd = spa->spa_root_vdev->vdev_child[i];
|
|
|
|
dsl_scan_io_queue_t *q = vd->vdev_scan_io_queue;
|
|
|
|
|
|
|
|
if (q == NULL)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
mutex_enter(&vd->vdev_scan_io_queue_lock);
|
|
|
|
ASSERT3P(avl_first(&q->q_sios_by_addr), ==, NULL);
|
Reduce loaded range tree memory usage
This patch implements a new tree structure for ZFS, and uses it to
store range trees more efficiently.
The new structure is approximately a B-tree, though there are some
small differences from the usual characterizations. The tree has core
nodes and leaf nodes; each contain data elements, which the elements
in the core nodes acting as separators between its children. The
difference between core and leaf nodes is that the core nodes have an
array of children, while leaf nodes don't. Every node in the tree may
be only partially full; in most cases, they are all at least 50% full
(in terms of element count) except for the root node, which can be
less full. Underfull nodes will steal from their neighbors or merge to
remain full enough, while overfull nodes will split in two. The data
elements are contained in tree-controlled buffers; they are copied
into these on insertion, and overwritten on deletion. This means that
the elements are not independently allocated, which reduces overhead,
but also means they can't be shared between trees (and also that
pointers to them are only valid until a side-effectful tree operation
occurs). The overhead varies based on how dense the tree is, but is
usually on the order of about 50% of the element size; the per-node
overheads are very small, and so don't make a significant difference.
The trees can accept arbitrary records; they accept a size and a
comparator to allow them to be used for a variety of purposes.
The new trees replace the AVL trees used in the range trees today.
Currently, the range_seg_t structure contains three 8 byte integers
of payload and two 24 byte avl_tree_node_ts to handle its storage in
both an offset-sorted tree and a size-sorted tree (total size: 64
bytes). In the new model, the range seg structures are usually two 4
byte integers, but a separate one needs to exist for the size-sorted
and offset-sorted tree. Between the raw size, the 50% overhead, and
the double storage, the new btrees are expected to use 8*1.5*2 = 24
bytes per record, or 33.3% as much memory as the AVL trees (this is
for the purposes of storing metaslab range trees; for other purposes,
like scrubs, they use ~50% as much memory).
We reduced the size of the payload in the range segments by teaching
range trees about starting offsets and shifts; since metaslabs have a
fixed starting offset, and they all operate in terms of disk sectors,
we can store the ranges using 4-byte integers as long as the size of
the metaslab divided by the sector size is less than 2^32. For 512-byte
sectors, this is a 2^41 (or 2TB) metaslab, which with the default
settings corresponds to a 256PB disk. 4k sector disks can handle
metaslabs up to 2^46 bytes, or 2^63 byte disks. Since we do not
anticipate disks of this size in the near future, there should be
almost no cases where metaslabs need 64-byte integers to store their
ranges. We do still have the capability to store 64-byte integer ranges
to account for cases where we are storing per-vdev (or per-dnode) trees,
which could reasonably go above the limits discussed. We also do not
store fill information in the compact version of the node, since it
is only used for sorted scrub.
We also optimized the metaslab loading process in various other ways
to offset some inefficiencies in the btree model. While individual
operations (find, insert, remove_from) are faster for the btree than
they are for the avl tree, remove usually requires a find operation,
while in the AVL tree model the element itself suffices. Some clever
changes actually caused an overall speedup in metaslab loading; we use
approximately 40% less cpu to load metaslabs in our tests on Illumos.
Another memory and performance optimization was achieved by changing
what is stored in the size-sorted trees. When a disk is heavily
fragmented, the df algorithm used by default in ZFS will almost always
find a number of small regions in its initial cursor-based search; it
will usually only fall back to the size-sorted tree to find larger
regions. If we increase the size of the cursor-based search slightly,
and don't store segments that are smaller than a tunable size floor
in the size-sorted tree, we can further cut memory usage down to
below 20% of what the AVL trees store. This also results in further
reductions in CPU time spent loading metaslabs.
The 16KiB size floor was chosen because it results in substantial memory
usage reduction while not usually resulting in situations where we can't
find an appropriate chunk with the cursor and are forced to use an
oversized chunk from the size-sorted tree. In addition, even if we do
have to use an oversized chunk from the size-sorted tree, the chunk
would be too small to use for ZIL allocations, so it isn't as big of a
loss as it might otherwise be. And often, more small allocations will
follow the initial one, and the cursor search will now find the
remainder of the chunk we didn't use all of and use it for subsequent
allocations. Practical testing has shown little or no change in
fragmentation as a result of this change.
If the size-sorted tree becomes empty while the offset sorted one still
has entries, it will load all the entries from the offset sorted tree
and disregard the size floor until it is unloaded again. This operation
occurs rarely with the default setting, only on incredibly thoroughly
fragmented pools.
There are some other small changes to zdb to teach it to handle btrees,
but nothing major.
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Sebastien Roy seb@delphix.com
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9181
2019-10-09 20:36:03 +03:00
|
|
|
ASSERT3P(zfs_btree_first(&q->q_exts_by_size, NULL), ==,
|
|
|
|
NULL);
|
2017-11-16 04:27:01 +03:00
|
|
|
ASSERT3P(range_tree_first(q->q_exts_by_addr), ==, NULL);
|
|
|
|
mutex_exit(&vd->vdev_scan_io_queue_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (scn->scn_phys.scn_queue_obj != 0)
|
|
|
|
scan_ds_queue_sync(scn, tx);
|
|
|
|
VERIFY0(zap_update(scn->scn_dp->dp_meta_objset,
|
|
|
|
DMU_POOL_DIRECTORY_OBJECT,
|
|
|
|
DMU_POOL_SCAN, sizeof (uint64_t), SCAN_PHYS_NUMINTS,
|
|
|
|
&scn->scn_phys, tx));
|
2022-02-25 16:26:54 +03:00
|
|
|
memcpy(&scn->scn_phys_cached, &scn->scn_phys,
|
2017-11-16 04:27:01 +03:00
|
|
|
sizeof (scn->scn_phys));
|
|
|
|
|
|
|
|
if (scn->scn_checkpointing)
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("finish scan checkpoint for %s",
|
|
|
|
spa->spa_name);
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
scn->scn_checkpointing = B_FALSE;
|
|
|
|
scn->scn_last_checkpoint = ddi_get_lbolt();
|
|
|
|
} else if (sync_type == SYNC_CACHED) {
|
|
|
|
VERIFY0(zap_update(scn->scn_dp->dp_meta_objset,
|
|
|
|
DMU_POOL_DIRECTORY_OBJECT,
|
|
|
|
DMU_POOL_SCAN, sizeof (uint64_t), SCAN_PHYS_NUMINTS,
|
|
|
|
&scn->scn_phys_cached, tx));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-04-09 00:33:15 +03:00
|
|
|
int
|
2013-09-04 16:00:57 +04:00
|
|
|
dsl_scan_setup_check(void *arg, dmu_tx_t *tx)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2021-12-12 18:06:44 +03:00
|
|
|
(void) arg;
|
2013-09-04 16:00:57 +04:00
|
|
|
dsl_scan_t *scn = dmu_tx_pool(tx)->dp_scan;
|
2020-07-03 21:05:50 +03:00
|
|
|
vdev_t *rvd = scn->scn_dp->dp_spa->spa_root_vdev;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2021-12-17 23:35:28 +03:00
|
|
|
if (dsl_scan_is_running(scn) || vdev_rebuild_active(rvd) ||
|
|
|
|
dsl_errorscrubbing(scn->scn_dp))
|
2013-03-08 22:41:28 +04:00
|
|
|
return (SET_ERROR(EBUSY));
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
Distributed Spare (dRAID) Feature
This patch adds a new top-level vdev type called dRAID, which stands
for Distributed parity RAID. This pool configuration allows all dRAID
vdevs to participate when rebuilding to a distributed hot spare device.
This can substantially reduce the total time required to restore full
parity to pool with a failed device.
A dRAID pool can be created using the new top-level `draid` type.
Like `raidz`, the desired redundancy is specified after the type:
`draid[1,2,3]`. No additional information is required to create the
pool and reasonable default values will be chosen based on the number
of child vdevs in the dRAID vdev.
zpool create <pool> draid[1,2,3] <vdevs...>
Unlike raidz, additional optional dRAID configuration values can be
provided as part of the draid type as colon separated values. This
allows administrators to fully specify a layout for either performance
or capacity reasons. The supported options include:
zpool create <pool> \
draid[<parity>][:<data>d][:<children>c][:<spares>s] \
<vdevs...>
- draid[parity] - Parity level (default 1)
- draid[:<data>d] - Data devices per group (default 8)
- draid[:<children>c] - Expected number of child vdevs
- draid[:<spares>s] - Distributed hot spares (default 0)
Abbreviated example `zpool status` output for a 68 disk dRAID pool
with two distributed spares using special allocation classes.
```
pool: tank
state: ONLINE
config:
NAME STATE READ WRITE CKSUM
slag7 ONLINE 0 0 0
draid2:8d:68c:2s-0 ONLINE 0 0 0
L0 ONLINE 0 0 0
L1 ONLINE 0 0 0
...
U25 ONLINE 0 0 0
U26 ONLINE 0 0 0
spare-53 ONLINE 0 0 0
U27 ONLINE 0 0 0
draid2-0-0 ONLINE 0 0 0
U28 ONLINE 0 0 0
U29 ONLINE 0 0 0
...
U42 ONLINE 0 0 0
U43 ONLINE 0 0 0
special
mirror-1 ONLINE 0 0 0
L5 ONLINE 0 0 0
U5 ONLINE 0 0 0
mirror-2 ONLINE 0 0 0
L6 ONLINE 0 0 0
U6 ONLINE 0 0 0
spares
draid2-0-0 INUSE currently in use
draid2-0-1 AVAIL
```
When adding test coverage for the new dRAID vdev type the following
options were added to the ztest command. These options are leverages
by zloop.sh to test a wide range of dRAID configurations.
-K draid|raidz|random - kind of RAID to test
-D <value> - dRAID data drives per group
-S <value> - dRAID distributed hot spares
-R <value> - RAID parity (raidz or dRAID)
The zpool_create, zpool_import, redundancy, replacement and fault
test groups have all been updated provide test coverage for the
dRAID feature.
Co-authored-by: Isaac Huang <he.huang@intel.com>
Co-authored-by: Mark Maybee <mmaybee@cray.com>
Co-authored-by: Don Brady <don.brady@delphix.com>
Co-authored-by: Matthew Ahrens <mahrens@delphix.com>
Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Mark Maybee <mmaybee@cray.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #10102
2020-11-14 00:51:51 +03:00
|
|
|
void
|
2013-09-04 16:00:57 +04:00
|
|
|
dsl_scan_setup_sync(void *arg, dmu_tx_t *tx)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2021-12-17 23:35:28 +03:00
|
|
|
(void) arg;
|
2013-09-04 16:00:57 +04:00
|
|
|
dsl_scan_t *scn = dmu_tx_pool(tx)->dp_scan;
|
|
|
|
pool_scan_func_t *funcp = arg;
|
2010-05-29 00:45:14 +04:00
|
|
|
dmu_object_type_t ot = 0;
|
|
|
|
dsl_pool_t *dp = scn->scn_dp;
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
ASSERT(!dsl_scan_is_running(scn));
|
2010-05-29 00:45:14 +04:00
|
|
|
ASSERT(*funcp > POOL_SCAN_NONE && *funcp < POOL_SCAN_FUNCS);
|
2022-02-25 16:26:54 +03:00
|
|
|
memset(&scn->scn_phys, 0, sizeof (scn->scn_phys));
|
2021-12-17 23:35:28 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we are starting a fresh scrub, we erase the error scrub
|
|
|
|
* information from disk.
|
|
|
|
*/
|
|
|
|
memset(&scn->errorscrub_phys, 0, sizeof (scn->errorscrub_phys));
|
|
|
|
dsl_errorscrub_sync_state(scn, tx);
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
scn->scn_phys.scn_func = *funcp;
|
|
|
|
scn->scn_phys.scn_state = DSS_SCANNING;
|
|
|
|
scn->scn_phys.scn_min_txg = 0;
|
|
|
|
scn->scn_phys.scn_max_txg = tx->tx_txg;
|
|
|
|
scn->scn_phys.scn_ddt_class_max = DDT_CLASSES - 1; /* the entire DDT */
|
|
|
|
scn->scn_phys.scn_start_time = gethrestime_sec();
|
|
|
|
scn->scn_phys.scn_errors = 0;
|
|
|
|
scn->scn_phys.scn_to_examine = spa->spa_root_vdev->vdev_stat.vs_alloc;
|
2017-11-16 04:27:01 +03:00
|
|
|
scn->scn_issued_before_pass = 0;
|
2010-05-29 00:45:14 +04:00
|
|
|
scn->scn_restart_txg = 0;
|
2013-08-08 00:16:22 +04:00
|
|
|
scn->scn_done_txg = 0;
|
2017-11-16 04:27:01 +03:00
|
|
|
scn->scn_last_checkpoint = 0;
|
|
|
|
scn->scn_checkpointing = B_FALSE;
|
2010-05-29 00:45:14 +04:00
|
|
|
spa_scan_stat_init(spa);
|
2023-01-25 22:28:54 +03:00
|
|
|
vdev_scan_stat_init(spa->spa_root_vdev);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
if (DSL_SCAN_IS_SCRUB_RESILVER(scn)) {
|
|
|
|
scn->scn_phys.scn_ddt_class_max = zfs_scrub_ddt_class_max;
|
|
|
|
|
|
|
|
/* rewrite all disk labels */
|
|
|
|
vdev_config_dirty(spa->spa_root_vdev);
|
|
|
|
|
|
|
|
if (vdev_resilver_needed(spa->spa_root_vdev,
|
|
|
|
&scn->scn_phys.scn_min_txg, &scn->scn_phys.scn_max_txg)) {
|
2020-07-03 21:05:50 +03:00
|
|
|
nvlist_t *aux = fnvlist_alloc();
|
|
|
|
fnvlist_add_string(aux, ZFS_EV_RESILVER_TYPE,
|
|
|
|
"healing");
|
|
|
|
spa_event_notify(spa, NULL, aux,
|
2017-05-30 21:39:17 +03:00
|
|
|
ESC_ZFS_RESILVER_START);
|
2020-07-03 21:05:50 +03:00
|
|
|
nvlist_free(aux);
|
2010-05-29 00:45:14 +04:00
|
|
|
} else {
|
2017-05-30 21:39:17 +03:00
|
|
|
spa_event_notify(spa, NULL, NULL, ESC_ZFS_SCRUB_START);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
spa->spa_scrub_started = B_TRUE;
|
|
|
|
/*
|
|
|
|
* If this is an incremental scrub, limit the DDT scrub phase
|
|
|
|
* to just the auto-ditto class (for correctness); the rest
|
|
|
|
* of the scrub should go faster using top-down pruning.
|
|
|
|
*/
|
|
|
|
if (scn->scn_phys.scn_min_txg > TXG_INITIAL)
|
|
|
|
scn->scn_phys.scn_ddt_class_max = DDT_CLASS_DITTO;
|
|
|
|
|
2020-07-03 21:05:50 +03:00
|
|
|
/*
|
|
|
|
* When starting a resilver clear any existing rebuild state.
|
|
|
|
* This is required to prevent stale rebuild status from
|
|
|
|
* being reported when a rebuild is run, then a resilver and
|
|
|
|
* finally a scrub. In which case only the scrub status
|
|
|
|
* should be reported by 'zpool status'.
|
|
|
|
*/
|
|
|
|
if (scn->scn_phys.scn_func == POOL_SCAN_RESILVER) {
|
|
|
|
vdev_t *rvd = spa->spa_root_vdev;
|
|
|
|
for (uint64_t i = 0; i < rvd->vdev_children; i++) {
|
|
|
|
vdev_t *vd = rvd->vdev_child[i];
|
|
|
|
vdev_rebuild_clear_sync(
|
|
|
|
(void *)(uintptr_t)vd->vdev_id, tx);
|
|
|
|
}
|
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/* back to the generic stuff */
|
|
|
|
|
2022-06-28 21:23:31 +03:00
|
|
|
if (zfs_scan_blkstats) {
|
|
|
|
if (dp->dp_blkstats == NULL) {
|
|
|
|
dp->dp_blkstats =
|
|
|
|
vmem_alloc(sizeof (zfs_all_blkstats_t), KM_SLEEP);
|
|
|
|
}
|
|
|
|
memset(&dp->dp_blkstats->zab_type, 0,
|
|
|
|
sizeof (dp->dp_blkstats->zab_type));
|
|
|
|
} else {
|
|
|
|
if (dp->dp_blkstats) {
|
|
|
|
vmem_free(dp->dp_blkstats, sizeof (zfs_all_blkstats_t));
|
|
|
|
dp->dp_blkstats = NULL;
|
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
if (spa_version(spa) < SPA_VERSION_DSL_SCRUB)
|
|
|
|
ot = DMU_OT_ZAP_OTHER;
|
|
|
|
|
|
|
|
scn->scn_phys.scn_queue_obj = zap_create(dp->dp_meta_objset,
|
|
|
|
ot ? ot : DMU_OT_SCAN_QUEUE, DMU_OT_NONE, 0, tx);
|
|
|
|
|
2022-02-25 16:26:54 +03:00
|
|
|
memcpy(&scn->scn_phys_cached, &scn->scn_phys, sizeof (scn->scn_phys));
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
dsl_scan_sync_state(scn, tx, SYNC_MANDATORY);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2013-08-28 15:45:09 +04:00
|
|
|
spa_history_log_internal(spa, "scan setup", tx,
|
2010-05-29 00:45:14 +04:00
|
|
|
"func=%u mintxg=%llu maxtxg=%llu",
|
2019-09-12 23:28:26 +03:00
|
|
|
*funcp, (u_longlong_t)scn->scn_phys.scn_min_txg,
|
|
|
|
(u_longlong_t)scn->scn_phys.scn_max_txg);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
2021-12-17 23:35:28 +03:00
|
|
|
* Called by ZFS_IOC_POOL_SCRUB and ZFS_IOC_POOL_SCAN ioctl to start a scrub,
|
|
|
|
* error scrub or resilver. Can also be called to resume a paused scrub or
|
|
|
|
* error scrub.
|
2017-11-16 04:27:01 +03:00
|
|
|
*/
|
|
|
|
int
|
|
|
|
dsl_scan(dsl_pool_t *dp, pool_scan_func_t func)
|
|
|
|
{
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Purge all vdev caches and probe all devices. We do this here
|
|
|
|
* rather than in sync context because this requires a writer lock
|
|
|
|
* on the spa_config lock, which we can't do from sync context. The
|
|
|
|
* spa_scrub_reopen flag indicates that vdev_open() should not
|
|
|
|
* attempt to start another scrub.
|
|
|
|
*/
|
|
|
|
spa_vdev_state_enter(spa, SCL_NONE);
|
|
|
|
spa->spa_scrub_reopen = B_TRUE;
|
|
|
|
vdev_reopen(spa->spa_root_vdev);
|
|
|
|
spa->spa_scrub_reopen = B_FALSE;
|
|
|
|
(void) spa_vdev_state_exit(spa, NULL, 0);
|
|
|
|
|
2018-10-19 07:06:18 +03:00
|
|
|
if (func == POOL_SCAN_RESILVER) {
|
2019-11-27 21:15:01 +03:00
|
|
|
dsl_scan_restart_resilver(spa->spa_dsl_pool, 0);
|
2018-10-19 07:06:18 +03:00
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
2021-12-17 23:35:28 +03:00
|
|
|
if (func == POOL_SCAN_ERRORSCRUB) {
|
|
|
|
if (dsl_errorscrub_is_paused(dp->dp_scan)) {
|
|
|
|
/*
|
|
|
|
* got error scrub start cmd, resume paused error scrub.
|
|
|
|
*/
|
|
|
|
int err = dsl_scrub_set_pause_resume(scn->scn_dp,
|
|
|
|
POOL_SCRUB_NORMAL);
|
|
|
|
if (err == 0) {
|
|
|
|
spa_event_notify(spa, NULL, NULL,
|
|
|
|
ESC_ZFS_ERRORSCRUB_RESUME);
|
|
|
|
return (ECANCELED);
|
|
|
|
}
|
|
|
|
return (SET_ERROR(err));
|
|
|
|
}
|
|
|
|
|
|
|
|
return (dsl_sync_task(spa_name(dp->dp_spa),
|
|
|
|
dsl_errorscrub_setup_check, dsl_errorscrub_setup_sync,
|
|
|
|
&func, 0, ZFS_SPACE_CHECK_RESERVED));
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
if (func == POOL_SCAN_SCRUB && dsl_scan_is_paused_scrub(scn)) {
|
|
|
|
/* got scrub start cmd, resume paused scrub */
|
|
|
|
int err = dsl_scrub_set_pause_resume(scn->scn_dp,
|
|
|
|
POOL_SCRUB_NORMAL);
|
2017-11-07 02:13:23 +03:00
|
|
|
if (err == 0) {
|
|
|
|
spa_event_notify(spa, NULL, NULL, ESC_ZFS_SCRUB_RESUME);
|
2020-02-27 03:09:17 +03:00
|
|
|
return (SET_ERROR(ECANCELED));
|
2017-11-07 02:13:23 +03:00
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
return (SET_ERROR(err));
|
|
|
|
}
|
|
|
|
|
|
|
|
return (dsl_sync_task(spa_name(spa), dsl_scan_setup_check,
|
2016-12-17 01:11:29 +03:00
|
|
|
dsl_scan_setup_sync, &func, 0, ZFS_SPACE_CHECK_EXTRA_RESERVED));
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
|
2021-12-17 23:35:28 +03:00
|
|
|
static void
|
|
|
|
dsl_errorscrub_done(dsl_scan_t *scn, boolean_t complete, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
dsl_pool_t *dp = scn->scn_dp;
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
|
|
|
|
if (complete) {
|
|
|
|
spa_event_notify(spa, NULL, NULL, ESC_ZFS_ERRORSCRUB_FINISH);
|
|
|
|
spa_history_log_internal(spa, "error scrub done", tx,
|
|
|
|
"errors=%llu", (u_longlong_t)spa_approx_errlog_size(spa));
|
|
|
|
} else {
|
|
|
|
spa_history_log_internal(spa, "error scrub canceled", tx,
|
|
|
|
"errors=%llu", (u_longlong_t)spa_approx_errlog_size(spa));
|
|
|
|
}
|
|
|
|
|
|
|
|
scn->errorscrub_phys.dep_state = complete ? DSS_FINISHED : DSS_CANCELED;
|
|
|
|
spa->spa_scrub_active = B_FALSE;
|
|
|
|
spa_errlog_rotate(spa);
|
|
|
|
scn->errorscrub_phys.dep_end_time = gethrestime_sec();
|
|
|
|
zap_cursor_fini(&scn->errorscrub_cursor);
|
|
|
|
|
|
|
|
if (spa->spa_errata == ZPOOL_ERRATA_ZOL_2094_SCRUB)
|
|
|
|
spa->spa_errata = 0;
|
|
|
|
|
|
|
|
ASSERT(!dsl_errorscrubbing(scn->scn_dp));
|
|
|
|
}
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
static void
|
|
|
|
dsl_scan_done(dsl_scan_t *scn, boolean_t complete, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
static const char *old_names[] = {
|
|
|
|
"scrub_bookmark",
|
|
|
|
"scrub_ddt_bookmark",
|
|
|
|
"scrub_ddt_class_max",
|
|
|
|
"scrub_queue",
|
|
|
|
"scrub_min_txg",
|
|
|
|
"scrub_max_txg",
|
|
|
|
"scrub_func",
|
|
|
|
"scrub_errors",
|
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
|
|
|
dsl_pool_t *dp = scn->scn_dp;
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* Remove any remnants of an old-style scrub. */
|
|
|
|
for (i = 0; old_names[i]; i++) {
|
|
|
|
(void) zap_remove(dp->dp_meta_objset,
|
|
|
|
DMU_POOL_DIRECTORY_OBJECT, old_names[i], tx);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (scn->scn_phys.scn_queue_obj != 0) {
|
2017-11-16 04:27:01 +03:00
|
|
|
VERIFY0(dmu_object_free(dp->dp_meta_objset,
|
2010-05-29 00:45:14 +04:00
|
|
|
scn->scn_phys.scn_queue_obj, tx));
|
|
|
|
scn->scn_phys.scn_queue_obj = 0;
|
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_ds_queue_clear(scn);
|
2018-12-06 20:47:23 +03:00
|
|
|
scan_ds_prefetch_queue_clear(scn);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-07-07 08:16:13 +03:00
|
|
|
scn->scn_phys.scn_flags &= ~DSF_SCRUB_PAUSED;
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
/*
|
|
|
|
* If we were "restarted" from a stopped state, don't bother
|
|
|
|
* with anything else.
|
|
|
|
*/
|
2017-11-16 04:27:01 +03:00
|
|
|
if (!dsl_scan_is_running(scn)) {
|
|
|
|
ASSERT(!scn->scn_is_sorted);
|
2010-05-29 00:45:14 +04:00
|
|
|
return;
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
if (scn->scn_is_sorted) {
|
|
|
|
scan_io_queues_destroy(scn);
|
|
|
|
scn->scn_is_sorted = B_FALSE;
|
|
|
|
|
|
|
|
if (scn->scn_taskq != NULL) {
|
|
|
|
taskq_destroy(scn->scn_taskq);
|
|
|
|
scn->scn_taskq = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
scn->scn_phys.scn_state = complete ? DSS_FINISHED : DSS_CANCELED;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
Add subcommand to wait for background zfs activity to complete
Currently the best way to wait for the completion of a long-running
operation in a pool, like a scrub or device removal, is to poll 'zpool
status' and parse its output, which is neither efficient nor convenient.
This change adds a 'wait' subcommand to the zpool command. When invoked,
'zpool wait' will block until a specified type of background activity
completes. Currently, this subcommand can wait for any of the following:
- Scrubs or resilvers to complete
- Devices to initialized
- Devices to be replaced
- Devices to be removed
- Checkpoints to be discarded
- Background freeing to complete
For example, a scrub that is in progress could be waited for by running
zpool wait -t scrub <pool>
This also adds a -w flag to the attach, checkpoint, initialize, replace,
remove, and scrub subcommands. When used, this flag makes the operations
kicked off by these subcommands synchronous instead of asynchronous.
This functionality is implemented using a new ioctl. The type of
activity to wait for is provided as input to the ioctl, and the ioctl
blocks until all activity of that type has completed. An ioctl was used
over other methods of kernel-userspace communiction primarily for the
sake of portability.
Porting Notes:
This is ported from Delphix OS change DLPX-44432. The following changes
were made while porting:
- Added ZoL-style ioctl input declaration.
- Reorganized error handling in zpool_initialize in libzfs to integrate
better with changes made for TRIM support.
- Fixed check for whether a checkpoint discard is in progress.
Previously it also waited if the pool had a checkpoint, instead of
just if a checkpoint was being discarded.
- Exposed zfs_initialize_chunk_size as a ZoL-style tunable.
- Updated more existing tests to make use of new 'zpool wait'
functionality, tests that don't exist in Delphix OS.
- Used existing ZoL tunable zfs_scan_suspend_progress, together with
zinject, in place of a new tunable zfs_scan_max_blks_per_txg.
- Added support for a non-integral interval argument to zpool wait.
Future work:
ZoL has support for trimming devices, which Delphix OS does not. In the
future, 'zpool wait' could be extended to add the ability to wait for
trim operations to complete.
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: John Gallagher <john.gallagher@delphix.com>
Closes #9162
2019-09-14 04:09:06 +03:00
|
|
|
spa_notify_waiters(spa);
|
|
|
|
|
2016-06-23 11:39:40 +03:00
|
|
|
if (dsl_scan_restarting(scn, tx))
|
|
|
|
spa_history_log_internal(spa, "scan aborted, restarting", tx,
|
2022-12-22 22:48:49 +03:00
|
|
|
"errors=%llu", (u_longlong_t)spa_approx_errlog_size(spa));
|
2016-06-23 11:39:40 +03:00
|
|
|
else if (!complete)
|
|
|
|
spa_history_log_internal(spa, "scan cancelled", tx,
|
2022-12-22 22:48:49 +03:00
|
|
|
"errors=%llu", (u_longlong_t)spa_approx_errlog_size(spa));
|
2016-06-23 11:39:40 +03:00
|
|
|
else
|
|
|
|
spa_history_log_internal(spa, "scan done", tx,
|
2022-12-22 22:48:49 +03:00
|
|
|
"errors=%llu", (u_longlong_t)spa_approx_errlog_size(spa));
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
if (DSL_SCAN_IS_SCRUB_RESILVER(scn)) {
|
|
|
|
spa->spa_scrub_active = B_FALSE;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the scrub/resilver completed, update all DTLs to
|
|
|
|
* reflect this. Whether it succeeded or not, vacate
|
|
|
|
* all temporary scrub DTLs.
|
2016-12-17 01:11:29 +03:00
|
|
|
*
|
|
|
|
* As the scrub does not currently support traversing
|
|
|
|
* data that have been freed but are part of a checkpoint,
|
|
|
|
* we don't mark the scrub as done in the DTLs as faults
|
|
|
|
* may still exist in those vdevs.
|
2010-05-29 00:45:14 +04:00
|
|
|
*/
|
2016-12-17 01:11:29 +03:00
|
|
|
if (complete &&
|
|
|
|
!spa_feature_is_active(spa, SPA_FEATURE_POOL_CHECKPOINT)) {
|
|
|
|
vdev_dtl_reassess(spa->spa_root_vdev, tx->tx_txg,
|
2020-07-03 21:05:50 +03:00
|
|
|
scn->scn_phys.scn_max_txg, B_TRUE, B_FALSE);
|
|
|
|
|
|
|
|
if (scn->scn_phys.scn_min_txg) {
|
|
|
|
nvlist_t *aux = fnvlist_alloc();
|
|
|
|
fnvlist_add_string(aux, ZFS_EV_RESILVER_TYPE,
|
|
|
|
"healing");
|
|
|
|
spa_event_notify(spa, NULL, aux,
|
|
|
|
ESC_ZFS_RESILVER_FINISH);
|
|
|
|
nvlist_free(aux);
|
|
|
|
} else {
|
|
|
|
spa_event_notify(spa, NULL, NULL,
|
|
|
|
ESC_ZFS_SCRUB_FINISH);
|
|
|
|
}
|
2016-12-17 01:11:29 +03:00
|
|
|
} else {
|
|
|
|
vdev_dtl_reassess(spa->spa_root_vdev, tx->tx_txg,
|
2020-07-03 21:05:50 +03:00
|
|
|
0, B_TRUE, B_FALSE);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
spa_errlog_rotate(spa);
|
|
|
|
|
Resilver restarts unnecessarily when it encounters errors
When a resilver finishes, vdev_dtl_reassess is called to hopefully
excise DTL_MISSING (amongst other things). If there are errors during
the resilver, they are tracked in DTL_SCRUB, as spelled out in the
block comment in vdev.c. DTL_SCRUB is in-core only, so it can only
be used if the pool was online for the whole resilver. This state is
tracked with the spa_scrub_started flag, which only gets set when
the scan is initialized. Unfortunately, this flag gets cleared right
before vdev_dtl_reassess gets called, so if there are any errors
during the scan, DTL_MISSING will never get excised and the resilver
will just continually restart. This fix simply moves clearing that
flag until after the call to vdev_dtl_reasses.
In addition, if a pool is imported and already has scn_errors > 0,
this change will restart the resilver immediately instead of doing
the rest of the scan and then restarting it from the beginning. On
the other hand, if scn_errors == 0 at import, then no errors have
been encountered so far, so the spa_scrub_started flag can be safely
set.
A test has been added to verify that resilver does not restart when
relevant DTL's are available.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Paul Zuchowski <pzuchowski@datto.com>
Signed-off-by: John Poduska <jpoduska@datto.com>
Closes #10291
2020-05-13 20:54:27 +03:00
|
|
|
/*
|
|
|
|
* Don't clear flag until after vdev_dtl_reassess to ensure that
|
|
|
|
* DTL_MISSING will get updated when possible.
|
|
|
|
*/
|
|
|
|
spa->spa_scrub_started = B_FALSE;
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
/*
|
|
|
|
* We may have finished replacing a device.
|
|
|
|
* Let the async thread assess this and handle the detach.
|
|
|
|
*/
|
|
|
|
spa_async_request(spa, SPA_ASYNC_RESILVER_DONE);
|
2018-10-19 07:06:18 +03:00
|
|
|
|
|
|
|
/*
|
2019-11-27 21:15:01 +03:00
|
|
|
* Clear any resilver_deferred flags in the config.
|
2018-10-19 07:06:18 +03:00
|
|
|
* If there are drives that need resilvering, kick
|
|
|
|
* off an asynchronous request to start resilver.
|
2019-11-27 21:15:01 +03:00
|
|
|
* vdev_clear_resilver_deferred() may update the config
|
2018-10-19 07:06:18 +03:00
|
|
|
* before the resilver can restart. In the event of
|
|
|
|
* a crash during this period, the spa loading code
|
|
|
|
* will find the drives that need to be resilvered
|
2019-11-27 21:15:01 +03:00
|
|
|
* and start the resilver then.
|
2018-10-19 07:06:18 +03:00
|
|
|
*/
|
2019-11-27 21:15:01 +03:00
|
|
|
if (spa_feature_is_enabled(spa, SPA_FEATURE_RESILVER_DEFER) &&
|
|
|
|
vdev_clear_resilver_deferred(spa->spa_root_vdev, tx)) {
|
|
|
|
spa_history_log_internal(spa,
|
|
|
|
"starting deferred resilver", tx, "errors=%llu",
|
2022-12-22 22:48:49 +03:00
|
|
|
(u_longlong_t)spa_approx_errlog_size(spa));
|
2019-11-27 21:15:01 +03:00
|
|
|
spa_async_request(spa, SPA_ASYNC_RESILVER);
|
2018-10-19 07:06:18 +03:00
|
|
|
}
|
2021-02-20 09:33:15 +03:00
|
|
|
|
|
|
|
/* Clear recent error events (i.e. duplicate events tracking) */
|
|
|
|
if (complete)
|
|
|
|
zfs_ereport_clear(spa, NULL);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
scn->scn_phys.scn_end_time = gethrestime_sec();
|
Add erratum for issue #2094
ZoL commit 1421c89 unintentionally changed the disk format in a forward-
compatible, but not backward compatible way. This was accomplished by
adding an entry to zbookmark_t, which is included in a couple of
on-disk structures. That lead to the creation of pools with incorrect
dsl_scan_phys_t objects that could only be imported by versions of ZoL
containing that commit. Such pools cannot be imported by other versions
of ZFS or past versions of ZoL.
The additional field has been removed by the previous commit. However,
affected pools must be imported and scrubbed using a version of ZoL with
this commit applied. This will return the pools to a state in which they
may be imported by other implementations.
The 'zpool import' or 'zpool status' command can be used to determine if
a pool is impacted. A message similar to one of the following means your
pool must be scrubbed to restore compatibility.
$ zpool import
pool: zol-0.6.2-173
id: 1165955789558693437
state: ONLINE
status: Errata #1 detected.
action: The pool can be imported using its name or numeric identifier,
however there is a compatibility issue which should be corrected
by running 'zpool scrub'
see: http://zfsonlinux.org/msg/ZFS-8000-ER
config:
...
$ zpool status
pool: zol-0.6.2-173
state: ONLINE
scan: pool compatibility issue detected.
see: https://github.com/zfsonlinux/zfs/issues/2094
action: To correct the issue run 'zpool scrub'.
config:
...
If there was an async destroy in progress 'zpool import' will prevent
the pool from being imported. Further advice on how to proceed will be
provided by the error message as follows.
$ zpool import
pool: zol-0.6.2-173
id: 1165955789558693437
state: ONLINE
status: Errata #2 detected.
action: The pool can not be imported with this version of ZFS due to an
active asynchronous destroy. Revert to an earlier version and
allow the destroy to complete before updating.
see: http://zfsonlinux.org/msg/ZFS-8000-ER
config:
...
Pools affected by the damaged dsl_scan_phys_t can be detected prior to
an upgrade by running the following command as root:
zdb -dddd poolname 1 | grep -P '^\t\tscan = ' | sed -e 's;scan = ;;' | wc -w
Note that `poolname` must be replaced with the name of the pool you wish
to check. A value of 25 indicates the dsl_scan_phys_t has been damaged.
A value of 24 indicates that the dsl_scan_phys_t is normal. A value of 0
indicates that there has never been a scrub run on the pool.
The regression caused by the change to zbookmark_t never made it into a
tagged release, Gentoo backports, Ubuntu, Debian, Fedora, or EPEL
stable respositorys. Only those using the HEAD version directly from
Github after the 0.6.2 but before the 0.6.3 tag are affected.
This patch does have one limitation that should be mentioned. It will not
detect errata #2 on a pool unless errata #1 is also present. It expected
this will not be a significant problem because pools impacted by errata #2
have a high probably of being impacted by errata #1.
End users can ensure they do no hit this unlikely case by waiting for all
asynchronous destroy operations to complete before updating ZoL. The
presence of any background destroys on any imported pools can be checked
by running `zpool get freeing` as root. This will display a non-zero
value for any pool with an active asynchronous destroy.
Lastly, it is expected that no user data has been lost as a result of
this erratum.
Original-patch-by: Tim Chase <tim@chase2k.com>
Reworked-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #2094
2014-02-21 08:28:33 +04:00
|
|
|
|
|
|
|
if (spa->spa_errata == ZPOOL_ERRATA_ZOL_2094_SCRUB)
|
|
|
|
spa->spa_errata = 0;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
ASSERT(!dsl_scan_is_running(scn));
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2021-12-17 23:35:28 +03:00
|
|
|
static int
|
|
|
|
dsl_errorscrub_pause_resume_check(void *arg, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
pool_scrub_cmd_t *cmd = arg;
|
|
|
|
dsl_pool_t *dp = dmu_tx_pool(tx);
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
|
|
|
|
if (*cmd == POOL_SCRUB_PAUSE) {
|
|
|
|
/*
|
|
|
|
* can't pause a error scrub when there is no in-progress
|
|
|
|
* error scrub.
|
|
|
|
*/
|
|
|
|
if (!dsl_errorscrubbing(dp))
|
|
|
|
return (SET_ERROR(ENOENT));
|
|
|
|
|
|
|
|
/* can't pause a paused error scrub */
|
|
|
|
if (dsl_errorscrub_is_paused(scn))
|
|
|
|
return (SET_ERROR(EBUSY));
|
|
|
|
} else if (*cmd != POOL_SCRUB_NORMAL) {
|
|
|
|
return (SET_ERROR(ENOTSUP));
|
|
|
|
}
|
|
|
|
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_errorscrub_pause_resume_sync(void *arg, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
pool_scrub_cmd_t *cmd = arg;
|
|
|
|
dsl_pool_t *dp = dmu_tx_pool(tx);
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
|
|
|
|
if (*cmd == POOL_SCRUB_PAUSE) {
|
|
|
|
spa->spa_scan_pass_errorscrub_pause = gethrestime_sec();
|
|
|
|
scn->errorscrub_phys.dep_paused_flags = B_TRUE;
|
|
|
|
dsl_errorscrub_sync_state(scn, tx);
|
|
|
|
spa_event_notify(spa, NULL, NULL, ESC_ZFS_ERRORSCRUB_PAUSED);
|
|
|
|
} else {
|
|
|
|
ASSERT3U(*cmd, ==, POOL_SCRUB_NORMAL);
|
|
|
|
if (dsl_errorscrub_is_paused(scn)) {
|
|
|
|
/*
|
|
|
|
* We need to keep track of how much time we spend
|
|
|
|
* paused per pass so that we can adjust the error scrub
|
|
|
|
* rate shown in the output of 'zpool status'.
|
|
|
|
*/
|
|
|
|
spa->spa_scan_pass_errorscrub_spent_paused +=
|
|
|
|
gethrestime_sec() -
|
|
|
|
spa->spa_scan_pass_errorscrub_pause;
|
|
|
|
|
|
|
|
spa->spa_scan_pass_errorscrub_pause = 0;
|
|
|
|
scn->errorscrub_phys.dep_paused_flags = B_FALSE;
|
|
|
|
|
|
|
|
zap_cursor_init_serialized(
|
|
|
|
&scn->errorscrub_cursor,
|
|
|
|
spa->spa_meta_objset, spa->spa_errlog_last,
|
|
|
|
scn->errorscrub_phys.dep_cursor);
|
|
|
|
|
|
|
|
dsl_errorscrub_sync_state(scn, tx);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
dsl_errorscrub_cancel_check(void *arg, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
(void) arg;
|
|
|
|
dsl_scan_t *scn = dmu_tx_pool(tx)->dp_scan;
|
|
|
|
/* can't cancel a error scrub when there is no one in-progress */
|
|
|
|
if (!dsl_errorscrubbing(scn->scn_dp))
|
|
|
|
return (SET_ERROR(ENOENT));
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_errorscrub_cancel_sync(void *arg, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
(void) arg;
|
|
|
|
dsl_scan_t *scn = dmu_tx_pool(tx)->dp_scan;
|
|
|
|
|
|
|
|
dsl_errorscrub_done(scn, B_FALSE, tx);
|
|
|
|
dsl_errorscrub_sync_state(scn, tx);
|
|
|
|
spa_event_notify(scn->scn_dp->dp_spa, NULL, NULL,
|
|
|
|
ESC_ZFS_ERRORSCRUB_ABORT);
|
|
|
|
}
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
static int
|
2013-09-04 16:00:57 +04:00
|
|
|
dsl_scan_cancel_check(void *arg, dmu_tx_t *tx)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2021-12-12 18:06:44 +03:00
|
|
|
(void) arg;
|
2013-09-04 16:00:57 +04:00
|
|
|
dsl_scan_t *scn = dmu_tx_pool(tx)->dp_scan;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
if (!dsl_scan_is_running(scn))
|
2013-03-08 22:41:28 +04:00
|
|
|
return (SET_ERROR(ENOENT));
|
2010-05-29 00:45:14 +04:00
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2013-09-04 16:00:57 +04:00
|
|
|
dsl_scan_cancel_sync(void *arg, dmu_tx_t *tx)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2021-12-12 18:06:44 +03:00
|
|
|
(void) arg;
|
2013-09-04 16:00:57 +04:00
|
|
|
dsl_scan_t *scn = dmu_tx_pool(tx)->dp_scan;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
dsl_scan_done(scn, B_FALSE, tx);
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_sync_state(scn, tx, SYNC_MANDATORY);
|
2017-11-07 02:13:23 +03:00
|
|
|
spa_event_notify(scn->scn_dp->dp_spa, NULL, NULL, ESC_ZFS_SCRUB_ABORT);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
int
|
|
|
|
dsl_scan_cancel(dsl_pool_t *dp)
|
|
|
|
{
|
2021-12-17 23:35:28 +03:00
|
|
|
if (dsl_errorscrubbing(dp)) {
|
|
|
|
return (dsl_sync_task(spa_name(dp->dp_spa),
|
|
|
|
dsl_errorscrub_cancel_check, dsl_errorscrub_cancel_sync,
|
|
|
|
NULL, 3, ZFS_SPACE_CHECK_RESERVED));
|
|
|
|
}
|
2013-09-04 16:00:57 +04:00
|
|
|
return (dsl_sync_task(spa_name(dp->dp_spa), dsl_scan_cancel_check,
|
2014-11-03 23:28:43 +03:00
|
|
|
dsl_scan_cancel_sync, NULL, 3, ZFS_SPACE_CHECK_RESERVED));
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2017-07-07 08:16:13 +03:00
|
|
|
static int
|
|
|
|
dsl_scrub_pause_resume_check(void *arg, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
pool_scrub_cmd_t *cmd = arg;
|
|
|
|
dsl_pool_t *dp = dmu_tx_pool(tx);
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
|
|
|
|
if (*cmd == POOL_SCRUB_PAUSE) {
|
|
|
|
/* can't pause a scrub when there is no in-progress scrub */
|
|
|
|
if (!dsl_scan_scrubbing(dp))
|
|
|
|
return (SET_ERROR(ENOENT));
|
|
|
|
|
|
|
|
/* can't pause a paused scrub */
|
|
|
|
if (dsl_scan_is_paused_scrub(scn))
|
|
|
|
return (SET_ERROR(EBUSY));
|
|
|
|
} else if (*cmd != POOL_SCRUB_NORMAL) {
|
|
|
|
return (SET_ERROR(ENOTSUP));
|
|
|
|
}
|
|
|
|
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_scrub_pause_resume_sync(void *arg, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
pool_scrub_cmd_t *cmd = arg;
|
|
|
|
dsl_pool_t *dp = dmu_tx_pool(tx);
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
|
|
|
|
if (*cmd == POOL_SCRUB_PAUSE) {
|
|
|
|
/* can't pause a scrub when there is no in-progress scrub */
|
|
|
|
spa->spa_scan_pass_scrub_pause = gethrestime_sec();
|
|
|
|
scn->scn_phys.scn_flags |= DSF_SCRUB_PAUSED;
|
2018-10-23 22:17:18 +03:00
|
|
|
scn->scn_phys_cached.scn_flags |= DSF_SCRUB_PAUSED;
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_sync_state(scn, tx, SYNC_CACHED);
|
2017-11-07 02:13:23 +03:00
|
|
|
spa_event_notify(spa, NULL, NULL, ESC_ZFS_SCRUB_PAUSED);
|
Add subcommand to wait for background zfs activity to complete
Currently the best way to wait for the completion of a long-running
operation in a pool, like a scrub or device removal, is to poll 'zpool
status' and parse its output, which is neither efficient nor convenient.
This change adds a 'wait' subcommand to the zpool command. When invoked,
'zpool wait' will block until a specified type of background activity
completes. Currently, this subcommand can wait for any of the following:
- Scrubs or resilvers to complete
- Devices to initialized
- Devices to be replaced
- Devices to be removed
- Checkpoints to be discarded
- Background freeing to complete
For example, a scrub that is in progress could be waited for by running
zpool wait -t scrub <pool>
This also adds a -w flag to the attach, checkpoint, initialize, replace,
remove, and scrub subcommands. When used, this flag makes the operations
kicked off by these subcommands synchronous instead of asynchronous.
This functionality is implemented using a new ioctl. The type of
activity to wait for is provided as input to the ioctl, and the ioctl
blocks until all activity of that type has completed. An ioctl was used
over other methods of kernel-userspace communiction primarily for the
sake of portability.
Porting Notes:
This is ported from Delphix OS change DLPX-44432. The following changes
were made while porting:
- Added ZoL-style ioctl input declaration.
- Reorganized error handling in zpool_initialize in libzfs to integrate
better with changes made for TRIM support.
- Fixed check for whether a checkpoint discard is in progress.
Previously it also waited if the pool had a checkpoint, instead of
just if a checkpoint was being discarded.
- Exposed zfs_initialize_chunk_size as a ZoL-style tunable.
- Updated more existing tests to make use of new 'zpool wait'
functionality, tests that don't exist in Delphix OS.
- Used existing ZoL tunable zfs_scan_suspend_progress, together with
zinject, in place of a new tunable zfs_scan_max_blks_per_txg.
- Added support for a non-integral interval argument to zpool wait.
Future work:
ZoL has support for trimming devices, which Delphix OS does not. In the
future, 'zpool wait' could be extended to add the ability to wait for
trim operations to complete.
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: John Gallagher <john.gallagher@delphix.com>
Closes #9162
2019-09-14 04:09:06 +03:00
|
|
|
spa_notify_waiters(spa);
|
2017-07-07 08:16:13 +03:00
|
|
|
} else {
|
|
|
|
ASSERT3U(*cmd, ==, POOL_SCRUB_NORMAL);
|
|
|
|
if (dsl_scan_is_paused_scrub(scn)) {
|
|
|
|
/*
|
|
|
|
* We need to keep track of how much time we spend
|
|
|
|
* paused per pass so that we can adjust the scrub rate
|
|
|
|
* shown in the output of 'zpool status'
|
|
|
|
*/
|
|
|
|
spa->spa_scan_pass_scrub_spent_paused +=
|
|
|
|
gethrestime_sec() - spa->spa_scan_pass_scrub_pause;
|
|
|
|
spa->spa_scan_pass_scrub_pause = 0;
|
|
|
|
scn->scn_phys.scn_flags &= ~DSF_SCRUB_PAUSED;
|
2018-10-23 22:17:18 +03:00
|
|
|
scn->scn_phys_cached.scn_flags &= ~DSF_SCRUB_PAUSED;
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_sync_state(scn, tx, SYNC_CACHED);
|
2017-07-07 08:16:13 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Set scrub pause/resume state if it makes sense to do so
|
|
|
|
*/
|
|
|
|
int
|
|
|
|
dsl_scrub_set_pause_resume(const dsl_pool_t *dp, pool_scrub_cmd_t cmd)
|
|
|
|
{
|
2021-12-17 23:35:28 +03:00
|
|
|
if (dsl_errorscrubbing(dp)) {
|
|
|
|
return (dsl_sync_task(spa_name(dp->dp_spa),
|
|
|
|
dsl_errorscrub_pause_resume_check,
|
|
|
|
dsl_errorscrub_pause_resume_sync, &cmd, 3,
|
|
|
|
ZFS_SPACE_CHECK_RESERVED));
|
|
|
|
}
|
2017-07-07 08:16:13 +03:00
|
|
|
return (dsl_sync_task(spa_name(dp->dp_spa),
|
|
|
|
dsl_scrub_pause_resume_check, dsl_scrub_pause_resume_sync, &cmd, 3,
|
|
|
|
ZFS_SPACE_CHECK_RESERVED));
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/* start a new scan, or restart an existing one. */
|
|
|
|
void
|
2019-11-27 21:15:01 +03:00
|
|
|
dsl_scan_restart_resilver(dsl_pool_t *dp, uint64_t txg)
|
2017-11-16 04:27:01 +03:00
|
|
|
{
|
|
|
|
if (txg == 0) {
|
|
|
|
dmu_tx_t *tx;
|
|
|
|
tx = dmu_tx_create_dd(dp->dp_mos_dir);
|
|
|
|
VERIFY(0 == dmu_tx_assign(tx, TXG_WAIT));
|
2017-07-07 08:16:13 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
txg = dmu_tx_get_txg(tx);
|
|
|
|
dp->dp_scan->scn_restart_txg = txg;
|
|
|
|
dmu_tx_commit(tx);
|
|
|
|
} else {
|
|
|
|
dp->dp_scan->scn_restart_txg = txg;
|
|
|
|
}
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("restarting resilver for %s at txg=%llu",
|
|
|
|
dp->dp_spa->spa_name, (longlong_t)txg);
|
2017-07-07 08:16:13 +03:00
|
|
|
}
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
void
|
|
|
|
dsl_free(dsl_pool_t *dp, uint64_t txg, const blkptr_t *bp)
|
|
|
|
{
|
|
|
|
zio_free(dp->dp_spa, txg, bp);
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
dsl_free_sync(zio_t *pio, dsl_pool_t *dp, uint64_t txg, const blkptr_t *bpp)
|
|
|
|
{
|
|
|
|
ASSERT(dsl_pool_sync_context(dp));
|
|
|
|
zio_nowait(zio_free_sync(pio, dp->dp_spa, txg, bpp, pio->io_flags));
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static int
|
|
|
|
scan_ds_queue_compare(const void *a, const void *b)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
const scan_ds_t *sds_a = a, *sds_b = b;
|
|
|
|
|
|
|
|
if (sds_a->sds_dsobj < sds_b->sds_dsobj)
|
|
|
|
return (-1);
|
|
|
|
if (sds_a->sds_dsobj == sds_b->sds_dsobj)
|
|
|
|
return (0);
|
|
|
|
return (1);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_ds_queue_clear(dsl_scan_t *scn)
|
|
|
|
{
|
|
|
|
void *cookie = NULL;
|
|
|
|
scan_ds_t *sds;
|
|
|
|
while ((sds = avl_destroy_nodes(&scn->scn_queue, &cookie)) != NULL) {
|
|
|
|
kmem_free(sds, sizeof (*sds));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static boolean_t
|
|
|
|
scan_ds_queue_contains(dsl_scan_t *scn, uint64_t dsobj, uint64_t *txg)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_ds_t srch, *sds;
|
|
|
|
|
|
|
|
srch.sds_dsobj = dsobj;
|
|
|
|
sds = avl_find(&scn->scn_queue, &srch, NULL);
|
|
|
|
if (sds != NULL && txg != NULL)
|
|
|
|
*txg = sds->sds_txg;
|
|
|
|
return (sds != NULL);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static void
|
|
|
|
scan_ds_queue_insert(dsl_scan_t *scn, uint64_t dsobj, uint64_t txg)
|
|
|
|
{
|
|
|
|
scan_ds_t *sds;
|
|
|
|
avl_index_t where;
|
|
|
|
|
|
|
|
sds = kmem_zalloc(sizeof (*sds), KM_SLEEP);
|
|
|
|
sds->sds_dsobj = dsobj;
|
|
|
|
sds->sds_txg = txg;
|
|
|
|
|
|
|
|
VERIFY3P(avl_find(&scn->scn_queue, sds, &where), ==, NULL);
|
|
|
|
avl_insert(&scn->scn_queue, sds, where);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
scan_ds_queue_remove(dsl_scan_t *scn, uint64_t dsobj)
|
|
|
|
{
|
|
|
|
scan_ds_t srch, *sds;
|
|
|
|
|
|
|
|
srch.sds_dsobj = dsobj;
|
|
|
|
|
|
|
|
sds = avl_find(&scn->scn_queue, &srch, NULL);
|
|
|
|
VERIFY(sds != NULL);
|
|
|
|
avl_remove(&scn->scn_queue, sds);
|
|
|
|
kmem_free(sds, sizeof (*sds));
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
scan_ds_queue_sync(dsl_scan_t *scn, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
dsl_pool_t *dp = scn->scn_dp;
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
dmu_object_type_t ot = (spa_version(spa) >= SPA_VERSION_DSL_SCRUB) ?
|
|
|
|
DMU_OT_SCAN_QUEUE : DMU_OT_ZAP_OTHER;
|
|
|
|
|
2022-06-24 19:50:37 +03:00
|
|
|
ASSERT0(scn->scn_queues_pending);
|
2017-11-16 04:27:01 +03:00
|
|
|
ASSERT(scn->scn_phys.scn_queue_obj != 0);
|
|
|
|
|
|
|
|
VERIFY0(dmu_object_free(dp->dp_meta_objset,
|
|
|
|
scn->scn_phys.scn_queue_obj, tx));
|
|
|
|
scn->scn_phys.scn_queue_obj = zap_create(dp->dp_meta_objset, ot,
|
|
|
|
DMU_OT_NONE, 0, tx);
|
|
|
|
for (scan_ds_t *sds = avl_first(&scn->scn_queue);
|
|
|
|
sds != NULL; sds = AVL_NEXT(&scn->scn_queue, sds)) {
|
|
|
|
VERIFY0(zap_add_int_key(dp->dp_meta_objset,
|
|
|
|
scn->scn_phys.scn_queue_obj, sds->sds_dsobj,
|
|
|
|
sds->sds_txg, tx));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Computes the memory limit state that we're currently in. A sorted scan
|
|
|
|
* needs quite a bit of memory to hold the sorting queue, so we need to
|
|
|
|
* reasonably constrain the size so it doesn't impact overall system
|
|
|
|
* performance. We compute two limits:
|
|
|
|
* 1) Hard memory limit: if the amount of memory used by the sorting
|
|
|
|
* queues on a pool gets above this value, we stop the metadata
|
|
|
|
* scanning portion and start issuing the queued up and sorted
|
|
|
|
* I/Os to reduce memory usage.
|
|
|
|
* This limit is calculated as a fraction of physmem (by default 5%).
|
|
|
|
* We constrain the lower bound of the hard limit to an absolute
|
|
|
|
* minimum of zfs_scan_mem_lim_min (default: 16 MiB). We also constrain
|
|
|
|
* the upper bound to 5% of the total pool size - no chance we'll
|
|
|
|
* ever need that much memory, but just to keep the value in check.
|
|
|
|
* 2) Soft memory limit: once we hit the hard memory limit, we start
|
|
|
|
* issuing I/O to reduce queue memory usage, but we don't want to
|
|
|
|
* completely empty out the queues, since we might be able to find I/Os
|
|
|
|
* that will fill in the gaps of our non-sequential IOs at some point
|
|
|
|
* in the future. So we stop the issuing of I/Os once the amount of
|
|
|
|
* memory used drops below the soft limit (at which point we stop issuing
|
|
|
|
* I/O and start scanning metadata again).
|
|
|
|
*
|
|
|
|
* This limit is calculated by subtracting a fraction of the hard
|
|
|
|
* limit from the hard limit. By default this fraction is 5%, so
|
|
|
|
* the soft limit is 95% of the hard limit. We cap the size of the
|
|
|
|
* difference between the hard and soft limits at an absolute
|
|
|
|
* maximum of zfs_scan_mem_lim_soft_max (default: 128 MiB) - this is
|
|
|
|
* sufficient to not cause too frequent switching between the
|
|
|
|
* metadata scan and I/O issue (even at 2k recordsize, 128 MiB's
|
|
|
|
* worth of queues is about 1.2 GiB of on-pool data, so scanning
|
|
|
|
* that should take at least a decent fraction of a second).
|
|
|
|
*/
|
|
|
|
static boolean_t
|
|
|
|
dsl_scan_should_clear(dsl_scan_t *scn)
|
|
|
|
{
|
2020-03-12 20:52:03 +03:00
|
|
|
spa_t *spa = scn->scn_dp->dp_spa;
|
2017-11-16 04:27:01 +03:00
|
|
|
vdev_t *rvd = scn->scn_dp->dp_spa->spa_root_vdev;
|
2020-03-12 20:52:03 +03:00
|
|
|
uint64_t alloc, mlim_hard, mlim_soft, mused;
|
|
|
|
|
|
|
|
alloc = metaslab_class_get_alloc(spa_normal_class(spa));
|
|
|
|
alloc += metaslab_class_get_alloc(spa_special_class(spa));
|
|
|
|
alloc += metaslab_class_get_alloc(spa_dedup_class(spa));
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
mlim_hard = MAX((physmem / zfs_scan_mem_lim_fact) * PAGESIZE,
|
|
|
|
zfs_scan_mem_lim_min);
|
|
|
|
mlim_hard = MIN(mlim_hard, alloc / 20);
|
|
|
|
mlim_soft = mlim_hard - MIN(mlim_hard / zfs_scan_mem_lim_soft_fact,
|
|
|
|
zfs_scan_mem_lim_soft_max);
|
|
|
|
mused = 0;
|
|
|
|
for (uint64_t i = 0; i < rvd->vdev_children; i++) {
|
|
|
|
vdev_t *tvd = rvd->vdev_child[i];
|
|
|
|
dsl_scan_io_queue_t *queue;
|
|
|
|
|
|
|
|
mutex_enter(&tvd->vdev_scan_io_queue_lock);
|
|
|
|
queue = tvd->vdev_scan_io_queue;
|
|
|
|
if (queue != NULL) {
|
2022-06-10 20:01:46 +03:00
|
|
|
/*
|
2022-06-24 19:50:37 +03:00
|
|
|
* # of extents in exts_by_addr = # in exts_by_size.
|
2022-06-10 20:01:46 +03:00
|
|
|
* B-tree efficiency is ~75%, but can be as low as 50%.
|
|
|
|
*/
|
Reduce loaded range tree memory usage
This patch implements a new tree structure for ZFS, and uses it to
store range trees more efficiently.
The new structure is approximately a B-tree, though there are some
small differences from the usual characterizations. The tree has core
nodes and leaf nodes; each contain data elements, which the elements
in the core nodes acting as separators between its children. The
difference between core and leaf nodes is that the core nodes have an
array of children, while leaf nodes don't. Every node in the tree may
be only partially full; in most cases, they are all at least 50% full
(in terms of element count) except for the root node, which can be
less full. Underfull nodes will steal from their neighbors or merge to
remain full enough, while overfull nodes will split in two. The data
elements are contained in tree-controlled buffers; they are copied
into these on insertion, and overwritten on deletion. This means that
the elements are not independently allocated, which reduces overhead,
but also means they can't be shared between trees (and also that
pointers to them are only valid until a side-effectful tree operation
occurs). The overhead varies based on how dense the tree is, but is
usually on the order of about 50% of the element size; the per-node
overheads are very small, and so don't make a significant difference.
The trees can accept arbitrary records; they accept a size and a
comparator to allow them to be used for a variety of purposes.
The new trees replace the AVL trees used in the range trees today.
Currently, the range_seg_t structure contains three 8 byte integers
of payload and two 24 byte avl_tree_node_ts to handle its storage in
both an offset-sorted tree and a size-sorted tree (total size: 64
bytes). In the new model, the range seg structures are usually two 4
byte integers, but a separate one needs to exist for the size-sorted
and offset-sorted tree. Between the raw size, the 50% overhead, and
the double storage, the new btrees are expected to use 8*1.5*2 = 24
bytes per record, or 33.3% as much memory as the AVL trees (this is
for the purposes of storing metaslab range trees; for other purposes,
like scrubs, they use ~50% as much memory).
We reduced the size of the payload in the range segments by teaching
range trees about starting offsets and shifts; since metaslabs have a
fixed starting offset, and they all operate in terms of disk sectors,
we can store the ranges using 4-byte integers as long as the size of
the metaslab divided by the sector size is less than 2^32. For 512-byte
sectors, this is a 2^41 (or 2TB) metaslab, which with the default
settings corresponds to a 256PB disk. 4k sector disks can handle
metaslabs up to 2^46 bytes, or 2^63 byte disks. Since we do not
anticipate disks of this size in the near future, there should be
almost no cases where metaslabs need 64-byte integers to store their
ranges. We do still have the capability to store 64-byte integer ranges
to account for cases where we are storing per-vdev (or per-dnode) trees,
which could reasonably go above the limits discussed. We also do not
store fill information in the compact version of the node, since it
is only used for sorted scrub.
We also optimized the metaslab loading process in various other ways
to offset some inefficiencies in the btree model. While individual
operations (find, insert, remove_from) are faster for the btree than
they are for the avl tree, remove usually requires a find operation,
while in the AVL tree model the element itself suffices. Some clever
changes actually caused an overall speedup in metaslab loading; we use
approximately 40% less cpu to load metaslabs in our tests on Illumos.
Another memory and performance optimization was achieved by changing
what is stored in the size-sorted trees. When a disk is heavily
fragmented, the df algorithm used by default in ZFS will almost always
find a number of small regions in its initial cursor-based search; it
will usually only fall back to the size-sorted tree to find larger
regions. If we increase the size of the cursor-based search slightly,
and don't store segments that are smaller than a tunable size floor
in the size-sorted tree, we can further cut memory usage down to
below 20% of what the AVL trees store. This also results in further
reductions in CPU time spent loading metaslabs.
The 16KiB size floor was chosen because it results in substantial memory
usage reduction while not usually resulting in situations where we can't
find an appropriate chunk with the cursor and are forced to use an
oversized chunk from the size-sorted tree. In addition, even if we do
have to use an oversized chunk from the size-sorted tree, the chunk
would be too small to use for ZIL allocations, so it isn't as big of a
loss as it might otherwise be. And often, more small allocations will
follow the initial one, and the cursor search will now find the
remainder of the chunk we didn't use all of and use it for subsequent
allocations. Practical testing has shown little or no change in
fragmentation as a result of this change.
If the size-sorted tree becomes empty while the offset sorted one still
has entries, it will load all the entries from the offset sorted tree
and disregard the size floor until it is unloaded again. This operation
occurs rarely with the default setting, only on incredibly thoroughly
fragmented pools.
There are some other small changes to zdb to teach it to handle btrees,
but nothing major.
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Sebastien Roy seb@delphix.com
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9181
2019-10-09 20:36:03 +03:00
|
|
|
mused += zfs_btree_numnodes(&queue->q_exts_by_size) *
|
2022-06-24 19:50:37 +03:00
|
|
|
((sizeof (range_seg_gap_t) + sizeof (uint64_t)) *
|
|
|
|
3 / 2) + queue->q_sio_memused;
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
mutex_exit(&tvd->vdev_scan_io_queue_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
dprintf("current scan memory usage: %llu bytes\n", (longlong_t)mused);
|
|
|
|
|
|
|
|
if (mused == 0)
|
2022-06-24 19:50:37 +03:00
|
|
|
ASSERT0(scn->scn_queues_pending);
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we are above our hard limit, we need to clear out memory.
|
|
|
|
* If we are below our soft limit, we need to accumulate sequential IOs.
|
|
|
|
* Otherwise, we should keep doing whatever we are currently doing.
|
|
|
|
*/
|
|
|
|
if (mused >= mlim_hard)
|
|
|
|
return (B_TRUE);
|
|
|
|
else if (mused < mlim_soft)
|
|
|
|
return (B_FALSE);
|
|
|
|
else
|
|
|
|
return (scn->scn_clearing);
|
|
|
|
}
|
2015-05-06 20:38:29 +03:00
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
static boolean_t
|
2017-07-07 08:16:13 +03:00
|
|
|
dsl_scan_check_suspend(dsl_scan_t *scn, const zbookmark_phys_t *zb)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
|
|
|
/* we never skip user/group accounting objects */
|
|
|
|
if (zb && (int64_t)zb->zb_object < 0)
|
|
|
|
return (B_FALSE);
|
|
|
|
|
2017-07-07 08:16:13 +03:00
|
|
|
if (scn->scn_suspending)
|
|
|
|
return (B_TRUE); /* we're already suspending */
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2012-12-14 03:24:15 +04:00
|
|
|
if (!ZB_IS_ZERO(&scn->scn_phys.scn_bookmark))
|
2010-05-29 00:45:14 +04:00
|
|
|
return (B_FALSE); /* we're resuming */
|
|
|
|
|
2019-09-11 21:16:48 +03:00
|
|
|
/* We only know how to resume from level-0 and objset blocks. */
|
|
|
|
if (zb && (zb->zb_level != 0 && zb->zb_level != ZB_ROOT_LEVEL))
|
2010-05-29 00:45:14 +04:00
|
|
|
return (B_FALSE);
|
|
|
|
|
2015-05-06 20:38:29 +03:00
|
|
|
/*
|
2017-07-07 08:16:13 +03:00
|
|
|
* We suspend if:
|
2015-05-06 20:38:29 +03:00
|
|
|
* - we have scanned for at least the minimum time (default 1 sec
|
|
|
|
* for scrub, 3 sec for resilver), and either we have sufficient
|
|
|
|
* dirty data that we are starting to write more quickly
|
2017-11-16 04:27:01 +03:00
|
|
|
* (default 30%), someone is explicitly waiting for this txg
|
|
|
|
* to complete, or we have used up all of the time in the txg
|
|
|
|
* timeout (default 5 sec).
|
2015-05-06 20:38:29 +03:00
|
|
|
* or
|
|
|
|
* - the spa is shutting down because this pool is being exported
|
|
|
|
* or the machine is rebooting.
|
2017-11-16 04:27:01 +03:00
|
|
|
* or
|
|
|
|
* - the scan queue has reached its memory use limit
|
2015-05-06 20:38:29 +03:00
|
|
|
*/
|
2017-11-16 04:27:01 +03:00
|
|
|
uint64_t curr_time_ns = gethrtime();
|
|
|
|
uint64_t scan_time_ns = curr_time_ns - scn->scn_sync_start_time;
|
|
|
|
uint64_t sync_time_ns = curr_time_ns -
|
|
|
|
scn->scn_dp->dp_spa->spa_sync_starttime;
|
2022-06-27 21:08:21 +03:00
|
|
|
uint64_t dirty_min_bytes = zfs_dirty_data_max *
|
|
|
|
zfs_vdev_async_write_active_min_dirty_percent / 100;
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
uint_t mintime = (scn->scn_phys.scn_func == POOL_SCAN_RESILVER) ?
|
2017-11-16 04:27:01 +03:00
|
|
|
zfs_resilver_min_time_ms : zfs_scrub_min_time_ms;
|
|
|
|
|
|
|
|
if ((NSEC2MSEC(scan_time_ns) > mintime &&
|
2022-06-27 21:08:21 +03:00
|
|
|
(scn->scn_dp->dp_dirty_total >= dirty_min_bytes ||
|
2017-11-16 04:27:01 +03:00
|
|
|
txg_sync_waiting(scn->scn_dp) ||
|
|
|
|
NSEC2SEC(sync_time_ns) >= zfs_txg_timeout)) ||
|
|
|
|
spa_shutting_down(scn->scn_dp->dp_spa) ||
|
|
|
|
(zfs_scan_strict_mem_lim && dsl_scan_should_clear(scn))) {
|
2019-09-11 21:16:48 +03:00
|
|
|
if (zb && zb->zb_level == ZB_ROOT_LEVEL) {
|
|
|
|
dprintf("suspending at first available bookmark "
|
|
|
|
"%llx/%llx/%llx/%llx\n",
|
|
|
|
(longlong_t)zb->zb_objset,
|
|
|
|
(longlong_t)zb->zb_object,
|
|
|
|
(longlong_t)zb->zb_level,
|
|
|
|
(longlong_t)zb->zb_blkid);
|
|
|
|
SET_BOOKMARK(&scn->scn_phys.scn_bookmark,
|
|
|
|
zb->zb_objset, 0, 0, 0);
|
|
|
|
} else if (zb != NULL) {
|
2017-07-07 08:16:13 +03:00
|
|
|
dprintf("suspending at bookmark %llx/%llx/%llx/%llx\n",
|
2010-05-29 00:45:14 +04:00
|
|
|
(longlong_t)zb->zb_objset,
|
|
|
|
(longlong_t)zb->zb_object,
|
|
|
|
(longlong_t)zb->zb_level,
|
|
|
|
(longlong_t)zb->zb_blkid);
|
|
|
|
scn->scn_phys.scn_bookmark = *zb;
|
2017-11-16 04:27:01 +03:00
|
|
|
} else {
|
2018-04-04 20:16:47 +03:00
|
|
|
#ifdef ZFS_DEBUG
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_phys_t *scnp = &scn->scn_phys;
|
|
|
|
dprintf("suspending at at DDT bookmark "
|
|
|
|
"%llx/%llx/%llx/%llx\n",
|
|
|
|
(longlong_t)scnp->scn_ddt_bookmark.ddb_class,
|
|
|
|
(longlong_t)scnp->scn_ddt_bookmark.ddb_type,
|
|
|
|
(longlong_t)scnp->scn_ddt_bookmark.ddb_checksum,
|
|
|
|
(longlong_t)scnp->scn_ddt_bookmark.ddb_cursor);
|
2018-04-04 20:16:47 +03:00
|
|
|
#endif
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2017-07-07 08:16:13 +03:00
|
|
|
scn->scn_suspending = B_TRUE;
|
2010-05-29 00:45:14 +04:00
|
|
|
return (B_TRUE);
|
|
|
|
}
|
|
|
|
return (B_FALSE);
|
|
|
|
}
|
|
|
|
|
2021-12-17 23:35:28 +03:00
|
|
|
static boolean_t
|
|
|
|
dsl_error_scrub_check_suspend(dsl_scan_t *scn, const zbookmark_phys_t *zb)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* We suspend if:
|
|
|
|
* - we have scrubbed for at least the minimum time (default 1 sec
|
|
|
|
* for error scrub), someone is explicitly waiting for this txg
|
|
|
|
* to complete, or we have used up all of the time in the txg
|
|
|
|
* timeout (default 5 sec).
|
|
|
|
* or
|
|
|
|
* - the spa is shutting down because this pool is being exported
|
|
|
|
* or the machine is rebooting.
|
|
|
|
*/
|
|
|
|
uint64_t curr_time_ns = gethrtime();
|
|
|
|
uint64_t error_scrub_time_ns = curr_time_ns - scn->scn_sync_start_time;
|
|
|
|
uint64_t sync_time_ns = curr_time_ns -
|
|
|
|
scn->scn_dp->dp_spa->spa_sync_starttime;
|
|
|
|
int mintime = zfs_scrub_min_time_ms;
|
|
|
|
|
|
|
|
if ((NSEC2MSEC(error_scrub_time_ns) > mintime &&
|
|
|
|
(txg_sync_waiting(scn->scn_dp) ||
|
|
|
|
NSEC2SEC(sync_time_ns) >= zfs_txg_timeout)) ||
|
|
|
|
spa_shutting_down(scn->scn_dp->dp_spa)) {
|
|
|
|
if (zb) {
|
|
|
|
dprintf("error scrub suspending at bookmark "
|
|
|
|
"%llx/%llx/%llx/%llx\n",
|
|
|
|
(longlong_t)zb->zb_objset,
|
|
|
|
(longlong_t)zb->zb_object,
|
|
|
|
(longlong_t)zb->zb_level,
|
|
|
|
(longlong_t)zb->zb_blkid);
|
|
|
|
}
|
|
|
|
return (B_TRUE);
|
|
|
|
}
|
|
|
|
return (B_FALSE);
|
|
|
|
}
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
typedef struct zil_scan_arg {
|
|
|
|
dsl_pool_t *zsa_dp;
|
|
|
|
zil_header_t *zsa_zh;
|
|
|
|
} zil_scan_arg_t;
|
|
|
|
|
|
|
|
static int
|
2020-10-09 19:34:54 +03:00
|
|
|
dsl_scan_zil_block(zilog_t *zilog, const blkptr_t *bp, void *arg,
|
|
|
|
uint64_t claim_txg)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2021-12-12 18:06:44 +03:00
|
|
|
(void) zilog;
|
2010-05-29 00:45:14 +04:00
|
|
|
zil_scan_arg_t *zsa = arg;
|
|
|
|
dsl_pool_t *dp = zsa->zsa_dp;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
zil_header_t *zh = zsa->zsa_zh;
|
2014-06-25 22:37:59 +04:00
|
|
|
zbookmark_phys_t zb;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
Implement Redacted Send/Receive
Redacted send/receive allows users to send subsets of their data to
a target system. One possible use case for this feature is to not
transmit sensitive information to a data warehousing, test/dev, or
analytics environment. Another is to save space by not replicating
unimportant data within a given dataset, for example in backup tools
like zrepl.
Redacted send/receive is a three-stage process. First, a clone (or
clones) is made of the snapshot to be sent to the target. In this
clone (or clones), all unnecessary or unwanted data is removed or
modified. This clone is then snapshotted to create the "redaction
snapshot" (or snapshots). Second, the new zfs redact command is used
to create a redaction bookmark. The redaction bookmark stores the
list of blocks in a snapshot that were modified by the redaction
snapshot(s). Finally, the redaction bookmark is passed as a parameter
to zfs send. When sending to the snapshot that was redacted, the
redaction bookmark is used to filter out blocks that contain sensitive
or unwanted information, and those blocks are not included in the send
stream. When sending from the redaction bookmark, the blocks it
contains are considered as candidate blocks in addition to those
blocks in the destination snapshot that were modified since the
creation_txg of the redaction bookmark. This step is necessary to
allow the target to rehydrate data in the case where some blocks are
accidentally or unnecessarily modified in the redaction snapshot.
The changes to bookmarks to enable fast space estimation involve
adding deadlists to bookmarks. There is also logic to manage the
life cycles of these deadlists.
The new size estimation process operates in cases where previously
an accurate estimate could not be provided. In those cases, a send
is performed where no data blocks are read, reducing the runtime
significantly and providing a byte-accurate size estimate.
Reviewed-by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Prashanth Sreenivasa <pks@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: Chris Williamson <chris.williamson@delphix.com>
Reviewed-by: Pavel Zhakarov <pavel.zakharov@delphix.com>
Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #7958
2019-06-19 19:48:13 +03:00
|
|
|
ASSERT(!BP_IS_REDACTED(bp));
|
2024-03-26 01:01:54 +03:00
|
|
|
if (BP_IS_HOLE(bp) ||
|
|
|
|
BP_GET_LOGICAL_BIRTH(bp) <= scn->scn_phys.scn_cur_min_txg)
|
2010-05-29 00:45:14 +04:00
|
|
|
return (0);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* One block ("stubby") can be allocated a long time ago; we
|
|
|
|
* want to visit that one because it has been allocated
|
|
|
|
* (on-disk) even if it hasn't been claimed (even though for
|
|
|
|
* scrub there's nothing to do to it).
|
|
|
|
*/
|
2024-03-26 01:01:54 +03:00
|
|
|
if (claim_txg == 0 &&
|
|
|
|
BP_GET_LOGICAL_BIRTH(bp) >= spa_min_claim_txg(dp->dp_spa))
|
2010-05-29 00:45:14 +04:00
|
|
|
return (0);
|
|
|
|
|
|
|
|
SET_BOOKMARK(&zb, zh->zh_log.blk_cksum.zc_word[ZIL_ZC_OBJSET],
|
|
|
|
ZB_ZIL_OBJECT, ZB_ZIL_LEVEL, bp->blk_cksum.zc_word[ZIL_ZC_SEQ]);
|
|
|
|
|
|
|
|
VERIFY(0 == scan_funcs[scn->scn_phys.scn_func](dp, bp, &zb));
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2020-10-09 19:34:54 +03:00
|
|
|
dsl_scan_zil_record(zilog_t *zilog, const lr_t *lrc, void *arg,
|
|
|
|
uint64_t claim_txg)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2021-12-12 18:06:44 +03:00
|
|
|
(void) zilog;
|
2010-05-29 00:45:14 +04:00
|
|
|
if (lrc->lrc_txtype == TX_WRITE) {
|
|
|
|
zil_scan_arg_t *zsa = arg;
|
|
|
|
dsl_pool_t *dp = zsa->zsa_dp;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
zil_header_t *zh = zsa->zsa_zh;
|
2020-10-09 19:34:54 +03:00
|
|
|
const lr_write_t *lr = (const lr_write_t *)lrc;
|
|
|
|
const blkptr_t *bp = &lr->lr_blkptr;
|
2014-06-25 22:37:59 +04:00
|
|
|
zbookmark_phys_t zb;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
Implement Redacted Send/Receive
Redacted send/receive allows users to send subsets of their data to
a target system. One possible use case for this feature is to not
transmit sensitive information to a data warehousing, test/dev, or
analytics environment. Another is to save space by not replicating
unimportant data within a given dataset, for example in backup tools
like zrepl.
Redacted send/receive is a three-stage process. First, a clone (or
clones) is made of the snapshot to be sent to the target. In this
clone (or clones), all unnecessary or unwanted data is removed or
modified. This clone is then snapshotted to create the "redaction
snapshot" (or snapshots). Second, the new zfs redact command is used
to create a redaction bookmark. The redaction bookmark stores the
list of blocks in a snapshot that were modified by the redaction
snapshot(s). Finally, the redaction bookmark is passed as a parameter
to zfs send. When sending to the snapshot that was redacted, the
redaction bookmark is used to filter out blocks that contain sensitive
or unwanted information, and those blocks are not included in the send
stream. When sending from the redaction bookmark, the blocks it
contains are considered as candidate blocks in addition to those
blocks in the destination snapshot that were modified since the
creation_txg of the redaction bookmark. This step is necessary to
allow the target to rehydrate data in the case where some blocks are
accidentally or unnecessarily modified in the redaction snapshot.
The changes to bookmarks to enable fast space estimation involve
adding deadlists to bookmarks. There is also logic to manage the
life cycles of these deadlists.
The new size estimation process operates in cases where previously
an accurate estimate could not be provided. In those cases, a send
is performed where no data blocks are read, reducing the runtime
significantly and providing a byte-accurate size estimate.
Reviewed-by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Prashanth Sreenivasa <pks@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: Chris Williamson <chris.williamson@delphix.com>
Reviewed-by: Pavel Zhakarov <pavel.zakharov@delphix.com>
Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #7958
2019-06-19 19:48:13 +03:00
|
|
|
ASSERT(!BP_IS_REDACTED(bp));
|
2013-12-09 22:37:51 +04:00
|
|
|
if (BP_IS_HOLE(bp) ||
|
2024-03-26 01:01:54 +03:00
|
|
|
BP_GET_LOGICAL_BIRTH(bp) <= scn->scn_phys.scn_cur_min_txg)
|
2010-05-29 00:45:14 +04:00
|
|
|
return (0);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* birth can be < claim_txg if this record's txg is
|
|
|
|
* already txg sync'ed (but this log block contains
|
|
|
|
* other records that are not synced)
|
|
|
|
*/
|
2024-03-26 01:01:54 +03:00
|
|
|
if (claim_txg == 0 || BP_GET_LOGICAL_BIRTH(bp) < claim_txg)
|
2010-05-29 00:45:14 +04:00
|
|
|
return (0);
|
|
|
|
|
2022-10-12 21:25:18 +03:00
|
|
|
ASSERT3U(BP_GET_LSIZE(bp), !=, 0);
|
2010-05-29 00:45:14 +04:00
|
|
|
SET_BOOKMARK(&zb, zh->zh_log.blk_cksum.zc_word[ZIL_ZC_OBJSET],
|
|
|
|
lr->lr_foid, ZB_ZIL_LEVEL,
|
|
|
|
lr->lr_offset / BP_GET_LSIZE(bp));
|
|
|
|
|
|
|
|
VERIFY(0 == scan_funcs[scn->scn_phys.scn_func](dp, bp, &zb));
|
|
|
|
}
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_scan_zil(dsl_pool_t *dp, zil_header_t *zh)
|
|
|
|
{
|
|
|
|
uint64_t claim_txg = zh->zh_claim_txg;
|
|
|
|
zil_scan_arg_t zsa = { dp, zh };
|
|
|
|
zilog_t *zilog;
|
|
|
|
|
2016-12-17 01:11:29 +03:00
|
|
|
ASSERT(spa_writeable(dp->dp_spa));
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
/*
|
|
|
|
* We only want to visit blocks that have been claimed but not yet
|
|
|
|
* replayed (or, in read-only mode, blocks that *would* be claimed).
|
|
|
|
*/
|
2016-12-17 01:11:29 +03:00
|
|
|
if (claim_txg == 0)
|
2010-05-29 00:45:14 +04:00
|
|
|
return;
|
|
|
|
|
|
|
|
zilog = zil_alloc(dp->dp_meta_objset, zh);
|
|
|
|
|
|
|
|
(void) zil_parse(zilog, dsl_scan_zil_block, dsl_scan_zil_record, &zsa,
|
Native Encryption for ZFS on Linux
This change incorporates three major pieces:
The first change is a keystore that manages wrapping
and encryption keys for encrypted datasets. These
commands mostly involve manipulating the new
DSL Crypto Key ZAP Objects that live in the MOS. Each
encrypted dataset has its own DSL Crypto Key that is
protected with a user's key. This level of indirection
allows users to change their keys without re-encrypting
their entire datasets. The change implements the new
subcommands "zfs load-key", "zfs unload-key" and
"zfs change-key" which allow the user to manage their
encryption keys and settings. In addition, several new
flags and properties have been added to allow dataset
creation and to make mounting and unmounting more
convenient.
The second piece of this patch provides the ability to
encrypt, decyrpt, and authenticate protected datasets.
Each object set maintains a Merkel tree of Message
Authentication Codes that protect the lower layers,
similarly to how checksums are maintained. This part
impacts the zio layer, which handles the actual
encryption and generation of MACs, as well as the ARC
and DMU, which need to be able to handle encrypted
buffers and protected data.
The last addition is the ability to do raw, encrypted
sends and receives. The idea here is to send raw
encrypted and compressed data and receive it exactly
as is on a backup system. This means that the dataset
on the receiving system is protected using the same
user key that is in use on the sending side. By doing
so, datasets can be efficiently backed up to an
untrusted system without fear of data being
compromised.
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #494
Closes #5769
2017-08-14 20:36:48 +03:00
|
|
|
claim_txg, B_FALSE);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
zil_free(zilog);
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* We compare scan_prefetch_issue_ctx_t's based on their bookmarks. The idea
|
|
|
|
* here is to sort the AVL tree by the order each block will be needed.
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
scan_prefetch_queue_compare(const void *a, const void *b)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
const scan_prefetch_issue_ctx_t *spic_a = a, *spic_b = b;
|
|
|
|
const scan_prefetch_ctx_t *spc_a = spic_a->spic_spc;
|
|
|
|
const scan_prefetch_ctx_t *spc_b = spic_b->spic_spc;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
return (zbookmark_compare(spc_a->spc_datablkszsec,
|
|
|
|
spc_a->spc_indblkshift, spc_b->spc_datablkszsec,
|
|
|
|
spc_b->spc_indblkshift, &spic_a->spic_zb, &spic_b->spic_zb));
|
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static void
|
2022-04-19 21:49:30 +03:00
|
|
|
scan_prefetch_ctx_rele(scan_prefetch_ctx_t *spc, const void *tag)
|
2017-11-16 04:27:01 +03:00
|
|
|
{
|
2018-10-01 20:42:05 +03:00
|
|
|
if (zfs_refcount_remove(&spc->spc_refcnt, tag) == 0) {
|
|
|
|
zfs_refcount_destroy(&spc->spc_refcnt);
|
2017-11-16 04:27:01 +03:00
|
|
|
kmem_free(spc, sizeof (scan_prefetch_ctx_t));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static scan_prefetch_ctx_t *
|
2022-04-19 21:49:30 +03:00
|
|
|
scan_prefetch_ctx_create(dsl_scan_t *scn, dnode_phys_t *dnp, const void *tag)
|
2017-11-16 04:27:01 +03:00
|
|
|
{
|
|
|
|
scan_prefetch_ctx_t *spc;
|
|
|
|
|
|
|
|
spc = kmem_alloc(sizeof (scan_prefetch_ctx_t), KM_SLEEP);
|
2018-10-01 20:42:05 +03:00
|
|
|
zfs_refcount_create(&spc->spc_refcnt);
|
2018-09-26 20:29:26 +03:00
|
|
|
zfs_refcount_add(&spc->spc_refcnt, tag);
|
2017-11-16 04:27:01 +03:00
|
|
|
spc->spc_scn = scn;
|
|
|
|
if (dnp != NULL) {
|
|
|
|
spc->spc_datablkszsec = dnp->dn_datablkszsec;
|
|
|
|
spc->spc_indblkshift = dnp->dn_indblkshift;
|
|
|
|
spc->spc_root = B_FALSE;
|
|
|
|
} else {
|
|
|
|
spc->spc_datablkszsec = 0;
|
|
|
|
spc->spc_indblkshift = 0;
|
|
|
|
spc->spc_root = B_TRUE;
|
|
|
|
}
|
|
|
|
|
|
|
|
return (spc);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2022-04-19 21:49:30 +03:00
|
|
|
scan_prefetch_ctx_add_ref(scan_prefetch_ctx_t *spc, const void *tag)
|
2017-11-16 04:27:01 +03:00
|
|
|
{
|
2018-09-26 20:29:26 +03:00
|
|
|
zfs_refcount_add(&spc->spc_refcnt, tag);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
|
2018-12-06 20:47:23 +03:00
|
|
|
static void
|
|
|
|
scan_ds_prefetch_queue_clear(dsl_scan_t *scn)
|
|
|
|
{
|
|
|
|
spa_t *spa = scn->scn_dp->dp_spa;
|
|
|
|
void *cookie = NULL;
|
|
|
|
scan_prefetch_issue_ctx_t *spic = NULL;
|
|
|
|
|
|
|
|
mutex_enter(&spa->spa_scrub_lock);
|
|
|
|
while ((spic = avl_destroy_nodes(&scn->scn_prefetch_queue,
|
|
|
|
&cookie)) != NULL) {
|
|
|
|
scan_prefetch_ctx_rele(spic->spic_spc, scn);
|
|
|
|
kmem_free(spic, sizeof (scan_prefetch_issue_ctx_t));
|
|
|
|
}
|
|
|
|
mutex_exit(&spa->spa_scrub_lock);
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static boolean_t
|
|
|
|
dsl_scan_check_prefetch_resume(scan_prefetch_ctx_t *spc,
|
|
|
|
const zbookmark_phys_t *zb)
|
|
|
|
{
|
|
|
|
zbookmark_phys_t *last_zb = &spc->spc_scn->scn_prefetch_bookmark;
|
|
|
|
dnode_phys_t tmp_dnp;
|
|
|
|
dnode_phys_t *dnp = (spc->spc_root) ? NULL : &tmp_dnp;
|
|
|
|
|
|
|
|
if (zb->zb_objset != last_zb->zb_objset)
|
|
|
|
return (B_TRUE);
|
|
|
|
if ((int64_t)zb->zb_object < 0)
|
|
|
|
return (B_FALSE);
|
|
|
|
|
|
|
|
tmp_dnp.dn_datablkszsec = spc->spc_datablkszsec;
|
|
|
|
tmp_dnp.dn_indblkshift = spc->spc_indblkshift;
|
|
|
|
|
|
|
|
if (zbookmark_subtree_completed(dnp, zb, last_zb))
|
|
|
|
return (B_TRUE);
|
|
|
|
|
|
|
|
return (B_FALSE);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_scan_prefetch(scan_prefetch_ctx_t *spc, blkptr_t *bp, zbookmark_phys_t *zb)
|
|
|
|
{
|
|
|
|
avl_index_t idx;
|
|
|
|
dsl_scan_t *scn = spc->spc_scn;
|
|
|
|
spa_t *spa = scn->scn_dp->dp_spa;
|
|
|
|
scan_prefetch_issue_ctx_t *spic;
|
|
|
|
|
Implement Redacted Send/Receive
Redacted send/receive allows users to send subsets of their data to
a target system. One possible use case for this feature is to not
transmit sensitive information to a data warehousing, test/dev, or
analytics environment. Another is to save space by not replicating
unimportant data within a given dataset, for example in backup tools
like zrepl.
Redacted send/receive is a three-stage process. First, a clone (or
clones) is made of the snapshot to be sent to the target. In this
clone (or clones), all unnecessary or unwanted data is removed or
modified. This clone is then snapshotted to create the "redaction
snapshot" (or snapshots). Second, the new zfs redact command is used
to create a redaction bookmark. The redaction bookmark stores the
list of blocks in a snapshot that were modified by the redaction
snapshot(s). Finally, the redaction bookmark is passed as a parameter
to zfs send. When sending to the snapshot that was redacted, the
redaction bookmark is used to filter out blocks that contain sensitive
or unwanted information, and those blocks are not included in the send
stream. When sending from the redaction bookmark, the blocks it
contains are considered as candidate blocks in addition to those
blocks in the destination snapshot that were modified since the
creation_txg of the redaction bookmark. This step is necessary to
allow the target to rehydrate data in the case where some blocks are
accidentally or unnecessarily modified in the redaction snapshot.
The changes to bookmarks to enable fast space estimation involve
adding deadlists to bookmarks. There is also logic to manage the
life cycles of these deadlists.
The new size estimation process operates in cases where previously
an accurate estimate could not be provided. In those cases, a send
is performed where no data blocks are read, reducing the runtime
significantly and providing a byte-accurate size estimate.
Reviewed-by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Prashanth Sreenivasa <pks@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: Chris Williamson <chris.williamson@delphix.com>
Reviewed-by: Pavel Zhakarov <pavel.zakharov@delphix.com>
Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #7958
2019-06-19 19:48:13 +03:00
|
|
|
if (zfs_no_scrub_prefetch || BP_IS_REDACTED(bp))
|
2017-11-16 04:27:01 +03:00
|
|
|
return;
|
|
|
|
|
2024-03-26 01:01:54 +03:00
|
|
|
if (BP_IS_HOLE(bp) ||
|
|
|
|
BP_GET_LOGICAL_BIRTH(bp) <= scn->scn_phys.scn_cur_min_txg ||
|
2017-11-16 04:27:01 +03:00
|
|
|
(BP_GET_LEVEL(bp) == 0 && BP_GET_TYPE(bp) != DMU_OT_DNODE &&
|
|
|
|
BP_GET_TYPE(bp) != DMU_OT_OBJSET))
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (dsl_scan_check_prefetch_resume(spc, zb))
|
|
|
|
return;
|
|
|
|
|
|
|
|
scan_prefetch_ctx_add_ref(spc, scn);
|
|
|
|
spic = kmem_alloc(sizeof (scan_prefetch_issue_ctx_t), KM_SLEEP);
|
|
|
|
spic->spic_spc = spc;
|
|
|
|
spic->spic_bp = *bp;
|
|
|
|
spic->spic_zb = *zb;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Add the IO to the queue of blocks to prefetch. This allows us to
|
|
|
|
* prioritize blocks that we will need first for the main traversal
|
|
|
|
* thread.
|
|
|
|
*/
|
|
|
|
mutex_enter(&spa->spa_scrub_lock);
|
|
|
|
if (avl_find(&scn->scn_prefetch_queue, spic, &idx) != NULL) {
|
|
|
|
/* this block is already queued for prefetch */
|
|
|
|
kmem_free(spic, sizeof (scan_prefetch_issue_ctx_t));
|
|
|
|
scan_prefetch_ctx_rele(spc, scn);
|
|
|
|
mutex_exit(&spa->spa_scrub_lock);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
avl_insert(&scn->scn_prefetch_queue, spic, idx);
|
|
|
|
cv_broadcast(&spa->spa_scrub_io_cv);
|
|
|
|
mutex_exit(&spa->spa_scrub_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_scan_prefetch_dnode(dsl_scan_t *scn, dnode_phys_t *dnp,
|
|
|
|
uint64_t objset, uint64_t object)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
zbookmark_phys_t zb;
|
|
|
|
scan_prefetch_ctx_t *spc;
|
|
|
|
|
|
|
|
if (dnp->dn_nblkptr == 0 && !(dnp->dn_flags & DNODE_FLAG_SPILL_BLKPTR))
|
|
|
|
return;
|
|
|
|
|
|
|
|
SET_BOOKMARK(&zb, objset, object, 0, 0);
|
|
|
|
|
|
|
|
spc = scan_prefetch_ctx_create(scn, dnp, FTAG);
|
|
|
|
|
|
|
|
for (i = 0; i < dnp->dn_nblkptr; i++) {
|
|
|
|
zb.zb_level = BP_GET_LEVEL(&dnp->dn_blkptr[i]);
|
|
|
|
zb.zb_blkid = i;
|
|
|
|
dsl_scan_prefetch(spc, &dnp->dn_blkptr[i], &zb);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (dnp->dn_flags & DNODE_FLAG_SPILL_BLKPTR) {
|
|
|
|
zb.zb_level = 0;
|
|
|
|
zb.zb_blkid = DMU_SPILL_BLKID;
|
|
|
|
dsl_scan_prefetch(spc, DN_SPILL_BLKPTR(dnp), &zb);
|
|
|
|
}
|
|
|
|
|
|
|
|
scan_prefetch_ctx_rele(spc, FTAG);
|
|
|
|
}
|
|
|
|
|
2020-06-15 21:30:37 +03:00
|
|
|
static void
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_prefetch_cb(zio_t *zio, const zbookmark_phys_t *zb, const blkptr_t *bp,
|
|
|
|
arc_buf_t *buf, void *private)
|
|
|
|
{
|
2021-12-12 18:06:44 +03:00
|
|
|
(void) zio;
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_prefetch_ctx_t *spc = private;
|
|
|
|
dsl_scan_t *scn = spc->spc_scn;
|
|
|
|
spa_t *spa = scn->scn_dp->dp_spa;
|
|
|
|
|
2018-03-29 04:30:44 +03:00
|
|
|
/* broadcast that the IO has completed for rate limiting purposes */
|
2017-11-16 04:27:01 +03:00
|
|
|
mutex_enter(&spa->spa_scrub_lock);
|
|
|
|
ASSERT3U(spa->spa_scrub_inflight, >=, BP_GET_PSIZE(bp));
|
|
|
|
spa->spa_scrub_inflight -= BP_GET_PSIZE(bp);
|
|
|
|
cv_broadcast(&spa->spa_scrub_io_cv);
|
|
|
|
mutex_exit(&spa->spa_scrub_lock);
|
|
|
|
|
|
|
|
/* if there was an error or we are done prefetching, just cleanup */
|
2018-03-29 04:30:44 +03:00
|
|
|
if (buf == NULL || scn->scn_prefetch_stop)
|
2017-11-16 04:27:01 +03:00
|
|
|
goto out;
|
|
|
|
|
|
|
|
if (BP_GET_LEVEL(bp) > 0) {
|
|
|
|
int i;
|
|
|
|
blkptr_t *cbp;
|
|
|
|
int epb = BP_GET_LSIZE(bp) >> SPA_BLKPTRSHIFT;
|
|
|
|
zbookmark_phys_t czb;
|
|
|
|
|
|
|
|
for (i = 0, cbp = buf->b_data; i < epb; i++, cbp++) {
|
|
|
|
SET_BOOKMARK(&czb, zb->zb_objset, zb->zb_object,
|
|
|
|
zb->zb_level - 1, zb->zb_blkid * epb + i);
|
|
|
|
dsl_scan_prefetch(spc, cbp, &czb);
|
|
|
|
}
|
|
|
|
} else if (BP_GET_TYPE(bp) == DMU_OT_DNODE) {
|
|
|
|
dnode_phys_t *cdnp;
|
|
|
|
int i;
|
|
|
|
int epb = BP_GET_LSIZE(bp) >> DNODE_SHIFT;
|
|
|
|
|
|
|
|
for (i = 0, cdnp = buf->b_data; i < epb;
|
|
|
|
i += cdnp->dn_extra_slots + 1,
|
|
|
|
cdnp += cdnp->dn_extra_slots + 1) {
|
|
|
|
dsl_scan_prefetch_dnode(scn, cdnp,
|
|
|
|
zb->zb_objset, zb->zb_blkid * epb + i);
|
|
|
|
}
|
|
|
|
} else if (BP_GET_TYPE(bp) == DMU_OT_OBJSET) {
|
|
|
|
objset_phys_t *osp = buf->b_data;
|
|
|
|
|
|
|
|
dsl_scan_prefetch_dnode(scn, &osp->os_meta_dnode,
|
|
|
|
zb->zb_objset, DMU_META_DNODE_OBJECT);
|
|
|
|
|
|
|
|
if (OBJSET_BUF_HAS_USERUSED(buf)) {
|
2023-07-13 19:12:55 +03:00
|
|
|
if (OBJSET_BUF_HAS_PROJECTUSED(buf)) {
|
|
|
|
dsl_scan_prefetch_dnode(scn,
|
|
|
|
&osp->os_projectused_dnode, zb->zb_objset,
|
|
|
|
DMU_PROJECTUSED_OBJECT);
|
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_prefetch_dnode(scn,
|
|
|
|
&osp->os_groupused_dnode, zb->zb_objset,
|
|
|
|
DMU_GROUPUSED_OBJECT);
|
|
|
|
dsl_scan_prefetch_dnode(scn,
|
|
|
|
&osp->os_userused_dnode, zb->zb_objset,
|
|
|
|
DMU_USERUSED_OBJECT);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
|
|
|
if (buf != NULL)
|
|
|
|
arc_buf_destroy(buf, private);
|
|
|
|
scan_prefetch_ctx_rele(spc, scn);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_scan_prefetch_thread(void *arg)
|
|
|
|
{
|
|
|
|
dsl_scan_t *scn = arg;
|
|
|
|
spa_t *spa = scn->scn_dp->dp_spa;
|
|
|
|
scan_prefetch_issue_ctx_t *spic;
|
|
|
|
|
|
|
|
/* loop until we are told to stop */
|
|
|
|
while (!scn->scn_prefetch_stop) {
|
|
|
|
arc_flags_t flags = ARC_FLAG_NOWAIT |
|
|
|
|
ARC_FLAG_PRESCIENT_PREFETCH | ARC_FLAG_PREFETCH;
|
|
|
|
int zio_flags = ZIO_FLAG_CANFAIL | ZIO_FLAG_SCAN_THREAD;
|
|
|
|
|
|
|
|
mutex_enter(&spa->spa_scrub_lock);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Wait until we have an IO to issue and are not above our
|
|
|
|
* maximum in flight limit.
|
|
|
|
*/
|
|
|
|
while (!scn->scn_prefetch_stop &&
|
|
|
|
(avl_numnodes(&scn->scn_prefetch_queue) == 0 ||
|
|
|
|
spa->spa_scrub_inflight >= scn->scn_maxinflight_bytes)) {
|
|
|
|
cv_wait(&spa->spa_scrub_io_cv, &spa->spa_scrub_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* recheck if we should stop since we waited for the cv */
|
|
|
|
if (scn->scn_prefetch_stop) {
|
|
|
|
mutex_exit(&spa->spa_scrub_lock);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* remove the prefetch IO from the tree */
|
|
|
|
spic = avl_first(&scn->scn_prefetch_queue);
|
|
|
|
spa->spa_scrub_inflight += BP_GET_PSIZE(&spic->spic_bp);
|
|
|
|
avl_remove(&scn->scn_prefetch_queue, spic);
|
|
|
|
|
|
|
|
mutex_exit(&spa->spa_scrub_lock);
|
|
|
|
|
|
|
|
if (BP_IS_PROTECTED(&spic->spic_bp)) {
|
|
|
|
ASSERT(BP_GET_TYPE(&spic->spic_bp) == DMU_OT_DNODE ||
|
|
|
|
BP_GET_TYPE(&spic->spic_bp) == DMU_OT_OBJSET);
|
|
|
|
ASSERT3U(BP_GET_LEVEL(&spic->spic_bp), ==, 0);
|
|
|
|
zio_flags |= ZIO_FLAG_RAW;
|
|
|
|
}
|
|
|
|
|
2023-07-20 19:10:04 +03:00
|
|
|
/* We don't need data L1 buffer since we do not prefetch L0. */
|
|
|
|
blkptr_t *bp = &spic->spic_bp;
|
|
|
|
if (BP_GET_LEVEL(bp) == 1 && BP_GET_TYPE(bp) != DMU_OT_DNODE &&
|
|
|
|
BP_GET_TYPE(bp) != DMU_OT_OBJSET)
|
|
|
|
flags |= ARC_FLAG_NO_BUF;
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/* issue the prefetch asynchronously */
|
2023-07-20 19:10:04 +03:00
|
|
|
(void) arc_read(scn->scn_zio_root, spa, bp,
|
|
|
|
dsl_scan_prefetch_cb, spic->spic_spc, ZIO_PRIORITY_SCRUB,
|
|
|
|
zio_flags, &flags, &spic->spic_zb);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
kmem_free(spic, sizeof (scan_prefetch_issue_ctx_t));
|
Native Encryption for ZFS on Linux
This change incorporates three major pieces:
The first change is a keystore that manages wrapping
and encryption keys for encrypted datasets. These
commands mostly involve manipulating the new
DSL Crypto Key ZAP Objects that live in the MOS. Each
encrypted dataset has its own DSL Crypto Key that is
protected with a user's key. This level of indirection
allows users to change their keys without re-encrypting
their entire datasets. The change implements the new
subcommands "zfs load-key", "zfs unload-key" and
"zfs change-key" which allow the user to manage their
encryption keys and settings. In addition, several new
flags and properties have been added to allow dataset
creation and to make mounting and unmounting more
convenient.
The second piece of this patch provides the ability to
encrypt, decyrpt, and authenticate protected datasets.
Each object set maintains a Merkel tree of Message
Authentication Codes that protect the lower layers,
similarly to how checksums are maintained. This part
impacts the zio layer, which handles the actual
encryption and generation of MACs, as well as the ARC
and DMU, which need to be able to handle encrypted
buffers and protected data.
The last addition is the ability to do raw, encrypted
sends and receives. The idea here is to send raw
encrypted and compressed data and receive it exactly
as is on a backup system. This means that the dataset
on the receiving system is protected using the same
user key that is in use on the sending side. By doing
so, datasets can be efficiently backed up to an
untrusted system without fear of data being
compromised.
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #494
Closes #5769
2017-08-14 20:36:48 +03:00
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
ASSERT(scn->scn_prefetch_stop);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/* free any prefetches we didn't get to complete */
|
|
|
|
mutex_enter(&spa->spa_scrub_lock);
|
|
|
|
while ((spic = avl_first(&scn->scn_prefetch_queue)) != NULL) {
|
|
|
|
avl_remove(&scn->scn_prefetch_queue, spic);
|
|
|
|
scan_prefetch_ctx_rele(spic->spic_spc, scn);
|
|
|
|
kmem_free(spic, sizeof (scan_prefetch_issue_ctx_t));
|
|
|
|
}
|
|
|
|
ASSERT0(avl_numnodes(&scn->scn_prefetch_queue));
|
|
|
|
mutex_exit(&spa->spa_scrub_lock);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static boolean_t
|
|
|
|
dsl_scan_check_resume(dsl_scan_t *scn, const dnode_phys_t *dnp,
|
2014-06-25 22:37:59 +04:00
|
|
|
const zbookmark_phys_t *zb)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
|
|
|
/*
|
|
|
|
* We never skip over user/group accounting objects (obj<0)
|
|
|
|
*/
|
2012-12-14 03:24:15 +04:00
|
|
|
if (!ZB_IS_ZERO(&scn->scn_phys.scn_bookmark) &&
|
2010-05-29 00:45:14 +04:00
|
|
|
(int64_t)zb->zb_object >= 0) {
|
|
|
|
/*
|
|
|
|
* If we already visited this bp & everything below (in
|
|
|
|
* a prior txg sync), don't bother doing it again.
|
|
|
|
*/
|
2015-12-22 04:31:57 +03:00
|
|
|
if (zbookmark_subtree_completed(dnp, zb,
|
|
|
|
&scn->scn_phys.scn_bookmark))
|
2010-05-29 00:45:14 +04:00
|
|
|
return (B_TRUE);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we found the block we're trying to resume from, or
|
2022-07-21 03:02:36 +03:00
|
|
|
* we went past it, zero it out to indicate that it's OK
|
|
|
|
* to start checking for suspending again.
|
2010-05-29 00:45:14 +04:00
|
|
|
*/
|
2022-07-21 03:02:36 +03:00
|
|
|
if (zbookmark_subtree_tbd(dnp, zb,
|
|
|
|
&scn->scn_phys.scn_bookmark)) {
|
2010-05-29 00:45:14 +04:00
|
|
|
dprintf("resuming at %llx/%llx/%llx/%llx\n",
|
|
|
|
(longlong_t)zb->zb_objset,
|
|
|
|
(longlong_t)zb->zb_object,
|
|
|
|
(longlong_t)zb->zb_level,
|
|
|
|
(longlong_t)zb->zb_blkid);
|
2022-02-25 16:26:54 +03:00
|
|
|
memset(&scn->scn_phys.scn_bookmark, 0, sizeof (*zb));
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return (B_FALSE);
|
|
|
|
}
|
|
|
|
|
2023-11-28 20:20:48 +03:00
|
|
|
static void dsl_scan_visitbp(const blkptr_t *bp, const zbookmark_phys_t *zb,
|
2017-11-16 04:27:01 +03:00
|
|
|
dnode_phys_t *dnp, dsl_dataset_t *ds, dsl_scan_t *scn,
|
|
|
|
dmu_objset_type_t ostype, dmu_tx_t *tx);
|
|
|
|
inline __attribute__((always_inline)) static void dsl_scan_visitdnode(
|
|
|
|
dsl_scan_t *, dsl_dataset_t *ds, dmu_objset_type_t ostype,
|
|
|
|
dnode_phys_t *dnp, uint64_t object, dmu_tx_t *tx);
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
/*
|
|
|
|
* Return nonzero on i/o error.
|
|
|
|
* Return new buf to write out in *bufp.
|
|
|
|
*/
|
2012-07-19 03:56:24 +04:00
|
|
|
inline __attribute__((always_inline)) static int
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_scan_recurse(dsl_scan_t *scn, dsl_dataset_t *ds, dmu_objset_type_t ostype,
|
|
|
|
dnode_phys_t *dnp, const blkptr_t *bp,
|
2014-09-17 11:07:28 +04:00
|
|
|
const zbookmark_phys_t *zb, dmu_tx_t *tx)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
|
|
|
dsl_pool_t *dp = scn->scn_dp;
|
2022-05-20 20:36:14 +03:00
|
|
|
spa_t *spa = dp->dp_spa;
|
2010-08-27 01:24:34 +04:00
|
|
|
int zio_flags = ZIO_FLAG_CANFAIL | ZIO_FLAG_SCAN_THREAD;
|
2010-05-29 00:45:14 +04:00
|
|
|
int err;
|
|
|
|
|
Implement Redacted Send/Receive
Redacted send/receive allows users to send subsets of their data to
a target system. One possible use case for this feature is to not
transmit sensitive information to a data warehousing, test/dev, or
analytics environment. Another is to save space by not replicating
unimportant data within a given dataset, for example in backup tools
like zrepl.
Redacted send/receive is a three-stage process. First, a clone (or
clones) is made of the snapshot to be sent to the target. In this
clone (or clones), all unnecessary or unwanted data is removed or
modified. This clone is then snapshotted to create the "redaction
snapshot" (or snapshots). Second, the new zfs redact command is used
to create a redaction bookmark. The redaction bookmark stores the
list of blocks in a snapshot that were modified by the redaction
snapshot(s). Finally, the redaction bookmark is passed as a parameter
to zfs send. When sending to the snapshot that was redacted, the
redaction bookmark is used to filter out blocks that contain sensitive
or unwanted information, and those blocks are not included in the send
stream. When sending from the redaction bookmark, the blocks it
contains are considered as candidate blocks in addition to those
blocks in the destination snapshot that were modified since the
creation_txg of the redaction bookmark. This step is necessary to
allow the target to rehydrate data in the case where some blocks are
accidentally or unnecessarily modified in the redaction snapshot.
The changes to bookmarks to enable fast space estimation involve
adding deadlists to bookmarks. There is also logic to manage the
life cycles of these deadlists.
The new size estimation process operates in cases where previously
an accurate estimate could not be provided. In those cases, a send
is performed where no data blocks are read, reducing the runtime
significantly and providing a byte-accurate size estimate.
Reviewed-by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Prashanth Sreenivasa <pks@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: Chris Williamson <chris.williamson@delphix.com>
Reviewed-by: Pavel Zhakarov <pavel.zakharov@delphix.com>
Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #7958
2019-06-19 19:48:13 +03:00
|
|
|
ASSERT(!BP_IS_REDACTED(bp));
|
|
|
|
|
2022-02-04 01:28:19 +03:00
|
|
|
/*
|
|
|
|
* There is an unlikely case of encountering dnodes with contradicting
|
|
|
|
* dn_bonuslen and DNODE_FLAG_SPILL_BLKPTR flag before in files created
|
|
|
|
* or modified before commit 4254acb was merged. As it is not possible
|
|
|
|
* to know which of the two is correct, report an error.
|
|
|
|
*/
|
|
|
|
if (dnp != NULL &&
|
|
|
|
dnp->dn_bonuslen > DN_MAX_BONUS_LEN(dnp)) {
|
|
|
|
scn->scn_phys.scn_errors++;
|
2024-03-26 01:01:54 +03:00
|
|
|
spa_log_error(spa, zb, BP_GET_LOGICAL_BIRTH(bp));
|
2022-02-04 01:28:19 +03:00
|
|
|
return (SET_ERROR(EINVAL));
|
|
|
|
}
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
if (BP_GET_LEVEL(bp) > 0) {
|
2014-12-06 20:24:32 +03:00
|
|
|
arc_flags_t flags = ARC_FLAG_WAIT;
|
2010-05-29 00:45:14 +04:00
|
|
|
int i;
|
|
|
|
blkptr_t *cbp;
|
|
|
|
int epb = BP_GET_LSIZE(bp) >> SPA_BLKPTRSHIFT;
|
2014-09-17 11:07:28 +04:00
|
|
|
arc_buf_t *buf;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2022-05-20 20:36:14 +03:00
|
|
|
err = arc_read(NULL, spa, bp, arc_getbuf_func, &buf,
|
2017-12-21 20:13:06 +03:00
|
|
|
ZIO_PRIORITY_SCRUB, zio_flags, &flags, zb);
|
2010-05-29 00:45:14 +04:00
|
|
|
if (err) {
|
|
|
|
scn->scn_phys.scn_errors++;
|
|
|
|
return (err);
|
|
|
|
}
|
2014-09-17 11:07:28 +04:00
|
|
|
for (i = 0, cbp = buf->b_data; i < epb; i++, cbp++) {
|
2014-06-25 22:37:59 +04:00
|
|
|
zbookmark_phys_t czb;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
SET_BOOKMARK(&czb, zb->zb_objset, zb->zb_object,
|
|
|
|
zb->zb_level - 1,
|
|
|
|
zb->zb_blkid * epb + i);
|
|
|
|
dsl_scan_visitbp(cbp, &czb, dnp,
|
2014-09-17 11:07:28 +04:00
|
|
|
ds, scn, ostype, tx);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2016-06-02 07:04:53 +03:00
|
|
|
arc_buf_destroy(buf, &buf);
|
2010-05-29 00:45:14 +04:00
|
|
|
} else if (BP_GET_TYPE(bp) == DMU_OT_DNODE) {
|
2014-12-06 20:24:32 +03:00
|
|
|
arc_flags_t flags = ARC_FLAG_WAIT;
|
2010-05-29 00:45:14 +04:00
|
|
|
dnode_phys_t *cdnp;
|
2017-11-16 04:27:01 +03:00
|
|
|
int i;
|
2010-05-29 00:45:14 +04:00
|
|
|
int epb = BP_GET_LSIZE(bp) >> DNODE_SHIFT;
|
2014-09-17 11:07:28 +04:00
|
|
|
arc_buf_t *buf;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
Native Encryption for ZFS on Linux
This change incorporates three major pieces:
The first change is a keystore that manages wrapping
and encryption keys for encrypted datasets. These
commands mostly involve manipulating the new
DSL Crypto Key ZAP Objects that live in the MOS. Each
encrypted dataset has its own DSL Crypto Key that is
protected with a user's key. This level of indirection
allows users to change their keys without re-encrypting
their entire datasets. The change implements the new
subcommands "zfs load-key", "zfs unload-key" and
"zfs change-key" which allow the user to manage their
encryption keys and settings. In addition, several new
flags and properties have been added to allow dataset
creation and to make mounting and unmounting more
convenient.
The second piece of this patch provides the ability to
encrypt, decyrpt, and authenticate protected datasets.
Each object set maintains a Merkel tree of Message
Authentication Codes that protect the lower layers,
similarly to how checksums are maintained. This part
impacts the zio layer, which handles the actual
encryption and generation of MACs, as well as the ARC
and DMU, which need to be able to handle encrypted
buffers and protected data.
The last addition is the ability to do raw, encrypted
sends and receives. The idea here is to send raw
encrypted and compressed data and receive it exactly
as is on a backup system. This means that the dataset
on the receiving system is protected using the same
user key that is in use on the sending side. By doing
so, datasets can be efficiently backed up to an
untrusted system without fear of data being
compromised.
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #494
Closes #5769
2017-08-14 20:36:48 +03:00
|
|
|
if (BP_IS_PROTECTED(bp)) {
|
|
|
|
ASSERT3U(BP_GET_COMPRESS(bp), ==, ZIO_COMPRESS_OFF);
|
|
|
|
zio_flags |= ZIO_FLAG_RAW;
|
|
|
|
}
|
|
|
|
|
2022-05-20 20:36:14 +03:00
|
|
|
err = arc_read(NULL, spa, bp, arc_getbuf_func, &buf,
|
2017-12-21 20:13:06 +03:00
|
|
|
ZIO_PRIORITY_SCRUB, zio_flags, &flags, zb);
|
2010-05-29 00:45:14 +04:00
|
|
|
if (err) {
|
|
|
|
scn->scn_phys.scn_errors++;
|
|
|
|
return (err);
|
|
|
|
}
|
Implement large_dnode pool feature
Justification
-------------
This feature adds support for variable length dnodes. Our motivation is
to eliminate the overhead associated with using spill blocks. Spill
blocks are used to store system attribute data (i.e. file metadata) that
does not fit in the dnode's bonus buffer. By allowing a larger bonus
buffer area the use of a spill block can be avoided. Spill blocks
potentially incur an additional read I/O for every dnode in a dnode
block. As a worst case example, reading 32 dnodes from a 16k dnode block
and all of the spill blocks could issue 33 separate reads. Now suppose
those dnodes have size 1024 and therefore don't need spill blocks. Then
the worst case number of blocks read is reduced to from 33 to two--one
per dnode block. In practice spill blocks may tend to be co-located on
disk with the dnode blocks so the reduction in I/O would not be this
drastic. In a badly fragmented pool, however, the improvement could be
significant.
ZFS-on-Linux systems that make heavy use of extended attributes would
benefit from this feature. In particular, ZFS-on-Linux supports the
xattr=sa dataset property which allows file extended attribute data
to be stored in the dnode bonus buffer as an alternative to the
traditional directory-based format. Workloads such as SELinux and the
Lustre distributed filesystem often store enough xattr data to force
spill bocks when xattr=sa is in effect. Large dnodes may therefore
provide a performance benefit to such systems.
Other use cases that may benefit from this feature include files with
large ACLs and symbolic links with long target names. Furthermore,
this feature may be desirable on other platforms in case future
applications or features are developed that could make use of a
larger bonus buffer area.
Implementation
--------------
The size of a dnode may be a multiple of 512 bytes up to the size of
a dnode block (currently 16384 bytes). A dn_extra_slots field was
added to the current on-disk dnode_phys_t structure to describe the
size of the physical dnode on disk. The 8 bits for this field were
taken from the zero filled dn_pad2 field. The field represents how
many "extra" dnode_phys_t slots a dnode consumes in its dnode block.
This convention results in a value of 0 for 512 byte dnodes which
preserves on-disk format compatibility with older software.
Similarly, the in-memory dnode_t structure has a new dn_num_slots field
to represent the total number of dnode_phys_t slots consumed on disk.
Thus dn->dn_num_slots is 1 greater than the corresponding
dnp->dn_extra_slots. This difference in convention was adopted
because, unlike on-disk structures, backward compatibility is not a
concern for in-memory objects, so we used a more natural way to
represent size for a dnode_t.
The default size for newly created dnodes is determined by the value of
a new "dnodesize" dataset property. By default the property is set to
"legacy" which is compatible with older software. Setting the property
to "auto" will allow the filesystem to choose the most suitable dnode
size. Currently this just sets the default dnode size to 1k, but future
code improvements could dynamically choose a size based on observed
workload patterns. Dnodes of varying sizes can coexist within the same
dataset and even within the same dnode block. For example, to enable
automatically-sized dnodes, run
# zfs set dnodesize=auto tank/fish
The user can also specify literal values for the dnodesize property.
These are currently limited to powers of two from 1k to 16k. The
power-of-2 limitation is only for simplicity of the user interface.
Internally the implementation can handle any multiple of 512 up to 16k,
and consumers of the DMU API can specify any legal dnode value.
The size of a new dnode is determined at object allocation time and
stored as a new field in the znode in-memory structure. New DMU
interfaces are added to allow the consumer to specify the dnode size
that a newly allocated object should use. Existing interfaces are
unchanged to avoid having to update every call site and to preserve
compatibility with external consumers such as Lustre. The new
interfaces names are given below. The versions of these functions that
don't take a dnodesize parameter now just call the _dnsize() versions
with a dnodesize of 0, which means use the legacy dnode size.
New DMU interfaces:
dmu_object_alloc_dnsize()
dmu_object_claim_dnsize()
dmu_object_reclaim_dnsize()
New ZAP interfaces:
zap_create_dnsize()
zap_create_norm_dnsize()
zap_create_flags_dnsize()
zap_create_claim_norm_dnsize()
zap_create_link_dnsize()
The constant DN_MAX_BONUSLEN is renamed to DN_OLD_MAX_BONUSLEN. The
spa_maxdnodesize() function should be used to determine the maximum
bonus length for a pool.
These are a few noteworthy changes to key functions:
* The prototype for dnode_hold_impl() now takes a "slots" parameter.
When the DNODE_MUST_BE_FREE flag is set, this parameter is used to
ensure the hole at the specified object offset is large enough to
hold the dnode being created. The slots parameter is also used
to ensure a dnode does not span multiple dnode blocks. In both of
these cases, if a failure occurs, ENOSPC is returned. Keep in mind,
these failure cases are only possible when using DNODE_MUST_BE_FREE.
If the DNODE_MUST_BE_ALLOCATED flag is set, "slots" must be 0.
dnode_hold_impl() will check if the requested dnode is already
consumed as an extra dnode slot by an large dnode, in which case
it returns ENOENT.
* The function dmu_object_alloc() advances to the next dnode block
if dnode_hold_impl() returns an error for a requested object.
This is because the beginning of the next dnode block is the only
location it can safely assume to either be a hole or a valid
starting point for a dnode.
* dnode_next_offset_level() and other functions that iterate
through dnode blocks may no longer use a simple array indexing
scheme. These now use the current dnode's dn_num_slots field to
advance to the next dnode in the block. This is to ensure we
properly skip the current dnode's bonus area and don't interpret it
as a valid dnode.
zdb
---
The zdb command was updated to display a dnode's size under the
"dnsize" column when the object is dumped.
For ZIL create log records, zdb will now display the slot count for
the object.
ztest
-----
Ztest chooses a random dnodesize for every newly created object. The
random distribution is more heavily weighted toward small dnodes to
better simulate real-world datasets.
Unused bonus buffer space is filled with non-zero values computed from
the object number, dataset id, offset, and generation number. This
helps ensure that the dnode traversal code properly skips the interior
regions of large dnodes, and that these interior regions are not
overwritten by data belonging to other dnodes. A new test visits each
object in a dataset. It verifies that the actual dnode size matches what
was stored in the ztest block tag when it was created. It also verifies
that the unused bonus buffer space is filled with the expected data
patterns.
ZFS Test Suite
--------------
Added six new large dnode-specific tests, and integrated the dnodesize
property into existing tests for zfs allow and send/recv.
Send/Receive
------------
ZFS send streams for datasets containing large dnodes cannot be received
on pools that don't support the large_dnode feature. A send stream with
large dnodes sets a DMU_BACKUP_FEATURE_LARGE_DNODE flag which will be
unrecognized by an incompatible receiving pool so that the zfs receive
will fail gracefully.
While not implemented here, it may be possible to generate a
backward-compatible send stream from a dataset containing large
dnodes. The implementation may be tricky, however, because the send
object record for a large dnode would need to be resized to a 512
byte dnode, possibly kicking in a spill block in the process. This
means we would need to construct a new SA layout and possibly
register it in the SA layout object. The SA layout is normally just
sent as an ordinary object record. But if we are constructing new
layouts while generating the send stream we'd have to build the SA
layout object dynamically and send it at the end of the stream.
For sending and receiving between pools that do support large dnodes,
the drr_object send record type is extended with a new field to store
the dnode slot count. This field was repurposed from unused padding
in the structure.
ZIL Replay
----------
The dnode slot count is stored in the uppermost 8 bits of the lr_foid
field. The bits were unused as the object id is currently capped at
48 bits.
Resizing Dnodes
---------------
It should be possible to resize a dnode when it is dirtied if the
current dnodesize dataset property differs from the dnode's size, but
this functionality is not currently implemented. Clearly a dnode can
only grow if there are sufficient contiguous unused slots in the
dnode block, but it should always be possible to shrink a dnode.
Growing dnodes may be useful to reduce fragmentation in a pool with
many spill blocks in use. Shrinking dnodes may be useful to allow
sending a dataset to a pool that doesn't support the large_dnode
feature.
Feature Reference Counting
--------------------------
The reference count for the large_dnode pool feature tracks the
number of datasets that have ever contained a dnode of size larger
than 512 bytes. The first time a large dnode is created in a dataset
the dataset is converted to an extensible dataset. This is a one-way
operation and the only way to decrement the feature count is to
destroy the dataset, even if the dataset no longer contains any large
dnodes. The complexity of reference counting on a per-dnode basis was
too high, so we chose to track it on a per-dataset basis similarly to
the large_block feature.
Signed-off-by: Ned Bass <bass6@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #3542
2016-03-17 04:25:34 +03:00
|
|
|
for (i = 0, cdnp = buf->b_data; i < epb;
|
|
|
|
i += cdnp->dn_extra_slots + 1,
|
|
|
|
cdnp += cdnp->dn_extra_slots + 1) {
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_scan_visitdnode(scn, ds, ostype,
|
2014-09-17 11:07:28 +04:00
|
|
|
cdnp, zb->zb_blkid * epb + i, tx);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2016-06-02 07:04:53 +03:00
|
|
|
arc_buf_destroy(buf, &buf);
|
2010-05-29 00:45:14 +04:00
|
|
|
} else if (BP_GET_TYPE(bp) == DMU_OT_OBJSET) {
|
2014-12-06 20:24:32 +03:00
|
|
|
arc_flags_t flags = ARC_FLAG_WAIT;
|
2010-05-29 00:45:14 +04:00
|
|
|
objset_phys_t *osp;
|
2014-09-17 11:07:28 +04:00
|
|
|
arc_buf_t *buf;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2022-05-20 20:36:14 +03:00
|
|
|
err = arc_read(NULL, spa, bp, arc_getbuf_func, &buf,
|
2017-12-21 20:13:06 +03:00
|
|
|
ZIO_PRIORITY_SCRUB, zio_flags, &flags, zb);
|
2010-05-29 00:45:14 +04:00
|
|
|
if (err) {
|
|
|
|
scn->scn_phys.scn_errors++;
|
|
|
|
return (err);
|
|
|
|
}
|
|
|
|
|
2014-09-17 11:07:28 +04:00
|
|
|
osp = buf->b_data;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
dsl_scan_visitdnode(scn, ds, osp->os_type,
|
2014-09-17 11:07:28 +04:00
|
|
|
&osp->os_meta_dnode, DMU_META_DNODE_OBJECT, tx);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2014-09-17 11:07:28 +04:00
|
|
|
if (OBJSET_BUF_HAS_USERUSED(buf)) {
|
2010-05-29 00:45:14 +04:00
|
|
|
/*
|
2018-02-14 01:54:54 +03:00
|
|
|
* We also always visit user/group/project accounting
|
2010-05-29 00:45:14 +04:00
|
|
|
* objects, and never skip them, even if we are
|
2017-11-16 04:27:01 +03:00
|
|
|
* suspending. This is necessary so that the
|
|
|
|
* space deltas from this txg get integrated.
|
2010-05-29 00:45:14 +04:00
|
|
|
*/
|
2018-02-14 01:54:54 +03:00
|
|
|
if (OBJSET_BUF_HAS_PROJECTUSED(buf))
|
|
|
|
dsl_scan_visitdnode(scn, ds, osp->os_type,
|
|
|
|
&osp->os_projectused_dnode,
|
|
|
|
DMU_PROJECTUSED_OBJECT, tx);
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_scan_visitdnode(scn, ds, osp->os_type,
|
2014-09-17 11:07:28 +04:00
|
|
|
&osp->os_groupused_dnode,
|
2010-05-29 00:45:14 +04:00
|
|
|
DMU_GROUPUSED_OBJECT, tx);
|
|
|
|
dsl_scan_visitdnode(scn, ds, osp->os_type,
|
2014-09-17 11:07:28 +04:00
|
|
|
&osp->os_userused_dnode,
|
2010-05-29 00:45:14 +04:00
|
|
|
DMU_USERUSED_OBJECT, tx);
|
|
|
|
}
|
2016-06-02 07:04:53 +03:00
|
|
|
arc_buf_destroy(buf, &buf);
|
Verify block pointers before writing them out
If a block pointer is corrupted (but the block containing it checksums
correctly, e.g. due to a bug that overwrites random memory), we can
often detect it before the block is read, with the `zfs_blkptr_verify()`
function, which is used in `arc_read()`, `zio_free()`, etc.
However, such corruption is not typically recoverable. To recover from
it we would need to detect the memory error before the block pointer is
written to disk.
This PR verifies BP's that are contained in indirect blocks and dnodes
before they are written to disk, in `dbuf_write_ready()`. This way,
we'll get a panic before the on-disk data is corrupted. This will help
us to diagnose what's causing the corruption, as well as being much
easier to recover from.
To minimize performance impact, only checks that can be done without
holding the spa_config_lock are performed.
Additionally, when corruption is detected, the raw words of the block
pointer are logged. (Note that `dprintf_bp()` is a no-op by default,
but if enabled it is not safe to use with invalid block pointers.)
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Paul Zuchowski <pzuchowski@datto.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #14817
2023-05-08 21:20:23 +03:00
|
|
|
} else if (!zfs_blkptr_verify(spa, bp,
|
|
|
|
BLK_CONFIG_NEEDED, BLK_VERIFY_LOG)) {
|
2022-05-20 20:36:14 +03:00
|
|
|
/*
|
|
|
|
* Sanity check the block pointer contents, this is handled
|
|
|
|
* by arc_read() for the cases above.
|
|
|
|
*/
|
|
|
|
scn->scn_phys.scn_errors++;
|
2024-03-26 01:01:54 +03:00
|
|
|
spa_log_error(spa, zb, BP_GET_LOGICAL_BIRTH(bp));
|
2022-05-20 20:36:14 +03:00
|
|
|
return (SET_ERROR(EINVAL));
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
2012-07-19 03:56:24 +04:00
|
|
|
inline __attribute__((always_inline)) static void
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_scan_visitdnode(dsl_scan_t *scn, dsl_dataset_t *ds,
|
2014-09-17 11:07:28 +04:00
|
|
|
dmu_objset_type_t ostype, dnode_phys_t *dnp,
|
2010-05-29 00:45:14 +04:00
|
|
|
uint64_t object, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
int j;
|
|
|
|
|
|
|
|
for (j = 0; j < dnp->dn_nblkptr; j++) {
|
2014-06-25 22:37:59 +04:00
|
|
|
zbookmark_phys_t czb;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
SET_BOOKMARK(&czb, ds ? ds->ds_object : 0, object,
|
|
|
|
dnp->dn_nlevels - 1, j);
|
|
|
|
dsl_scan_visitbp(&dnp->dn_blkptr[j],
|
2014-09-17 11:07:28 +04:00
|
|
|
&czb, dnp, ds, scn, ostype, tx);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
if (dnp->dn_flags & DNODE_FLAG_SPILL_BLKPTR) {
|
2014-06-25 22:37:59 +04:00
|
|
|
zbookmark_phys_t czb;
|
2010-05-29 00:45:14 +04:00
|
|
|
SET_BOOKMARK(&czb, ds ? ds->ds_object : 0, object,
|
|
|
|
0, DMU_SPILL_BLKID);
|
Implement large_dnode pool feature
Justification
-------------
This feature adds support for variable length dnodes. Our motivation is
to eliminate the overhead associated with using spill blocks. Spill
blocks are used to store system attribute data (i.e. file metadata) that
does not fit in the dnode's bonus buffer. By allowing a larger bonus
buffer area the use of a spill block can be avoided. Spill blocks
potentially incur an additional read I/O for every dnode in a dnode
block. As a worst case example, reading 32 dnodes from a 16k dnode block
and all of the spill blocks could issue 33 separate reads. Now suppose
those dnodes have size 1024 and therefore don't need spill blocks. Then
the worst case number of blocks read is reduced to from 33 to two--one
per dnode block. In practice spill blocks may tend to be co-located on
disk with the dnode blocks so the reduction in I/O would not be this
drastic. In a badly fragmented pool, however, the improvement could be
significant.
ZFS-on-Linux systems that make heavy use of extended attributes would
benefit from this feature. In particular, ZFS-on-Linux supports the
xattr=sa dataset property which allows file extended attribute data
to be stored in the dnode bonus buffer as an alternative to the
traditional directory-based format. Workloads such as SELinux and the
Lustre distributed filesystem often store enough xattr data to force
spill bocks when xattr=sa is in effect. Large dnodes may therefore
provide a performance benefit to such systems.
Other use cases that may benefit from this feature include files with
large ACLs and symbolic links with long target names. Furthermore,
this feature may be desirable on other platforms in case future
applications or features are developed that could make use of a
larger bonus buffer area.
Implementation
--------------
The size of a dnode may be a multiple of 512 bytes up to the size of
a dnode block (currently 16384 bytes). A dn_extra_slots field was
added to the current on-disk dnode_phys_t structure to describe the
size of the physical dnode on disk. The 8 bits for this field were
taken from the zero filled dn_pad2 field. The field represents how
many "extra" dnode_phys_t slots a dnode consumes in its dnode block.
This convention results in a value of 0 for 512 byte dnodes which
preserves on-disk format compatibility with older software.
Similarly, the in-memory dnode_t structure has a new dn_num_slots field
to represent the total number of dnode_phys_t slots consumed on disk.
Thus dn->dn_num_slots is 1 greater than the corresponding
dnp->dn_extra_slots. This difference in convention was adopted
because, unlike on-disk structures, backward compatibility is not a
concern for in-memory objects, so we used a more natural way to
represent size for a dnode_t.
The default size for newly created dnodes is determined by the value of
a new "dnodesize" dataset property. By default the property is set to
"legacy" which is compatible with older software. Setting the property
to "auto" will allow the filesystem to choose the most suitable dnode
size. Currently this just sets the default dnode size to 1k, but future
code improvements could dynamically choose a size based on observed
workload patterns. Dnodes of varying sizes can coexist within the same
dataset and even within the same dnode block. For example, to enable
automatically-sized dnodes, run
# zfs set dnodesize=auto tank/fish
The user can also specify literal values for the dnodesize property.
These are currently limited to powers of two from 1k to 16k. The
power-of-2 limitation is only for simplicity of the user interface.
Internally the implementation can handle any multiple of 512 up to 16k,
and consumers of the DMU API can specify any legal dnode value.
The size of a new dnode is determined at object allocation time and
stored as a new field in the znode in-memory structure. New DMU
interfaces are added to allow the consumer to specify the dnode size
that a newly allocated object should use. Existing interfaces are
unchanged to avoid having to update every call site and to preserve
compatibility with external consumers such as Lustre. The new
interfaces names are given below. The versions of these functions that
don't take a dnodesize parameter now just call the _dnsize() versions
with a dnodesize of 0, which means use the legacy dnode size.
New DMU interfaces:
dmu_object_alloc_dnsize()
dmu_object_claim_dnsize()
dmu_object_reclaim_dnsize()
New ZAP interfaces:
zap_create_dnsize()
zap_create_norm_dnsize()
zap_create_flags_dnsize()
zap_create_claim_norm_dnsize()
zap_create_link_dnsize()
The constant DN_MAX_BONUSLEN is renamed to DN_OLD_MAX_BONUSLEN. The
spa_maxdnodesize() function should be used to determine the maximum
bonus length for a pool.
These are a few noteworthy changes to key functions:
* The prototype for dnode_hold_impl() now takes a "slots" parameter.
When the DNODE_MUST_BE_FREE flag is set, this parameter is used to
ensure the hole at the specified object offset is large enough to
hold the dnode being created. The slots parameter is also used
to ensure a dnode does not span multiple dnode blocks. In both of
these cases, if a failure occurs, ENOSPC is returned. Keep in mind,
these failure cases are only possible when using DNODE_MUST_BE_FREE.
If the DNODE_MUST_BE_ALLOCATED flag is set, "slots" must be 0.
dnode_hold_impl() will check if the requested dnode is already
consumed as an extra dnode slot by an large dnode, in which case
it returns ENOENT.
* The function dmu_object_alloc() advances to the next dnode block
if dnode_hold_impl() returns an error for a requested object.
This is because the beginning of the next dnode block is the only
location it can safely assume to either be a hole or a valid
starting point for a dnode.
* dnode_next_offset_level() and other functions that iterate
through dnode blocks may no longer use a simple array indexing
scheme. These now use the current dnode's dn_num_slots field to
advance to the next dnode in the block. This is to ensure we
properly skip the current dnode's bonus area and don't interpret it
as a valid dnode.
zdb
---
The zdb command was updated to display a dnode's size under the
"dnsize" column when the object is dumped.
For ZIL create log records, zdb will now display the slot count for
the object.
ztest
-----
Ztest chooses a random dnodesize for every newly created object. The
random distribution is more heavily weighted toward small dnodes to
better simulate real-world datasets.
Unused bonus buffer space is filled with non-zero values computed from
the object number, dataset id, offset, and generation number. This
helps ensure that the dnode traversal code properly skips the interior
regions of large dnodes, and that these interior regions are not
overwritten by data belonging to other dnodes. A new test visits each
object in a dataset. It verifies that the actual dnode size matches what
was stored in the ztest block tag when it was created. It also verifies
that the unused bonus buffer space is filled with the expected data
patterns.
ZFS Test Suite
--------------
Added six new large dnode-specific tests, and integrated the dnodesize
property into existing tests for zfs allow and send/recv.
Send/Receive
------------
ZFS send streams for datasets containing large dnodes cannot be received
on pools that don't support the large_dnode feature. A send stream with
large dnodes sets a DMU_BACKUP_FEATURE_LARGE_DNODE flag which will be
unrecognized by an incompatible receiving pool so that the zfs receive
will fail gracefully.
While not implemented here, it may be possible to generate a
backward-compatible send stream from a dataset containing large
dnodes. The implementation may be tricky, however, because the send
object record for a large dnode would need to be resized to a 512
byte dnode, possibly kicking in a spill block in the process. This
means we would need to construct a new SA layout and possibly
register it in the SA layout object. The SA layout is normally just
sent as an ordinary object record. But if we are constructing new
layouts while generating the send stream we'd have to build the SA
layout object dynamically and send it at the end of the stream.
For sending and receiving between pools that do support large dnodes,
the drr_object send record type is extended with a new field to store
the dnode slot count. This field was repurposed from unused padding
in the structure.
ZIL Replay
----------
The dnode slot count is stored in the uppermost 8 bits of the lr_foid
field. The bits were unused as the object id is currently capped at
48 bits.
Resizing Dnodes
---------------
It should be possible to resize a dnode when it is dirtied if the
current dnodesize dataset property differs from the dnode's size, but
this functionality is not currently implemented. Clearly a dnode can
only grow if there are sufficient contiguous unused slots in the
dnode block, but it should always be possible to shrink a dnode.
Growing dnodes may be useful to reduce fragmentation in a pool with
many spill blocks in use. Shrinking dnodes may be useful to allow
sending a dataset to a pool that doesn't support the large_dnode
feature.
Feature Reference Counting
--------------------------
The reference count for the large_dnode pool feature tracks the
number of datasets that have ever contained a dnode of size larger
than 512 bytes. The first time a large dnode is created in a dataset
the dataset is converted to an extensible dataset. This is a one-way
operation and the only way to decrement the feature count is to
destroy the dataset, even if the dataset no longer contains any large
dnodes. The complexity of reference counting on a per-dnode basis was
too high, so we chose to track it on a per-dataset basis similarly to
the large_block feature.
Signed-off-by: Ned Bass <bass6@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #3542
2016-03-17 04:25:34 +03:00
|
|
|
dsl_scan_visitbp(DN_SPILL_BLKPTR(dnp),
|
2014-09-17 11:07:28 +04:00
|
|
|
&czb, dnp, ds, scn, ostype, tx);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The arguments are in this order because mdb can only print the
|
|
|
|
* first 5; we want them to be useful.
|
|
|
|
*/
|
|
|
|
static void
|
2023-11-28 20:20:48 +03:00
|
|
|
dsl_scan_visitbp(const blkptr_t *bp, const zbookmark_phys_t *zb,
|
2014-09-17 11:07:28 +04:00
|
|
|
dnode_phys_t *dnp, dsl_dataset_t *ds, dsl_scan_t *scn,
|
|
|
|
dmu_objset_type_t ostype, dmu_tx_t *tx)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
|
|
|
dsl_pool_t *dp = scn->scn_dp;
|
|
|
|
|
2017-07-07 08:16:13 +03:00
|
|
|
if (dsl_scan_check_suspend(scn, zb))
|
2017-11-16 04:27:01 +03:00
|
|
|
return;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
if (dsl_scan_check_resume(scn, dnp, zb))
|
2017-11-16 04:27:01 +03:00
|
|
|
return;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
scn->scn_visited_this_txg++;
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
if (BP_IS_HOLE(bp)) {
|
|
|
|
scn->scn_holes_this_txg++;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
Implement Redacted Send/Receive
Redacted send/receive allows users to send subsets of their data to
a target system. One possible use case for this feature is to not
transmit sensitive information to a data warehousing, test/dev, or
analytics environment. Another is to save space by not replicating
unimportant data within a given dataset, for example in backup tools
like zrepl.
Redacted send/receive is a three-stage process. First, a clone (or
clones) is made of the snapshot to be sent to the target. In this
clone (or clones), all unnecessary or unwanted data is removed or
modified. This clone is then snapshotted to create the "redaction
snapshot" (or snapshots). Second, the new zfs redact command is used
to create a redaction bookmark. The redaction bookmark stores the
list of blocks in a snapshot that were modified by the redaction
snapshot(s). Finally, the redaction bookmark is passed as a parameter
to zfs send. When sending to the snapshot that was redacted, the
redaction bookmark is used to filter out blocks that contain sensitive
or unwanted information, and those blocks are not included in the send
stream. When sending from the redaction bookmark, the blocks it
contains are considered as candidate blocks in addition to those
blocks in the destination snapshot that were modified since the
creation_txg of the redaction bookmark. This step is necessary to
allow the target to rehydrate data in the case where some blocks are
accidentally or unnecessarily modified in the redaction snapshot.
The changes to bookmarks to enable fast space estimation involve
adding deadlists to bookmarks. There is also logic to manage the
life cycles of these deadlists.
The new size estimation process operates in cases where previously
an accurate estimate could not be provided. In those cases, a send
is performed where no data blocks are read, reducing the runtime
significantly and providing a byte-accurate size estimate.
Reviewed-by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed-by: Matt Ahrens <mahrens@delphix.com>
Reviewed-by: Prashanth Sreenivasa <pks@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: Chris Williamson <chris.williamson@delphix.com>
Reviewed-by: Pavel Zhakarov <pavel.zakharov@delphix.com>
Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #7958
2019-06-19 19:48:13 +03:00
|
|
|
if (BP_IS_REDACTED(bp)) {
|
|
|
|
ASSERT(dsl_dataset_feature_is_active(ds,
|
|
|
|
SPA_FEATURE_REDACTED_DATASETS));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-02-14 03:37:46 +03:00
|
|
|
/*
|
|
|
|
* Check if this block contradicts any filesystem flags.
|
|
|
|
*/
|
|
|
|
spa_feature_t f = SPA_FEATURE_LARGE_BLOCKS;
|
|
|
|
if (BP_GET_LSIZE(bp) > SPA_OLD_MAXBLOCKSIZE)
|
|
|
|
ASSERT(dsl_dataset_feature_is_active(ds, f));
|
|
|
|
|
|
|
|
f = zio_checksum_to_feature(BP_GET_CHECKSUM(bp));
|
|
|
|
if (f != SPA_FEATURE_NONE)
|
|
|
|
ASSERT(dsl_dataset_feature_is_active(ds, f));
|
|
|
|
|
|
|
|
f = zio_compress_to_feature(BP_GET_COMPRESS(bp));
|
|
|
|
if (f != SPA_FEATURE_NONE)
|
|
|
|
ASSERT(dsl_dataset_feature_is_active(ds, f));
|
|
|
|
|
2024-03-26 01:01:54 +03:00
|
|
|
if (BP_GET_LOGICAL_BIRTH(bp) <= scn->scn_phys.scn_cur_min_txg) {
|
2023-02-14 03:37:46 +03:00
|
|
|
scn->scn_lt_min_this_txg++;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-11-28 20:20:48 +03:00
|
|
|
if (dsl_scan_recurse(scn, ds, ostype, dnp, bp, zb, tx) != 0)
|
|
|
|
return;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
/*
|
2017-01-03 20:31:18 +03:00
|
|
|
* If dsl_scan_ddt() has already visited this block, it will have
|
2010-05-29 00:45:14 +04:00
|
|
|
* already done any translations or scrubbing, so don't call the
|
|
|
|
* callback again.
|
|
|
|
*/
|
|
|
|
if (ddt_class_contains(dp->dp_spa,
|
|
|
|
scn->scn_phys.scn_ddt_class_max, bp)) {
|
2017-11-16 04:27:01 +03:00
|
|
|
scn->scn_ddt_contained_this_txg++;
|
2023-11-28 20:20:48 +03:00
|
|
|
return;
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If this block is from the future (after cur_max_txg), then we
|
|
|
|
* are doing this on behalf of a deleted snapshot, and we will
|
|
|
|
* revisit the future block on the next pass of this dataset.
|
|
|
|
* Don't scan it now unless we need to because something
|
|
|
|
* under it was modified.
|
|
|
|
*/
|
2024-03-26 01:01:54 +03:00
|
|
|
if (BP_GET_BIRTH(bp) > scn->scn_phys.scn_cur_max_txg) {
|
2017-11-16 04:27:01 +03:00
|
|
|
scn->scn_gt_max_this_txg++;
|
2023-11-28 20:20:48 +03:00
|
|
|
return;
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
scan_funcs[scn->scn_phys.scn_func](dp, bp, zb);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_scan_visit_rootbp(dsl_scan_t *scn, dsl_dataset_t *ds, blkptr_t *bp,
|
|
|
|
dmu_tx_t *tx)
|
|
|
|
{
|
2014-06-25 22:37:59 +04:00
|
|
|
zbookmark_phys_t zb;
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_prefetch_ctx_t *spc;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
SET_BOOKMARK(&zb, ds ? ds->ds_object : DMU_META_OBJSET,
|
|
|
|
ZB_ROOT_OBJECT, ZB_ROOT_LEVEL, ZB_ROOT_BLKID);
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
if (ZB_IS_ZERO(&scn->scn_phys.scn_bookmark)) {
|
|
|
|
SET_BOOKMARK(&scn->scn_prefetch_bookmark,
|
|
|
|
zb.zb_objset, 0, 0, 0);
|
|
|
|
} else {
|
|
|
|
scn->scn_prefetch_bookmark = scn->scn_phys.scn_bookmark;
|
|
|
|
}
|
|
|
|
|
|
|
|
scn->scn_objsets_visited_this_txg++;
|
|
|
|
|
|
|
|
spc = scan_prefetch_ctx_create(scn, NULL, FTAG);
|
|
|
|
dsl_scan_prefetch(spc, bp, &zb);
|
|
|
|
scan_prefetch_ctx_rele(spc, FTAG);
|
|
|
|
|
|
|
|
dsl_scan_visitbp(bp, &zb, NULL, ds, scn, DMU_OST_NONE, tx);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
dprintf_ds(ds, "finished scan%s", "");
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static void
|
|
|
|
ds_destroyed_scn_phys(dsl_dataset_t *ds, dsl_scan_phys_t *scn_phys)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
if (scn_phys->scn_bookmark.zb_objset == ds->ds_object) {
|
2015-04-02 06:44:32 +03:00
|
|
|
if (ds->ds_is_snapshot) {
|
2016-01-30 23:40:28 +03:00
|
|
|
/*
|
|
|
|
* Note:
|
|
|
|
* - scn_cur_{min,max}_txg stays the same.
|
|
|
|
* - Setting the flag is not really necessary if
|
|
|
|
* scn_cur_max_txg == scn_max_txg, because there
|
|
|
|
* is nothing after this snapshot that we care
|
|
|
|
* about. However, we set it anyway and then
|
|
|
|
* ignore it when we retraverse it in
|
|
|
|
* dsl_scan_visitds().
|
|
|
|
*/
|
2017-11-16 04:27:01 +03:00
|
|
|
scn_phys->scn_bookmark.zb_objset =
|
2015-04-01 18:14:34 +03:00
|
|
|
dsl_dataset_phys(ds)->ds_next_snap_obj;
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("destroying ds %llu on %s; currently "
|
|
|
|
"traversing; reset zb_objset to %llu",
|
2010-05-29 00:45:14 +04:00
|
|
|
(u_longlong_t)ds->ds_object,
|
2021-10-27 02:24:14 +03:00
|
|
|
ds->ds_dir->dd_pool->dp_spa->spa_name,
|
2015-04-01 18:14:34 +03:00
|
|
|
(u_longlong_t)dsl_dataset_phys(ds)->
|
|
|
|
ds_next_snap_obj);
|
2017-11-16 04:27:01 +03:00
|
|
|
scn_phys->scn_flags |= DSF_VISIT_DS_AGAIN;
|
2010-05-29 00:45:14 +04:00
|
|
|
} else {
|
2017-11-16 04:27:01 +03:00
|
|
|
SET_BOOKMARK(&scn_phys->scn_bookmark,
|
2010-05-29 00:45:14 +04:00
|
|
|
ZB_DESTROYED_OBJSET, 0, 0, 0);
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("destroying ds %llu on %s; currently "
|
|
|
|
"traversing; reset bookmark to -1,0,0,0",
|
|
|
|
(u_longlong_t)ds->ds_object,
|
|
|
|
ds->ds_dir->dd_pool->dp_spa->spa_name);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Invoked when a dataset is destroyed. We need to make sure that:
|
|
|
|
*
|
|
|
|
* 1) If it is the dataset that was currently being scanned, we write
|
|
|
|
* a new dsl_scan_phys_t and marking the objset reference in it
|
|
|
|
* as destroyed.
|
|
|
|
* 2) Remove it from the work queue, if it was present.
|
|
|
|
*
|
|
|
|
* If the dataset was actually a snapshot, instead of marking the dataset
|
|
|
|
* as destroyed, we instead substitute the next snapshot in line.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
dsl_scan_ds_destroyed(dsl_dataset_t *ds, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
dsl_pool_t *dp = ds->ds_dir->dd_pool;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
uint64_t mintxg;
|
|
|
|
|
|
|
|
if (!dsl_scan_is_running(scn))
|
|
|
|
return;
|
|
|
|
|
|
|
|
ds_destroyed_scn_phys(ds, &scn->scn_phys);
|
|
|
|
ds_destroyed_scn_phys(ds, &scn->scn_phys_cached);
|
|
|
|
|
|
|
|
if (scan_ds_queue_contains(scn, ds->ds_object, &mintxg)) {
|
|
|
|
scan_ds_queue_remove(scn, ds->ds_object);
|
|
|
|
if (ds->ds_is_snapshot)
|
|
|
|
scan_ds_queue_insert(scn,
|
|
|
|
dsl_dataset_phys(ds)->ds_next_snap_obj, mintxg);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (zap_lookup_int_key(dp->dp_meta_objset, scn->scn_phys.scn_queue_obj,
|
|
|
|
ds->ds_object, &mintxg) == 0) {
|
2015-04-01 18:14:34 +03:00
|
|
|
ASSERT3U(dsl_dataset_phys(ds)->ds_num_children, <=, 1);
|
2010-05-29 00:45:14 +04:00
|
|
|
VERIFY3U(0, ==, zap_remove_int(dp->dp_meta_objset,
|
|
|
|
scn->scn_phys.scn_queue_obj, ds->ds_object, tx));
|
2015-04-02 06:44:32 +03:00
|
|
|
if (ds->ds_is_snapshot) {
|
2010-05-29 00:45:14 +04:00
|
|
|
/*
|
|
|
|
* We keep the same mintxg; it could be >
|
|
|
|
* ds_creation_txg if the previous snapshot was
|
|
|
|
* deleted too.
|
|
|
|
*/
|
|
|
|
VERIFY(zap_add_int_key(dp->dp_meta_objset,
|
|
|
|
scn->scn_phys.scn_queue_obj,
|
2015-04-01 18:14:34 +03:00
|
|
|
dsl_dataset_phys(ds)->ds_next_snap_obj,
|
|
|
|
mintxg, tx) == 0);
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("destroying ds %llu on %s; in queue; "
|
2010-05-29 00:45:14 +04:00
|
|
|
"replacing with %llu",
|
|
|
|
(u_longlong_t)ds->ds_object,
|
2021-10-27 02:24:14 +03:00
|
|
|
dp->dp_spa->spa_name,
|
2015-04-01 18:14:34 +03:00
|
|
|
(u_longlong_t)dsl_dataset_phys(ds)->
|
|
|
|
ds_next_snap_obj);
|
2010-05-29 00:45:14 +04:00
|
|
|
} else {
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("destroying ds %llu on %s; in queue; "
|
|
|
|
"removing",
|
|
|
|
(u_longlong_t)ds->ds_object,
|
|
|
|
dp->dp_spa->spa_name);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* dsl_scan_sync() should be called after this, and should sync
|
|
|
|
* out our changed state, but just to be safe, do it here.
|
|
|
|
*/
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_sync_state(scn, tx, SYNC_CACHED);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
ds_snapshotted_bookmark(dsl_dataset_t *ds, zbookmark_phys_t *scn_bookmark)
|
|
|
|
{
|
|
|
|
if (scn_bookmark->zb_objset == ds->ds_object) {
|
|
|
|
scn_bookmark->zb_objset =
|
|
|
|
dsl_dataset_phys(ds)->ds_prev_snap_obj;
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("snapshotting ds %llu on %s; currently traversing; "
|
2017-11-16 04:27:01 +03:00
|
|
|
"reset zb_objset to %llu",
|
|
|
|
(u_longlong_t)ds->ds_object,
|
2021-10-27 02:24:14 +03:00
|
|
|
ds->ds_dir->dd_pool->dp_spa->spa_name,
|
2017-11-16 04:27:01 +03:00
|
|
|
(u_longlong_t)dsl_dataset_phys(ds)->ds_prev_snap_obj);
|
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* Called when a dataset is snapshotted. If we were currently traversing
|
|
|
|
* this snapshot, we reset our bookmark to point at the newly created
|
|
|
|
* snapshot. We also modify our work queue to remove the old snapshot and
|
|
|
|
* replace with the new one.
|
|
|
|
*/
|
2010-05-29 00:45:14 +04:00
|
|
|
void
|
|
|
|
dsl_scan_ds_snapshotted(dsl_dataset_t *ds, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
dsl_pool_t *dp = ds->ds_dir->dd_pool;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
uint64_t mintxg;
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
if (!dsl_scan_is_running(scn))
|
2010-05-29 00:45:14 +04:00
|
|
|
return;
|
|
|
|
|
2015-04-01 18:14:34 +03:00
|
|
|
ASSERT(dsl_dataset_phys(ds)->ds_prev_snap_obj != 0);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
ds_snapshotted_bookmark(ds, &scn->scn_phys.scn_bookmark);
|
|
|
|
ds_snapshotted_bookmark(ds, &scn->scn_phys_cached.scn_bookmark);
|
|
|
|
|
|
|
|
if (scan_ds_queue_contains(scn, ds->ds_object, &mintxg)) {
|
|
|
|
scan_ds_queue_remove(scn, ds->ds_object);
|
|
|
|
scan_ds_queue_insert(scn,
|
|
|
|
dsl_dataset_phys(ds)->ds_prev_snap_obj, mintxg);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (zap_lookup_int_key(dp->dp_meta_objset, scn->scn_phys.scn_queue_obj,
|
|
|
|
ds->ds_object, &mintxg) == 0) {
|
2010-05-29 00:45:14 +04:00
|
|
|
VERIFY3U(0, ==, zap_remove_int(dp->dp_meta_objset,
|
|
|
|
scn->scn_phys.scn_queue_obj, ds->ds_object, tx));
|
|
|
|
VERIFY(zap_add_int_key(dp->dp_meta_objset,
|
|
|
|
scn->scn_phys.scn_queue_obj,
|
2015-04-01 18:14:34 +03:00
|
|
|
dsl_dataset_phys(ds)->ds_prev_snap_obj, mintxg, tx) == 0);
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("snapshotting ds %llu on %s; in queue; "
|
2010-05-29 00:45:14 +04:00
|
|
|
"replacing with %llu",
|
|
|
|
(u_longlong_t)ds->ds_object,
|
2021-10-27 02:24:14 +03:00
|
|
|
dp->dp_spa->spa_name,
|
2015-04-01 18:14:34 +03:00
|
|
|
(u_longlong_t)dsl_dataset_phys(ds)->ds_prev_snap_obj);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
dsl_scan_sync_state(scn, tx, SYNC_CACHED);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static void
|
|
|
|
ds_clone_swapped_bookmark(dsl_dataset_t *ds1, dsl_dataset_t *ds2,
|
|
|
|
zbookmark_phys_t *scn_bookmark)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
if (scn_bookmark->zb_objset == ds1->ds_object) {
|
|
|
|
scn_bookmark->zb_objset = ds2->ds_object;
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("clone_swap ds %llu on %s; currently traversing; "
|
2010-05-29 00:45:14 +04:00
|
|
|
"reset zb_objset to %llu",
|
|
|
|
(u_longlong_t)ds1->ds_object,
|
2021-10-27 02:24:14 +03:00
|
|
|
ds1->ds_dir->dd_pool->dp_spa->spa_name,
|
2010-05-29 00:45:14 +04:00
|
|
|
(u_longlong_t)ds2->ds_object);
|
2017-11-16 04:27:01 +03:00
|
|
|
} else if (scn_bookmark->zb_objset == ds2->ds_object) {
|
|
|
|
scn_bookmark->zb_objset = ds1->ds_object;
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("clone_swap ds %llu on %s; currently traversing; "
|
2010-05-29 00:45:14 +04:00
|
|
|
"reset zb_objset to %llu",
|
|
|
|
(u_longlong_t)ds2->ds_object,
|
2021-10-27 02:24:14 +03:00
|
|
|
ds2->ds_dir->dd_pool->dp_spa->spa_name,
|
2010-05-29 00:45:14 +04:00
|
|
|
(u_longlong_t)ds1->ds_object);
|
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2019-09-18 19:04:45 +03:00
|
|
|
* Called when an origin dataset and its clone are swapped. If we were
|
2017-11-16 04:27:01 +03:00
|
|
|
* currently traversing the dataset, we need to switch to traversing the
|
2019-09-18 19:04:45 +03:00
|
|
|
* newly promoted clone.
|
2017-11-16 04:27:01 +03:00
|
|
|
*/
|
|
|
|
void
|
|
|
|
dsl_scan_ds_clone_swapped(dsl_dataset_t *ds1, dsl_dataset_t *ds2, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
dsl_pool_t *dp = ds1->ds_dir->dd_pool;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
2019-09-18 19:04:45 +03:00
|
|
|
uint64_t mintxg1, mintxg2;
|
|
|
|
boolean_t ds1_queued, ds2_queued;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
if (!dsl_scan_is_running(scn))
|
|
|
|
return;
|
|
|
|
|
|
|
|
ds_clone_swapped_bookmark(ds1, ds2, &scn->scn_phys.scn_bookmark);
|
|
|
|
ds_clone_swapped_bookmark(ds1, ds2, &scn->scn_phys_cached.scn_bookmark);
|
|
|
|
|
2019-09-18 19:04:45 +03:00
|
|
|
/*
|
|
|
|
* Handle the in-memory scan queue.
|
|
|
|
*/
|
|
|
|
ds1_queued = scan_ds_queue_contains(scn, ds1->ds_object, &mintxg1);
|
|
|
|
ds2_queued = scan_ds_queue_contains(scn, ds2->ds_object, &mintxg2);
|
|
|
|
|
|
|
|
/* Sanity checking. */
|
|
|
|
if (ds1_queued) {
|
|
|
|
ASSERT3U(mintxg1, ==, dsl_dataset_phys(ds1)->ds_prev_snap_txg);
|
|
|
|
ASSERT3U(mintxg1, ==, dsl_dataset_phys(ds2)->ds_prev_snap_txg);
|
|
|
|
}
|
|
|
|
if (ds2_queued) {
|
|
|
|
ASSERT3U(mintxg2, ==, dsl_dataset_phys(ds1)->ds_prev_snap_txg);
|
|
|
|
ASSERT3U(mintxg2, ==, dsl_dataset_phys(ds2)->ds_prev_snap_txg);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
2019-09-18 19:04:45 +03:00
|
|
|
|
|
|
|
if (ds1_queued && ds2_queued) {
|
|
|
|
/*
|
|
|
|
* If both are queued, we don't need to do anything.
|
|
|
|
* The swapping code below would not handle this case correctly,
|
|
|
|
* since we can't insert ds2 if it is already there. That's
|
|
|
|
* because scan_ds_queue_insert() prohibits a duplicate insert
|
|
|
|
* and panics.
|
|
|
|
*/
|
|
|
|
} else if (ds1_queued) {
|
|
|
|
scan_ds_queue_remove(scn, ds1->ds_object);
|
|
|
|
scan_ds_queue_insert(scn, ds2->ds_object, mintxg1);
|
|
|
|
} else if (ds2_queued) {
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_ds_queue_remove(scn, ds2->ds_object);
|
2019-09-18 19:04:45 +03:00
|
|
|
scan_ds_queue_insert(scn, ds1->ds_object, mintxg2);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2019-09-18 19:04:45 +03:00
|
|
|
/*
|
|
|
|
* Handle the on-disk scan queue.
|
|
|
|
* The on-disk state is an out-of-date version of the in-memory state,
|
|
|
|
* so the in-memory and on-disk values for ds1_queued and ds2_queued may
|
|
|
|
* be different. Therefore we need to apply the swap logic to the
|
|
|
|
* on-disk state independently of the in-memory state.
|
|
|
|
*/
|
|
|
|
ds1_queued = zap_lookup_int_key(dp->dp_meta_objset,
|
|
|
|
scn->scn_phys.scn_queue_obj, ds1->ds_object, &mintxg1) == 0;
|
|
|
|
ds2_queued = zap_lookup_int_key(dp->dp_meta_objset,
|
|
|
|
scn->scn_phys.scn_queue_obj, ds2->ds_object, &mintxg2) == 0;
|
|
|
|
|
|
|
|
/* Sanity checking. */
|
|
|
|
if (ds1_queued) {
|
|
|
|
ASSERT3U(mintxg1, ==, dsl_dataset_phys(ds1)->ds_prev_snap_txg);
|
|
|
|
ASSERT3U(mintxg1, ==, dsl_dataset_phys(ds2)->ds_prev_snap_txg);
|
|
|
|
}
|
|
|
|
if (ds2_queued) {
|
|
|
|
ASSERT3U(mintxg2, ==, dsl_dataset_phys(ds1)->ds_prev_snap_txg);
|
|
|
|
ASSERT3U(mintxg2, ==, dsl_dataset_phys(ds2)->ds_prev_snap_txg);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ds1_queued && ds2_queued) {
|
|
|
|
/*
|
|
|
|
* If both are queued, we don't need to do anything.
|
|
|
|
* Alternatively, we could check for EEXIST from
|
|
|
|
* zap_add_int_key() and back out to the original state, but
|
|
|
|
* that would be more work than checking for this case upfront.
|
|
|
|
*/
|
|
|
|
} else if (ds1_queued) {
|
|
|
|
VERIFY3S(0, ==, zap_remove_int(dp->dp_meta_objset,
|
2010-05-29 00:45:14 +04:00
|
|
|
scn->scn_phys.scn_queue_obj, ds1->ds_object, tx));
|
2019-09-18 19:04:45 +03:00
|
|
|
VERIFY3S(0, ==, zap_add_int_key(dp->dp_meta_objset,
|
|
|
|
scn->scn_phys.scn_queue_obj, ds2->ds_object, mintxg1, tx));
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("clone_swap ds %llu on %s; in queue; "
|
2010-05-29 00:45:14 +04:00
|
|
|
"replacing with %llu",
|
|
|
|
(u_longlong_t)ds1->ds_object,
|
2021-10-27 02:24:14 +03:00
|
|
|
dp->dp_spa->spa_name,
|
2010-05-29 00:45:14 +04:00
|
|
|
(u_longlong_t)ds2->ds_object);
|
2019-09-18 19:04:45 +03:00
|
|
|
} else if (ds2_queued) {
|
|
|
|
VERIFY3S(0, ==, zap_remove_int(dp->dp_meta_objset,
|
2010-05-29 00:45:14 +04:00
|
|
|
scn->scn_phys.scn_queue_obj, ds2->ds_object, tx));
|
2019-09-18 19:04:45 +03:00
|
|
|
VERIFY3S(0, ==, zap_add_int_key(dp->dp_meta_objset,
|
|
|
|
scn->scn_phys.scn_queue_obj, ds1->ds_object, mintxg2, tx));
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("clone_swap ds %llu on %s; in queue; "
|
2010-05-29 00:45:14 +04:00
|
|
|
"replacing with %llu",
|
|
|
|
(u_longlong_t)ds2->ds_object,
|
2021-10-27 02:24:14 +03:00
|
|
|
dp->dp_spa->spa_name,
|
2010-05-29 00:45:14 +04:00
|
|
|
(u_longlong_t)ds1->ds_object);
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_sync_state(scn, tx, SYNC_CACHED);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2013-09-04 16:00:57 +04:00
|
|
|
enqueue_clones_cb(dsl_pool_t *dp, dsl_dataset_t *hds, void *arg)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
uint64_t originobj = *(uint64_t *)arg;
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_dataset_t *ds;
|
|
|
|
int err;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
if (dsl_dir_phys(hds->ds_dir)->dd_origin_obj != originobj)
|
2013-09-04 16:00:57 +04:00
|
|
|
return (0);
|
|
|
|
|
|
|
|
err = dsl_dataset_hold_obj(dp, hds->ds_object, FTAG, &ds);
|
2010-05-29 00:45:14 +04:00
|
|
|
if (err)
|
|
|
|
return (err);
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
while (dsl_dataset_phys(ds)->ds_prev_snap_obj != originobj) {
|
2013-09-04 16:00:57 +04:00
|
|
|
dsl_dataset_t *prev;
|
|
|
|
err = dsl_dataset_hold_obj(dp,
|
2015-04-01 18:14:34 +03:00
|
|
|
dsl_dataset_phys(ds)->ds_prev_snap_obj, FTAG, &prev);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2013-09-04 16:00:57 +04:00
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
if (err)
|
|
|
|
return (err);
|
|
|
|
ds = prev;
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2024-05-09 17:32:59 +03:00
|
|
|
mutex_enter(&scn->scn_queue_lock);
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_ds_queue_insert(scn, ds->ds_object,
|
|
|
|
dsl_dataset_phys(ds)->ds_prev_snap_txg);
|
2024-05-09 17:32:59 +03:00
|
|
|
mutex_exit(&scn->scn_queue_lock);
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_scan_visitds(dsl_scan_t *scn, uint64_t dsobj, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
dsl_pool_t *dp = scn->scn_dp;
|
|
|
|
dsl_dataset_t *ds;
|
|
|
|
|
|
|
|
VERIFY3U(0, ==, dsl_dataset_hold_obj(dp, dsobj, FTAG, &ds));
|
|
|
|
|
2016-01-30 23:40:28 +03:00
|
|
|
if (scn->scn_phys.scn_cur_min_txg >=
|
|
|
|
scn->scn_phys.scn_max_txg) {
|
|
|
|
/*
|
|
|
|
* This can happen if this snapshot was created after the
|
|
|
|
* scan started, and we already completed a previous snapshot
|
|
|
|
* that was created after the scan started. This snapshot
|
|
|
|
* only references blocks with:
|
|
|
|
*
|
|
|
|
* birth < our ds_creation_txg
|
|
|
|
* cur_min_txg is no less than ds_creation_txg.
|
|
|
|
* We have already visited these blocks.
|
|
|
|
* or
|
|
|
|
* birth > scn_max_txg
|
|
|
|
* The scan requested not to visit these blocks.
|
|
|
|
*
|
|
|
|
* Subsequent snapshots (and clones) can reference our
|
|
|
|
* blocks, or blocks with even higher birth times.
|
|
|
|
* Therefore we do not need to visit them either,
|
|
|
|
* so we do not add them to the work queue.
|
|
|
|
*
|
|
|
|
* Note that checking for cur_min_txg >= cur_max_txg
|
|
|
|
* is not sufficient, because in that case we may need to
|
|
|
|
* visit subsequent snapshots. This happens when min_txg > 0,
|
|
|
|
* which raises cur_min_txg. In this case we will visit
|
|
|
|
* this dataset but skip all of its blocks, because the
|
|
|
|
* rootbp's birth time is < cur_min_txg. Then we will
|
|
|
|
* add the next snapshots/clones to the work queue.
|
|
|
|
*/
|
2016-06-16 00:28:36 +03:00
|
|
|
char *dsname = kmem_alloc(ZFS_MAX_DATASET_NAME_LEN, KM_SLEEP);
|
2016-01-30 23:40:28 +03:00
|
|
|
dsl_dataset_name(ds, dsname);
|
|
|
|
zfs_dbgmsg("scanning dataset %llu (%s) is unnecessary because "
|
|
|
|
"cur_min_txg (%llu) >= max_txg (%llu)",
|
2017-11-16 04:27:01 +03:00
|
|
|
(longlong_t)dsobj, dsname,
|
|
|
|
(longlong_t)scn->scn_phys.scn_cur_min_txg,
|
|
|
|
(longlong_t)scn->scn_phys.scn_max_txg);
|
2016-01-30 23:40:28 +03:00
|
|
|
kmem_free(dsname, MAXNAMELEN);
|
|
|
|
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2010-08-27 01:24:34 +04:00
|
|
|
/*
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
* Only the ZIL in the head (non-snapshot) is valid. Even though
|
2010-08-27 01:24:34 +04:00
|
|
|
* snapshots can have ZIL block pointers (which may be the same
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
* BP as in the head), they must be ignored. In addition, $ORIGIN
|
|
|
|
* doesn't have a objset (i.e. its ds_bp is a hole) so we don't
|
|
|
|
* need to look for a ZIL in it either. So we traverse the ZIL here,
|
|
|
|
* rather than in scan_recurse(), because the regular snapshot
|
|
|
|
* block-sharing rules don't apply to it.
|
2010-08-27 01:24:34 +04:00
|
|
|
*/
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
if (!dsl_dataset_is_snapshot(ds) &&
|
2018-02-05 21:06:18 +03:00
|
|
|
(dp->dp_origin_snap == NULL ||
|
|
|
|
ds->ds_dir != dp->dp_origin_snap->ds_dir)) {
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
objset_t *os;
|
|
|
|
if (dmu_objset_from_ds(ds, &os) != 0) {
|
|
|
|
goto out;
|
|
|
|
}
|
2010-08-27 01:24:34 +04:00
|
|
|
dsl_scan_zil(dp, &os->os_zil_header);
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
}
|
2010-08-27 01:24:34 +04:00
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
/*
|
|
|
|
* Iterate over the bps in this ds.
|
|
|
|
*/
|
|
|
|
dmu_buf_will_dirty(ds->ds_dbuf, tx);
|
2017-01-27 22:43:42 +03:00
|
|
|
rrw_enter(&ds->ds_bp_rwlock, RW_READER, FTAG);
|
2015-04-01 18:14:34 +03:00
|
|
|
dsl_scan_visit_rootbp(scn, ds, &dsl_dataset_phys(ds)->ds_bp, tx);
|
2017-01-27 22:43:42 +03:00
|
|
|
rrw_exit(&ds->ds_bp_rwlock, FTAG);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-04 23:25:13 +03:00
|
|
|
char *dsname = kmem_alloc(ZFS_MAX_DATASET_NAME_LEN, KM_SLEEP);
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_dataset_name(ds, dsname);
|
|
|
|
zfs_dbgmsg("scanned dataset %llu (%s) with min=%llu max=%llu; "
|
2017-07-07 08:16:13 +03:00
|
|
|
"suspending=%u",
|
2010-05-29 00:45:14 +04:00
|
|
|
(longlong_t)dsobj, dsname,
|
|
|
|
(longlong_t)scn->scn_phys.scn_cur_min_txg,
|
|
|
|
(longlong_t)scn->scn_phys.scn_cur_max_txg,
|
2017-07-07 08:16:13 +03:00
|
|
|
(int)scn->scn_suspending);
|
2016-06-16 00:28:36 +03:00
|
|
|
kmem_free(dsname, ZFS_MAX_DATASET_NAME_LEN);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-07-07 08:16:13 +03:00
|
|
|
if (scn->scn_suspending)
|
2010-05-29 00:45:14 +04:00
|
|
|
goto out;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We've finished this pass over this dataset.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we did not completely visit this dataset, do another pass.
|
|
|
|
*/
|
|
|
|
if (scn->scn_phys.scn_flags & DSF_VISIT_DS_AGAIN) {
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("incomplete pass on %s; visiting again",
|
|
|
|
dp->dp_spa->spa_name);
|
2010-05-29 00:45:14 +04:00
|
|
|
scn->scn_phys.scn_flags &= ~DSF_VISIT_DS_AGAIN;
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_ds_queue_insert(scn, ds->ds_object,
|
|
|
|
scn->scn_phys.scn_cur_max_txg);
|
2010-05-29 00:45:14 +04:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2018-03-29 04:30:44 +03:00
|
|
|
* Add descendant datasets to work queue.
|
2010-05-29 00:45:14 +04:00
|
|
|
*/
|
2015-04-01 18:14:34 +03:00
|
|
|
if (dsl_dataset_phys(ds)->ds_next_snap_obj != 0) {
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_ds_queue_insert(scn,
|
2015-04-01 18:14:34 +03:00
|
|
|
dsl_dataset_phys(ds)->ds_next_snap_obj,
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_dataset_phys(ds)->ds_creation_txg);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2015-04-01 18:14:34 +03:00
|
|
|
if (dsl_dataset_phys(ds)->ds_num_children > 1) {
|
2010-05-29 00:45:14 +04:00
|
|
|
boolean_t usenext = B_FALSE;
|
2015-04-01 18:14:34 +03:00
|
|
|
if (dsl_dataset_phys(ds)->ds_next_clones_obj != 0) {
|
2010-05-29 00:45:14 +04:00
|
|
|
uint64_t count;
|
|
|
|
/*
|
|
|
|
* A bug in a previous version of the code could
|
|
|
|
* cause upgrade_clones_cb() to not set
|
|
|
|
* ds_next_snap_obj when it should, leading to a
|
|
|
|
* missing entry. Therefore we can only use the
|
|
|
|
* next_clones_obj when its count is correct.
|
|
|
|
*/
|
|
|
|
int err = zap_count(dp->dp_meta_objset,
|
2015-04-01 18:14:34 +03:00
|
|
|
dsl_dataset_phys(ds)->ds_next_clones_obj, &count);
|
2010-05-29 00:45:14 +04:00
|
|
|
if (err == 0 &&
|
2015-04-01 18:14:34 +03:00
|
|
|
count == dsl_dataset_phys(ds)->ds_num_children - 1)
|
2010-05-29 00:45:14 +04:00
|
|
|
usenext = B_TRUE;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (usenext) {
|
2017-11-16 04:27:01 +03:00
|
|
|
zap_cursor_t zc;
|
|
|
|
zap_attribute_t za;
|
|
|
|
for (zap_cursor_init(&zc, dp->dp_meta_objset,
|
|
|
|
dsl_dataset_phys(ds)->ds_next_clones_obj);
|
|
|
|
zap_cursor_retrieve(&zc, &za) == 0;
|
|
|
|
(void) zap_cursor_advance(&zc)) {
|
|
|
|
scan_ds_queue_insert(scn,
|
|
|
|
zfs_strtonum(za.za_name, NULL),
|
|
|
|
dsl_dataset_phys(ds)->ds_creation_txg);
|
|
|
|
}
|
|
|
|
zap_cursor_fini(&zc);
|
2010-05-29 00:45:14 +04:00
|
|
|
} else {
|
2013-09-04 16:00:57 +04:00
|
|
|
VERIFY0(dmu_objset_find_dp(dp, dp->dp_root_dir_obj,
|
2017-11-16 04:27:01 +03:00
|
|
|
enqueue_clones_cb, &ds->ds_object,
|
|
|
|
DS_FIND_CHILDREN));
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2013-09-04 16:00:57 +04:00
|
|
|
enqueue_cb(dsl_pool_t *dp, dsl_dataset_t *hds, void *arg)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2021-12-12 18:06:44 +03:00
|
|
|
(void) arg;
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_dataset_t *ds;
|
|
|
|
int err;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
|
2013-09-04 16:00:57 +04:00
|
|
|
err = dsl_dataset_hold_obj(dp, hds->ds_object, FTAG, &ds);
|
2010-05-29 00:45:14 +04:00
|
|
|
if (err)
|
|
|
|
return (err);
|
|
|
|
|
2015-04-01 18:14:34 +03:00
|
|
|
while (dsl_dataset_phys(ds)->ds_prev_snap_obj != 0) {
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_dataset_t *prev;
|
2015-04-01 18:14:34 +03:00
|
|
|
err = dsl_dataset_hold_obj(dp,
|
|
|
|
dsl_dataset_phys(ds)->ds_prev_snap_obj, FTAG, &prev);
|
2010-05-29 00:45:14 +04:00
|
|
|
if (err) {
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return (err);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If this is a clone, we don't need to worry about it for now.
|
|
|
|
*/
|
2015-04-01 18:14:34 +03:00
|
|
|
if (dsl_dataset_phys(prev)->ds_next_snap_obj != ds->ds_object) {
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
dsl_dataset_rele(prev, FTAG);
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
ds = prev;
|
|
|
|
}
|
|
|
|
|
2024-05-09 17:32:59 +03:00
|
|
|
mutex_enter(&scn->scn_queue_lock);
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_ds_queue_insert(scn, ds->ds_object,
|
|
|
|
dsl_dataset_phys(ds)->ds_prev_snap_txg);
|
2024-05-09 17:32:59 +03:00
|
|
|
mutex_exit(&scn->scn_queue_lock);
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
void
|
|
|
|
dsl_scan_ddt_entry(dsl_scan_t *scn, enum zio_checksum checksum,
|
|
|
|
ddt_entry_t *dde, dmu_tx_t *tx)
|
|
|
|
{
|
2021-12-12 18:06:44 +03:00
|
|
|
(void) tx;
|
2017-11-16 04:27:01 +03:00
|
|
|
const ddt_key_t *ddk = &dde->dde_key;
|
|
|
|
ddt_phys_t *ddp = dde->dde_phys;
|
|
|
|
blkptr_t bp;
|
|
|
|
zbookmark_phys_t zb = { 0 };
|
|
|
|
|
2018-01-31 20:33:33 +03:00
|
|
|
if (!dsl_scan_is_running(scn))
|
2017-11-16 04:27:01 +03:00
|
|
|
return;
|
|
|
|
|
2018-10-18 11:13:07 +03:00
|
|
|
/*
|
|
|
|
* This function is special because it is the only thing
|
|
|
|
* that can add scan_io_t's to the vdev scan queues from
|
|
|
|
* outside dsl_scan_sync(). For the most part this is ok
|
|
|
|
* as long as it is called from within syncing context.
|
|
|
|
* However, dsl_scan_sync() expects that no new sio's will
|
|
|
|
* be added between when all the work for a scan is done
|
|
|
|
* and the next txg when the scan is actually marked as
|
|
|
|
* completed. This check ensures we do not issue new sio's
|
|
|
|
* during this period.
|
|
|
|
*/
|
|
|
|
if (scn->scn_done_txg != 0)
|
|
|
|
return;
|
|
|
|
|
2021-12-12 18:06:44 +03:00
|
|
|
for (int p = 0; p < DDT_PHYS_TYPES; p++, ddp++) {
|
2017-11-16 04:27:01 +03:00
|
|
|
if (ddp->ddp_phys_birth == 0 ||
|
|
|
|
ddp->ddp_phys_birth > scn->scn_phys.scn_max_txg)
|
|
|
|
continue;
|
|
|
|
ddt_bp_create(checksum, ddk, ddp, &bp);
|
|
|
|
|
|
|
|
scn->scn_visited_this_txg++;
|
|
|
|
scan_funcs[scn->scn_phys.scn_func](scn->scn_dp, &bp, &zb);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
/*
|
|
|
|
* Scrub/dedup interaction.
|
|
|
|
*
|
|
|
|
* If there are N references to a deduped block, we don't want to scrub it
|
|
|
|
* N times -- ideally, we should scrub it exactly once.
|
|
|
|
*
|
2023-07-03 05:32:53 +03:00
|
|
|
* We leverage the fact that the dde's replication class (ddt_class_t)
|
2010-05-29 00:45:14 +04:00
|
|
|
* is ordered from highest replication class (DDT_CLASS_DITTO) to lowest
|
|
|
|
* (DDT_CLASS_UNIQUE) so that we may walk the DDT in that order.
|
|
|
|
*
|
|
|
|
* To prevent excess scrubbing, the scrub begins by walking the DDT
|
|
|
|
* to find all blocks with refcnt > 1, and scrubs each of these once.
|
|
|
|
* Since there are two replication classes which contain blocks with
|
|
|
|
* refcnt > 1, we scrub the highest replication class (DDT_CLASS_DITTO) first.
|
|
|
|
* Finally the top-down scrub begins, only visiting blocks with refcnt == 1.
|
|
|
|
*
|
|
|
|
* There would be nothing more to say if a block's refcnt couldn't change
|
|
|
|
* during a scrub, but of course it can so we must account for changes
|
|
|
|
* in a block's replication class.
|
|
|
|
*
|
|
|
|
* Here's an example of what can occur:
|
|
|
|
*
|
|
|
|
* If a block has refcnt > 1 during the DDT scrub phase, but has refcnt == 1
|
|
|
|
* when visited during the top-down scrub phase, it will be scrubbed twice.
|
|
|
|
* This negates our scrub optimization, but is otherwise harmless.
|
|
|
|
*
|
|
|
|
* If a block has refcnt == 1 during the DDT scrub phase, but has refcnt > 1
|
|
|
|
* on each visit during the top-down scrub phase, it will never be scrubbed.
|
|
|
|
* To catch this, ddt_sync_entry() notifies the scrub code whenever a block's
|
|
|
|
* reference class transitions to a higher level (i.e DDT_CLASS_UNIQUE to
|
|
|
|
* DDT_CLASS_DUPLICATE); if it transitions from refcnt == 1 to refcnt > 1
|
|
|
|
* while a scrub is in progress, it scrubs the block right then.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
dsl_scan_ddt(dsl_scan_t *scn, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
ddt_bookmark_t *ddb = &scn->scn_phys.scn_ddt_bookmark;
|
2022-02-25 16:26:54 +03:00
|
|
|
ddt_entry_t dde = {{{{0}}}};
|
2010-05-29 00:45:14 +04:00
|
|
|
int error;
|
|
|
|
uint64_t n = 0;
|
|
|
|
|
|
|
|
while ((error = ddt_walk(scn->scn_dp->dp_spa, ddb, &dde)) == 0) {
|
|
|
|
ddt_t *ddt;
|
|
|
|
|
|
|
|
if (ddb->ddb_class > scn->scn_phys.scn_ddt_class_max)
|
|
|
|
break;
|
|
|
|
dprintf("visiting ddb=%llu/%llu/%llu/%llx\n",
|
|
|
|
(longlong_t)ddb->ddb_class,
|
|
|
|
(longlong_t)ddb->ddb_type,
|
|
|
|
(longlong_t)ddb->ddb_checksum,
|
|
|
|
(longlong_t)ddb->ddb_cursor);
|
|
|
|
|
|
|
|
/* There should be no pending changes to the dedup table */
|
|
|
|
ddt = scn->scn_dp->dp_spa->spa_ddt[ddb->ddb_checksum];
|
|
|
|
ASSERT(avl_first(&ddt->ddt_tree) == NULL);
|
|
|
|
|
|
|
|
dsl_scan_ddt_entry(scn, ddb->ddb_checksum, &dde, tx);
|
|
|
|
n++;
|
|
|
|
|
2017-07-07 08:16:13 +03:00
|
|
|
if (dsl_scan_check_suspend(scn, NULL))
|
2010-05-29 00:45:14 +04:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("scanned %llu ddt entries on %s with class_max = %u; "
|
|
|
|
"suspending=%u", (longlong_t)n, scn->scn_dp->dp_spa->spa_name,
|
2017-07-07 08:16:13 +03:00
|
|
|
(int)scn->scn_phys.scn_ddt_class_max, (int)scn->scn_suspending);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
ASSERT(error == 0 || error == ENOENT);
|
|
|
|
ASSERT(error != ENOENT ||
|
|
|
|
ddb->ddb_class > scn->scn_phys.scn_ddt_class_max);
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static uint64_t
|
|
|
|
dsl_scan_ds_maxtxg(dsl_dataset_t *ds)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
uint64_t smt = ds->ds_dir->dd_pool->dp_scan->scn_phys.scn_max_txg;
|
|
|
|
if (ds->ds_is_snapshot)
|
|
|
|
return (MIN(smt, dsl_dataset_phys(ds)->ds_creation_txg));
|
|
|
|
return (smt);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_scan_visit(dsl_scan_t *scn, dmu_tx_t *tx)
|
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_ds_t *sds;
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_pool_t *dp = scn->scn_dp;
|
|
|
|
|
|
|
|
if (scn->scn_phys.scn_ddt_bookmark.ddb_class <=
|
|
|
|
scn->scn_phys.scn_ddt_class_max) {
|
|
|
|
scn->scn_phys.scn_cur_min_txg = scn->scn_phys.scn_min_txg;
|
|
|
|
scn->scn_phys.scn_cur_max_txg = scn->scn_phys.scn_max_txg;
|
|
|
|
dsl_scan_ddt(scn, tx);
|
2017-07-07 08:16:13 +03:00
|
|
|
if (scn->scn_suspending)
|
2010-05-29 00:45:14 +04:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (scn->scn_phys.scn_bookmark.zb_objset == DMU_META_OBJSET) {
|
|
|
|
/* First do the MOS & ORIGIN */
|
|
|
|
|
|
|
|
scn->scn_phys.scn_cur_min_txg = scn->scn_phys.scn_min_txg;
|
|
|
|
scn->scn_phys.scn_cur_max_txg = scn->scn_phys.scn_max_txg;
|
|
|
|
dsl_scan_visit_rootbp(scn, NULL,
|
|
|
|
&dp->dp_meta_rootbp, tx);
|
2017-07-07 08:16:13 +03:00
|
|
|
if (scn->scn_suspending)
|
2010-05-29 00:45:14 +04:00
|
|
|
return;
|
|
|
|
|
|
|
|
if (spa_version(dp->dp_spa) < SPA_VERSION_DSL_SCRUB) {
|
2013-09-04 16:00:57 +04:00
|
|
|
VERIFY0(dmu_objset_find_dp(dp, dp->dp_root_dir_obj,
|
2017-11-16 04:27:01 +03:00
|
|
|
enqueue_cb, NULL, DS_FIND_CHILDREN));
|
2010-05-29 00:45:14 +04:00
|
|
|
} else {
|
|
|
|
dsl_scan_visitds(scn,
|
|
|
|
dp->dp_origin_snap->ds_object, tx);
|
|
|
|
}
|
2017-07-07 08:16:13 +03:00
|
|
|
ASSERT(!scn->scn_suspending);
|
2010-05-29 00:45:14 +04:00
|
|
|
} else if (scn->scn_phys.scn_bookmark.zb_objset !=
|
|
|
|
ZB_DESTROYED_OBJSET) {
|
2017-11-16 04:27:01 +03:00
|
|
|
uint64_t dsobj = scn->scn_phys.scn_bookmark.zb_objset;
|
2010-05-29 00:45:14 +04:00
|
|
|
/*
|
2017-11-16 04:27:01 +03:00
|
|
|
* If we were suspended, continue from here. Note if the
|
2017-07-07 08:16:13 +03:00
|
|
|
* ds we were suspended on was deleted, the zb_objset may
|
2010-05-29 00:45:14 +04:00
|
|
|
* be -1, so we will skip this and find a new objset
|
|
|
|
* below.
|
|
|
|
*/
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_visitds(scn, dsobj, tx);
|
2017-07-07 08:16:13 +03:00
|
|
|
if (scn->scn_suspending)
|
2010-05-29 00:45:14 +04:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2017-11-16 04:27:01 +03:00
|
|
|
* In case we suspended right at the end of the ds, zero the
|
2010-05-29 00:45:14 +04:00
|
|
|
* bookmark so we don't think that we're still trying to resume.
|
|
|
|
*/
|
2022-02-25 16:26:54 +03:00
|
|
|
memset(&scn->scn_phys.scn_bookmark, 0, sizeof (zbookmark_phys_t));
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* Keep pulling things out of the dataset avl queue. Updates to the
|
|
|
|
* persistent zap-object-as-queue happen only at checkpoints.
|
|
|
|
*/
|
|
|
|
while ((sds = avl_first(&scn->scn_queue)) != NULL) {
|
2010-05-29 00:45:14 +04:00
|
|
|
dsl_dataset_t *ds;
|
2017-11-16 04:27:01 +03:00
|
|
|
uint64_t dsobj = sds->sds_dsobj;
|
|
|
|
uint64_t txg = sds->sds_txg;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/* dequeue and free the ds from the queue */
|
|
|
|
scan_ds_queue_remove(scn, dsobj);
|
|
|
|
sds = NULL;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/* set up min / max txg */
|
2010-05-29 00:45:14 +04:00
|
|
|
VERIFY3U(0, ==, dsl_dataset_hold_obj(dp, dsobj, FTAG, &ds));
|
2017-11-16 04:27:01 +03:00
|
|
|
if (txg != 0) {
|
2010-05-29 00:45:14 +04:00
|
|
|
scn->scn_phys.scn_cur_min_txg =
|
2017-11-16 04:27:01 +03:00
|
|
|
MAX(scn->scn_phys.scn_min_txg, txg);
|
2010-05-29 00:45:14 +04:00
|
|
|
} else {
|
|
|
|
scn->scn_phys.scn_cur_min_txg =
|
|
|
|
MAX(scn->scn_phys.scn_min_txg,
|
2015-04-01 18:14:34 +03:00
|
|
|
dsl_dataset_phys(ds)->ds_prev_snap_txg);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
scn->scn_phys.scn_cur_max_txg = dsl_scan_ds_maxtxg(ds);
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
|
|
|
|
dsl_scan_visitds(scn, dsobj, tx);
|
2017-07-07 08:16:13 +03:00
|
|
|
if (scn->scn_suspending)
|
2017-11-16 04:27:01 +03:00
|
|
|
return;
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/* No more objsets to fetch, we're done */
|
|
|
|
scn->scn_phys.scn_bookmark.zb_objset = ZB_DESTROYED_OBJSET;
|
|
|
|
ASSERT0(scn->scn_suspending);
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint64_t
|
2023-01-25 01:05:45 +03:00
|
|
|
dsl_scan_count_data_disks(spa_t *spa)
|
2017-11-16 04:27:01 +03:00
|
|
|
{
|
2023-01-25 01:05:45 +03:00
|
|
|
vdev_t *rvd = spa->spa_root_vdev;
|
2017-11-16 04:27:01 +03:00
|
|
|
uint64_t i, leaves = 0;
|
|
|
|
|
2021-05-27 19:11:39 +03:00
|
|
|
for (i = 0; i < rvd->vdev_children; i++) {
|
|
|
|
vdev_t *vd = rvd->vdev_child[i];
|
|
|
|
if (vd->vdev_islog || vd->vdev_isspare || vd->vdev_isl2cache)
|
|
|
|
continue;
|
|
|
|
leaves += vdev_get_ndisks(vd) - vdev_get_nparity(vd);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
return (leaves);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
scan_io_queues_update_zio_stats(dsl_scan_io_queue_t *q, const blkptr_t *bp)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
uint64_t cur_size = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < BP_GET_NDVAS(bp); i++) {
|
|
|
|
cur_size += DVA_GET_ASIZE(&bp->blk_dva[i]);
|
|
|
|
}
|
|
|
|
|
|
|
|
q->q_total_zio_size_this_txg += cur_size;
|
|
|
|
q->q_zios_this_txg++;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
scan_io_queues_update_seg_stats(dsl_scan_io_queue_t *q, uint64_t start,
|
|
|
|
uint64_t end)
|
|
|
|
{
|
|
|
|
q->q_total_seg_size_this_txg += end - start;
|
|
|
|
q->q_segs_this_txg++;
|
|
|
|
}
|
|
|
|
|
|
|
|
static boolean_t
|
|
|
|
scan_io_queue_check_suspend(dsl_scan_t *scn)
|
|
|
|
{
|
|
|
|
/* See comment in dsl_scan_check_suspend() */
|
|
|
|
uint64_t curr_time_ns = gethrtime();
|
|
|
|
uint64_t scan_time_ns = curr_time_ns - scn->scn_sync_start_time;
|
|
|
|
uint64_t sync_time_ns = curr_time_ns -
|
|
|
|
scn->scn_dp->dp_spa->spa_sync_starttime;
|
2022-06-27 21:08:21 +03:00
|
|
|
uint64_t dirty_min_bytes = zfs_dirty_data_max *
|
|
|
|
zfs_vdev_async_write_active_min_dirty_percent / 100;
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
uint_t mintime = (scn->scn_phys.scn_func == POOL_SCAN_RESILVER) ?
|
2017-11-16 04:27:01 +03:00
|
|
|
zfs_resilver_min_time_ms : zfs_scrub_min_time_ms;
|
|
|
|
|
|
|
|
return ((NSEC2MSEC(scan_time_ns) > mintime &&
|
2022-06-27 21:08:21 +03:00
|
|
|
(scn->scn_dp->dp_dirty_total >= dirty_min_bytes ||
|
2017-11-16 04:27:01 +03:00
|
|
|
txg_sync_waiting(scn->scn_dp) ||
|
|
|
|
NSEC2SEC(sync_time_ns) >= zfs_txg_timeout)) ||
|
|
|
|
spa_shutting_down(scn->scn_dp->dp_spa));
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2018-03-29 04:30:44 +03:00
|
|
|
* Given a list of scan_io_t's in io_list, this issues the I/Os out to
|
2017-11-16 04:27:01 +03:00
|
|
|
* disk. This consumes the io_list and frees the scan_io_t's. This is
|
|
|
|
* called when emptying queues, either when we're up against the memory
|
|
|
|
* limit or when we have finished scanning. Returns B_TRUE if we stopped
|
2018-03-29 04:30:44 +03:00
|
|
|
* processing the list before we finished. Any sios that were not issued
|
2017-11-16 04:27:01 +03:00
|
|
|
* will remain in the io_list.
|
|
|
|
*/
|
|
|
|
static boolean_t
|
|
|
|
scan_io_queue_issue(dsl_scan_io_queue_t *queue, list_t *io_list)
|
|
|
|
{
|
|
|
|
dsl_scan_t *scn = queue->q_scn;
|
|
|
|
scan_io_t *sio;
|
|
|
|
boolean_t suspended = B_FALSE;
|
|
|
|
|
|
|
|
while ((sio = list_head(io_list)) != NULL) {
|
|
|
|
blkptr_t bp;
|
|
|
|
|
|
|
|
if (scan_io_queue_check_suspend(scn)) {
|
|
|
|
suspended = B_TRUE;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2019-03-16 00:14:31 +03:00
|
|
|
sio2bp(sio, &bp);
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_exec_io(scn->scn_dp, &bp, sio->sio_flags,
|
|
|
|
&sio->sio_zb, queue);
|
|
|
|
(void) list_remove_head(io_list);
|
|
|
|
scan_io_queues_update_zio_stats(queue, &bp);
|
2019-03-16 00:14:31 +03:00
|
|
|
sio_free(sio);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
return (suspended);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This function removes sios from an IO queue which reside within a given
|
|
|
|
* range_seg_t and inserts them (in offset order) into a list. Note that
|
|
|
|
* we only ever return a maximum of 32 sios at once. If there are more sios
|
|
|
|
* to process within this segment that did not make it onto the list we
|
|
|
|
* return B_TRUE and otherwise B_FALSE.
|
|
|
|
*/
|
|
|
|
static boolean_t
|
|
|
|
scan_io_queue_gather(dsl_scan_io_queue_t *queue, range_seg_t *rs, list_t *list)
|
|
|
|
{
|
2019-03-16 00:14:31 +03:00
|
|
|
scan_io_t *srch_sio, *sio, *next_sio;
|
2017-11-16 04:27:01 +03:00
|
|
|
avl_index_t idx;
|
|
|
|
uint_t num_sios = 0;
|
|
|
|
int64_t bytes_issued = 0;
|
|
|
|
|
|
|
|
ASSERT(rs != NULL);
|
|
|
|
ASSERT(MUTEX_HELD(&queue->q_vd->vdev_scan_io_queue_lock));
|
|
|
|
|
2019-03-16 00:14:31 +03:00
|
|
|
srch_sio = sio_alloc(1);
|
|
|
|
srch_sio->sio_nr_dvas = 1;
|
Reduce loaded range tree memory usage
This patch implements a new tree structure for ZFS, and uses it to
store range trees more efficiently.
The new structure is approximately a B-tree, though there are some
small differences from the usual characterizations. The tree has core
nodes and leaf nodes; each contain data elements, which the elements
in the core nodes acting as separators between its children. The
difference between core and leaf nodes is that the core nodes have an
array of children, while leaf nodes don't. Every node in the tree may
be only partially full; in most cases, they are all at least 50% full
(in terms of element count) except for the root node, which can be
less full. Underfull nodes will steal from their neighbors or merge to
remain full enough, while overfull nodes will split in two. The data
elements are contained in tree-controlled buffers; they are copied
into these on insertion, and overwritten on deletion. This means that
the elements are not independently allocated, which reduces overhead,
but also means they can't be shared between trees (and also that
pointers to them are only valid until a side-effectful tree operation
occurs). The overhead varies based on how dense the tree is, but is
usually on the order of about 50% of the element size; the per-node
overheads are very small, and so don't make a significant difference.
The trees can accept arbitrary records; they accept a size and a
comparator to allow them to be used for a variety of purposes.
The new trees replace the AVL trees used in the range trees today.
Currently, the range_seg_t structure contains three 8 byte integers
of payload and two 24 byte avl_tree_node_ts to handle its storage in
both an offset-sorted tree and a size-sorted tree (total size: 64
bytes). In the new model, the range seg structures are usually two 4
byte integers, but a separate one needs to exist for the size-sorted
and offset-sorted tree. Between the raw size, the 50% overhead, and
the double storage, the new btrees are expected to use 8*1.5*2 = 24
bytes per record, or 33.3% as much memory as the AVL trees (this is
for the purposes of storing metaslab range trees; for other purposes,
like scrubs, they use ~50% as much memory).
We reduced the size of the payload in the range segments by teaching
range trees about starting offsets and shifts; since metaslabs have a
fixed starting offset, and they all operate in terms of disk sectors,
we can store the ranges using 4-byte integers as long as the size of
the metaslab divided by the sector size is less than 2^32. For 512-byte
sectors, this is a 2^41 (or 2TB) metaslab, which with the default
settings corresponds to a 256PB disk. 4k sector disks can handle
metaslabs up to 2^46 bytes, or 2^63 byte disks. Since we do not
anticipate disks of this size in the near future, there should be
almost no cases where metaslabs need 64-byte integers to store their
ranges. We do still have the capability to store 64-byte integer ranges
to account for cases where we are storing per-vdev (or per-dnode) trees,
which could reasonably go above the limits discussed. We also do not
store fill information in the compact version of the node, since it
is only used for sorted scrub.
We also optimized the metaslab loading process in various other ways
to offset some inefficiencies in the btree model. While individual
operations (find, insert, remove_from) are faster for the btree than
they are for the avl tree, remove usually requires a find operation,
while in the AVL tree model the element itself suffices. Some clever
changes actually caused an overall speedup in metaslab loading; we use
approximately 40% less cpu to load metaslabs in our tests on Illumos.
Another memory and performance optimization was achieved by changing
what is stored in the size-sorted trees. When a disk is heavily
fragmented, the df algorithm used by default in ZFS will almost always
find a number of small regions in its initial cursor-based search; it
will usually only fall back to the size-sorted tree to find larger
regions. If we increase the size of the cursor-based search slightly,
and don't store segments that are smaller than a tunable size floor
in the size-sorted tree, we can further cut memory usage down to
below 20% of what the AVL trees store. This also results in further
reductions in CPU time spent loading metaslabs.
The 16KiB size floor was chosen because it results in substantial memory
usage reduction while not usually resulting in situations where we can't
find an appropriate chunk with the cursor and are forced to use an
oversized chunk from the size-sorted tree. In addition, even if we do
have to use an oversized chunk from the size-sorted tree, the chunk
would be too small to use for ZIL allocations, so it isn't as big of a
loss as it might otherwise be. And often, more small allocations will
follow the initial one, and the cursor search will now find the
remainder of the chunk we didn't use all of and use it for subsequent
allocations. Practical testing has shown little or no change in
fragmentation as a result of this change.
If the size-sorted tree becomes empty while the offset sorted one still
has entries, it will load all the entries from the offset sorted tree
and disregard the size floor until it is unloaded again. This operation
occurs rarely with the default setting, only on incredibly thoroughly
fragmented pools.
There are some other small changes to zdb to teach it to handle btrees,
but nothing major.
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Sebastien Roy seb@delphix.com
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9181
2019-10-09 20:36:03 +03:00
|
|
|
SIO_SET_OFFSET(srch_sio, rs_get_start(rs, queue->q_exts_by_addr));
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* The exact start of the extent might not contain any matching zios,
|
|
|
|
* so if that's the case, examine the next one in the tree.
|
|
|
|
*/
|
2019-03-16 00:14:31 +03:00
|
|
|
sio = avl_find(&queue->q_sios_by_addr, srch_sio, &idx);
|
|
|
|
sio_free(srch_sio);
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
if (sio == NULL)
|
|
|
|
sio = avl_nearest(&queue->q_sios_by_addr, idx, AVL_AFTER);
|
|
|
|
|
Reduce loaded range tree memory usage
This patch implements a new tree structure for ZFS, and uses it to
store range trees more efficiently.
The new structure is approximately a B-tree, though there are some
small differences from the usual characterizations. The tree has core
nodes and leaf nodes; each contain data elements, which the elements
in the core nodes acting as separators between its children. The
difference between core and leaf nodes is that the core nodes have an
array of children, while leaf nodes don't. Every node in the tree may
be only partially full; in most cases, they are all at least 50% full
(in terms of element count) except for the root node, which can be
less full. Underfull nodes will steal from their neighbors or merge to
remain full enough, while overfull nodes will split in two. The data
elements are contained in tree-controlled buffers; they are copied
into these on insertion, and overwritten on deletion. This means that
the elements are not independently allocated, which reduces overhead,
but also means they can't be shared between trees (and also that
pointers to them are only valid until a side-effectful tree operation
occurs). The overhead varies based on how dense the tree is, but is
usually on the order of about 50% of the element size; the per-node
overheads are very small, and so don't make a significant difference.
The trees can accept arbitrary records; they accept a size and a
comparator to allow them to be used for a variety of purposes.
The new trees replace the AVL trees used in the range trees today.
Currently, the range_seg_t structure contains three 8 byte integers
of payload and two 24 byte avl_tree_node_ts to handle its storage in
both an offset-sorted tree and a size-sorted tree (total size: 64
bytes). In the new model, the range seg structures are usually two 4
byte integers, but a separate one needs to exist for the size-sorted
and offset-sorted tree. Between the raw size, the 50% overhead, and
the double storage, the new btrees are expected to use 8*1.5*2 = 24
bytes per record, or 33.3% as much memory as the AVL trees (this is
for the purposes of storing metaslab range trees; for other purposes,
like scrubs, they use ~50% as much memory).
We reduced the size of the payload in the range segments by teaching
range trees about starting offsets and shifts; since metaslabs have a
fixed starting offset, and they all operate in terms of disk sectors,
we can store the ranges using 4-byte integers as long as the size of
the metaslab divided by the sector size is less than 2^32. For 512-byte
sectors, this is a 2^41 (or 2TB) metaslab, which with the default
settings corresponds to a 256PB disk. 4k sector disks can handle
metaslabs up to 2^46 bytes, or 2^63 byte disks. Since we do not
anticipate disks of this size in the near future, there should be
almost no cases where metaslabs need 64-byte integers to store their
ranges. We do still have the capability to store 64-byte integer ranges
to account for cases where we are storing per-vdev (or per-dnode) trees,
which could reasonably go above the limits discussed. We also do not
store fill information in the compact version of the node, since it
is only used for sorted scrub.
We also optimized the metaslab loading process in various other ways
to offset some inefficiencies in the btree model. While individual
operations (find, insert, remove_from) are faster for the btree than
they are for the avl tree, remove usually requires a find operation,
while in the AVL tree model the element itself suffices. Some clever
changes actually caused an overall speedup in metaslab loading; we use
approximately 40% less cpu to load metaslabs in our tests on Illumos.
Another memory and performance optimization was achieved by changing
what is stored in the size-sorted trees. When a disk is heavily
fragmented, the df algorithm used by default in ZFS will almost always
find a number of small regions in its initial cursor-based search; it
will usually only fall back to the size-sorted tree to find larger
regions. If we increase the size of the cursor-based search slightly,
and don't store segments that are smaller than a tunable size floor
in the size-sorted tree, we can further cut memory usage down to
below 20% of what the AVL trees store. This also results in further
reductions in CPU time spent loading metaslabs.
The 16KiB size floor was chosen because it results in substantial memory
usage reduction while not usually resulting in situations where we can't
find an appropriate chunk with the cursor and are forced to use an
oversized chunk from the size-sorted tree. In addition, even if we do
have to use an oversized chunk from the size-sorted tree, the chunk
would be too small to use for ZIL allocations, so it isn't as big of a
loss as it might otherwise be. And often, more small allocations will
follow the initial one, and the cursor search will now find the
remainder of the chunk we didn't use all of and use it for subsequent
allocations. Practical testing has shown little or no change in
fragmentation as a result of this change.
If the size-sorted tree becomes empty while the offset sorted one still
has entries, it will load all the entries from the offset sorted tree
and disregard the size floor until it is unloaded again. This operation
occurs rarely with the default setting, only on incredibly thoroughly
fragmented pools.
There are some other small changes to zdb to teach it to handle btrees,
but nothing major.
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Sebastien Roy seb@delphix.com
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9181
2019-10-09 20:36:03 +03:00
|
|
|
while (sio != NULL && SIO_GET_OFFSET(sio) < rs_get_end(rs,
|
|
|
|
queue->q_exts_by_addr) && num_sios <= 32) {
|
|
|
|
ASSERT3U(SIO_GET_OFFSET(sio), >=, rs_get_start(rs,
|
|
|
|
queue->q_exts_by_addr));
|
|
|
|
ASSERT3U(SIO_GET_END_OFFSET(sio), <=, rs_get_end(rs,
|
|
|
|
queue->q_exts_by_addr));
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
next_sio = AVL_NEXT(&queue->q_sios_by_addr, sio);
|
|
|
|
avl_remove(&queue->q_sios_by_addr, sio);
|
2022-06-24 19:50:37 +03:00
|
|
|
if (avl_is_empty(&queue->q_sios_by_addr))
|
|
|
|
atomic_add_64(&queue->q_scn->scn_queues_pending, -1);
|
2019-03-16 00:14:31 +03:00
|
|
|
queue->q_sio_memused -= SIO_GET_MUSED(sio);
|
2017-11-16 04:27:01 +03:00
|
|
|
|
2019-03-16 00:14:31 +03:00
|
|
|
bytes_issued += SIO_GET_ASIZE(sio);
|
2017-11-16 04:27:01 +03:00
|
|
|
num_sios++;
|
|
|
|
list_insert_tail(list, sio);
|
|
|
|
sio = next_sio;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We limit the number of sios we process at once to 32 to avoid
|
|
|
|
* biting off more than we can chew. If we didn't take everything
|
|
|
|
* in the segment we update it to reflect the work we were able to
|
|
|
|
* complete. Otherwise, we remove it from the range tree entirely.
|
|
|
|
*/
|
Reduce loaded range tree memory usage
This patch implements a new tree structure for ZFS, and uses it to
store range trees more efficiently.
The new structure is approximately a B-tree, though there are some
small differences from the usual characterizations. The tree has core
nodes and leaf nodes; each contain data elements, which the elements
in the core nodes acting as separators between its children. The
difference between core and leaf nodes is that the core nodes have an
array of children, while leaf nodes don't. Every node in the tree may
be only partially full; in most cases, they are all at least 50% full
(in terms of element count) except for the root node, which can be
less full. Underfull nodes will steal from their neighbors or merge to
remain full enough, while overfull nodes will split in two. The data
elements are contained in tree-controlled buffers; they are copied
into these on insertion, and overwritten on deletion. This means that
the elements are not independently allocated, which reduces overhead,
but also means they can't be shared between trees (and also that
pointers to them are only valid until a side-effectful tree operation
occurs). The overhead varies based on how dense the tree is, but is
usually on the order of about 50% of the element size; the per-node
overheads are very small, and so don't make a significant difference.
The trees can accept arbitrary records; they accept a size and a
comparator to allow them to be used for a variety of purposes.
The new trees replace the AVL trees used in the range trees today.
Currently, the range_seg_t structure contains three 8 byte integers
of payload and two 24 byte avl_tree_node_ts to handle its storage in
both an offset-sorted tree and a size-sorted tree (total size: 64
bytes). In the new model, the range seg structures are usually two 4
byte integers, but a separate one needs to exist for the size-sorted
and offset-sorted tree. Between the raw size, the 50% overhead, and
the double storage, the new btrees are expected to use 8*1.5*2 = 24
bytes per record, or 33.3% as much memory as the AVL trees (this is
for the purposes of storing metaslab range trees; for other purposes,
like scrubs, they use ~50% as much memory).
We reduced the size of the payload in the range segments by teaching
range trees about starting offsets and shifts; since metaslabs have a
fixed starting offset, and they all operate in terms of disk sectors,
we can store the ranges using 4-byte integers as long as the size of
the metaslab divided by the sector size is less than 2^32. For 512-byte
sectors, this is a 2^41 (or 2TB) metaslab, which with the default
settings corresponds to a 256PB disk. 4k sector disks can handle
metaslabs up to 2^46 bytes, or 2^63 byte disks. Since we do not
anticipate disks of this size in the near future, there should be
almost no cases where metaslabs need 64-byte integers to store their
ranges. We do still have the capability to store 64-byte integer ranges
to account for cases where we are storing per-vdev (or per-dnode) trees,
which could reasonably go above the limits discussed. We also do not
store fill information in the compact version of the node, since it
is only used for sorted scrub.
We also optimized the metaslab loading process in various other ways
to offset some inefficiencies in the btree model. While individual
operations (find, insert, remove_from) are faster for the btree than
they are for the avl tree, remove usually requires a find operation,
while in the AVL tree model the element itself suffices. Some clever
changes actually caused an overall speedup in metaslab loading; we use
approximately 40% less cpu to load metaslabs in our tests on Illumos.
Another memory and performance optimization was achieved by changing
what is stored in the size-sorted trees. When a disk is heavily
fragmented, the df algorithm used by default in ZFS will almost always
find a number of small regions in its initial cursor-based search; it
will usually only fall back to the size-sorted tree to find larger
regions. If we increase the size of the cursor-based search slightly,
and don't store segments that are smaller than a tunable size floor
in the size-sorted tree, we can further cut memory usage down to
below 20% of what the AVL trees store. This also results in further
reductions in CPU time spent loading metaslabs.
The 16KiB size floor was chosen because it results in substantial memory
usage reduction while not usually resulting in situations where we can't
find an appropriate chunk with the cursor and are forced to use an
oversized chunk from the size-sorted tree. In addition, even if we do
have to use an oversized chunk from the size-sorted tree, the chunk
would be too small to use for ZIL allocations, so it isn't as big of a
loss as it might otherwise be. And often, more small allocations will
follow the initial one, and the cursor search will now find the
remainder of the chunk we didn't use all of and use it for subsequent
allocations. Practical testing has shown little or no change in
fragmentation as a result of this change.
If the size-sorted tree becomes empty while the offset sorted one still
has entries, it will load all the entries from the offset sorted tree
and disregard the size floor until it is unloaded again. This operation
occurs rarely with the default setting, only on incredibly thoroughly
fragmented pools.
There are some other small changes to zdb to teach it to handle btrees,
but nothing major.
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Sebastien Roy seb@delphix.com
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9181
2019-10-09 20:36:03 +03:00
|
|
|
if (sio != NULL && SIO_GET_OFFSET(sio) < rs_get_end(rs,
|
|
|
|
queue->q_exts_by_addr)) {
|
2017-11-16 04:27:01 +03:00
|
|
|
range_tree_adjust_fill(queue->q_exts_by_addr, rs,
|
|
|
|
-bytes_issued);
|
|
|
|
range_tree_resize_segment(queue->q_exts_by_addr, rs,
|
Reduce loaded range tree memory usage
This patch implements a new tree structure for ZFS, and uses it to
store range trees more efficiently.
The new structure is approximately a B-tree, though there are some
small differences from the usual characterizations. The tree has core
nodes and leaf nodes; each contain data elements, which the elements
in the core nodes acting as separators between its children. The
difference between core and leaf nodes is that the core nodes have an
array of children, while leaf nodes don't. Every node in the tree may
be only partially full; in most cases, they are all at least 50% full
(in terms of element count) except for the root node, which can be
less full. Underfull nodes will steal from their neighbors or merge to
remain full enough, while overfull nodes will split in two. The data
elements are contained in tree-controlled buffers; they are copied
into these on insertion, and overwritten on deletion. This means that
the elements are not independently allocated, which reduces overhead,
but also means they can't be shared between trees (and also that
pointers to them are only valid until a side-effectful tree operation
occurs). The overhead varies based on how dense the tree is, but is
usually on the order of about 50% of the element size; the per-node
overheads are very small, and so don't make a significant difference.
The trees can accept arbitrary records; they accept a size and a
comparator to allow them to be used for a variety of purposes.
The new trees replace the AVL trees used in the range trees today.
Currently, the range_seg_t structure contains three 8 byte integers
of payload and two 24 byte avl_tree_node_ts to handle its storage in
both an offset-sorted tree and a size-sorted tree (total size: 64
bytes). In the new model, the range seg structures are usually two 4
byte integers, but a separate one needs to exist for the size-sorted
and offset-sorted tree. Between the raw size, the 50% overhead, and
the double storage, the new btrees are expected to use 8*1.5*2 = 24
bytes per record, or 33.3% as much memory as the AVL trees (this is
for the purposes of storing metaslab range trees; for other purposes,
like scrubs, they use ~50% as much memory).
We reduced the size of the payload in the range segments by teaching
range trees about starting offsets and shifts; since metaslabs have a
fixed starting offset, and they all operate in terms of disk sectors,
we can store the ranges using 4-byte integers as long as the size of
the metaslab divided by the sector size is less than 2^32. For 512-byte
sectors, this is a 2^41 (or 2TB) metaslab, which with the default
settings corresponds to a 256PB disk. 4k sector disks can handle
metaslabs up to 2^46 bytes, or 2^63 byte disks. Since we do not
anticipate disks of this size in the near future, there should be
almost no cases where metaslabs need 64-byte integers to store their
ranges. We do still have the capability to store 64-byte integer ranges
to account for cases where we are storing per-vdev (or per-dnode) trees,
which could reasonably go above the limits discussed. We also do not
store fill information in the compact version of the node, since it
is only used for sorted scrub.
We also optimized the metaslab loading process in various other ways
to offset some inefficiencies in the btree model. While individual
operations (find, insert, remove_from) are faster for the btree than
they are for the avl tree, remove usually requires a find operation,
while in the AVL tree model the element itself suffices. Some clever
changes actually caused an overall speedup in metaslab loading; we use
approximately 40% less cpu to load metaslabs in our tests on Illumos.
Another memory and performance optimization was achieved by changing
what is stored in the size-sorted trees. When a disk is heavily
fragmented, the df algorithm used by default in ZFS will almost always
find a number of small regions in its initial cursor-based search; it
will usually only fall back to the size-sorted tree to find larger
regions. If we increase the size of the cursor-based search slightly,
and don't store segments that are smaller than a tunable size floor
in the size-sorted tree, we can further cut memory usage down to
below 20% of what the AVL trees store. This also results in further
reductions in CPU time spent loading metaslabs.
The 16KiB size floor was chosen because it results in substantial memory
usage reduction while not usually resulting in situations where we can't
find an appropriate chunk with the cursor and are forced to use an
oversized chunk from the size-sorted tree. In addition, even if we do
have to use an oversized chunk from the size-sorted tree, the chunk
would be too small to use for ZIL allocations, so it isn't as big of a
loss as it might otherwise be. And often, more small allocations will
follow the initial one, and the cursor search will now find the
remainder of the chunk we didn't use all of and use it for subsequent
allocations. Practical testing has shown little or no change in
fragmentation as a result of this change.
If the size-sorted tree becomes empty while the offset sorted one still
has entries, it will load all the entries from the offset sorted tree
and disregard the size floor until it is unloaded again. This operation
occurs rarely with the default setting, only on incredibly thoroughly
fragmented pools.
There are some other small changes to zdb to teach it to handle btrees,
but nothing major.
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Sebastien Roy seb@delphix.com
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9181
2019-10-09 20:36:03 +03:00
|
|
|
SIO_GET_OFFSET(sio), rs_get_end(rs,
|
|
|
|
queue->q_exts_by_addr) - SIO_GET_OFFSET(sio));
|
2022-06-24 19:50:37 +03:00
|
|
|
queue->q_last_ext_addr = SIO_GET_OFFSET(sio);
|
2017-11-16 04:27:01 +03:00
|
|
|
return (B_TRUE);
|
|
|
|
} else {
|
Reduce loaded range tree memory usage
This patch implements a new tree structure for ZFS, and uses it to
store range trees more efficiently.
The new structure is approximately a B-tree, though there are some
small differences from the usual characterizations. The tree has core
nodes and leaf nodes; each contain data elements, which the elements
in the core nodes acting as separators between its children. The
difference between core and leaf nodes is that the core nodes have an
array of children, while leaf nodes don't. Every node in the tree may
be only partially full; in most cases, they are all at least 50% full
(in terms of element count) except for the root node, which can be
less full. Underfull nodes will steal from their neighbors or merge to
remain full enough, while overfull nodes will split in two. The data
elements are contained in tree-controlled buffers; they are copied
into these on insertion, and overwritten on deletion. This means that
the elements are not independently allocated, which reduces overhead,
but also means they can't be shared between trees (and also that
pointers to them are only valid until a side-effectful tree operation
occurs). The overhead varies based on how dense the tree is, but is
usually on the order of about 50% of the element size; the per-node
overheads are very small, and so don't make a significant difference.
The trees can accept arbitrary records; they accept a size and a
comparator to allow them to be used for a variety of purposes.
The new trees replace the AVL trees used in the range trees today.
Currently, the range_seg_t structure contains three 8 byte integers
of payload and two 24 byte avl_tree_node_ts to handle its storage in
both an offset-sorted tree and a size-sorted tree (total size: 64
bytes). In the new model, the range seg structures are usually two 4
byte integers, but a separate one needs to exist for the size-sorted
and offset-sorted tree. Between the raw size, the 50% overhead, and
the double storage, the new btrees are expected to use 8*1.5*2 = 24
bytes per record, or 33.3% as much memory as the AVL trees (this is
for the purposes of storing metaslab range trees; for other purposes,
like scrubs, they use ~50% as much memory).
We reduced the size of the payload in the range segments by teaching
range trees about starting offsets and shifts; since metaslabs have a
fixed starting offset, and they all operate in terms of disk sectors,
we can store the ranges using 4-byte integers as long as the size of
the metaslab divided by the sector size is less than 2^32. For 512-byte
sectors, this is a 2^41 (or 2TB) metaslab, which with the default
settings corresponds to a 256PB disk. 4k sector disks can handle
metaslabs up to 2^46 bytes, or 2^63 byte disks. Since we do not
anticipate disks of this size in the near future, there should be
almost no cases where metaslabs need 64-byte integers to store their
ranges. We do still have the capability to store 64-byte integer ranges
to account for cases where we are storing per-vdev (or per-dnode) trees,
which could reasonably go above the limits discussed. We also do not
store fill information in the compact version of the node, since it
is only used for sorted scrub.
We also optimized the metaslab loading process in various other ways
to offset some inefficiencies in the btree model. While individual
operations (find, insert, remove_from) are faster for the btree than
they are for the avl tree, remove usually requires a find operation,
while in the AVL tree model the element itself suffices. Some clever
changes actually caused an overall speedup in metaslab loading; we use
approximately 40% less cpu to load metaslabs in our tests on Illumos.
Another memory and performance optimization was achieved by changing
what is stored in the size-sorted trees. When a disk is heavily
fragmented, the df algorithm used by default in ZFS will almost always
find a number of small regions in its initial cursor-based search; it
will usually only fall back to the size-sorted tree to find larger
regions. If we increase the size of the cursor-based search slightly,
and don't store segments that are smaller than a tunable size floor
in the size-sorted tree, we can further cut memory usage down to
below 20% of what the AVL trees store. This also results in further
reductions in CPU time spent loading metaslabs.
The 16KiB size floor was chosen because it results in substantial memory
usage reduction while not usually resulting in situations where we can't
find an appropriate chunk with the cursor and are forced to use an
oversized chunk from the size-sorted tree. In addition, even if we do
have to use an oversized chunk from the size-sorted tree, the chunk
would be too small to use for ZIL allocations, so it isn't as big of a
loss as it might otherwise be. And often, more small allocations will
follow the initial one, and the cursor search will now find the
remainder of the chunk we didn't use all of and use it for subsequent
allocations. Practical testing has shown little or no change in
fragmentation as a result of this change.
If the size-sorted tree becomes empty while the offset sorted one still
has entries, it will load all the entries from the offset sorted tree
and disregard the size floor until it is unloaded again. This operation
occurs rarely with the default setting, only on incredibly thoroughly
fragmented pools.
There are some other small changes to zdb to teach it to handle btrees,
but nothing major.
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Sebastien Roy seb@delphix.com
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9181
2019-10-09 20:36:03 +03:00
|
|
|
uint64_t rstart = rs_get_start(rs, queue->q_exts_by_addr);
|
|
|
|
uint64_t rend = rs_get_end(rs, queue->q_exts_by_addr);
|
|
|
|
range_tree_remove(queue->q_exts_by_addr, rstart, rend - rstart);
|
2022-06-24 19:50:37 +03:00
|
|
|
queue->q_last_ext_addr = -1;
|
2017-11-16 04:27:01 +03:00
|
|
|
return (B_FALSE);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This is called from the queue emptying thread and selects the next
|
2018-03-29 04:30:44 +03:00
|
|
|
* extent from which we are to issue I/Os. The behavior of this function
|
2017-11-16 04:27:01 +03:00
|
|
|
* depends on the state of the scan, the current memory consumption and
|
|
|
|
* whether or not we are performing a scan shutdown.
|
|
|
|
* 1) We select extents in an elevator algorithm (LBA-order) if the scan
|
|
|
|
* needs to perform a checkpoint
|
|
|
|
* 2) We select the largest available extent if we are up against the
|
|
|
|
* memory limit.
|
|
|
|
* 3) Otherwise we don't select any extents.
|
|
|
|
*/
|
|
|
|
static range_seg_t *
|
|
|
|
scan_io_queue_fetch_ext(dsl_scan_io_queue_t *queue)
|
|
|
|
{
|
|
|
|
dsl_scan_t *scn = queue->q_scn;
|
Reduce loaded range tree memory usage
This patch implements a new tree structure for ZFS, and uses it to
store range trees more efficiently.
The new structure is approximately a B-tree, though there are some
small differences from the usual characterizations. The tree has core
nodes and leaf nodes; each contain data elements, which the elements
in the core nodes acting as separators between its children. The
difference between core and leaf nodes is that the core nodes have an
array of children, while leaf nodes don't. Every node in the tree may
be only partially full; in most cases, they are all at least 50% full
(in terms of element count) except for the root node, which can be
less full. Underfull nodes will steal from their neighbors or merge to
remain full enough, while overfull nodes will split in two. The data
elements are contained in tree-controlled buffers; they are copied
into these on insertion, and overwritten on deletion. This means that
the elements are not independently allocated, which reduces overhead,
but also means they can't be shared between trees (and also that
pointers to them are only valid until a side-effectful tree operation
occurs). The overhead varies based on how dense the tree is, but is
usually on the order of about 50% of the element size; the per-node
overheads are very small, and so don't make a significant difference.
The trees can accept arbitrary records; they accept a size and a
comparator to allow them to be used for a variety of purposes.
The new trees replace the AVL trees used in the range trees today.
Currently, the range_seg_t structure contains three 8 byte integers
of payload and two 24 byte avl_tree_node_ts to handle its storage in
both an offset-sorted tree and a size-sorted tree (total size: 64
bytes). In the new model, the range seg structures are usually two 4
byte integers, but a separate one needs to exist for the size-sorted
and offset-sorted tree. Between the raw size, the 50% overhead, and
the double storage, the new btrees are expected to use 8*1.5*2 = 24
bytes per record, or 33.3% as much memory as the AVL trees (this is
for the purposes of storing metaslab range trees; for other purposes,
like scrubs, they use ~50% as much memory).
We reduced the size of the payload in the range segments by teaching
range trees about starting offsets and shifts; since metaslabs have a
fixed starting offset, and they all operate in terms of disk sectors,
we can store the ranges using 4-byte integers as long as the size of
the metaslab divided by the sector size is less than 2^32. For 512-byte
sectors, this is a 2^41 (or 2TB) metaslab, which with the default
settings corresponds to a 256PB disk. 4k sector disks can handle
metaslabs up to 2^46 bytes, or 2^63 byte disks. Since we do not
anticipate disks of this size in the near future, there should be
almost no cases where metaslabs need 64-byte integers to store their
ranges. We do still have the capability to store 64-byte integer ranges
to account for cases where we are storing per-vdev (or per-dnode) trees,
which could reasonably go above the limits discussed. We also do not
store fill information in the compact version of the node, since it
is only used for sorted scrub.
We also optimized the metaslab loading process in various other ways
to offset some inefficiencies in the btree model. While individual
operations (find, insert, remove_from) are faster for the btree than
they are for the avl tree, remove usually requires a find operation,
while in the AVL tree model the element itself suffices. Some clever
changes actually caused an overall speedup in metaslab loading; we use
approximately 40% less cpu to load metaslabs in our tests on Illumos.
Another memory and performance optimization was achieved by changing
what is stored in the size-sorted trees. When a disk is heavily
fragmented, the df algorithm used by default in ZFS will almost always
find a number of small regions in its initial cursor-based search; it
will usually only fall back to the size-sorted tree to find larger
regions. If we increase the size of the cursor-based search slightly,
and don't store segments that are smaller than a tunable size floor
in the size-sorted tree, we can further cut memory usage down to
below 20% of what the AVL trees store. This also results in further
reductions in CPU time spent loading metaslabs.
The 16KiB size floor was chosen because it results in substantial memory
usage reduction while not usually resulting in situations where we can't
find an appropriate chunk with the cursor and are forced to use an
oversized chunk from the size-sorted tree. In addition, even if we do
have to use an oversized chunk from the size-sorted tree, the chunk
would be too small to use for ZIL allocations, so it isn't as big of a
loss as it might otherwise be. And often, more small allocations will
follow the initial one, and the cursor search will now find the
remainder of the chunk we didn't use all of and use it for subsequent
allocations. Practical testing has shown little or no change in
fragmentation as a result of this change.
If the size-sorted tree becomes empty while the offset sorted one still
has entries, it will load all the entries from the offset sorted tree
and disregard the size floor until it is unloaded again. This operation
occurs rarely with the default setting, only on incredibly thoroughly
fragmented pools.
There are some other small changes to zdb to teach it to handle btrees,
but nothing major.
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Sebastien Roy seb@delphix.com
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9181
2019-10-09 20:36:03 +03:00
|
|
|
range_tree_t *rt = queue->q_exts_by_addr;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
ASSERT(MUTEX_HELD(&queue->q_vd->vdev_scan_io_queue_lock));
|
|
|
|
ASSERT(scn->scn_is_sorted);
|
|
|
|
|
2022-06-24 19:50:37 +03:00
|
|
|
if (!scn->scn_checkpointing && !scn->scn_clearing)
|
|
|
|
return (NULL);
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* During normal clearing, we want to issue our largest segments
|
|
|
|
* first, keeping IO as sequential as possible, and leaving the
|
|
|
|
* smaller extents for later with the hope that they might eventually
|
|
|
|
* grow to larger sequential segments. However, when the scan is
|
|
|
|
* checkpointing, no new extents will be added to the sorting queue,
|
|
|
|
* so the way we are sorted now is as good as it will ever get.
|
|
|
|
* In this case, we instead switch to issuing extents in LBA order.
|
|
|
|
*/
|
2022-06-24 19:50:37 +03:00
|
|
|
if ((zfs_scan_issue_strategy < 1 && scn->scn_checkpointing) ||
|
|
|
|
zfs_scan_issue_strategy == 1)
|
Reduce loaded range tree memory usage
This patch implements a new tree structure for ZFS, and uses it to
store range trees more efficiently.
The new structure is approximately a B-tree, though there are some
small differences from the usual characterizations. The tree has core
nodes and leaf nodes; each contain data elements, which the elements
in the core nodes acting as separators between its children. The
difference between core and leaf nodes is that the core nodes have an
array of children, while leaf nodes don't. Every node in the tree may
be only partially full; in most cases, they are all at least 50% full
(in terms of element count) except for the root node, which can be
less full. Underfull nodes will steal from their neighbors or merge to
remain full enough, while overfull nodes will split in two. The data
elements are contained in tree-controlled buffers; they are copied
into these on insertion, and overwritten on deletion. This means that
the elements are not independently allocated, which reduces overhead,
but also means they can't be shared between trees (and also that
pointers to them are only valid until a side-effectful tree operation
occurs). The overhead varies based on how dense the tree is, but is
usually on the order of about 50% of the element size; the per-node
overheads are very small, and so don't make a significant difference.
The trees can accept arbitrary records; they accept a size and a
comparator to allow them to be used for a variety of purposes.
The new trees replace the AVL trees used in the range trees today.
Currently, the range_seg_t structure contains three 8 byte integers
of payload and two 24 byte avl_tree_node_ts to handle its storage in
both an offset-sorted tree and a size-sorted tree (total size: 64
bytes). In the new model, the range seg structures are usually two 4
byte integers, but a separate one needs to exist for the size-sorted
and offset-sorted tree. Between the raw size, the 50% overhead, and
the double storage, the new btrees are expected to use 8*1.5*2 = 24
bytes per record, or 33.3% as much memory as the AVL trees (this is
for the purposes of storing metaslab range trees; for other purposes,
like scrubs, they use ~50% as much memory).
We reduced the size of the payload in the range segments by teaching
range trees about starting offsets and shifts; since metaslabs have a
fixed starting offset, and they all operate in terms of disk sectors,
we can store the ranges using 4-byte integers as long as the size of
the metaslab divided by the sector size is less than 2^32. For 512-byte
sectors, this is a 2^41 (or 2TB) metaslab, which with the default
settings corresponds to a 256PB disk. 4k sector disks can handle
metaslabs up to 2^46 bytes, or 2^63 byte disks. Since we do not
anticipate disks of this size in the near future, there should be
almost no cases where metaslabs need 64-byte integers to store their
ranges. We do still have the capability to store 64-byte integer ranges
to account for cases where we are storing per-vdev (or per-dnode) trees,
which could reasonably go above the limits discussed. We also do not
store fill information in the compact version of the node, since it
is only used for sorted scrub.
We also optimized the metaslab loading process in various other ways
to offset some inefficiencies in the btree model. While individual
operations (find, insert, remove_from) are faster for the btree than
they are for the avl tree, remove usually requires a find operation,
while in the AVL tree model the element itself suffices. Some clever
changes actually caused an overall speedup in metaslab loading; we use
approximately 40% less cpu to load metaslabs in our tests on Illumos.
Another memory and performance optimization was achieved by changing
what is stored in the size-sorted trees. When a disk is heavily
fragmented, the df algorithm used by default in ZFS will almost always
find a number of small regions in its initial cursor-based search; it
will usually only fall back to the size-sorted tree to find larger
regions. If we increase the size of the cursor-based search slightly,
and don't store segments that are smaller than a tunable size floor
in the size-sorted tree, we can further cut memory usage down to
below 20% of what the AVL trees store. This also results in further
reductions in CPU time spent loading metaslabs.
The 16KiB size floor was chosen because it results in substantial memory
usage reduction while not usually resulting in situations where we can't
find an appropriate chunk with the cursor and are forced to use an
oversized chunk from the size-sorted tree. In addition, even if we do
have to use an oversized chunk from the size-sorted tree, the chunk
would be too small to use for ZIL allocations, so it isn't as big of a
loss as it might otherwise be. And often, more small allocations will
follow the initial one, and the cursor search will now find the
remainder of the chunk we didn't use all of and use it for subsequent
allocations. Practical testing has shown little or no change in
fragmentation as a result of this change.
If the size-sorted tree becomes empty while the offset sorted one still
has entries, it will load all the entries from the offset sorted tree
and disregard the size floor until it is unloaded again. This operation
occurs rarely with the default setting, only on incredibly thoroughly
fragmented pools.
There are some other small changes to zdb to teach it to handle btrees,
but nothing major.
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Sebastien Roy seb@delphix.com
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9181
2019-10-09 20:36:03 +03:00
|
|
|
return (range_tree_first(rt));
|
2022-06-24 19:50:37 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Try to continue previous extent if it is not completed yet. After
|
|
|
|
* shrink in scan_io_queue_gather() it may no longer be the best, but
|
|
|
|
* otherwise we leave shorter remnant every txg.
|
|
|
|
*/
|
|
|
|
uint64_t start;
|
2022-09-22 21:28:33 +03:00
|
|
|
uint64_t size = 1ULL << rt->rt_shift;
|
2022-06-24 19:50:37 +03:00
|
|
|
range_seg_t *addr_rs;
|
|
|
|
if (queue->q_last_ext_addr != -1) {
|
|
|
|
start = queue->q_last_ext_addr;
|
|
|
|
addr_rs = range_tree_find(rt, start, size);
|
|
|
|
if (addr_rs != NULL)
|
|
|
|
return (addr_rs);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
2022-06-24 19:50:37 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Nothing to continue, so find new best extent.
|
|
|
|
*/
|
|
|
|
uint64_t *v = zfs_btree_first(&queue->q_exts_by_size, NULL);
|
|
|
|
if (v == NULL)
|
|
|
|
return (NULL);
|
|
|
|
queue->q_last_ext_addr = start = *v << rt->rt_shift;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We need to get the original entry in the by_addr tree so we can
|
|
|
|
* modify it.
|
|
|
|
*/
|
|
|
|
addr_rs = range_tree_find(rt, start, size);
|
|
|
|
ASSERT3P(addr_rs, !=, NULL);
|
|
|
|
ASSERT3U(rs_get_start(addr_rs, rt), ==, start);
|
|
|
|
ASSERT3U(rs_get_end(addr_rs, rt), >, start);
|
|
|
|
return (addr_rs);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
scan_io_queues_run_one(void *arg)
|
|
|
|
{
|
|
|
|
dsl_scan_io_queue_t *queue = arg;
|
|
|
|
kmutex_t *q_lock = &queue->q_vd->vdev_scan_io_queue_lock;
|
|
|
|
boolean_t suspended = B_FALSE;
|
2022-06-16 00:25:08 +03:00
|
|
|
range_seg_t *rs;
|
|
|
|
scan_io_t *sio;
|
|
|
|
zio_t *zio;
|
2017-11-16 04:27:01 +03:00
|
|
|
list_t sio_list;
|
|
|
|
|
|
|
|
ASSERT(queue->q_scn->scn_is_sorted);
|
|
|
|
|
|
|
|
list_create(&sio_list, sizeof (scan_io_t),
|
|
|
|
offsetof(scan_io_t, sio_nodes.sio_list_node));
|
2022-06-16 00:25:08 +03:00
|
|
|
zio = zio_null(queue->q_scn->scn_zio_root, queue->q_scn->scn_dp->dp_spa,
|
|
|
|
NULL, NULL, NULL, ZIO_FLAG_CANFAIL);
|
2017-11-16 04:27:01 +03:00
|
|
|
mutex_enter(q_lock);
|
2022-06-16 00:25:08 +03:00
|
|
|
queue->q_zio = zio;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
2021-05-27 19:11:39 +03:00
|
|
|
/* Calculate maximum in-flight bytes for this vdev. */
|
|
|
|
queue->q_maxinflight_bytes = MAX(1, zfs_scan_vdev_limit *
|
|
|
|
(vdev_get_ndisks(queue->q_vd) - vdev_get_nparity(queue->q_vd)));
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/* reset per-queue scan statistics for this txg */
|
|
|
|
queue->q_total_seg_size_this_txg = 0;
|
|
|
|
queue->q_segs_this_txg = 0;
|
|
|
|
queue->q_total_zio_size_this_txg = 0;
|
|
|
|
queue->q_zios_this_txg = 0;
|
|
|
|
|
|
|
|
/* loop until we run out of time or sios */
|
|
|
|
while ((rs = scan_io_queue_fetch_ext(queue)) != NULL) {
|
|
|
|
uint64_t seg_start = 0, seg_end = 0;
|
2022-06-24 19:50:37 +03:00
|
|
|
boolean_t more_left;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
ASSERT(list_is_empty(&sio_list));
|
|
|
|
|
|
|
|
/* loop while we still have sios left to process in this rs */
|
2022-06-24 19:50:37 +03:00
|
|
|
do {
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_io_t *first_sio, *last_sio;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We have selected which extent needs to be
|
|
|
|
* processed next. Gather up the corresponding sios.
|
|
|
|
*/
|
|
|
|
more_left = scan_io_queue_gather(queue, rs, &sio_list);
|
|
|
|
ASSERT(!list_is_empty(&sio_list));
|
|
|
|
first_sio = list_head(&sio_list);
|
|
|
|
last_sio = list_tail(&sio_list);
|
|
|
|
|
2019-03-16 00:14:31 +03:00
|
|
|
seg_end = SIO_GET_END_OFFSET(last_sio);
|
2017-11-16 04:27:01 +03:00
|
|
|
if (seg_start == 0)
|
2019-03-16 00:14:31 +03:00
|
|
|
seg_start = SIO_GET_OFFSET(first_sio);
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Issuing sios can take a long time so drop the
|
|
|
|
* queue lock. The sio queue won't be updated by
|
|
|
|
* other threads since we're in syncing context so
|
|
|
|
* we can be sure that our trees will remain exactly
|
|
|
|
* as we left them.
|
|
|
|
*/
|
|
|
|
mutex_exit(q_lock);
|
|
|
|
suspended = scan_io_queue_issue(queue, &sio_list);
|
|
|
|
mutex_enter(q_lock);
|
|
|
|
|
|
|
|
if (suspended)
|
|
|
|
break;
|
2022-06-24 19:50:37 +03:00
|
|
|
} while (more_left);
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/* update statistics for debugging purposes */
|
|
|
|
scan_io_queues_update_seg_stats(queue, seg_start, seg_end);
|
|
|
|
|
|
|
|
if (suspended)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we were suspended in the middle of processing,
|
|
|
|
* requeue any unfinished sios and exit.
|
|
|
|
*/
|
2023-06-09 20:12:52 +03:00
|
|
|
while ((sio = list_remove_head(&sio_list)) != NULL)
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_io_queue_insert_impl(queue, sio);
|
|
|
|
|
2022-06-16 00:25:08 +03:00
|
|
|
queue->q_zio = NULL;
|
2017-11-16 04:27:01 +03:00
|
|
|
mutex_exit(q_lock);
|
2022-06-16 00:25:08 +03:00
|
|
|
zio_nowait(zio);
|
2017-11-16 04:27:01 +03:00
|
|
|
list_destroy(&sio_list);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Performs an emptying run on all scan queues in the pool. This just
|
|
|
|
* punches out one thread per top-level vdev, each of which processes
|
|
|
|
* only that vdev's scan queue. We can parallelize the I/O here because
|
2018-03-29 04:30:44 +03:00
|
|
|
* we know that each queue's I/Os only affect its own top-level vdev.
|
2017-11-16 04:27:01 +03:00
|
|
|
*
|
|
|
|
* This function waits for the queue runs to complete, and must be
|
|
|
|
* called from dsl_scan_sync (or in general, syncing context).
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
scan_io_queues_run(dsl_scan_t *scn)
|
|
|
|
{
|
|
|
|
spa_t *spa = scn->scn_dp->dp_spa;
|
|
|
|
|
|
|
|
ASSERT(scn->scn_is_sorted);
|
|
|
|
ASSERT(spa_config_held(spa, SCL_CONFIG, RW_READER));
|
|
|
|
|
2022-06-24 19:50:37 +03:00
|
|
|
if (scn->scn_queues_pending == 0)
|
2017-11-16 04:27:01 +03:00
|
|
|
return;
|
|
|
|
|
|
|
|
if (scn->scn_taskq == NULL) {
|
|
|
|
int nthreads = spa->spa_root_vdev->vdev_children;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We need to make this taskq *always* execute as many
|
|
|
|
* threads in parallel as we have top-level vdevs and no
|
|
|
|
* less, otherwise strange serialization of the calls to
|
|
|
|
* scan_io_queues_run_one can occur during spa_sync runs
|
|
|
|
* and that significantly impacts performance.
|
|
|
|
*/
|
|
|
|
scn->scn_taskq = taskq_create("dsl_scan_iss", nthreads,
|
|
|
|
minclsyspri, nthreads, nthreads, TASKQ_PREPOPULATE);
|
|
|
|
}
|
|
|
|
|
|
|
|
for (uint64_t i = 0; i < spa->spa_root_vdev->vdev_children; i++) {
|
|
|
|
vdev_t *vd = spa->spa_root_vdev->vdev_child[i];
|
|
|
|
|
|
|
|
mutex_enter(&vd->vdev_scan_io_queue_lock);
|
|
|
|
if (vd->vdev_scan_io_queue != NULL) {
|
|
|
|
VERIFY(taskq_dispatch(scn->scn_taskq,
|
|
|
|
scan_io_queues_run_one, vd->vdev_scan_io_queue,
|
|
|
|
TQ_SLEEP) != TASKQID_INVALID);
|
|
|
|
}
|
|
|
|
mutex_exit(&vd->vdev_scan_io_queue_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2018-03-29 04:30:44 +03:00
|
|
|
* Wait for the queues to finish issuing their IOs for this run
|
2017-11-16 04:27:01 +03:00
|
|
|
* before we return. There may still be IOs in flight at this
|
|
|
|
* point.
|
|
|
|
*/
|
|
|
|
taskq_wait(scn->scn_taskq);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2012-12-14 03:24:15 +04:00
|
|
|
static boolean_t
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
dsl_scan_async_block_should_pause(dsl_scan_t *scn)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
|
|
|
uint64_t elapsed_nanosecs;
|
|
|
|
|
2013-08-12 20:53:33 +04:00
|
|
|
if (zfs_recover)
|
|
|
|
return (B_FALSE);
|
|
|
|
|
2019-05-29 00:14:23 +03:00
|
|
|
if (zfs_async_block_max_blocks != 0 &&
|
|
|
|
scn->scn_visited_this_txg >= zfs_async_block_max_blocks) {
|
2014-09-07 19:06:08 +04:00
|
|
|
return (B_TRUE);
|
2019-05-29 00:14:23 +03:00
|
|
|
}
|
2014-09-07 19:06:08 +04:00
|
|
|
|
Remove limit on number of async zio_frees of non-dedup blocks
The module parameter zfs_async_block_max_blocks limits the number of
blocks that can be freed by the background freeing of filesystems and
snapshots (from "zfs destroy"), in one TXG. This is useful when freeing
dedup blocks, becuase each zio_free() of a dedup block can require an
i/o to read the relevant part of the dedup table (DDT), and will also
dirty that block.
zfs_async_block_max_blocks is set to 100,000 by default. For the more
typical case where dedup is not used, this can have a negative
performance impact on the rate of background freeing (from "zfs
destroy"). For example, with recordsize=8k, and TXG's syncing once
every 5 seconds, we can free only 160MB of data per second, which may be
much less than the rate we can write data.
This change increases zfs_async_block_max_blocks to be unlimited by
default. To address the dedup freeing issue, a new tunable is
introduced, zfs_max_async_dedup_frees, which limits the number of
zio_free()'s of dedup blocks done by background destroys, per txg. The
default is 100,000 free's (same as the old zfs_async_block_max_blocks
default).
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #10000
2020-02-14 19:39:46 +03:00
|
|
|
if (zfs_max_async_dedup_frees != 0 &&
|
|
|
|
scn->scn_dedup_frees_this_txg >= zfs_max_async_dedup_frees) {
|
|
|
|
return (B_TRUE);
|
|
|
|
}
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
elapsed_nanosecs = gethrtime() - scn->scn_sync_start_time;
|
2012-12-14 03:24:15 +04:00
|
|
|
return (elapsed_nanosecs / NANOSEC > zfs_txg_timeout ||
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
(NSEC2MSEC(elapsed_nanosecs) > scn->scn_async_block_min_time_ms &&
|
2010-05-29 00:45:14 +04:00
|
|
|
txg_sync_waiting(scn->scn_dp)) ||
|
2012-12-14 03:24:15 +04:00
|
|
|
spa_shutting_down(scn->scn_dp->dp_spa));
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
dsl_scan_free_block_cb(void *arg, const blkptr_t *bp, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
dsl_scan_t *scn = arg;
|
|
|
|
|
|
|
|
if (!scn->scn_is_bptree ||
|
|
|
|
(BP_GET_LEVEL(bp) == 0 && BP_GET_TYPE(bp) != DMU_OT_OBJSET)) {
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
if (dsl_scan_async_block_should_pause(scn))
|
2013-03-08 22:41:28 +04:00
|
|
|
return (SET_ERROR(ERESTART));
|
2012-12-14 03:24:15 +04:00
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
zio_nowait(zio_free_sync(scn->scn_zio_root, scn->scn_dp->dp_spa,
|
|
|
|
dmu_tx_get_txg(tx), bp, 0));
|
|
|
|
dsl_dir_diduse_space(tx->tx_pool->dp_free_dir, DD_USED_HEAD,
|
|
|
|
-bp_get_dsize_sync(scn->scn_dp->dp_spa, bp),
|
|
|
|
-BP_GET_PSIZE(bp), -BP_GET_UCSIZE(bp), tx);
|
|
|
|
scn->scn_visited_this_txg++;
|
Remove limit on number of async zio_frees of non-dedup blocks
The module parameter zfs_async_block_max_blocks limits the number of
blocks that can be freed by the background freeing of filesystems and
snapshots (from "zfs destroy"), in one TXG. This is useful when freeing
dedup blocks, becuase each zio_free() of a dedup block can require an
i/o to read the relevant part of the dedup table (DDT), and will also
dirty that block.
zfs_async_block_max_blocks is set to 100,000 by default. For the more
typical case where dedup is not used, this can have a negative
performance impact on the rate of background freeing (from "zfs
destroy"). For example, with recordsize=8k, and TXG's syncing once
every 5 seconds, we can free only 160MB of data per second, which may be
much less than the rate we can write data.
This change increases zfs_async_block_max_blocks to be unlimited by
default. To address the dedup freeing issue, a new tunable is
introduced, zfs_max_async_dedup_frees, which limits the number of
zio_free()'s of dedup blocks done by background destroys, per txg. The
default is 100,000 free's (same as the old zfs_async_block_max_blocks
default).
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #10000
2020-02-14 19:39:46 +03:00
|
|
|
if (BP_GET_DEDUP(bp))
|
|
|
|
scn->scn_dedup_frees_this_txg++;
|
2010-05-29 00:45:14 +04:00
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static void
|
|
|
|
dsl_scan_update_stats(dsl_scan_t *scn)
|
|
|
|
{
|
|
|
|
spa_t *spa = scn->scn_dp->dp_spa;
|
|
|
|
uint64_t i;
|
|
|
|
uint64_t seg_size_total = 0, zio_size_total = 0;
|
|
|
|
uint64_t seg_count_total = 0, zio_count_total = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < spa->spa_root_vdev->vdev_children; i++) {
|
|
|
|
vdev_t *vd = spa->spa_root_vdev->vdev_child[i];
|
|
|
|
dsl_scan_io_queue_t *queue = vd->vdev_scan_io_queue;
|
|
|
|
|
|
|
|
if (queue == NULL)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
seg_size_total += queue->q_total_seg_size_this_txg;
|
|
|
|
zio_size_total += queue->q_total_zio_size_this_txg;
|
|
|
|
seg_count_total += queue->q_segs_this_txg;
|
|
|
|
zio_count_total += queue->q_zios_this_txg;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (seg_count_total == 0 || zio_count_total == 0) {
|
|
|
|
scn->scn_avg_seg_size_this_txg = 0;
|
|
|
|
scn->scn_avg_zio_size_this_txg = 0;
|
|
|
|
scn->scn_segs_this_txg = 0;
|
|
|
|
scn->scn_zios_this_txg = 0;
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
scn->scn_avg_seg_size_this_txg = seg_size_total / seg_count_total;
|
|
|
|
scn->scn_avg_zio_size_this_txg = zio_size_total / zio_count_total;
|
|
|
|
scn->scn_segs_this_txg = seg_count_total;
|
|
|
|
scn->scn_zios_this_txg = zio_count_total;
|
|
|
|
}
|
|
|
|
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
static int
|
2019-07-26 20:54:14 +03:00
|
|
|
bpobj_dsl_scan_free_block_cb(void *arg, const blkptr_t *bp, boolean_t bp_freed,
|
|
|
|
dmu_tx_t *tx)
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
{
|
2019-07-26 20:54:14 +03:00
|
|
|
ASSERT(!bp_freed);
|
|
|
|
return (dsl_scan_free_block_cb(arg, bp, tx));
|
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
|
|
dsl_scan_obsolete_block_cb(void *arg, const blkptr_t *bp, boolean_t bp_freed,
|
|
|
|
dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
ASSERT(!bp_freed);
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
dsl_scan_t *scn = arg;
|
|
|
|
const dva_t *dva = &bp->blk_dva[0];
|
|
|
|
|
|
|
|
if (dsl_scan_async_block_should_pause(scn))
|
|
|
|
return (SET_ERROR(ERESTART));
|
|
|
|
|
|
|
|
spa_vdev_indirect_mark_obsolete(scn->scn_dp->dp_spa,
|
|
|
|
DVA_GET_VDEV(dva), DVA_GET_OFFSET(dva),
|
|
|
|
DVA_GET_ASIZE(dva), tx);
|
|
|
|
scn->scn_visited_this_txg++;
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
boolean_t
|
|
|
|
dsl_scan_active(dsl_scan_t *scn)
|
|
|
|
{
|
|
|
|
spa_t *spa = scn->scn_dp->dp_spa;
|
|
|
|
uint64_t used = 0, comp, uncomp;
|
2019-07-26 20:54:14 +03:00
|
|
|
boolean_t clones_left;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
if (spa->spa_load_state != SPA_LOAD_NONE)
|
|
|
|
return (B_FALSE);
|
|
|
|
if (spa_shutting_down(spa))
|
|
|
|
return (B_FALSE);
|
2017-11-16 04:27:01 +03:00
|
|
|
if ((dsl_scan_is_running(scn) && !dsl_scan_is_paused_scrub(scn)) ||
|
2014-06-06 01:20:08 +04:00
|
|
|
(scn->scn_async_destroying && !scn->scn_async_stalled))
|
2010-05-29 00:45:14 +04:00
|
|
|
return (B_TRUE);
|
|
|
|
|
|
|
|
if (spa_version(scn->scn_dp->dp_spa) >= SPA_VERSION_DEADLISTS) {
|
|
|
|
(void) bpobj_space(&scn->scn_dp->dp_free_bpobj,
|
|
|
|
&used, &comp, &uncomp);
|
|
|
|
}
|
2019-07-26 20:54:14 +03:00
|
|
|
clones_left = spa_livelist_delete_check(spa);
|
|
|
|
return ((used != 0) || (clones_left));
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2021-12-17 23:35:28 +03:00
|
|
|
boolean_t
|
|
|
|
dsl_errorscrub_active(dsl_scan_t *scn)
|
|
|
|
{
|
|
|
|
spa_t *spa = scn->scn_dp->dp_spa;
|
|
|
|
if (spa->spa_load_state != SPA_LOAD_NONE)
|
|
|
|
return (B_FALSE);
|
|
|
|
if (spa_shutting_down(spa))
|
|
|
|
return (B_FALSE);
|
|
|
|
if (dsl_errorscrubbing(scn->scn_dp))
|
|
|
|
return (B_TRUE);
|
|
|
|
return (B_FALSE);
|
|
|
|
}
|
|
|
|
|
2018-10-19 07:06:18 +03:00
|
|
|
static boolean_t
|
|
|
|
dsl_scan_check_deferred(vdev_t *vd)
|
|
|
|
{
|
|
|
|
boolean_t need_resilver = B_FALSE;
|
|
|
|
|
|
|
|
for (int c = 0; c < vd->vdev_children; c++) {
|
|
|
|
need_resilver |=
|
|
|
|
dsl_scan_check_deferred(vd->vdev_child[c]);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!vdev_is_concrete(vd) || vd->vdev_aux ||
|
|
|
|
!vd->vdev_ops->vdev_op_leaf)
|
|
|
|
return (need_resilver);
|
|
|
|
|
|
|
|
if (!vd->vdev_resilver_deferred)
|
|
|
|
need_resilver = B_TRUE;
|
|
|
|
|
|
|
|
return (need_resilver);
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static boolean_t
|
|
|
|
dsl_scan_need_resilver(spa_t *spa, const dva_t *dva, size_t psize,
|
|
|
|
uint64_t phys_birth)
|
|
|
|
{
|
|
|
|
vdev_t *vd;
|
|
|
|
|
OpenZFS 9290 - device removal reduces redundancy of mirrors
Mirrors are supposed to provide redundancy in the face of whole-disk
failure and silent damage (e.g. some data on disk is not right, but ZFS
hasn't detected the whole device as being broken). However, the current
device removal implementation bypasses some of the mirror's redundancy.
Note that in no case is incorrect data returned, but we might get a
checksum error when we should have been able to find the right data.
There are two underlying problems:
1. When we remove a mirror device, we only read one side of the mirror.
Since we can't verify the checksum, this side may be silently bad, but
the good data is on the other side of the mirror (which we didn't read).
This can cause the removal to "bake in" the busted data – all copies of
the data in the new location are the same, busted version, while we left
the good version behind.
The fix for this is to read and copy both sides of the mirror. If the
old and new vdevs are mirrors, we will read both sides of the old
mirror, and write each copy to the corresponding side of the new mirror.
(If the old and new vdevs have a different number of children, we will
do this as best as possible.) Even though we aren't verifying checksums,
this ensures that as long as there's a good copy of the data, we'll have
a good copy after the removal, even if there's silent damage to one side
of the mirror. If we're removing a mirror that has some silent damage,
we'll have exactly the same damage in the new location (assuming that
the new location is also a mirror).
2. When we read from an indirect vdev that points to a mirror vdev, we
only consider one copy of the data. This can lead to reduced effective
redundancy, because we might read a bad copy of the data from one side
of the mirror, and not retry the other, good side of the mirror.
Note that the problem is not with the removal process, but rather after
the removal has completed (having copied correct data to both sides of
the mirror), if one side of the new mirror is silently damaged, we
encounter the problem when reading the relocated data via the indirect
vdev. Also note that the problem doesn't occur when ZFS knows that one
side of the mirror is bad, e.g. when a disk entirely fails or is
offlined.
The impact is that reads (from indirect vdevs that point to mirrors) may
return a checksum error even though the good data exists on one side of
the mirror, and scrub doesn't repair all data on the mirror (if some of
it is pointed to via an indirect vdev).
The fix for this is complicated by "split blocks" - one logical block
may be split into two (or more) pieces with each piece moved to a
different new location. In this case we need to read all versions of
each split (one from each side of the mirror), and figure out which
combination of versions results in the correct checksum, and then repair
the incorrect versions.
This ensures that we supply the same redundancy whether you use device
removal or not. For example, if a mirror has small silent errors on all
of its children, we can still reconstruct the correct data, as long as
those errors are at sufficiently-separated offsets (specifically,
separated by the largest block size - default of 128KB, but up to 16MB).
Porting notes:
* A new indirect vdev check was moved from dsl_scan_needs_resilver_cb()
to dsl_scan_needs_resilver(), which was added to ZoL as part of the
sequential scrub work.
* Passed NULL for zfs_ereport_post_checksum()'s zbookmark_phys_t
parameter. The extra parameter is unique to ZoL.
* When posting indirect checksum errors the ABD can be passed directly,
zfs_ereport_post_checksum() is not yet ABD-aware in OpenZFS.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Ported-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://illumos.org/issues/9290
OpenZFS-commit: https://github.com/openzfs/openzfs/pull/591
Closes #6900
2018-02-13 22:37:56 +03:00
|
|
|
vd = vdev_lookup_top(spa, DVA_GET_VDEV(dva));
|
|
|
|
|
|
|
|
if (vd->vdev_ops == &vdev_indirect_ops) {
|
|
|
|
/*
|
|
|
|
* The indirect vdev can point to multiple
|
|
|
|
* vdevs. For simplicity, always create
|
|
|
|
* the resilver zio_t. zio_vdev_io_start()
|
|
|
|
* will bypass the child resilver i/o's if
|
|
|
|
* they are on vdevs that don't have DTL's.
|
|
|
|
*/
|
|
|
|
return (B_TRUE);
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
if (DVA_GET_GANG(dva)) {
|
|
|
|
/*
|
|
|
|
* Gang members may be spread across multiple
|
|
|
|
* vdevs, so the best estimate we have is the
|
|
|
|
* scrub range, which has already been checked.
|
|
|
|
* XXX -- it would be better to change our
|
|
|
|
* allocation policy to ensure that all
|
|
|
|
* gang members reside on the same vdev.
|
|
|
|
*/
|
|
|
|
return (B_TRUE);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Check if the top-level vdev must resilver this offset.
|
|
|
|
* When the offset does not intersect with a dirty leaf DTL
|
|
|
|
* then it may be possible to skip the resilver IO. The psize
|
|
|
|
* is provided instead of asize to simplify the check for RAIDZ.
|
|
|
|
*/
|
Distributed Spare (dRAID) Feature
This patch adds a new top-level vdev type called dRAID, which stands
for Distributed parity RAID. This pool configuration allows all dRAID
vdevs to participate when rebuilding to a distributed hot spare device.
This can substantially reduce the total time required to restore full
parity to pool with a failed device.
A dRAID pool can be created using the new top-level `draid` type.
Like `raidz`, the desired redundancy is specified after the type:
`draid[1,2,3]`. No additional information is required to create the
pool and reasonable default values will be chosen based on the number
of child vdevs in the dRAID vdev.
zpool create <pool> draid[1,2,3] <vdevs...>
Unlike raidz, additional optional dRAID configuration values can be
provided as part of the draid type as colon separated values. This
allows administrators to fully specify a layout for either performance
or capacity reasons. The supported options include:
zpool create <pool> \
draid[<parity>][:<data>d][:<children>c][:<spares>s] \
<vdevs...>
- draid[parity] - Parity level (default 1)
- draid[:<data>d] - Data devices per group (default 8)
- draid[:<children>c] - Expected number of child vdevs
- draid[:<spares>s] - Distributed hot spares (default 0)
Abbreviated example `zpool status` output for a 68 disk dRAID pool
with two distributed spares using special allocation classes.
```
pool: tank
state: ONLINE
config:
NAME STATE READ WRITE CKSUM
slag7 ONLINE 0 0 0
draid2:8d:68c:2s-0 ONLINE 0 0 0
L0 ONLINE 0 0 0
L1 ONLINE 0 0 0
...
U25 ONLINE 0 0 0
U26 ONLINE 0 0 0
spare-53 ONLINE 0 0 0
U27 ONLINE 0 0 0
draid2-0-0 ONLINE 0 0 0
U28 ONLINE 0 0 0
U29 ONLINE 0 0 0
...
U42 ONLINE 0 0 0
U43 ONLINE 0 0 0
special
mirror-1 ONLINE 0 0 0
L5 ONLINE 0 0 0
U5 ONLINE 0 0 0
mirror-2 ONLINE 0 0 0
L6 ONLINE 0 0 0
U6 ONLINE 0 0 0
spares
draid2-0-0 INUSE currently in use
draid2-0-1 AVAIL
```
When adding test coverage for the new dRAID vdev type the following
options were added to the ztest command. These options are leverages
by zloop.sh to test a wide range of dRAID configurations.
-K draid|raidz|random - kind of RAID to test
-D <value> - dRAID data drives per group
-S <value> - dRAID distributed hot spares
-R <value> - RAID parity (raidz or dRAID)
The zpool_create, zpool_import, redundancy, replacement and fault
test groups have all been updated provide test coverage for the
dRAID feature.
Co-authored-by: Isaac Huang <he.huang@intel.com>
Co-authored-by: Mark Maybee <mmaybee@cray.com>
Co-authored-by: Don Brady <don.brady@delphix.com>
Co-authored-by: Matthew Ahrens <mahrens@delphix.com>
Co-authored-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Mark Maybee <mmaybee@cray.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #10102
2020-11-14 00:51:51 +03:00
|
|
|
if (!vdev_dtl_need_resilver(vd, dva, psize, phys_birth))
|
2017-11-16 04:27:01 +03:00
|
|
|
return (B_FALSE);
|
|
|
|
|
2018-10-19 07:06:18 +03:00
|
|
|
/*
|
|
|
|
* Check that this top-level vdev has a device under it which
|
|
|
|
* is resilvering and is not deferred.
|
|
|
|
*/
|
|
|
|
if (!dsl_scan_check_deferred(vd))
|
|
|
|
return (B_FALSE);
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
return (B_TRUE);
|
|
|
|
}
|
|
|
|
|
2016-12-17 01:11:29 +03:00
|
|
|
static int
|
|
|
|
dsl_process_async_destroys(dsl_pool_t *dp, dmu_tx_t *tx)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
spa_t *spa = dp->dp_spa;
|
2016-12-17 01:11:29 +03:00
|
|
|
int err = 0;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2016-12-17 01:11:29 +03:00
|
|
|
if (spa_suspend_async_destroy(spa))
|
|
|
|
return (0);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2016-01-23 03:41:02 +03:00
|
|
|
if (zfs_free_bpobj_enabled &&
|
2017-11-16 04:27:01 +03:00
|
|
|
spa_version(spa) >= SPA_VERSION_DEADLISTS) {
|
2012-12-14 03:24:15 +04:00
|
|
|
scn->scn_is_bptree = B_FALSE;
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
scn->scn_async_block_min_time_ms = zfs_free_min_time_ms;
|
2017-11-16 04:27:01 +03:00
|
|
|
scn->scn_zio_root = zio_root(spa, NULL,
|
2010-05-29 00:45:14 +04:00
|
|
|
NULL, ZIO_FLAG_MUSTSUCCEED);
|
|
|
|
err = bpobj_iterate(&dp->dp_free_bpobj,
|
2019-07-26 20:54:14 +03:00
|
|
|
bpobj_dsl_scan_free_block_cb, scn, tx);
|
2017-11-16 04:27:01 +03:00
|
|
|
VERIFY0(zio_wait(scn->scn_zio_root));
|
|
|
|
scn->scn_zio_root = NULL;
|
2012-12-14 03:24:15 +04:00
|
|
|
|
2014-06-06 01:20:08 +04:00
|
|
|
if (err != 0 && err != ERESTART)
|
|
|
|
zfs_panic_recover("error %u from bpobj_iterate()", err);
|
|
|
|
}
|
2013-09-04 16:00:57 +04:00
|
|
|
|
2014-06-06 01:20:08 +04:00
|
|
|
if (err == 0 && spa_feature_is_active(spa, SPA_FEATURE_ASYNC_DESTROY)) {
|
|
|
|
ASSERT(scn->scn_async_destroying);
|
|
|
|
scn->scn_is_bptree = B_TRUE;
|
2017-11-16 04:27:01 +03:00
|
|
|
scn->scn_zio_root = zio_root(spa, NULL,
|
2014-06-06 01:20:08 +04:00
|
|
|
NULL, ZIO_FLAG_MUSTSUCCEED);
|
|
|
|
err = bptree_iterate(dp->dp_meta_objset,
|
|
|
|
dp->dp_bptree_obj, B_TRUE, dsl_scan_free_block_cb, scn, tx);
|
|
|
|
VERIFY0(zio_wait(scn->scn_zio_root));
|
2017-11-16 04:27:01 +03:00
|
|
|
scn->scn_zio_root = NULL;
|
2014-06-06 01:20:08 +04:00
|
|
|
|
|
|
|
if (err == EIO || err == ECKSUM) {
|
|
|
|
err = 0;
|
|
|
|
} else if (err != 0 && err != ERESTART) {
|
|
|
|
zfs_panic_recover("error %u from "
|
|
|
|
"traverse_dataset_destroyed()", err);
|
2012-12-14 03:24:15 +04:00
|
|
|
}
|
2014-06-06 01:20:08 +04:00
|
|
|
|
|
|
|
if (bptree_is_empty(dp->dp_meta_objset, dp->dp_bptree_obj)) {
|
|
|
|
/* finished; deactivate async destroy feature */
|
|
|
|
spa_feature_decr(spa, SPA_FEATURE_ASYNC_DESTROY, tx);
|
|
|
|
ASSERT(!spa_feature_is_active(spa,
|
|
|
|
SPA_FEATURE_ASYNC_DESTROY));
|
|
|
|
VERIFY0(zap_remove(dp->dp_meta_objset,
|
|
|
|
DMU_POOL_DIRECTORY_OBJECT,
|
|
|
|
DMU_POOL_BPTREE_OBJ, tx));
|
|
|
|
VERIFY0(bptree_free(dp->dp_meta_objset,
|
|
|
|
dp->dp_bptree_obj, tx));
|
|
|
|
dp->dp_bptree_obj = 0;
|
|
|
|
scn->scn_async_destroying = B_FALSE;
|
2015-07-11 03:19:41 +03:00
|
|
|
scn->scn_async_stalled = B_FALSE;
|
2014-10-16 06:23:27 +04:00
|
|
|
} else {
|
|
|
|
/*
|
2015-07-11 03:19:41 +03:00
|
|
|
* If we didn't make progress, mark the async
|
|
|
|
* destroy as stalled, so that we will not initiate
|
|
|
|
* a spa_sync() on its behalf. Note that we only
|
|
|
|
* check this if we are not finished, because if the
|
|
|
|
* bptree had no blocks for us to visit, we can
|
|
|
|
* finish without "making progress".
|
2014-10-16 06:23:27 +04:00
|
|
|
*/
|
|
|
|
scn->scn_async_stalled =
|
|
|
|
(scn->scn_visited_this_txg == 0);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2014-06-06 01:20:08 +04:00
|
|
|
}
|
|
|
|
if (scn->scn_visited_this_txg) {
|
|
|
|
zfs_dbgmsg("freed %llu blocks in %llums from "
|
2021-10-27 02:24:14 +03:00
|
|
|
"free_bpobj/bptree on %s in txg %llu; err=%u",
|
2014-06-06 01:20:08 +04:00
|
|
|
(longlong_t)scn->scn_visited_this_txg,
|
|
|
|
(longlong_t)
|
|
|
|
NSEC2MSEC(gethrtime() - scn->scn_sync_start_time),
|
2021-10-27 02:24:14 +03:00
|
|
|
spa->spa_name, (longlong_t)tx->tx_txg, err);
|
2014-06-06 01:20:08 +04:00
|
|
|
scn->scn_visited_this_txg = 0;
|
Remove limit on number of async zio_frees of non-dedup blocks
The module parameter zfs_async_block_max_blocks limits the number of
blocks that can be freed by the background freeing of filesystems and
snapshots (from "zfs destroy"), in one TXG. This is useful when freeing
dedup blocks, becuase each zio_free() of a dedup block can require an
i/o to read the relevant part of the dedup table (DDT), and will also
dirty that block.
zfs_async_block_max_blocks is set to 100,000 by default. For the more
typical case where dedup is not used, this can have a negative
performance impact on the rate of background freeing (from "zfs
destroy"). For example, with recordsize=8k, and TXG's syncing once
every 5 seconds, we can free only 160MB of data per second, which may be
much less than the rate we can write data.
This change increases zfs_async_block_max_blocks to be unlimited by
default. To address the dedup freeing issue, a new tunable is
introduced, zfs_max_async_dedup_frees, which limits the number of
zio_free()'s of dedup blocks done by background destroys, per txg. The
default is 100,000 free's (same as the old zfs_async_block_max_blocks
default).
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #10000
2020-02-14 19:39:46 +03:00
|
|
|
scn->scn_dedup_frees_this_txg = 0;
|
2014-06-06 01:20:08 +04:00
|
|
|
|
|
|
|
/*
|
2023-03-10 22:59:53 +03:00
|
|
|
* Write out changes to the DDT and the BRT that may be required
|
|
|
|
* as a result of the blocks freed. This ensures that the DDT
|
|
|
|
* and the BRT are clean when a scrub/resilver runs.
|
2014-06-06 01:20:08 +04:00
|
|
|
*/
|
|
|
|
ddt_sync(spa, tx->tx_txg);
|
2023-03-10 22:59:53 +03:00
|
|
|
brt_sync(spa, tx->tx_txg);
|
2014-06-06 01:20:08 +04:00
|
|
|
}
|
|
|
|
if (err != 0)
|
2016-12-17 01:11:29 +03:00
|
|
|
return (err);
|
2016-02-03 03:23:21 +03:00
|
|
|
if (dp->dp_free_dir != NULL && !scn->scn_async_destroying &&
|
|
|
|
zfs_free_leak_on_eio &&
|
2015-04-01 18:14:34 +03:00
|
|
|
(dsl_dir_phys(dp->dp_free_dir)->dd_used_bytes != 0 ||
|
|
|
|
dsl_dir_phys(dp->dp_free_dir)->dd_compressed_bytes != 0 ||
|
|
|
|
dsl_dir_phys(dp->dp_free_dir)->dd_uncompressed_bytes != 0)) {
|
2014-06-06 01:20:08 +04:00
|
|
|
/*
|
|
|
|
* We have finished background destroying, but there is still
|
|
|
|
* some space left in the dp_free_dir. Transfer this leaked
|
|
|
|
* space to the dp_leak_dir.
|
|
|
|
*/
|
|
|
|
if (dp->dp_leak_dir == NULL) {
|
|
|
|
rrw_enter(&dp->dp_config_rwlock, RW_WRITER, FTAG);
|
|
|
|
(void) dsl_dir_create_sync(dp, dp->dp_root_dir,
|
|
|
|
LEAK_DIR_NAME, tx);
|
|
|
|
VERIFY0(dsl_pool_open_special_dir(dp,
|
|
|
|
LEAK_DIR_NAME, &dp->dp_leak_dir));
|
|
|
|
rrw_exit(&dp->dp_config_rwlock, FTAG);
|
|
|
|
}
|
|
|
|
dsl_dir_diduse_space(dp->dp_leak_dir, DD_USED_HEAD,
|
2015-04-01 18:14:34 +03:00
|
|
|
dsl_dir_phys(dp->dp_free_dir)->dd_used_bytes,
|
|
|
|
dsl_dir_phys(dp->dp_free_dir)->dd_compressed_bytes,
|
|
|
|
dsl_dir_phys(dp->dp_free_dir)->dd_uncompressed_bytes, tx);
|
2014-06-06 01:20:08 +04:00
|
|
|
dsl_dir_diduse_space(dp->dp_free_dir, DD_USED_HEAD,
|
2015-04-01 18:14:34 +03:00
|
|
|
-dsl_dir_phys(dp->dp_free_dir)->dd_used_bytes,
|
|
|
|
-dsl_dir_phys(dp->dp_free_dir)->dd_compressed_bytes,
|
|
|
|
-dsl_dir_phys(dp->dp_free_dir)->dd_uncompressed_bytes, tx);
|
2014-06-06 01:20:08 +04:00
|
|
|
}
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
|
2019-07-26 20:54:14 +03:00
|
|
|
if (dp->dp_free_dir != NULL && !scn->scn_async_destroying &&
|
|
|
|
!spa_livelist_delete_check(spa)) {
|
2014-06-06 01:19:08 +04:00
|
|
|
/* finished; verify that space accounting went to zero */
|
2015-04-01 18:14:34 +03:00
|
|
|
ASSERT0(dsl_dir_phys(dp->dp_free_dir)->dd_used_bytes);
|
|
|
|
ASSERT0(dsl_dir_phys(dp->dp_free_dir)->dd_compressed_bytes);
|
|
|
|
ASSERT0(dsl_dir_phys(dp->dp_free_dir)->dd_uncompressed_bytes);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
Add subcommand to wait for background zfs activity to complete
Currently the best way to wait for the completion of a long-running
operation in a pool, like a scrub or device removal, is to poll 'zpool
status' and parse its output, which is neither efficient nor convenient.
This change adds a 'wait' subcommand to the zpool command. When invoked,
'zpool wait' will block until a specified type of background activity
completes. Currently, this subcommand can wait for any of the following:
- Scrubs or resilvers to complete
- Devices to initialized
- Devices to be replaced
- Devices to be removed
- Checkpoints to be discarded
- Background freeing to complete
For example, a scrub that is in progress could be waited for by running
zpool wait -t scrub <pool>
This also adds a -w flag to the attach, checkpoint, initialize, replace,
remove, and scrub subcommands. When used, this flag makes the operations
kicked off by these subcommands synchronous instead of asynchronous.
This functionality is implemented using a new ioctl. The type of
activity to wait for is provided as input to the ioctl, and the ioctl
blocks until all activity of that type has completed. An ioctl was used
over other methods of kernel-userspace communiction primarily for the
sake of portability.
Porting Notes:
This is ported from Delphix OS change DLPX-44432. The following changes
were made while porting:
- Added ZoL-style ioctl input declaration.
- Reorganized error handling in zpool_initialize in libzfs to integrate
better with changes made for TRIM support.
- Fixed check for whether a checkpoint discard is in progress.
Previously it also waited if the pool had a checkpoint, instead of
just if a checkpoint was being discarded.
- Exposed zfs_initialize_chunk_size as a ZoL-style tunable.
- Updated more existing tests to make use of new 'zpool wait'
functionality, tests that don't exist in Delphix OS.
- Used existing ZoL tunable zfs_scan_suspend_progress, together with
zinject, in place of a new tunable zfs_scan_max_blks_per_txg.
- Added support for a non-integral interval argument to zpool wait.
Future work:
ZoL has support for trimming devices, which Delphix OS does not. In the
future, 'zpool wait' could be extended to add the ability to wait for
trim operations to complete.
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: John Gallagher <john.gallagher@delphix.com>
Closes #9162
2019-09-14 04:09:06 +03:00
|
|
|
spa_notify_waiters(spa);
|
|
|
|
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
EQUIV(bpobj_is_open(&dp->dp_obsolete_bpobj),
|
|
|
|
0 == zap_contains(dp->dp_meta_objset, DMU_POOL_DIRECTORY_OBJECT,
|
|
|
|
DMU_POOL_OBSOLETE_BPOBJ));
|
|
|
|
if (err == 0 && bpobj_is_open(&dp->dp_obsolete_bpobj)) {
|
|
|
|
ASSERT(spa_feature_is_active(dp->dp_spa,
|
|
|
|
SPA_FEATURE_OBSOLETE_COUNTS));
|
|
|
|
|
|
|
|
scn->scn_is_bptree = B_FALSE;
|
|
|
|
scn->scn_async_block_min_time_ms = zfs_obsolete_min_time_ms;
|
|
|
|
err = bpobj_iterate(&dp->dp_obsolete_bpobj,
|
|
|
|
dsl_scan_obsolete_block_cb, scn, tx);
|
|
|
|
if (err != 0 && err != ERESTART)
|
|
|
|
zfs_panic_recover("error %u from bpobj_iterate()", err);
|
|
|
|
|
|
|
|
if (bpobj_is_empty(&dp->dp_obsolete_bpobj))
|
|
|
|
dsl_pool_destroy_obsolete_bpobj(dp, tx);
|
|
|
|
}
|
2016-12-17 01:11:29 +03:00
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
2021-12-17 23:35:28 +03:00
|
|
|
static void
|
|
|
|
name_to_bookmark(char *buf, zbookmark_phys_t *zb)
|
|
|
|
{
|
|
|
|
zb->zb_objset = zfs_strtonum(buf, &buf);
|
|
|
|
ASSERT(*buf == ':');
|
|
|
|
zb->zb_object = zfs_strtonum(buf + 1, &buf);
|
|
|
|
ASSERT(*buf == ':');
|
|
|
|
zb->zb_level = (int)zfs_strtonum(buf + 1, &buf);
|
|
|
|
ASSERT(*buf == ':');
|
|
|
|
zb->zb_blkid = zfs_strtonum(buf + 1, &buf);
|
|
|
|
ASSERT(*buf == '\0');
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
name_to_object(char *buf, uint64_t *obj)
|
|
|
|
{
|
|
|
|
*obj = zfs_strtonum(buf, &buf);
|
|
|
|
ASSERT(*buf == '\0');
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
read_by_block_level(dsl_scan_t *scn, zbookmark_phys_t zb)
|
|
|
|
{
|
|
|
|
dsl_pool_t *dp = scn->scn_dp;
|
|
|
|
dsl_dataset_t *ds;
|
|
|
|
objset_t *os;
|
|
|
|
if (dsl_dataset_hold_obj(dp, zb.zb_objset, FTAG, &ds) != 0)
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (dmu_objset_from_ds(ds, &os) != 0) {
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the key is not loaded dbuf_dnode_findbp() will error out with
|
|
|
|
* EACCES. However in that case dnode_hold() will eventually call
|
|
|
|
* dbuf_read()->zio_wait() which may call spa_log_error(). This will
|
|
|
|
* lead to a deadlock due to us holding the mutex spa_errlist_lock.
|
|
|
|
* Avoid this by checking here if the keys are loaded, if not return.
|
|
|
|
* If the keys are not loaded the head_errlog feature is meaningless
|
|
|
|
* as we cannot figure out the birth txg of the block pointer.
|
|
|
|
*/
|
|
|
|
if (dsl_dataset_get_keystatus(ds->ds_dir) ==
|
|
|
|
ZFS_KEYSTATUS_UNAVAILABLE) {
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
dnode_t *dn;
|
|
|
|
blkptr_t bp;
|
|
|
|
|
|
|
|
if (dnode_hold(os, zb.zb_object, FTAG, &dn) != 0) {
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
rw_enter(&dn->dn_struct_rwlock, RW_READER);
|
|
|
|
int error = dbuf_dnode_findbp(dn, zb.zb_level, zb.zb_blkid, &bp, NULL,
|
|
|
|
NULL);
|
|
|
|
|
|
|
|
if (error) {
|
|
|
|
rw_exit(&dn->dn_struct_rwlock);
|
|
|
|
dnode_rele(dn, FTAG);
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!error && BP_IS_HOLE(&bp)) {
|
|
|
|
rw_exit(&dn->dn_struct_rwlock);
|
|
|
|
dnode_rele(dn, FTAG);
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
int zio_flags = ZIO_FLAG_SCAN_THREAD | ZIO_FLAG_RAW |
|
|
|
|
ZIO_FLAG_CANFAIL | ZIO_FLAG_SCRUB;
|
|
|
|
|
|
|
|
/* If it's an intent log block, failure is expected. */
|
|
|
|
if (zb.zb_level == ZB_ZIL_LEVEL)
|
|
|
|
zio_flags |= ZIO_FLAG_SPECULATIVE;
|
|
|
|
|
|
|
|
ASSERT(!BP_IS_EMBEDDED(&bp));
|
|
|
|
scan_exec_io(dp, &bp, zio_flags, &zb, NULL);
|
|
|
|
rw_exit(&dn->dn_struct_rwlock);
|
|
|
|
dnode_rele(dn, FTAG);
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We keep track of the scrubbed error blocks in "count". This will be used
|
|
|
|
* when deciding whether we exceeded zfs_scrub_error_blocks_per_txg. This
|
|
|
|
* function is modelled after check_filesystem().
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
scrub_filesystem(spa_t *spa, uint64_t fs, zbookmark_err_phys_t *zep,
|
|
|
|
int *count)
|
|
|
|
{
|
|
|
|
dsl_dataset_t *ds;
|
|
|
|
dsl_pool_t *dp = spa->spa_dsl_pool;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
|
|
|
|
int error = dsl_dataset_hold_obj(dp, fs, FTAG, &ds);
|
|
|
|
if (error != 0)
|
|
|
|
return (error);
|
|
|
|
|
|
|
|
uint64_t latest_txg;
|
|
|
|
uint64_t txg_to_consider = spa->spa_syncing_txg;
|
|
|
|
boolean_t check_snapshot = B_TRUE;
|
|
|
|
|
|
|
|
error = find_birth_txg(ds, zep, &latest_txg);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If find_birth_txg() errors out, then err on the side of caution and
|
|
|
|
* proceed. In worst case scenario scrub all objects. If zep->zb_birth
|
|
|
|
* is 0 (e.g. in case of encryption with unloaded keys) also proceed to
|
|
|
|
* scrub all objects.
|
|
|
|
*/
|
|
|
|
if (error == 0 && zep->zb_birth == latest_txg) {
|
|
|
|
/* Block neither free nor re written. */
|
|
|
|
zbookmark_phys_t zb;
|
|
|
|
zep_to_zb(fs, zep, &zb);
|
|
|
|
scn->scn_zio_root = zio_root(spa, NULL, NULL,
|
|
|
|
ZIO_FLAG_CANFAIL);
|
|
|
|
/* We have already acquired the config lock for spa */
|
|
|
|
read_by_block_level(scn, zb);
|
|
|
|
|
|
|
|
(void) zio_wait(scn->scn_zio_root);
|
|
|
|
scn->scn_zio_root = NULL;
|
|
|
|
|
|
|
|
scn->errorscrub_phys.dep_examined++;
|
|
|
|
scn->errorscrub_phys.dep_to_examine--;
|
|
|
|
(*count)++;
|
|
|
|
if ((*count) == zfs_scrub_error_blocks_per_txg ||
|
|
|
|
dsl_error_scrub_check_suspend(scn, &zb)) {
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return (SET_ERROR(EFAULT));
|
|
|
|
}
|
|
|
|
|
|
|
|
check_snapshot = B_FALSE;
|
|
|
|
} else if (error == 0) {
|
|
|
|
txg_to_consider = latest_txg;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Retrieve the number of snapshots if the dataset is not a snapshot.
|
|
|
|
*/
|
|
|
|
uint64_t snap_count = 0;
|
|
|
|
if (dsl_dataset_phys(ds)->ds_snapnames_zapobj != 0) {
|
|
|
|
|
|
|
|
error = zap_count(spa->spa_meta_objset,
|
|
|
|
dsl_dataset_phys(ds)->ds_snapnames_zapobj, &snap_count);
|
|
|
|
|
|
|
|
if (error != 0) {
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return (error);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (snap_count == 0) {
|
|
|
|
/* Filesystem without snapshots. */
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
uint64_t snap_obj = dsl_dataset_phys(ds)->ds_prev_snap_obj;
|
|
|
|
uint64_t snap_obj_txg = dsl_dataset_phys(ds)->ds_prev_snap_txg;
|
|
|
|
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
|
|
|
|
/* Check only snapshots created from this file system. */
|
|
|
|
while (snap_obj != 0 && zep->zb_birth < snap_obj_txg &&
|
|
|
|
snap_obj_txg <= txg_to_consider) {
|
|
|
|
|
|
|
|
error = dsl_dataset_hold_obj(dp, snap_obj, FTAG, &ds);
|
|
|
|
if (error != 0)
|
|
|
|
return (error);
|
|
|
|
|
|
|
|
if (dsl_dir_phys(ds->ds_dir)->dd_head_dataset_obj != fs) {
|
|
|
|
snap_obj = dsl_dataset_phys(ds)->ds_prev_snap_obj;
|
|
|
|
snap_obj_txg = dsl_dataset_phys(ds)->ds_prev_snap_txg;
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
boolean_t affected = B_TRUE;
|
|
|
|
if (check_snapshot) {
|
|
|
|
uint64_t blk_txg;
|
|
|
|
error = find_birth_txg(ds, zep, &blk_txg);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Scrub the snapshot also when zb_birth == 0 or when
|
|
|
|
* find_birth_txg() returns an error.
|
|
|
|
*/
|
|
|
|
affected = (error == 0 && zep->zb_birth == blk_txg) ||
|
|
|
|
(error != 0) || (zep->zb_birth == 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Scrub snapshots. */
|
|
|
|
if (affected) {
|
|
|
|
zbookmark_phys_t zb;
|
|
|
|
zep_to_zb(snap_obj, zep, &zb);
|
|
|
|
scn->scn_zio_root = zio_root(spa, NULL, NULL,
|
|
|
|
ZIO_FLAG_CANFAIL);
|
|
|
|
/* We have already acquired the config lock for spa */
|
|
|
|
read_by_block_level(scn, zb);
|
|
|
|
|
|
|
|
(void) zio_wait(scn->scn_zio_root);
|
|
|
|
scn->scn_zio_root = NULL;
|
|
|
|
|
|
|
|
scn->errorscrub_phys.dep_examined++;
|
|
|
|
scn->errorscrub_phys.dep_to_examine--;
|
|
|
|
(*count)++;
|
|
|
|
if ((*count) == zfs_scrub_error_blocks_per_txg ||
|
|
|
|
dsl_error_scrub_check_suspend(scn, &zb)) {
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
return (EFAULT);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
snap_obj_txg = dsl_dataset_phys(ds)->ds_prev_snap_txg;
|
|
|
|
snap_obj = dsl_dataset_phys(ds)->ds_prev_snap_obj;
|
|
|
|
dsl_dataset_rele(ds, FTAG);
|
|
|
|
}
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
dsl_errorscrub_sync(dsl_pool_t *dp, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Only process scans in sync pass 1.
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (spa_sync_pass(spa) > 1)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the spa is shutting down, then stop scanning. This will
|
|
|
|
* ensure that the scan does not dirty any new data during the
|
|
|
|
* shutdown phase.
|
|
|
|
*/
|
|
|
|
if (spa_shutting_down(spa))
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (!dsl_errorscrub_active(scn) || dsl_errorscrub_is_paused(scn)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (dsl_scan_resilvering(scn->scn_dp)) {
|
|
|
|
/* cancel the error scrub if resilver started */
|
|
|
|
dsl_scan_cancel(scn->scn_dp);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
spa->spa_scrub_active = B_TRUE;
|
|
|
|
scn->scn_sync_start_time = gethrtime();
|
|
|
|
|
|
|
|
/*
|
|
|
|
* zfs_scan_suspend_progress can be set to disable scrub progress.
|
|
|
|
* See more detailed comment in dsl_scan_sync().
|
|
|
|
*/
|
|
|
|
if (zfs_scan_suspend_progress) {
|
|
|
|
uint64_t scan_time_ns = gethrtime() - scn->scn_sync_start_time;
|
|
|
|
int mintime = zfs_scrub_min_time_ms;
|
|
|
|
|
|
|
|
while (zfs_scan_suspend_progress &&
|
|
|
|
!txg_sync_waiting(scn->scn_dp) &&
|
|
|
|
!spa_shutting_down(scn->scn_dp->dp_spa) &&
|
|
|
|
NSEC2MSEC(scan_time_ns) < mintime) {
|
|
|
|
delay(hz);
|
|
|
|
scan_time_ns = gethrtime() - scn->scn_sync_start_time;
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
int i = 0;
|
|
|
|
zap_attribute_t *za;
|
|
|
|
zbookmark_phys_t *zb;
|
|
|
|
boolean_t limit_exceeded = B_FALSE;
|
|
|
|
|
|
|
|
za = kmem_zalloc(sizeof (zap_attribute_t), KM_SLEEP);
|
|
|
|
zb = kmem_zalloc(sizeof (zbookmark_phys_t), KM_SLEEP);
|
|
|
|
|
|
|
|
if (!spa_feature_is_enabled(spa, SPA_FEATURE_HEAD_ERRLOG)) {
|
|
|
|
for (; zap_cursor_retrieve(&scn->errorscrub_cursor, za) == 0;
|
|
|
|
zap_cursor_advance(&scn->errorscrub_cursor)) {
|
|
|
|
name_to_bookmark(za->za_name, zb);
|
|
|
|
|
|
|
|
scn->scn_zio_root = zio_root(dp->dp_spa, NULL,
|
|
|
|
NULL, ZIO_FLAG_CANFAIL);
|
|
|
|
dsl_pool_config_enter(dp, FTAG);
|
|
|
|
read_by_block_level(scn, *zb);
|
|
|
|
dsl_pool_config_exit(dp, FTAG);
|
|
|
|
|
|
|
|
(void) zio_wait(scn->scn_zio_root);
|
|
|
|
scn->scn_zio_root = NULL;
|
|
|
|
|
|
|
|
scn->errorscrub_phys.dep_examined += 1;
|
|
|
|
scn->errorscrub_phys.dep_to_examine -= 1;
|
|
|
|
i++;
|
|
|
|
if (i == zfs_scrub_error_blocks_per_txg ||
|
|
|
|
dsl_error_scrub_check_suspend(scn, zb)) {
|
|
|
|
limit_exceeded = B_TRUE;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!limit_exceeded)
|
|
|
|
dsl_errorscrub_done(scn, B_TRUE, tx);
|
|
|
|
|
|
|
|
dsl_errorscrub_sync_state(scn, tx);
|
|
|
|
kmem_free(za, sizeof (*za));
|
|
|
|
kmem_free(zb, sizeof (*zb));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
int error = 0;
|
|
|
|
for (; zap_cursor_retrieve(&scn->errorscrub_cursor, za) == 0;
|
|
|
|
zap_cursor_advance(&scn->errorscrub_cursor)) {
|
|
|
|
|
|
|
|
zap_cursor_t *head_ds_cursor;
|
|
|
|
zap_attribute_t *head_ds_attr;
|
|
|
|
zbookmark_err_phys_t head_ds_block;
|
|
|
|
|
|
|
|
head_ds_cursor = kmem_zalloc(sizeof (zap_cursor_t), KM_SLEEP);
|
|
|
|
head_ds_attr = kmem_zalloc(sizeof (zap_attribute_t), KM_SLEEP);
|
|
|
|
|
|
|
|
uint64_t head_ds_err_obj = za->za_first_integer;
|
|
|
|
uint64_t head_ds;
|
|
|
|
name_to_object(za->za_name, &head_ds);
|
|
|
|
boolean_t config_held = B_FALSE;
|
|
|
|
uint64_t top_affected_fs;
|
|
|
|
|
|
|
|
for (zap_cursor_init(head_ds_cursor, spa->spa_meta_objset,
|
|
|
|
head_ds_err_obj); zap_cursor_retrieve(head_ds_cursor,
|
|
|
|
head_ds_attr) == 0; zap_cursor_advance(head_ds_cursor)) {
|
|
|
|
|
|
|
|
name_to_errphys(head_ds_attr->za_name, &head_ds_block);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* In case we are called from spa_sync the pool
|
|
|
|
* config is already held.
|
|
|
|
*/
|
|
|
|
if (!dsl_pool_config_held(dp)) {
|
|
|
|
dsl_pool_config_enter(dp, FTAG);
|
|
|
|
config_held = B_TRUE;
|
|
|
|
}
|
|
|
|
|
|
|
|
error = find_top_affected_fs(spa,
|
|
|
|
head_ds, &head_ds_block, &top_affected_fs);
|
|
|
|
if (error)
|
|
|
|
break;
|
|
|
|
|
|
|
|
error = scrub_filesystem(spa, top_affected_fs,
|
|
|
|
&head_ds_block, &i);
|
|
|
|
|
|
|
|
if (error == SET_ERROR(EFAULT)) {
|
|
|
|
limit_exceeded = B_TRUE;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
zap_cursor_fini(head_ds_cursor);
|
|
|
|
kmem_free(head_ds_cursor, sizeof (*head_ds_cursor));
|
|
|
|
kmem_free(head_ds_attr, sizeof (*head_ds_attr));
|
|
|
|
|
|
|
|
if (config_held)
|
|
|
|
dsl_pool_config_exit(dp, FTAG);
|
|
|
|
}
|
|
|
|
|
|
|
|
kmem_free(za, sizeof (*za));
|
|
|
|
kmem_free(zb, sizeof (*zb));
|
|
|
|
if (!limit_exceeded)
|
|
|
|
dsl_errorscrub_done(scn, B_TRUE, tx);
|
|
|
|
|
|
|
|
dsl_errorscrub_sync_state(scn, tx);
|
|
|
|
}
|
|
|
|
|
2016-12-17 01:11:29 +03:00
|
|
|
/*
|
|
|
|
* This is the primary entry point for scans that is called from syncing
|
|
|
|
* context. Scans must happen entirely during syncing context so that we
|
2019-09-03 03:56:41 +03:00
|
|
|
* can guarantee that blocks we are currently scanning will not change out
|
2016-12-17 01:11:29 +03:00
|
|
|
* from under us. While a scan is active, this function controls how quickly
|
|
|
|
* transaction groups proceed, instead of the normal handling provided by
|
|
|
|
* txg_sync_thread().
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
dsl_scan_sync(dsl_pool_t *dp, dmu_tx_t *tx)
|
|
|
|
{
|
|
|
|
int err = 0;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
state_sync_type_t sync_type = SYNC_OPTIONAL;
|
|
|
|
|
2018-10-19 07:06:18 +03:00
|
|
|
if (spa->spa_resilver_deferred &&
|
|
|
|
!spa_feature_is_active(dp->dp_spa, SPA_FEATURE_RESILVER_DEFER))
|
|
|
|
spa_feature_incr(spa, SPA_FEATURE_RESILVER_DEFER, tx);
|
|
|
|
|
2016-12-17 01:11:29 +03:00
|
|
|
/*
|
|
|
|
* Check for scn_restart_txg before checking spa_load_state, so
|
|
|
|
* that we can restart an old-style scan while the pool is being
|
2018-10-19 07:06:18 +03:00
|
|
|
* imported (see dsl_scan_init). We also restart scans if there
|
|
|
|
* is a deferred resilver and the user has manually disabled
|
|
|
|
* deferred resilvers via the tunable.
|
2016-12-17 01:11:29 +03:00
|
|
|
*/
|
2018-10-19 07:06:18 +03:00
|
|
|
if (dsl_scan_restarting(scn, tx) ||
|
|
|
|
(spa->spa_resilver_deferred && zfs_resilver_disable_defer)) {
|
2016-12-17 01:11:29 +03:00
|
|
|
pool_scan_func_t func = POOL_SCAN_SCRUB;
|
|
|
|
dsl_scan_done(scn, B_FALSE, tx);
|
|
|
|
if (vdev_resilver_needed(spa->spa_root_vdev, NULL, NULL))
|
|
|
|
func = POOL_SCAN_RESILVER;
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("restarting scan func=%u on %s txg=%llu",
|
|
|
|
func, dp->dp_spa->spa_name, (longlong_t)tx->tx_txg);
|
2016-12-17 01:11:29 +03:00
|
|
|
dsl_scan_setup_sync(&func, tx);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Only process scans in sync pass 1.
|
|
|
|
*/
|
|
|
|
if (spa_sync_pass(spa) > 1)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the spa is shutting down, then stop scanning. This will
|
|
|
|
* ensure that the scan does not dirty any new data during the
|
|
|
|
* shutdown phase.
|
|
|
|
*/
|
|
|
|
if (spa_shutting_down(spa))
|
|
|
|
return;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the scan is inactive due to a stalled async destroy, try again.
|
|
|
|
*/
|
|
|
|
if (!scn->scn_async_stalled && !dsl_scan_active(scn))
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* reset scan statistics */
|
|
|
|
scn->scn_visited_this_txg = 0;
|
Remove limit on number of async zio_frees of non-dedup blocks
The module parameter zfs_async_block_max_blocks limits the number of
blocks that can be freed by the background freeing of filesystems and
snapshots (from "zfs destroy"), in one TXG. This is useful when freeing
dedup blocks, becuase each zio_free() of a dedup block can require an
i/o to read the relevant part of the dedup table (DDT), and will also
dirty that block.
zfs_async_block_max_blocks is set to 100,000 by default. For the more
typical case where dedup is not used, this can have a negative
performance impact on the rate of background freeing (from "zfs
destroy"). For example, with recordsize=8k, and TXG's syncing once
every 5 seconds, we can free only 160MB of data per second, which may be
much less than the rate we can write data.
This change increases zfs_async_block_max_blocks to be unlimited by
default. To address the dedup freeing issue, a new tunable is
introduced, zfs_max_async_dedup_frees, which limits the number of
zio_free()'s of dedup blocks done by background destroys, per txg. The
default is 100,000 free's (same as the old zfs_async_block_max_blocks
default).
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #10000
2020-02-14 19:39:46 +03:00
|
|
|
scn->scn_dedup_frees_this_txg = 0;
|
2016-12-17 01:11:29 +03:00
|
|
|
scn->scn_holes_this_txg = 0;
|
|
|
|
scn->scn_lt_min_this_txg = 0;
|
|
|
|
scn->scn_gt_max_this_txg = 0;
|
|
|
|
scn->scn_ddt_contained_this_txg = 0;
|
|
|
|
scn->scn_objsets_visited_this_txg = 0;
|
|
|
|
scn->scn_avg_seg_size_this_txg = 0;
|
|
|
|
scn->scn_segs_this_txg = 0;
|
|
|
|
scn->scn_avg_zio_size_this_txg = 0;
|
|
|
|
scn->scn_zios_this_txg = 0;
|
|
|
|
scn->scn_suspending = B_FALSE;
|
|
|
|
scn->scn_sync_start_time = gethrtime();
|
|
|
|
spa->spa_scrub_active = B_TRUE;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* First process the async destroys. If we suspend, don't do
|
|
|
|
* any scrubbing or resilvering. This ensures that there are no
|
|
|
|
* async destroys while we are scanning, so the scan code doesn't
|
|
|
|
* have to worry about traversing it. It is also faster to free the
|
|
|
|
* blocks than to scrub them.
|
|
|
|
*/
|
|
|
|
err = dsl_process_async_destroys(dp, tx);
|
|
|
|
if (err != 0)
|
|
|
|
return;
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
if (!dsl_scan_is_running(scn) || dsl_scan_is_paused_scrub(scn))
|
2010-05-29 00:45:14 +04:00
|
|
|
return;
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* Wait a few txgs after importing to begin scanning so that
|
|
|
|
* we can get the pool imported quickly.
|
|
|
|
*/
|
|
|
|
if (spa->spa_syncing_txg < spa->spa_first_txg + SCAN_IMPORT_WAIT_TXGS)
|
2013-08-08 00:16:22 +04:00
|
|
|
return;
|
|
|
|
|
2018-11-28 21:12:08 +03:00
|
|
|
/*
|
|
|
|
* zfs_scan_suspend_progress can be set to disable scan progress.
|
|
|
|
* We don't want to spin the txg_sync thread, so we add a delay
|
|
|
|
* here to simulate the time spent doing a scan. This is mostly
|
|
|
|
* useful for testing and debugging.
|
|
|
|
*/
|
|
|
|
if (zfs_scan_suspend_progress) {
|
|
|
|
uint64_t scan_time_ns = gethrtime() - scn->scn_sync_start_time;
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
uint_t mintime = (scn->scn_phys.scn_func ==
|
|
|
|
POOL_SCAN_RESILVER) ? zfs_resilver_min_time_ms :
|
|
|
|
zfs_scrub_min_time_ms;
|
2018-11-28 21:12:08 +03:00
|
|
|
|
|
|
|
while (zfs_scan_suspend_progress &&
|
|
|
|
!txg_sync_waiting(scn->scn_dp) &&
|
|
|
|
!spa_shutting_down(scn->scn_dp->dp_spa) &&
|
|
|
|
NSEC2MSEC(scan_time_ns) < mintime) {
|
|
|
|
delay(hz);
|
|
|
|
scan_time_ns = gethrtime() - scn->scn_sync_start_time;
|
|
|
|
}
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-01-25 22:28:54 +03:00
|
|
|
/*
|
|
|
|
* Disabled by default, set zfs_scan_report_txgs to report
|
|
|
|
* average performance over the last zfs_scan_report_txgs TXGs.
|
|
|
|
*/
|
Do not report bytes skipped by scan as issued.
Scan process may skip blocks based on their birth time, DVA, etc.
Traditionally those blocks were accounted as issued, that caused
reporting of hugely over-inflated numbers, having nothing to do
with actual disk I/O. This change utilizes never used field in
struct dsl_scan_phys to account such skipped bytes, allowing to
report how much data were actually scrubbed/resilvered and what
is the actual I/O speed. While formally it is an on-disk format
change, it should be compatible both ways, so should not need a
feature flag.
This should partially address the same issue as c85ac731a0e, but
from a different perspective, complementing it.
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Akash B <akash-b@hpe.com>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.
Closes #15007
2023-06-30 18:47:13 +03:00
|
|
|
if (zfs_scan_report_txgs != 0 &&
|
2023-01-25 22:28:54 +03:00
|
|
|
tx->tx_txg % zfs_scan_report_txgs == 0) {
|
|
|
|
scn->scn_issued_before_pass += spa->spa_scan_pass_issued;
|
|
|
|
spa_scan_stat_init(spa);
|
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* It is possible to switch from unsorted to sorted at any time,
|
|
|
|
* but afterwards the scan will remain sorted unless reloaded from
|
|
|
|
* a checkpoint after a reboot.
|
|
|
|
*/
|
|
|
|
if (!zfs_scan_legacy) {
|
|
|
|
scn->scn_is_sorted = B_TRUE;
|
|
|
|
if (scn->scn_last_checkpoint == 0)
|
|
|
|
scn->scn_last_checkpoint = ddi_get_lbolt();
|
|
|
|
}
|
2017-07-07 08:16:13 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* For sorted scans, determine what kind of work we will be doing
|
|
|
|
* this txg based on our memory limitations and whether or not we
|
|
|
|
* need to perform a checkpoint.
|
|
|
|
*/
|
|
|
|
if (scn->scn_is_sorted) {
|
|
|
|
/*
|
|
|
|
* If we are over our checkpoint interval, set scn_clearing
|
|
|
|
* so that we can begin checkpointing immediately. The
|
2018-03-29 04:30:44 +03:00
|
|
|
* checkpoint allows us to save a consistent bookmark
|
2017-11-16 04:27:01 +03:00
|
|
|
* representing how much data we have scrubbed so far.
|
|
|
|
* Otherwise, use the memory limit to determine if we should
|
|
|
|
* scan for metadata or start issue scrub IOs. We accumulate
|
|
|
|
* metadata until we hit our hard memory limit at which point
|
|
|
|
* we issue scrub IOs until we are at our soft memory limit.
|
|
|
|
*/
|
|
|
|
if (scn->scn_checkpointing ||
|
|
|
|
ddi_get_lbolt() - scn->scn_last_checkpoint >
|
|
|
|
SEC_TO_TICK(zfs_scan_checkpoint_intval)) {
|
|
|
|
if (!scn->scn_checkpointing)
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("begin scan checkpoint for %s",
|
|
|
|
spa->spa_name);
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
scn->scn_checkpointing = B_TRUE;
|
|
|
|
scn->scn_clearing = B_TRUE;
|
|
|
|
} else {
|
|
|
|
boolean_t should_clear = dsl_scan_should_clear(scn);
|
|
|
|
if (should_clear && !scn->scn_clearing) {
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("begin scan clearing for %s",
|
|
|
|
spa->spa_name);
|
2017-11-16 04:27:01 +03:00
|
|
|
scn->scn_clearing = B_TRUE;
|
|
|
|
} else if (!should_clear && scn->scn_clearing) {
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("finish scan clearing for %s",
|
|
|
|
spa->spa_name);
|
2017-11-16 04:27:01 +03:00
|
|
|
scn->scn_clearing = B_FALSE;
|
|
|
|
}
|
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
} else {
|
2017-11-16 04:27:01 +03:00
|
|
|
ASSERT0(scn->scn_checkpointing);
|
|
|
|
ASSERT0(scn->scn_clearing);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
if (!scn->scn_clearing && scn->scn_done_txg == 0) {
|
|
|
|
/* Need to scan metadata for more blocks to scrub */
|
|
|
|
dsl_scan_phys_t *scnp = &scn->scn_phys;
|
|
|
|
taskqid_t prefetch_tqid;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
2023-01-25 01:05:45 +03:00
|
|
|
* Calculate the max number of in-flight bytes for pool-wide
|
|
|
|
* scanning operations (minimum 1MB, maximum 1/4 of arc_c_max).
|
|
|
|
* Limits for the issuing phase are done per top-level vdev and
|
|
|
|
* are handled separately.
|
2017-11-16 04:27:01 +03:00
|
|
|
*/
|
2023-01-25 01:05:45 +03:00
|
|
|
scn->scn_maxinflight_bytes = MIN(arc_c_max / 4, MAX(1ULL << 20,
|
|
|
|
zfs_scan_vdev_limit * dsl_scan_count_data_disks(spa)));
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
if (scnp->scn_ddt_bookmark.ddb_class <=
|
|
|
|
scnp->scn_ddt_class_max) {
|
|
|
|
ASSERT(ZB_IS_ZERO(&scnp->scn_bookmark));
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("doing scan sync for %s txg %llu; "
|
2017-11-16 04:27:01 +03:00
|
|
|
"ddt bm=%llu/%llu/%llu/%llx",
|
2021-10-27 02:24:14 +03:00
|
|
|
spa->spa_name,
|
2017-11-16 04:27:01 +03:00
|
|
|
(longlong_t)tx->tx_txg,
|
|
|
|
(longlong_t)scnp->scn_ddt_bookmark.ddb_class,
|
|
|
|
(longlong_t)scnp->scn_ddt_bookmark.ddb_type,
|
|
|
|
(longlong_t)scnp->scn_ddt_bookmark.ddb_checksum,
|
|
|
|
(longlong_t)scnp->scn_ddt_bookmark.ddb_cursor);
|
|
|
|
} else {
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("doing scan sync for %s txg %llu; "
|
2017-11-16 04:27:01 +03:00
|
|
|
"bm=%llu/%llu/%llu/%llu",
|
2021-10-27 02:24:14 +03:00
|
|
|
spa->spa_name,
|
2017-11-16 04:27:01 +03:00
|
|
|
(longlong_t)tx->tx_txg,
|
|
|
|
(longlong_t)scnp->scn_bookmark.zb_objset,
|
|
|
|
(longlong_t)scnp->scn_bookmark.zb_object,
|
|
|
|
(longlong_t)scnp->scn_bookmark.zb_level,
|
|
|
|
(longlong_t)scnp->scn_bookmark.zb_blkid);
|
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
scn->scn_zio_root = zio_root(dp->dp_spa, NULL,
|
|
|
|
NULL, ZIO_FLAG_CANFAIL);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
scn->scn_prefetch_stop = B_FALSE;
|
|
|
|
prefetch_tqid = taskq_dispatch(dp->dp_sync_taskq,
|
|
|
|
dsl_scan_prefetch_thread, scn, TQ_SLEEP);
|
|
|
|
ASSERT(prefetch_tqid != TASKQID_INVALID);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_pool_config_enter(dp, FTAG);
|
|
|
|
dsl_scan_visit(scn, tx);
|
|
|
|
dsl_pool_config_exit(dp, FTAG);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
mutex_enter(&dp->dp_spa->spa_scrub_lock);
|
|
|
|
scn->scn_prefetch_stop = B_TRUE;
|
|
|
|
cv_broadcast(&spa->spa_scrub_io_cv);
|
|
|
|
mutex_exit(&dp->dp_spa->spa_scrub_lock);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
taskq_wait_id(dp->dp_sync_taskq, prefetch_tqid);
|
|
|
|
(void) zio_wait(scn->scn_zio_root);
|
|
|
|
scn->scn_zio_root = NULL;
|
|
|
|
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("scan visited %llu blocks of %s in %llums "
|
2017-11-16 04:27:01 +03:00
|
|
|
"(%llu os's, %llu holes, %llu < mintxg, "
|
|
|
|
"%llu in ddt, %llu > maxtxg)",
|
|
|
|
(longlong_t)scn->scn_visited_this_txg,
|
2021-10-27 02:24:14 +03:00
|
|
|
spa->spa_name,
|
2017-11-16 04:27:01 +03:00
|
|
|
(longlong_t)NSEC2MSEC(gethrtime() -
|
|
|
|
scn->scn_sync_start_time),
|
|
|
|
(longlong_t)scn->scn_objsets_visited_this_txg,
|
|
|
|
(longlong_t)scn->scn_holes_this_txg,
|
|
|
|
(longlong_t)scn->scn_lt_min_this_txg,
|
|
|
|
(longlong_t)scn->scn_ddt_contained_this_txg,
|
|
|
|
(longlong_t)scn->scn_gt_max_this_txg);
|
|
|
|
|
|
|
|
if (!scn->scn_suspending) {
|
|
|
|
ASSERT0(avl_numnodes(&scn->scn_queue));
|
|
|
|
scn->scn_done_txg = tx->tx_txg + 1;
|
|
|
|
if (scn->scn_is_sorted) {
|
|
|
|
scn->scn_checkpointing = B_TRUE;
|
|
|
|
scn->scn_clearing = B_TRUE;
|
2023-01-25 22:28:54 +03:00
|
|
|
scn->scn_issued_before_pass +=
|
|
|
|
spa->spa_scan_pass_issued;
|
|
|
|
spa_scan_stat_init(spa);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("scan complete for %s txg %llu",
|
|
|
|
spa->spa_name,
|
2017-11-16 04:27:01 +03:00
|
|
|
(longlong_t)tx->tx_txg);
|
|
|
|
}
|
2022-06-24 19:50:37 +03:00
|
|
|
} else if (scn->scn_is_sorted && scn->scn_queues_pending != 0) {
|
2018-10-18 11:13:07 +03:00
|
|
|
ASSERT(scn->scn_clearing);
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/* need to issue scrubbing IOs from per-vdev queues */
|
|
|
|
scn->scn_zio_root = zio_root(dp->dp_spa, NULL,
|
|
|
|
NULL, ZIO_FLAG_CANFAIL);
|
|
|
|
scan_io_queues_run(scn);
|
|
|
|
(void) zio_wait(scn->scn_zio_root);
|
|
|
|
scn->scn_zio_root = NULL;
|
|
|
|
|
|
|
|
/* calculate and dprintf the current memory usage */
|
|
|
|
(void) dsl_scan_should_clear(scn);
|
|
|
|
dsl_scan_update_stats(scn);
|
|
|
|
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("scan issued %llu blocks for %s (%llu segs) "
|
|
|
|
"in %llums (avg_block_size = %llu, avg_seg_size = %llu)",
|
2017-11-16 04:27:01 +03:00
|
|
|
(longlong_t)scn->scn_zios_this_txg,
|
2021-10-27 02:24:14 +03:00
|
|
|
spa->spa_name,
|
2017-11-16 04:27:01 +03:00
|
|
|
(longlong_t)scn->scn_segs_this_txg,
|
|
|
|
(longlong_t)NSEC2MSEC(gethrtime() -
|
|
|
|
scn->scn_sync_start_time),
|
|
|
|
(longlong_t)scn->scn_avg_zio_size_this_txg,
|
|
|
|
(longlong_t)scn->scn_avg_seg_size_this_txg);
|
|
|
|
} else if (scn->scn_done_txg != 0 && scn->scn_done_txg <= tx->tx_txg) {
|
|
|
|
/* Finished with everything. Mark the scrub as complete */
|
2021-10-27 02:24:14 +03:00
|
|
|
zfs_dbgmsg("scan issuing complete txg %llu for %s",
|
|
|
|
(longlong_t)tx->tx_txg,
|
|
|
|
spa->spa_name);
|
2017-11-16 04:27:01 +03:00
|
|
|
ASSERT3U(scn->scn_done_txg, !=, 0);
|
|
|
|
ASSERT0(spa->spa_scrub_inflight);
|
2022-06-24 19:50:37 +03:00
|
|
|
ASSERT0(scn->scn_queues_pending);
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_done(scn, B_TRUE, tx);
|
|
|
|
sync_type = SYNC_MANDATORY;
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_sync_state(scn, tx, sync_type);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2022-06-28 21:23:31 +03:00
|
|
|
count_block_issued(spa_t *spa, const blkptr_t *bp, boolean_t all)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2019-05-25 23:52:23 +03:00
|
|
|
/*
|
|
|
|
* Don't count embedded bp's, since we already did the work of
|
|
|
|
* scanning these when we scanned the containing block.
|
|
|
|
*/
|
|
|
|
if (BP_IS_EMBEDDED(bp))
|
|
|
|
return;
|
|
|
|
|
2019-03-16 00:14:31 +03:00
|
|
|
/*
|
|
|
|
* Update the spa's stats on how many bytes we have issued.
|
|
|
|
* Sequential scrubs create a zio for each DVA of the bp. Each
|
|
|
|
* of these will include all DVAs for repair purposes, but the
|
|
|
|
* zio code will only try the first one unless there is an issue.
|
|
|
|
* Therefore, we should only count the first DVA for these IOs.
|
|
|
|
*/
|
2022-06-28 21:23:31 +03:00
|
|
|
atomic_add_64(&spa->spa_scan_pass_issued,
|
|
|
|
all ? BP_GET_ASIZE(bp) : DVA_GET_ASIZE(&bp->blk_dva[0]));
|
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
|
Do not report bytes skipped by scan as issued.
Scan process may skip blocks based on their birth time, DVA, etc.
Traditionally those blocks were accounted as issued, that caused
reporting of hugely over-inflated numbers, having nothing to do
with actual disk I/O. This change utilizes never used field in
struct dsl_scan_phys to account such skipped bytes, allowing to
report how much data were actually scrubbed/resilvered and what
is the actual I/O speed. While formally it is an on-disk format
change, it should be compatible both ways, so should not need a
feature flag.
This should partially address the same issue as c85ac731a0e, but
from a different perspective, complementing it.
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Akash B <akash-b@hpe.com>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.
Closes #15007
2023-06-30 18:47:13 +03:00
|
|
|
static void
|
|
|
|
count_block_skipped(dsl_scan_t *scn, const blkptr_t *bp, boolean_t all)
|
|
|
|
{
|
|
|
|
if (BP_IS_EMBEDDED(bp))
|
|
|
|
return;
|
|
|
|
atomic_add_64(&scn->scn_phys.scn_skipped,
|
|
|
|
all ? BP_GET_ASIZE(bp) : DVA_GET_ASIZE(&bp->blk_dva[0]));
|
|
|
|
}
|
|
|
|
|
2022-06-28 21:23:31 +03:00
|
|
|
static void
|
|
|
|
count_block(zfs_all_blkstats_t *zab, const blkptr_t *bp)
|
|
|
|
{
|
2010-05-29 00:45:14 +04:00
|
|
|
/*
|
|
|
|
* If we resume after a reboot, zab will be NULL; don't record
|
|
|
|
* incomplete stats in that case.
|
|
|
|
*/
|
|
|
|
if (zab == NULL)
|
|
|
|
return;
|
|
|
|
|
2022-06-28 21:23:31 +03:00
|
|
|
for (int i = 0; i < 4; i++) {
|
2010-05-29 00:45:14 +04:00
|
|
|
int l = (i < 2) ? BP_GET_LEVEL(bp) : DN_MAX_LEVELS;
|
|
|
|
int t = (i & 1) ? BP_GET_TYPE(bp) : DMU_OT_TOTAL;
|
2012-12-14 03:24:15 +04:00
|
|
|
|
|
|
|
if (t & DMU_OT_NEWTYPE)
|
|
|
|
t = DMU_OT_OTHER;
|
2017-11-04 23:25:13 +03:00
|
|
|
zfs_blkstat_t *zb = &zab->zab_type[l][t];
|
|
|
|
int equal;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
zb->zb_count++;
|
|
|
|
zb->zb_asize += BP_GET_ASIZE(bp);
|
|
|
|
zb->zb_lsize += BP_GET_LSIZE(bp);
|
|
|
|
zb->zb_psize += BP_GET_PSIZE(bp);
|
|
|
|
zb->zb_gangs += BP_COUNT_GANG(bp);
|
|
|
|
|
|
|
|
switch (BP_GET_NDVAS(bp)) {
|
|
|
|
case 2:
|
|
|
|
if (DVA_GET_VDEV(&bp->blk_dva[0]) ==
|
|
|
|
DVA_GET_VDEV(&bp->blk_dva[1]))
|
|
|
|
zb->zb_ditto_2_of_2_samevdev++;
|
|
|
|
break;
|
|
|
|
case 3:
|
|
|
|
equal = (DVA_GET_VDEV(&bp->blk_dva[0]) ==
|
|
|
|
DVA_GET_VDEV(&bp->blk_dva[1])) +
|
|
|
|
(DVA_GET_VDEV(&bp->blk_dva[0]) ==
|
|
|
|
DVA_GET_VDEV(&bp->blk_dva[2])) +
|
|
|
|
(DVA_GET_VDEV(&bp->blk_dva[1]) ==
|
|
|
|
DVA_GET_VDEV(&bp->blk_dva[2]));
|
|
|
|
if (equal == 1)
|
|
|
|
zb->zb_ditto_2_of_3_samevdev++;
|
|
|
|
else if (equal == 3)
|
|
|
|
zb->zb_ditto_3_of_3_samevdev++;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_io_queue_insert_impl(dsl_scan_io_queue_t *queue, scan_io_t *sio)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
avl_index_t idx;
|
|
|
|
dsl_scan_t *scn = queue->q_scn;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
ASSERT(MUTEX_HELD(&queue->q_vd->vdev_scan_io_queue_lock));
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2022-06-24 19:50:37 +03:00
|
|
|
if (unlikely(avl_is_empty(&queue->q_sios_by_addr)))
|
|
|
|
atomic_add_64(&scn->scn_queues_pending, 1);
|
2017-11-16 04:27:01 +03:00
|
|
|
if (avl_find(&queue->q_sios_by_addr, sio, &idx) != NULL) {
|
|
|
|
/* block is already scheduled for reading */
|
2019-03-16 00:14:31 +03:00
|
|
|
sio_free(sio);
|
2017-11-16 04:27:01 +03:00
|
|
|
return;
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
avl_insert(&queue->q_sios_by_addr, sio, idx);
|
2019-03-16 00:14:31 +03:00
|
|
|
queue->q_sio_memused += SIO_GET_MUSED(sio);
|
2022-06-24 19:50:37 +03:00
|
|
|
range_tree_add(queue->q_exts_by_addr, SIO_GET_OFFSET(sio),
|
|
|
|
SIO_GET_ASIZE(sio));
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* Given all the info we got from our metadata scanning process, we
|
|
|
|
* construct a scan_io_t and insert it into the scan sorting queue. The
|
|
|
|
* I/O must already be suitable for us to process. This is controlled
|
|
|
|
* by dsl_scan_enqueue().
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
scan_io_queue_insert(dsl_scan_io_queue_t *queue, const blkptr_t *bp, int dva_i,
|
|
|
|
int zio_flags, const zbookmark_phys_t *zb)
|
2017-05-13 03:28:03 +03:00
|
|
|
{
|
2019-03-16 00:14:31 +03:00
|
|
|
scan_io_t *sio = sio_alloc(BP_GET_NDVAS(bp));
|
2017-05-13 03:28:03 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
ASSERT0(BP_IS_GANG(bp));
|
|
|
|
ASSERT(MUTEX_HELD(&queue->q_vd->vdev_scan_io_queue_lock));
|
2017-05-13 03:28:03 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
bp2sio(bp, sio, dva_i);
|
|
|
|
sio->sio_flags = zio_flags;
|
|
|
|
sio->sio_zb = *zb;
|
2017-05-13 03:28:03 +03:00
|
|
|
|
2022-06-24 19:50:37 +03:00
|
|
|
queue->q_last_ext_addr = -1;
|
2017-11-16 04:27:01 +03:00
|
|
|
scan_io_queue_insert_impl(queue, sio);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Given a set of I/O parameters as discovered by the metadata traversal
|
|
|
|
* process, attempts to place the I/O into the sorted queues (if allowed),
|
|
|
|
* or immediately executes the I/O.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
dsl_scan_enqueue(dsl_pool_t *dp, const blkptr_t *bp, int zio_flags,
|
|
|
|
const zbookmark_phys_t *zb)
|
|
|
|
{
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
|
|
|
|
ASSERT(!BP_IS_EMBEDDED(bp));
|
2017-05-13 03:28:03 +03:00
|
|
|
|
|
|
|
/*
|
2017-11-16 04:27:01 +03:00
|
|
|
* Gang blocks are hard to issue sequentially, so we just issue them
|
|
|
|
* here immediately instead of queuing them.
|
2017-05-13 03:28:03 +03:00
|
|
|
*/
|
2017-11-16 04:27:01 +03:00
|
|
|
if (!dp->dp_scan->scn_is_sorted || BP_IS_GANG(bp)) {
|
|
|
|
scan_exec_io(dp, bp, zio_flags, zb, NULL);
|
|
|
|
return;
|
|
|
|
}
|
2017-05-13 03:28:03 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
for (int i = 0; i < BP_GET_NDVAS(bp); i++) {
|
|
|
|
dva_t dva;
|
|
|
|
vdev_t *vdev;
|
|
|
|
|
|
|
|
dva = bp->blk_dva[i];
|
|
|
|
vdev = vdev_lookup_top(spa, DVA_GET_VDEV(&dva));
|
|
|
|
ASSERT(vdev != NULL);
|
|
|
|
|
|
|
|
mutex_enter(&vdev->vdev_scan_io_queue_lock);
|
|
|
|
if (vdev->vdev_scan_io_queue == NULL)
|
|
|
|
vdev->vdev_scan_io_queue = scan_io_queue_create(vdev);
|
|
|
|
ASSERT(dp->dp_scan != NULL);
|
|
|
|
scan_io_queue_insert(vdev->vdev_scan_io_queue, bp,
|
|
|
|
i, zio_flags, zb);
|
|
|
|
mutex_exit(&vdev->vdev_scan_io_queue_lock);
|
|
|
|
}
|
2017-05-13 03:28:03 +03:00
|
|
|
}
|
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
static int
|
|
|
|
dsl_scan_scrub_cb(dsl_pool_t *dp,
|
2014-06-25 22:37:59 +04:00
|
|
|
const blkptr_t *bp, const zbookmark_phys_t *zb)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
spa_t *spa = dp->dp_spa;
|
2024-03-26 01:01:54 +03:00
|
|
|
uint64_t phys_birth = BP_GET_BIRTH(bp);
|
2017-11-16 04:27:01 +03:00
|
|
|
size_t psize = BP_GET_PSIZE(bp);
|
2010-08-26 20:52:39 +04:00
|
|
|
boolean_t needs_io = B_FALSE;
|
2010-08-27 01:24:34 +04:00
|
|
|
int zio_flags = ZIO_FLAG_SCAN_THREAD | ZIO_FLAG_RAW | ZIO_FLAG_CANFAIL;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2022-06-28 21:23:31 +03:00
|
|
|
count_block(dp->dp_blkstats, bp);
|
2010-05-29 00:45:14 +04:00
|
|
|
if (phys_birth <= scn->scn_phys.scn_min_txg ||
|
2018-07-24 19:33:56 +03:00
|
|
|
phys_birth >= scn->scn_phys.scn_max_txg) {
|
Do not report bytes skipped by scan as issued.
Scan process may skip blocks based on their birth time, DVA, etc.
Traditionally those blocks were accounted as issued, that caused
reporting of hugely over-inflated numbers, having nothing to do
with actual disk I/O. This change utilizes never used field in
struct dsl_scan_phys to account such skipped bytes, allowing to
report how much data were actually scrubbed/resilvered and what
is the actual I/O speed. While formally it is an on-disk format
change, it should be compatible both ways, so should not need a
feature flag.
This should partially address the same issue as c85ac731a0e, but
from a different perspective, complementing it.
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Akash B <akash-b@hpe.com>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.
Closes #15007
2023-06-30 18:47:13 +03:00
|
|
|
count_block_skipped(scn, bp, B_TRUE);
|
2010-05-29 00:45:14 +04:00
|
|
|
return (0);
|
2018-07-24 19:33:56 +03:00
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-12-04 22:29:40 +03:00
|
|
|
/* Embedded BP's have phys_birth==0, so we reject them above. */
|
|
|
|
ASSERT(!BP_IS_EMBEDDED(bp));
|
2014-06-06 01:19:08 +04:00
|
|
|
|
2010-05-29 00:45:14 +04:00
|
|
|
ASSERT(DSL_SCAN_IS_SCRUB_RESILVER(scn));
|
|
|
|
if (scn->scn_phys.scn_func == POOL_SCAN_SCRUB) {
|
|
|
|
zio_flags |= ZIO_FLAG_SCRUB;
|
|
|
|
needs_io = B_TRUE;
|
2013-02-11 10:21:05 +04:00
|
|
|
} else {
|
|
|
|
ASSERT3U(scn->scn_phys.scn_func, ==, POOL_SCAN_RESILVER);
|
2010-05-29 00:45:14 +04:00
|
|
|
zio_flags |= ZIO_FLAG_RESILVER;
|
|
|
|
needs_io = B_FALSE;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* If it's an intent log block, failure is expected. */
|
|
|
|
if (zb->zb_level == ZB_ZIL_LEVEL)
|
|
|
|
zio_flags |= ZIO_FLAG_SPECULATIVE;
|
|
|
|
|
2017-11-04 23:25:13 +03:00
|
|
|
for (int d = 0; d < BP_GET_NDVAS(bp); d++) {
|
2017-05-13 03:28:03 +03:00
|
|
|
const dva_t *dva = &bp->blk_dva[d];
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Keep track of how much data we've examined so that
|
2020-10-30 18:55:59 +03:00
|
|
|
* zpool(8) status can make useful progress reports.
|
2010-05-29 00:45:14 +04:00
|
|
|
*/
|
2022-06-24 19:50:37 +03:00
|
|
|
uint64_t asize = DVA_GET_ASIZE(dva);
|
|
|
|
scn->scn_phys.scn_examined += asize;
|
|
|
|
spa->spa_scan_pass_exam += asize;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
|
|
|
/* if it's a resilver, this may not be in the target range */
|
2017-05-13 03:28:03 +03:00
|
|
|
if (!needs_io)
|
|
|
|
needs_io = dsl_scan_need_resilver(spa, dva, psize,
|
|
|
|
phys_birth);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
if (needs_io && !zfs_no_scrub_io) {
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_enqueue(dp, bp, zio_flags, zb);
|
|
|
|
} else {
|
Do not report bytes skipped by scan as issued.
Scan process may skip blocks based on their birth time, DVA, etc.
Traditionally those blocks were accounted as issued, that caused
reporting of hugely over-inflated numbers, having nothing to do
with actual disk I/O. This change utilizes never used field in
struct dsl_scan_phys to account such skipped bytes, allowing to
report how much data were actually scrubbed/resilvered and what
is the actual I/O speed. While formally it is an on-disk format
change, it should be compatible both ways, so should not need a
feature flag.
This should partially address the same issue as c85ac731a0e, but
from a different perspective, complementing it.
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Akash B <akash-b@hpe.com>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.
Closes #15007
2023-06-30 18:47:13 +03:00
|
|
|
count_block_skipped(scn, bp, B_TRUE);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* do not relocate this block */
|
|
|
|
return (0);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
dsl_scan_scrub_done(zio_t *zio)
|
|
|
|
{
|
|
|
|
spa_t *spa = zio->io_spa;
|
|
|
|
blkptr_t *bp = zio->io_bp;
|
|
|
|
dsl_scan_io_queue_t *queue = zio->io_private;
|
|
|
|
|
|
|
|
abd_free(zio->io_abd);
|
|
|
|
|
|
|
|
if (queue == NULL) {
|
|
|
|
mutex_enter(&spa->spa_scrub_lock);
|
|
|
|
ASSERT3U(spa->spa_scrub_inflight, >=, BP_GET_PSIZE(bp));
|
|
|
|
spa->spa_scrub_inflight -= BP_GET_PSIZE(bp);
|
|
|
|
cv_broadcast(&spa->spa_scrub_io_cv);
|
|
|
|
mutex_exit(&spa->spa_scrub_lock);
|
|
|
|
} else {
|
|
|
|
mutex_enter(&queue->q_vd->vdev_scan_io_queue_lock);
|
|
|
|
ASSERT3U(queue->q_inflight_bytes, >=, BP_GET_PSIZE(bp));
|
|
|
|
queue->q_inflight_bytes -= BP_GET_PSIZE(bp);
|
|
|
|
cv_broadcast(&queue->q_zio_cv);
|
|
|
|
mutex_exit(&queue->q_vd->vdev_scan_io_queue_lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (zio->io_error && (zio->io_error != ECKSUM ||
|
|
|
|
!(zio->io_flags & ZIO_FLAG_SPECULATIVE))) {
|
2021-12-17 23:35:28 +03:00
|
|
|
if (dsl_errorscrubbing(spa->spa_dsl_pool) &&
|
|
|
|
!dsl_errorscrub_is_paused(spa->spa_dsl_pool->dp_scan)) {
|
|
|
|
atomic_inc_64(&spa->spa_dsl_pool->dp_scan
|
|
|
|
->errorscrub_phys.dep_errors);
|
|
|
|
} else {
|
|
|
|
atomic_inc_64(&spa->spa_dsl_pool->dp_scan->scn_phys
|
|
|
|
.scn_errors);
|
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* Given a scanning zio's information, executes the zio. The zio need
|
|
|
|
* not necessarily be only sortable, this function simply executes the
|
|
|
|
* zio, no matter what it is. The optional queue argument allows the
|
|
|
|
* caller to specify that they want per top level vdev IO rate limiting
|
|
|
|
* instead of the legacy global limiting.
|
|
|
|
*/
|
|
|
|
static void
|
|
|
|
scan_exec_io(dsl_pool_t *dp, const blkptr_t *bp, int zio_flags,
|
|
|
|
const zbookmark_phys_t *zb, dsl_scan_io_queue_t *queue)
|
|
|
|
{
|
|
|
|
spa_t *spa = dp->dp_spa;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
size_t size = BP_GET_PSIZE(bp);
|
|
|
|
abd_t *data = abd_alloc_for_io(size, B_FALSE);
|
2022-06-16 00:25:08 +03:00
|
|
|
zio_t *pio;
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
if (queue == NULL) {
|
2021-05-27 19:11:39 +03:00
|
|
|
ASSERT3U(scn->scn_maxinflight_bytes, >, 0);
|
2010-05-29 00:45:14 +04:00
|
|
|
mutex_enter(&spa->spa_scrub_lock);
|
2017-11-16 04:27:01 +03:00
|
|
|
while (spa->spa_scrub_inflight >= scn->scn_maxinflight_bytes)
|
2010-05-29 00:45:14 +04:00
|
|
|
cv_wait(&spa->spa_scrub_io_cv, &spa->spa_scrub_lock);
|
2017-11-16 04:27:01 +03:00
|
|
|
spa->spa_scrub_inflight += BP_GET_PSIZE(bp);
|
2010-05-29 00:45:14 +04:00
|
|
|
mutex_exit(&spa->spa_scrub_lock);
|
2022-06-16 00:25:08 +03:00
|
|
|
pio = scn->scn_zio_root;
|
2017-11-16 04:27:01 +03:00
|
|
|
} else {
|
|
|
|
kmutex_t *q_lock = &queue->q_vd->vdev_scan_io_queue_lock;
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2021-05-27 19:11:39 +03:00
|
|
|
ASSERT3U(queue->q_maxinflight_bytes, >, 0);
|
2017-11-16 04:27:01 +03:00
|
|
|
mutex_enter(q_lock);
|
|
|
|
while (queue->q_inflight_bytes >= queue->q_maxinflight_bytes)
|
|
|
|
cv_wait(&queue->q_zio_cv, q_lock);
|
|
|
|
queue->q_inflight_bytes += BP_GET_PSIZE(bp);
|
2022-06-16 00:25:08 +03:00
|
|
|
pio = queue->q_zio;
|
2017-11-16 04:27:01 +03:00
|
|
|
mutex_exit(q_lock);
|
|
|
|
}
|
|
|
|
|
2022-06-16 00:25:08 +03:00
|
|
|
ASSERT(pio != NULL);
|
2022-06-28 21:23:31 +03:00
|
|
|
count_block_issued(spa, bp, queue == NULL);
|
2022-06-16 00:25:08 +03:00
|
|
|
zio_nowait(zio_read(pio, spa, bp, data, size, dsl_scan_scrub_done,
|
|
|
|
queue, ZIO_PRIORITY_SCRUB, zio_flags, zb));
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
2010-08-27 01:24:34 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* This is the primary extent sorting algorithm. We balance two parameters:
|
|
|
|
* 1) how many bytes of I/O are in an extent
|
|
|
|
* 2) how well the extent is filled with I/O (as a fraction of its total size)
|
|
|
|
* Since we allow extents to have gaps between their constituent I/Os, it's
|
|
|
|
* possible to have a fairly large extent that contains the same amount of
|
|
|
|
* I/O bytes than a much smaller extent, which just packs the I/O more tightly.
|
|
|
|
* The algorithm sorts based on a score calculated from the extent's size,
|
|
|
|
* the relative fill volume (in %) and a "fill weight" parameter that controls
|
|
|
|
* the split between whether we prefer larger extents or more well populated
|
|
|
|
* extents:
|
|
|
|
*
|
|
|
|
* SCORE = FILL_IN_BYTES + (FILL_IN_PERCENT * FILL_IN_BYTES * FILL_WEIGHT)
|
|
|
|
*
|
|
|
|
* Example:
|
|
|
|
* 1) assume extsz = 64 MiB
|
|
|
|
* 2) assume fill = 32 MiB (extent is half full)
|
|
|
|
* 3) assume fill_weight = 3
|
|
|
|
* 4) SCORE = 32M + (((32M * 100) / 64M) * 3 * 32M) / 100
|
|
|
|
* SCORE = 32M + (50 * 3 * 32M) / 100
|
|
|
|
* SCORE = 32M + (4800M / 100)
|
|
|
|
* SCORE = 32M + 48M
|
|
|
|
* ^ ^
|
|
|
|
* | +--- final total relative fill-based score
|
|
|
|
* +--------- final total fill-based score
|
|
|
|
* SCORE = 80M
|
|
|
|
*
|
|
|
|
* As can be seen, at fill_ratio=3, the algorithm is slightly biased towards
|
|
|
|
* extents that are more completely filled (in a 3:2 ratio) vs just larger.
|
|
|
|
* Note that as an optimization, we replace multiplication and division by
|
2019-09-03 03:56:41 +03:00
|
|
|
* 100 with bitshifting by 7 (which effectively multiplies and divides by 128).
|
2022-06-24 19:50:37 +03:00
|
|
|
*
|
|
|
|
* Since we do not care if one extent is only few percent better than another,
|
|
|
|
* compress the score into 6 bits via binary logarithm AKA highbit64() and
|
|
|
|
* put into otherwise unused due to ashift high bits of offset. This allows
|
|
|
|
* to reduce q_exts_by_size B-tree elements to only 64 bits and compare them
|
|
|
|
* with single operation. Plus it makes scrubs more sequential and reduces
|
|
|
|
* chances that minor extent change move it within the B-tree.
|
2017-11-16 04:27:01 +03:00
|
|
|
*/
|
2023-05-26 20:03:12 +03:00
|
|
|
__attribute__((always_inline)) inline
|
2017-11-16 04:27:01 +03:00
|
|
|
static int
|
|
|
|
ext_size_compare(const void *x, const void *y)
|
|
|
|
{
|
2022-06-24 19:50:37 +03:00
|
|
|
const uint64_t *a = x, *b = y;
|
|
|
|
|
|
|
|
return (TREE_CMP(*a, *b));
|
|
|
|
}
|
|
|
|
|
2023-05-26 20:03:12 +03:00
|
|
|
ZFS_BTREE_FIND_IN_BUF_FUNC(ext_size_find_in_buf, uint64_t,
|
|
|
|
ext_size_compare)
|
|
|
|
|
2022-06-24 19:50:37 +03:00
|
|
|
static void
|
|
|
|
ext_size_create(range_tree_t *rt, void *arg)
|
|
|
|
{
|
|
|
|
(void) rt;
|
|
|
|
zfs_btree_t *size_tree = arg;
|
Reduce loaded range tree memory usage
This patch implements a new tree structure for ZFS, and uses it to
store range trees more efficiently.
The new structure is approximately a B-tree, though there are some
small differences from the usual characterizations. The tree has core
nodes and leaf nodes; each contain data elements, which the elements
in the core nodes acting as separators between its children. The
difference between core and leaf nodes is that the core nodes have an
array of children, while leaf nodes don't. Every node in the tree may
be only partially full; in most cases, they are all at least 50% full
(in terms of element count) except for the root node, which can be
less full. Underfull nodes will steal from their neighbors or merge to
remain full enough, while overfull nodes will split in two. The data
elements are contained in tree-controlled buffers; they are copied
into these on insertion, and overwritten on deletion. This means that
the elements are not independently allocated, which reduces overhead,
but also means they can't be shared between trees (and also that
pointers to them are only valid until a side-effectful tree operation
occurs). The overhead varies based on how dense the tree is, but is
usually on the order of about 50% of the element size; the per-node
overheads are very small, and so don't make a significant difference.
The trees can accept arbitrary records; they accept a size and a
comparator to allow them to be used for a variety of purposes.
The new trees replace the AVL trees used in the range trees today.
Currently, the range_seg_t structure contains three 8 byte integers
of payload and two 24 byte avl_tree_node_ts to handle its storage in
both an offset-sorted tree and a size-sorted tree (total size: 64
bytes). In the new model, the range seg structures are usually two 4
byte integers, but a separate one needs to exist for the size-sorted
and offset-sorted tree. Between the raw size, the 50% overhead, and
the double storage, the new btrees are expected to use 8*1.5*2 = 24
bytes per record, or 33.3% as much memory as the AVL trees (this is
for the purposes of storing metaslab range trees; for other purposes,
like scrubs, they use ~50% as much memory).
We reduced the size of the payload in the range segments by teaching
range trees about starting offsets and shifts; since metaslabs have a
fixed starting offset, and they all operate in terms of disk sectors,
we can store the ranges using 4-byte integers as long as the size of
the metaslab divided by the sector size is less than 2^32. For 512-byte
sectors, this is a 2^41 (or 2TB) metaslab, which with the default
settings corresponds to a 256PB disk. 4k sector disks can handle
metaslabs up to 2^46 bytes, or 2^63 byte disks. Since we do not
anticipate disks of this size in the near future, there should be
almost no cases where metaslabs need 64-byte integers to store their
ranges. We do still have the capability to store 64-byte integer ranges
to account for cases where we are storing per-vdev (or per-dnode) trees,
which could reasonably go above the limits discussed. We also do not
store fill information in the compact version of the node, since it
is only used for sorted scrub.
We also optimized the metaslab loading process in various other ways
to offset some inefficiencies in the btree model. While individual
operations (find, insert, remove_from) are faster for the btree than
they are for the avl tree, remove usually requires a find operation,
while in the AVL tree model the element itself suffices. Some clever
changes actually caused an overall speedup in metaslab loading; we use
approximately 40% less cpu to load metaslabs in our tests on Illumos.
Another memory and performance optimization was achieved by changing
what is stored in the size-sorted trees. When a disk is heavily
fragmented, the df algorithm used by default in ZFS will almost always
find a number of small regions in its initial cursor-based search; it
will usually only fall back to the size-sorted tree to find larger
regions. If we increase the size of the cursor-based search slightly,
and don't store segments that are smaller than a tunable size floor
in the size-sorted tree, we can further cut memory usage down to
below 20% of what the AVL trees store. This also results in further
reductions in CPU time spent loading metaslabs.
The 16KiB size floor was chosen because it results in substantial memory
usage reduction while not usually resulting in situations where we can't
find an appropriate chunk with the cursor and are forced to use an
oversized chunk from the size-sorted tree. In addition, even if we do
have to use an oversized chunk from the size-sorted tree, the chunk
would be too small to use for ZIL allocations, so it isn't as big of a
loss as it might otherwise be. And often, more small allocations will
follow the initial one, and the cursor search will now find the
remainder of the chunk we didn't use all of and use it for subsequent
allocations. Practical testing has shown little or no change in
fragmentation as a result of this change.
If the size-sorted tree becomes empty while the offset sorted one still
has entries, it will load all the entries from the offset sorted tree
and disregard the size floor until it is unloaded again. This operation
occurs rarely with the default setting, only on incredibly thoroughly
fragmented pools.
There are some other small changes to zdb to teach it to handle btrees,
but nothing major.
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Sebastien Roy seb@delphix.com
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9181
2019-10-09 20:36:03 +03:00
|
|
|
|
2023-05-26 20:03:12 +03:00
|
|
|
zfs_btree_create(size_tree, ext_size_compare, ext_size_find_in_buf,
|
|
|
|
sizeof (uint64_t));
|
2022-06-24 19:50:37 +03:00
|
|
|
}
|
2017-11-16 04:27:01 +03:00
|
|
|
|
2022-06-24 19:50:37 +03:00
|
|
|
static void
|
|
|
|
ext_size_destroy(range_tree_t *rt, void *arg)
|
|
|
|
{
|
|
|
|
(void) rt;
|
|
|
|
zfs_btree_t *size_tree = arg;
|
|
|
|
ASSERT0(zfs_btree_numnodes(size_tree));
|
2017-11-16 04:27:01 +03:00
|
|
|
|
2022-06-24 19:50:37 +03:00
|
|
|
zfs_btree_destroy(size_tree);
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint64_t
|
|
|
|
ext_size_value(range_tree_t *rt, range_seg_gap_t *rsg)
|
|
|
|
{
|
|
|
|
(void) rt;
|
|
|
|
uint64_t size = rsg->rs_end - rsg->rs_start;
|
|
|
|
uint64_t score = rsg->rs_fill + ((((rsg->rs_fill << 7) / size) *
|
|
|
|
fill_weight * rsg->rs_fill) >> 7);
|
|
|
|
ASSERT3U(rt->rt_shift, >=, 8);
|
|
|
|
return (((uint64_t)(64 - highbit64(score)) << 56) | rsg->rs_start);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2022-06-24 19:50:37 +03:00
|
|
|
static void
|
|
|
|
ext_size_add(range_tree_t *rt, range_seg_t *rs, void *arg)
|
|
|
|
{
|
|
|
|
zfs_btree_t *size_tree = arg;
|
|
|
|
ASSERT3U(rt->rt_type, ==, RANGE_SEG_GAP);
|
|
|
|
uint64_t v = ext_size_value(rt, (range_seg_gap_t *)rs);
|
|
|
|
zfs_btree_add(size_tree, &v);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
ext_size_remove(range_tree_t *rt, range_seg_t *rs, void *arg)
|
|
|
|
{
|
|
|
|
zfs_btree_t *size_tree = arg;
|
|
|
|
ASSERT3U(rt->rt_type, ==, RANGE_SEG_GAP);
|
|
|
|
uint64_t v = ext_size_value(rt, (range_seg_gap_t *)rs);
|
|
|
|
zfs_btree_remove(size_tree, &v);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
ext_size_vacate(range_tree_t *rt, void *arg)
|
|
|
|
{
|
|
|
|
zfs_btree_t *size_tree = arg;
|
|
|
|
zfs_btree_clear(size_tree);
|
|
|
|
zfs_btree_destroy(size_tree);
|
|
|
|
|
|
|
|
ext_size_create(rt, arg);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const range_tree_ops_t ext_size_ops = {
|
|
|
|
.rtop_create = ext_size_create,
|
|
|
|
.rtop_destroy = ext_size_destroy,
|
|
|
|
.rtop_add = ext_size_add,
|
|
|
|
.rtop_remove = ext_size_remove,
|
|
|
|
.rtop_vacate = ext_size_vacate
|
|
|
|
};
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* Comparator for the q_sios_by_addr tree. Sorting is simply performed
|
|
|
|
* based on LBA-order (from lowest to highest).
|
|
|
|
*/
|
|
|
|
static int
|
|
|
|
sio_addr_compare(const void *x, const void *y)
|
|
|
|
{
|
|
|
|
const scan_io_t *a = x, *b = y;
|
|
|
|
|
Reduce loaded range tree memory usage
This patch implements a new tree structure for ZFS, and uses it to
store range trees more efficiently.
The new structure is approximately a B-tree, though there are some
small differences from the usual characterizations. The tree has core
nodes and leaf nodes; each contain data elements, which the elements
in the core nodes acting as separators between its children. The
difference between core and leaf nodes is that the core nodes have an
array of children, while leaf nodes don't. Every node in the tree may
be only partially full; in most cases, they are all at least 50% full
(in terms of element count) except for the root node, which can be
less full. Underfull nodes will steal from their neighbors or merge to
remain full enough, while overfull nodes will split in two. The data
elements are contained in tree-controlled buffers; they are copied
into these on insertion, and overwritten on deletion. This means that
the elements are not independently allocated, which reduces overhead,
but also means they can't be shared between trees (and also that
pointers to them are only valid until a side-effectful tree operation
occurs). The overhead varies based on how dense the tree is, but is
usually on the order of about 50% of the element size; the per-node
overheads are very small, and so don't make a significant difference.
The trees can accept arbitrary records; they accept a size and a
comparator to allow them to be used for a variety of purposes.
The new trees replace the AVL trees used in the range trees today.
Currently, the range_seg_t structure contains three 8 byte integers
of payload and two 24 byte avl_tree_node_ts to handle its storage in
both an offset-sorted tree and a size-sorted tree (total size: 64
bytes). In the new model, the range seg structures are usually two 4
byte integers, but a separate one needs to exist for the size-sorted
and offset-sorted tree. Between the raw size, the 50% overhead, and
the double storage, the new btrees are expected to use 8*1.5*2 = 24
bytes per record, or 33.3% as much memory as the AVL trees (this is
for the purposes of storing metaslab range trees; for other purposes,
like scrubs, they use ~50% as much memory).
We reduced the size of the payload in the range segments by teaching
range trees about starting offsets and shifts; since metaslabs have a
fixed starting offset, and they all operate in terms of disk sectors,
we can store the ranges using 4-byte integers as long as the size of
the metaslab divided by the sector size is less than 2^32. For 512-byte
sectors, this is a 2^41 (or 2TB) metaslab, which with the default
settings corresponds to a 256PB disk. 4k sector disks can handle
metaslabs up to 2^46 bytes, or 2^63 byte disks. Since we do not
anticipate disks of this size in the near future, there should be
almost no cases where metaslabs need 64-byte integers to store their
ranges. We do still have the capability to store 64-byte integer ranges
to account for cases where we are storing per-vdev (or per-dnode) trees,
which could reasonably go above the limits discussed. We also do not
store fill information in the compact version of the node, since it
is only used for sorted scrub.
We also optimized the metaslab loading process in various other ways
to offset some inefficiencies in the btree model. While individual
operations (find, insert, remove_from) are faster for the btree than
they are for the avl tree, remove usually requires a find operation,
while in the AVL tree model the element itself suffices. Some clever
changes actually caused an overall speedup in metaslab loading; we use
approximately 40% less cpu to load metaslabs in our tests on Illumos.
Another memory and performance optimization was achieved by changing
what is stored in the size-sorted trees. When a disk is heavily
fragmented, the df algorithm used by default in ZFS will almost always
find a number of small regions in its initial cursor-based search; it
will usually only fall back to the size-sorted tree to find larger
regions. If we increase the size of the cursor-based search slightly,
and don't store segments that are smaller than a tunable size floor
in the size-sorted tree, we can further cut memory usage down to
below 20% of what the AVL trees store. This also results in further
reductions in CPU time spent loading metaslabs.
The 16KiB size floor was chosen because it results in substantial memory
usage reduction while not usually resulting in situations where we can't
find an appropriate chunk with the cursor and are forced to use an
oversized chunk from the size-sorted tree. In addition, even if we do
have to use an oversized chunk from the size-sorted tree, the chunk
would be too small to use for ZIL allocations, so it isn't as big of a
loss as it might otherwise be. And often, more small allocations will
follow the initial one, and the cursor search will now find the
remainder of the chunk we didn't use all of and use it for subsequent
allocations. Practical testing has shown little or no change in
fragmentation as a result of this change.
If the size-sorted tree becomes empty while the offset sorted one still
has entries, it will load all the entries from the offset sorted tree
and disregard the size floor until it is unloaded again. This operation
occurs rarely with the default setting, only on incredibly thoroughly
fragmented pools.
There are some other small changes to zdb to teach it to handle btrees,
but nothing major.
Reviewed-by: George Wilson <gwilson@delphix.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed by: Sebastien Roy seb@delphix.com
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9181
2019-10-09 20:36:03 +03:00
|
|
|
return (TREE_CMP(SIO_GET_OFFSET(a), SIO_GET_OFFSET(b)));
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/* IO queues are created on demand when they are needed. */
|
|
|
|
static dsl_scan_io_queue_t *
|
|
|
|
scan_io_queue_create(vdev_t *vd)
|
|
|
|
{
|
|
|
|
dsl_scan_t *scn = vd->vdev_spa->spa_dsl_pool->dp_scan;
|
|
|
|
dsl_scan_io_queue_t *q = kmem_zalloc(sizeof (*q), KM_SLEEP);
|
|
|
|
|
|
|
|
q->q_scn = scn;
|
|
|
|
q->q_vd = vd;
|
2019-03-16 00:14:31 +03:00
|
|
|
q->q_sio_memused = 0;
|
2022-06-24 19:50:37 +03:00
|
|
|
q->q_last_ext_addr = -1;
|
2017-11-16 04:27:01 +03:00
|
|
|
cv_init(&q->q_zio_cv, NULL, CV_DEFAULT, NULL);
|
2022-06-24 19:50:37 +03:00
|
|
|
q->q_exts_by_addr = range_tree_create_gap(&ext_size_ops, RANGE_SEG_GAP,
|
|
|
|
&q->q_exts_by_size, 0, vd->vdev_ashift, zfs_scan_max_ext_gap);
|
2017-11-16 04:27:01 +03:00
|
|
|
avl_create(&q->q_sios_by_addr, sio_addr_compare,
|
|
|
|
sizeof (scan_io_t), offsetof(scan_io_t, sio_nodes.sio_addr_node));
|
|
|
|
|
|
|
|
return (q);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
|
|
|
|
2017-07-07 08:16:13 +03:00
|
|
|
/*
|
2017-11-16 04:27:01 +03:00
|
|
|
* Destroys a scan queue and all segments and scan_io_t's contained in it.
|
|
|
|
* No further execution of I/O occurs, anything pending in the queue is
|
|
|
|
* simply freed without being executed.
|
2017-07-07 08:16:13 +03:00
|
|
|
*/
|
2017-11-16 04:27:01 +03:00
|
|
|
void
|
|
|
|
dsl_scan_io_queue_destroy(dsl_scan_io_queue_t *queue)
|
2010-05-29 00:45:14 +04:00
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
dsl_scan_t *scn = queue->q_scn;
|
|
|
|
scan_io_t *sio;
|
|
|
|
void *cookie = NULL;
|
|
|
|
|
|
|
|
ASSERT(MUTEX_HELD(&queue->q_vd->vdev_scan_io_queue_lock));
|
|
|
|
|
2022-06-24 19:50:37 +03:00
|
|
|
if (!avl_is_empty(&queue->q_sios_by_addr))
|
|
|
|
atomic_add_64(&scn->scn_queues_pending, -1);
|
2017-11-16 04:27:01 +03:00
|
|
|
while ((sio = avl_destroy_nodes(&queue->q_sios_by_addr, &cookie)) !=
|
|
|
|
NULL) {
|
|
|
|
ASSERT(range_tree_contains(queue->q_exts_by_addr,
|
2019-03-16 00:14:31 +03:00
|
|
|
SIO_GET_OFFSET(sio), SIO_GET_ASIZE(sio)));
|
|
|
|
queue->q_sio_memused -= SIO_GET_MUSED(sio);
|
|
|
|
sio_free(sio);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2019-03-16 00:14:31 +03:00
|
|
|
ASSERT0(queue->q_sio_memused);
|
2017-11-16 04:27:01 +03:00
|
|
|
range_tree_vacate(queue->q_exts_by_addr, NULL, queue);
|
|
|
|
range_tree_destroy(queue->q_exts_by_addr);
|
|
|
|
avl_destroy(&queue->q_sios_by_addr);
|
|
|
|
cv_destroy(&queue->q_zio_cv);
|
2010-05-29 00:45:14 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
kmem_free(queue, sizeof (*queue));
|
|
|
|
}
|
2017-07-07 08:16:13 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* Properly transfers a dsl_scan_queue_t from `svd' to `tvd'. This is
|
|
|
|
* called on behalf of vdev_top_transfer when creating or destroying
|
|
|
|
* a mirror vdev due to zpool attach/detach.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
dsl_scan_io_queue_vdev_xfer(vdev_t *svd, vdev_t *tvd)
|
|
|
|
{
|
|
|
|
mutex_enter(&svd->vdev_scan_io_queue_lock);
|
|
|
|
mutex_enter(&tvd->vdev_scan_io_queue_lock);
|
|
|
|
|
|
|
|
VERIFY3P(tvd->vdev_scan_io_queue, ==, NULL);
|
|
|
|
tvd->vdev_scan_io_queue = svd->vdev_scan_io_queue;
|
|
|
|
svd->vdev_scan_io_queue = NULL;
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
if (tvd->vdev_scan_io_queue != NULL)
|
2017-11-16 04:27:01 +03:00
|
|
|
tvd->vdev_scan_io_queue->q_vd = tvd;
|
2017-07-07 08:16:13 +03:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
mutex_exit(&tvd->vdev_scan_io_queue_lock);
|
|
|
|
mutex_exit(&svd->vdev_scan_io_queue_lock);
|
2010-05-29 00:45:14 +04:00
|
|
|
}
|
2011-05-04 02:09:28 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static void
|
|
|
|
scan_io_queues_destroy(dsl_scan_t *scn)
|
2016-06-23 11:39:40 +03:00
|
|
|
{
|
2017-11-16 04:27:01 +03:00
|
|
|
vdev_t *rvd = scn->scn_dp->dp_spa->spa_root_vdev;
|
|
|
|
|
|
|
|
for (uint64_t i = 0; i < rvd->vdev_children; i++) {
|
|
|
|
vdev_t *tvd = rvd->vdev_child[i];
|
|
|
|
|
|
|
|
mutex_enter(&tvd->vdev_scan_io_queue_lock);
|
|
|
|
if (tvd->vdev_scan_io_queue != NULL)
|
|
|
|
dsl_scan_io_queue_destroy(tvd->vdev_scan_io_queue);
|
|
|
|
tvd->vdev_scan_io_queue = NULL;
|
|
|
|
mutex_exit(&tvd->vdev_scan_io_queue_lock);
|
|
|
|
}
|
2016-06-23 11:39:40 +03:00
|
|
|
}
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
static void
|
|
|
|
dsl_scan_freed_dva(spa_t *spa, const blkptr_t *bp, int dva_i)
|
|
|
|
{
|
|
|
|
dsl_pool_t *dp = spa->spa_dsl_pool;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
vdev_t *vdev;
|
|
|
|
kmutex_t *q_lock;
|
|
|
|
dsl_scan_io_queue_t *queue;
|
2019-03-16 00:14:31 +03:00
|
|
|
scan_io_t *srch_sio, *sio;
|
2017-11-16 04:27:01 +03:00
|
|
|
avl_index_t idx;
|
|
|
|
uint64_t start, size;
|
|
|
|
|
|
|
|
vdev = vdev_lookup_top(spa, DVA_GET_VDEV(&bp->blk_dva[dva_i]));
|
|
|
|
ASSERT(vdev != NULL);
|
|
|
|
q_lock = &vdev->vdev_scan_io_queue_lock;
|
|
|
|
queue = vdev->vdev_scan_io_queue;
|
|
|
|
|
|
|
|
mutex_enter(q_lock);
|
|
|
|
if (queue == NULL) {
|
|
|
|
mutex_exit(q_lock);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2019-03-16 00:14:31 +03:00
|
|
|
srch_sio = sio_alloc(BP_GET_NDVAS(bp));
|
|
|
|
bp2sio(bp, srch_sio, dva_i);
|
|
|
|
start = SIO_GET_OFFSET(srch_sio);
|
|
|
|
size = SIO_GET_ASIZE(srch_sio);
|
2017-11-16 04:27:01 +03:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We can find the zio in two states:
|
|
|
|
* 1) Cold, just sitting in the queue of zio's to be issued at
|
|
|
|
* some point in the future. In this case, all we do is
|
|
|
|
* remove the zio from the q_sios_by_addr tree, decrement
|
|
|
|
* its data volume from the containing range_seg_t and
|
|
|
|
* resort the q_exts_by_size tree to reflect that the
|
|
|
|
* range_seg_t has lost some of its 'fill'. We don't shorten
|
|
|
|
* the range_seg_t - this is usually rare enough not to be
|
|
|
|
* worth the extra hassle of trying keep track of precise
|
|
|
|
* extent boundaries.
|
|
|
|
* 2) Hot, where the zio is currently in-flight in
|
|
|
|
* dsl_scan_issue_ios. In this case, we can't simply
|
|
|
|
* reach in and stop the in-flight zio's, so we instead
|
|
|
|
* block the caller. Eventually, dsl_scan_issue_ios will
|
|
|
|
* be done with issuing the zio's it gathered and will
|
|
|
|
* signal us.
|
|
|
|
*/
|
2019-03-16 00:14:31 +03:00
|
|
|
sio = avl_find(&queue->q_sios_by_addr, srch_sio, &idx);
|
|
|
|
sio_free(srch_sio);
|
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
if (sio != NULL) {
|
|
|
|
blkptr_t tmpbp;
|
|
|
|
|
|
|
|
/* Got it while it was cold in the queue */
|
2019-03-16 00:14:31 +03:00
|
|
|
ASSERT3U(start, ==, SIO_GET_OFFSET(sio));
|
2022-06-24 19:50:37 +03:00
|
|
|
ASSERT3U(size, ==, SIO_GET_ASIZE(sio));
|
2017-11-16 04:27:01 +03:00
|
|
|
avl_remove(&queue->q_sios_by_addr, sio);
|
2022-06-24 19:50:37 +03:00
|
|
|
if (avl_is_empty(&queue->q_sios_by_addr))
|
|
|
|
atomic_add_64(&scn->scn_queues_pending, -1);
|
2019-03-16 00:14:31 +03:00
|
|
|
queue->q_sio_memused -= SIO_GET_MUSED(sio);
|
2011-05-04 02:09:28 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
ASSERT(range_tree_contains(queue->q_exts_by_addr, start, size));
|
|
|
|
range_tree_remove_fill(queue->q_exts_by_addr, start, size);
|
|
|
|
|
Do not report bytes skipped by scan as issued.
Scan process may skip blocks based on their birth time, DVA, etc.
Traditionally those blocks were accounted as issued, that caused
reporting of hugely over-inflated numbers, having nothing to do
with actual disk I/O. This change utilizes never used field in
struct dsl_scan_phys to account such skipped bytes, allowing to
report how much data were actually scrubbed/resilvered and what
is the actual I/O speed. While formally it is an on-disk format
change, it should be compatible both ways, so should not need a
feature flag.
This should partially address the same issue as c85ac731a0e, but
from a different perspective, complementing it.
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Akash B <akash-b@hpe.com>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.
Closes #15007
2023-06-30 18:47:13 +03:00
|
|
|
/* count the block as though we skipped it */
|
2019-03-16 00:14:31 +03:00
|
|
|
sio2bp(sio, &tmpbp);
|
Do not report bytes skipped by scan as issued.
Scan process may skip blocks based on their birth time, DVA, etc.
Traditionally those blocks were accounted as issued, that caused
reporting of hugely over-inflated numbers, having nothing to do
with actual disk I/O. This change utilizes never used field in
struct dsl_scan_phys to account such skipped bytes, allowing to
report how much data were actually scrubbed/resilvered and what
is the actual I/O speed. While formally it is an on-disk format
change, it should be compatible both ways, so should not need a
feature flag.
This should partially address the same issue as c85ac731a0e, but
from a different perspective, complementing it.
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Akash B <akash-b@hpe.com>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.
Closes #15007
2023-06-30 18:47:13 +03:00
|
|
|
count_block_skipped(scn, &tmpbp, B_FALSE);
|
2011-05-04 02:09:28 +04:00
|
|
|
|
2019-03-16 00:14:31 +03:00
|
|
|
sio_free(sio);
|
2017-11-16 04:27:01 +03:00
|
|
|
}
|
|
|
|
mutex_exit(q_lock);
|
|
|
|
}
|
2011-05-04 02:09:28 +04:00
|
|
|
|
2017-11-16 04:27:01 +03:00
|
|
|
/*
|
|
|
|
* Callback invoked when a zio_free() zio is executing. This needs to be
|
|
|
|
* intercepted to prevent the zio from deallocating a particular portion
|
|
|
|
* of disk space and it then getting reallocated and written to, while we
|
|
|
|
* still have it queued up for processing.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
dsl_scan_freed(spa_t *spa, const blkptr_t *bp)
|
|
|
|
{
|
|
|
|
dsl_pool_t *dp = spa->spa_dsl_pool;
|
|
|
|
dsl_scan_t *scn = dp->dp_scan;
|
|
|
|
|
|
|
|
ASSERT(!BP_IS_EMBEDDED(bp));
|
|
|
|
ASSERT(scn != NULL);
|
|
|
|
if (!dsl_scan_is_running(scn))
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (int i = 0; i < BP_GET_NDVAS(bp); i++)
|
|
|
|
dsl_scan_freed_dva(spa, bp, i);
|
|
|
|
}
|
|
|
|
|
2019-11-27 21:15:01 +03:00
|
|
|
/*
|
|
|
|
* Check if a vdev needs resilvering (non-empty DTL), if so, and resilver has
|
|
|
|
* not started, start it. Otherwise, only restart if max txg in DTL range is
|
|
|
|
* greater than the max txg in the current scan. If the DTL max is less than
|
|
|
|
* the scan max, then the vdev has not missed any new data since the resilver
|
|
|
|
* started, so a restart is not needed.
|
|
|
|
*/
|
|
|
|
void
|
|
|
|
dsl_scan_assess_vdev(dsl_pool_t *dp, vdev_t *vd)
|
|
|
|
{
|
|
|
|
uint64_t min, max;
|
|
|
|
|
|
|
|
if (!vdev_resilver_needed(vd, &min, &max))
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (!dsl_scan_resilvering(dp)) {
|
|
|
|
spa_async_request(dp->dp_spa, SPA_ASYNC_RESILVER);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (max <= dp->dp_scan->scn_phys.scn_max_txg)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* restart is needed, check if it can be deferred */
|
|
|
|
if (spa_feature_is_enabled(dp->dp_spa, SPA_FEATURE_RESILVER_DEFER))
|
|
|
|
vdev_defer_resilver(vd);
|
|
|
|
else
|
|
|
|
spa_async_request(dp->dp_spa, SPA_ASYNC_RESILVER);
|
|
|
|
}
|
|
|
|
|
Cleanup: 64-bit kernel module parameters should use fixed width types
Various module parameters such as `zfs_arc_max` were originally
`uint64_t` on OpenSolaris/Illumos, but were changed to `unsigned long`
for Linux compatibility because Linux's kernel default module parameter
implementation did not support 64-bit types on 32-bit platforms. This
caused problems when porting OpenZFS to Windows because its LLP64 memory
model made `unsigned long` a 32-bit type on 64-bit, which created the
undesireable situation that parameters that should accept 64-bit values
could not on 64-bit Windows.
Upon inspection, it turns out that the Linux kernel module parameter
interface is extensible, such that we are allowed to define our own
types. Rather than maintaining the original type change via hacks to to
continue shrinking module parameters on 32-bit Linux, we implement
support for 64-bit module parameters on Linux.
After doing a review of all 64-bit kernel parameters (found via the man
page and also proposed changes by Andrew Innes), the kernel module
parameters fell into a few groups:
Parameters that were originally 64-bit on Illumos:
* dbuf_cache_max_bytes
* dbuf_metadata_cache_max_bytes
* l2arc_feed_min_ms
* l2arc_feed_secs
* l2arc_headroom
* l2arc_headroom_boost
* l2arc_write_boost
* l2arc_write_max
* metaslab_aliquot
* metaslab_force_ganging
* zfetch_array_rd_sz
* zfs_arc_max
* zfs_arc_meta_limit
* zfs_arc_meta_min
* zfs_arc_min
* zfs_async_block_max_blocks
* zfs_condense_max_obsolete_bytes
* zfs_condense_min_mapping_bytes
* zfs_deadman_checktime_ms
* zfs_deadman_synctime_ms
* zfs_initialize_chunk_size
* zfs_initialize_value
* zfs_lua_max_instrlimit
* zfs_lua_max_memlimit
* zil_slog_bulk
Parameters that were originally 32-bit on Illumos:
* zfs_per_txg_dirty_frees_percent
Parameters that were originally `ssize_t` on Illumos:
* zfs_immediate_write_sz
Note that `ssize_t` is `int32_t` on 32-bit and `int64_t` on 64-bit. It
has been upgraded to 64-bit.
Parameters that were `long`/`unsigned long` because of Linux/FreeBSD
influence:
* l2arc_rebuild_blocks_min_l2size
* zfs_key_max_salt_uses
* zfs_max_log_walking
* zfs_max_logsm_summary_length
* zfs_metaslab_max_size_cache_sec
* zfs_min_metaslabs_to_flush
* zfs_multihost_interval
* zfs_unflushed_log_block_max
* zfs_unflushed_log_block_min
* zfs_unflushed_log_block_pct
* zfs_unflushed_max_mem_amt
* zfs_unflushed_max_mem_ppm
New parameters that do not exist in Illumos:
* l2arc_trim_ahead
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_arc_sys_free
* zfs_deadman_ziotime_ms
* zfs_delete_blocks
* zfs_history_output_max
* zfs_livelist_max_entries
* zfs_max_async_dedup_frees
* zfs_max_nvlist_src_size
* zfs_rebuild_max_segment
* zfs_rebuild_vdev_limit
* zfs_unflushed_log_txg_max
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
* zfs_vnops_read_chunk_size
* zvol_max_discard_blocks
Rather than clutter the lists with commentary, the module parameters
that need comments are repeated below.
A few parameters were defined in Linux/FreeBSD specific code, where the
use of ulong/long is not an issue for portability, so we leave them
alone:
* zfs_delete_blocks
* zfs_key_max_salt_uses
* zvol_max_discard_blocks
The documentation for a few parameters was found to be incorrect:
* zfs_deadman_checktime_ms - incorrectly documented as int
* zfs_delete_blocks - not documented as Linux only
* zfs_history_output_max - incorrectly documented as int
* zfs_vnops_read_chunk_size - incorrectly documented as long
* zvol_max_discard_blocks - incorrectly documented as ulong
The documentation for these has been fixed, alongside the changes to
document the switch to fixed width types.
In addition, several kernel module parameters were percentages or held
ashift values, so being 64-bit never made sense for them. They have been
downgraded to 32-bit:
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_per_txg_dirty_frees_percent
* zfs_unflushed_log_block_pct
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
Of special note are `zfs_vdev_max_auto_ashift` and
`zfs_vdev_min_auto_ashift`, which were already defined as `uint64_t`,
and passed to the kernel as `ulong`. This is inherently buggy on big
endian 32-bit Linux, since the values would not be written to the
correct locations. 32-bit FreeBSD was unaffected because its sysctl code
correctly treated this as a `uint64_t`.
Lastly, a code comment suggests that `zfs_arc_sys_free` is
Linux-specific, but there is nothing to indicate to me that it is
Linux-specific. Nothing was done about that.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Original-patch-by: Andrew Innes <andrew.c12@gmail.com>
Original-patch-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13984
Closes #14004
2022-10-03 22:06:54 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_vdev_limit, U64, ZMOD_RW,
|
2017-11-16 04:27:01 +03:00
|
|
|
"Max bytes in flight per leaf vdev for scrubs and resilvers");
|
|
|
|
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scrub_min_time_ms, UINT, ZMOD_RW,
|
2019-09-06 00:49:49 +03:00
|
|
|
"Min millisecs to scrub per txg");
|
2011-05-04 02:09:28 +04:00
|
|
|
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, obsolete_min_time_ms, UINT, ZMOD_RW,
|
2019-09-06 00:49:49 +03:00
|
|
|
"Min millisecs to obsolete per txg");
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, free_min_time_ms, UINT, ZMOD_RW,
|
2019-09-06 00:49:49 +03:00
|
|
|
"Min millisecs to free per txg");
|
2011-05-04 02:09:28 +04:00
|
|
|
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, resilver_min_time_ms, UINT, ZMOD_RW,
|
2019-09-06 00:49:49 +03:00
|
|
|
"Min millisecs to resilver per txg");
|
2011-05-04 02:09:28 +04:00
|
|
|
|
2019-09-06 00:49:49 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_suspend_progress, INT, ZMOD_RW,
|
2018-11-28 21:12:08 +03:00
|
|
|
"Set to prevent scans from progressing");
|
|
|
|
|
2019-09-06 00:49:49 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, no_scrub_io, INT, ZMOD_RW,
|
|
|
|
"Set to disable scrub I/O");
|
2011-05-04 02:09:28 +04:00
|
|
|
|
2019-09-06 00:49:49 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, no_scrub_prefetch, INT, ZMOD_RW,
|
|
|
|
"Set to disable scrub prefetching");
|
2014-09-07 19:06:08 +04:00
|
|
|
|
Cleanup: 64-bit kernel module parameters should use fixed width types
Various module parameters such as `zfs_arc_max` were originally
`uint64_t` on OpenSolaris/Illumos, but were changed to `unsigned long`
for Linux compatibility because Linux's kernel default module parameter
implementation did not support 64-bit types on 32-bit platforms. This
caused problems when porting OpenZFS to Windows because its LLP64 memory
model made `unsigned long` a 32-bit type on 64-bit, which created the
undesireable situation that parameters that should accept 64-bit values
could not on 64-bit Windows.
Upon inspection, it turns out that the Linux kernel module parameter
interface is extensible, such that we are allowed to define our own
types. Rather than maintaining the original type change via hacks to to
continue shrinking module parameters on 32-bit Linux, we implement
support for 64-bit module parameters on Linux.
After doing a review of all 64-bit kernel parameters (found via the man
page and also proposed changes by Andrew Innes), the kernel module
parameters fell into a few groups:
Parameters that were originally 64-bit on Illumos:
* dbuf_cache_max_bytes
* dbuf_metadata_cache_max_bytes
* l2arc_feed_min_ms
* l2arc_feed_secs
* l2arc_headroom
* l2arc_headroom_boost
* l2arc_write_boost
* l2arc_write_max
* metaslab_aliquot
* metaslab_force_ganging
* zfetch_array_rd_sz
* zfs_arc_max
* zfs_arc_meta_limit
* zfs_arc_meta_min
* zfs_arc_min
* zfs_async_block_max_blocks
* zfs_condense_max_obsolete_bytes
* zfs_condense_min_mapping_bytes
* zfs_deadman_checktime_ms
* zfs_deadman_synctime_ms
* zfs_initialize_chunk_size
* zfs_initialize_value
* zfs_lua_max_instrlimit
* zfs_lua_max_memlimit
* zil_slog_bulk
Parameters that were originally 32-bit on Illumos:
* zfs_per_txg_dirty_frees_percent
Parameters that were originally `ssize_t` on Illumos:
* zfs_immediate_write_sz
Note that `ssize_t` is `int32_t` on 32-bit and `int64_t` on 64-bit. It
has been upgraded to 64-bit.
Parameters that were `long`/`unsigned long` because of Linux/FreeBSD
influence:
* l2arc_rebuild_blocks_min_l2size
* zfs_key_max_salt_uses
* zfs_max_log_walking
* zfs_max_logsm_summary_length
* zfs_metaslab_max_size_cache_sec
* zfs_min_metaslabs_to_flush
* zfs_multihost_interval
* zfs_unflushed_log_block_max
* zfs_unflushed_log_block_min
* zfs_unflushed_log_block_pct
* zfs_unflushed_max_mem_amt
* zfs_unflushed_max_mem_ppm
New parameters that do not exist in Illumos:
* l2arc_trim_ahead
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_arc_sys_free
* zfs_deadman_ziotime_ms
* zfs_delete_blocks
* zfs_history_output_max
* zfs_livelist_max_entries
* zfs_max_async_dedup_frees
* zfs_max_nvlist_src_size
* zfs_rebuild_max_segment
* zfs_rebuild_vdev_limit
* zfs_unflushed_log_txg_max
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
* zfs_vnops_read_chunk_size
* zvol_max_discard_blocks
Rather than clutter the lists with commentary, the module parameters
that need comments are repeated below.
A few parameters were defined in Linux/FreeBSD specific code, where the
use of ulong/long is not an issue for portability, so we leave them
alone:
* zfs_delete_blocks
* zfs_key_max_salt_uses
* zvol_max_discard_blocks
The documentation for a few parameters was found to be incorrect:
* zfs_deadman_checktime_ms - incorrectly documented as int
* zfs_delete_blocks - not documented as Linux only
* zfs_history_output_max - incorrectly documented as int
* zfs_vnops_read_chunk_size - incorrectly documented as long
* zvol_max_discard_blocks - incorrectly documented as ulong
The documentation for these has been fixed, alongside the changes to
document the switch to fixed width types.
In addition, several kernel module parameters were percentages or held
ashift values, so being 64-bit never made sense for them. They have been
downgraded to 32-bit:
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_per_txg_dirty_frees_percent
* zfs_unflushed_log_block_pct
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
Of special note are `zfs_vdev_max_auto_ashift` and
`zfs_vdev_min_auto_ashift`, which were already defined as `uint64_t`,
and passed to the kernel as `ulong`. This is inherently buggy on big
endian 32-bit Linux, since the values would not be written to the
correct locations. 32-bit FreeBSD was unaffected because its sysctl code
correctly treated this as a `uint64_t`.
Lastly, a code comment suggests that `zfs_arc_sys_free` is
Linux-specific, but there is nothing to indicate to me that it is
Linux-specific. Nothing was done about that.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Original-patch-by: Andrew Innes <andrew.c12@gmail.com>
Original-patch-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13984
Closes #14004
2022-10-03 22:06:54 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, async_block_max_blocks, U64, ZMOD_RW,
|
OpenZFS 7614, 9064 - zfs device evacuation/removal
OpenZFS 7614 - zfs device evacuation/removal
OpenZFS 9064 - remove_mirror should wait for device removal to complete
This project allows top-level vdevs to be removed from the storage pool
with "zpool remove", reducing the total amount of storage in the pool.
This operation copies all allocated regions of the device to be removed
onto other devices, recording the mapping from old to new location.
After the removal is complete, read and free operations to the removed
(now "indirect") vdev must be remapped and performed at the new location
on disk. The indirect mapping table is kept in memory whenever the pool
is loaded, so there is minimal performance overhead when doing operations
on the indirect vdev.
The size of the in-memory mapping table will be reduced when its entries
become "obsolete" because they are no longer used by any block pointers
in the pool. An entry becomes obsolete when all the blocks that use
it are freed. An entry can also become obsolete when all the snapshots
that reference it are deleted, and the block pointers that reference it
have been "remapped" in all filesystems/zvols (and clones). Whenever an
indirect block is written, all the block pointers in it will be "remapped"
to their new (concrete) locations if possible. This process can be
accelerated by using the "zfs remap" command to proactively rewrite all
indirect blocks that reference indirect (removed) vdevs.
Note that when a device is removed, we do not verify the checksum of
the data that is copied. This makes the process much faster, but if it
were used on redundant vdevs (i.e. mirror or raidz vdevs), it would be
possible to copy the wrong data, when we have the correct data on e.g.
the other side of the mirror.
At the moment, only mirrors and simple top-level vdevs can be removed
and no removal is allowed if any of the top-level vdevs are raidz.
Porting Notes:
* Avoid zero-sized kmem_alloc() in vdev_compact_children().
The device evacuation code adds a dependency that
vdev_compact_children() be able to properly empty the vdev_child
array by setting it to NULL and zeroing vdev_children. Under Linux,
kmem_alloc() and related functions return a sentinel pointer rather
than NULL for zero-sized allocations.
* Remove comment regarding "mpt" driver where zfs_remove_max_segment
is initialized to SPA_MAXBLOCKSIZE.
Change zfs_condense_indirect_commit_entry_delay_ticks to
zfs_condense_indirect_commit_entry_delay_ms for consistency with
most other tunables in which delays are specified in ms.
* ZTS changes:
Use set_tunable rather than mdb
Use zpool sync as appropriate
Use sync_pool instead of sync
Kill jobs during test_removal_with_operation to allow unmount/export
Don't add non-disk names such as "mirror" or "raidz" to $DISKS
Use $TEST_BASE_DIR instead of /tmp
Increase HZ from 100 to 1000 which is more common on Linux
removal_multiple_indirection.ksh
Reduce iterations in order to not time out on the code
coverage builders.
removal_resume_export:
Functionally, the test case is correct but there exists a race
where the kernel thread hasn't been fully started yet and is
not visible. Wait for up to 1 second for the removal thread
to be started before giving up on it. Also, increase the
amount of data copied in order that the removal not finish
before the export has a chance to fail.
* MMP compatibility, the concept of concrete versus non-concrete devices
has slightly changed the semantics of vdev_writeable(). Update
mmp_random_leaf_impl() accordingly.
* Updated dbuf_remap() to handle the org.zfsonlinux:large_dnode pool
feature which is not supported by OpenZFS.
* Added support for new vdev removal tracepoints.
* Test cases removal_with_zdb and removal_condense_export have been
intentionally disabled. When run manually they pass as intended,
but when running in the automated test environment they produce
unreliable results on the latest Fedora release.
They may work better once the upstream pool import refectoring is
merged into ZoL at which point they will be re-enabled.
Authored by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Alex Reece <alex@delphix.com>
Reviewed-by: George Wilson <george.wilson@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Richard Laager <rlaager@wiktel.com>
Reviewed by: Tim Chase <tim@chase2k.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Garrett D'Amore <garrett@damore.org>
Ported-by: Tim Chase <tim@chase2k.com>
Signed-off-by: Tim Chase <tim@chase2k.com>
OpenZFS-issue: https://www.illumos.org/issues/7614
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/f539f1eb
Closes #6900
2016-09-22 19:30:13 +03:00
|
|
|
"Max number of blocks freed in one txg");
|
2016-01-23 03:41:02 +03:00
|
|
|
|
Cleanup: 64-bit kernel module parameters should use fixed width types
Various module parameters such as `zfs_arc_max` were originally
`uint64_t` on OpenSolaris/Illumos, but were changed to `unsigned long`
for Linux compatibility because Linux's kernel default module parameter
implementation did not support 64-bit types on 32-bit platforms. This
caused problems when porting OpenZFS to Windows because its LLP64 memory
model made `unsigned long` a 32-bit type on 64-bit, which created the
undesireable situation that parameters that should accept 64-bit values
could not on 64-bit Windows.
Upon inspection, it turns out that the Linux kernel module parameter
interface is extensible, such that we are allowed to define our own
types. Rather than maintaining the original type change via hacks to to
continue shrinking module parameters on 32-bit Linux, we implement
support for 64-bit module parameters on Linux.
After doing a review of all 64-bit kernel parameters (found via the man
page and also proposed changes by Andrew Innes), the kernel module
parameters fell into a few groups:
Parameters that were originally 64-bit on Illumos:
* dbuf_cache_max_bytes
* dbuf_metadata_cache_max_bytes
* l2arc_feed_min_ms
* l2arc_feed_secs
* l2arc_headroom
* l2arc_headroom_boost
* l2arc_write_boost
* l2arc_write_max
* metaslab_aliquot
* metaslab_force_ganging
* zfetch_array_rd_sz
* zfs_arc_max
* zfs_arc_meta_limit
* zfs_arc_meta_min
* zfs_arc_min
* zfs_async_block_max_blocks
* zfs_condense_max_obsolete_bytes
* zfs_condense_min_mapping_bytes
* zfs_deadman_checktime_ms
* zfs_deadman_synctime_ms
* zfs_initialize_chunk_size
* zfs_initialize_value
* zfs_lua_max_instrlimit
* zfs_lua_max_memlimit
* zil_slog_bulk
Parameters that were originally 32-bit on Illumos:
* zfs_per_txg_dirty_frees_percent
Parameters that were originally `ssize_t` on Illumos:
* zfs_immediate_write_sz
Note that `ssize_t` is `int32_t` on 32-bit and `int64_t` on 64-bit. It
has been upgraded to 64-bit.
Parameters that were `long`/`unsigned long` because of Linux/FreeBSD
influence:
* l2arc_rebuild_blocks_min_l2size
* zfs_key_max_salt_uses
* zfs_max_log_walking
* zfs_max_logsm_summary_length
* zfs_metaslab_max_size_cache_sec
* zfs_min_metaslabs_to_flush
* zfs_multihost_interval
* zfs_unflushed_log_block_max
* zfs_unflushed_log_block_min
* zfs_unflushed_log_block_pct
* zfs_unflushed_max_mem_amt
* zfs_unflushed_max_mem_ppm
New parameters that do not exist in Illumos:
* l2arc_trim_ahead
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_arc_sys_free
* zfs_deadman_ziotime_ms
* zfs_delete_blocks
* zfs_history_output_max
* zfs_livelist_max_entries
* zfs_max_async_dedup_frees
* zfs_max_nvlist_src_size
* zfs_rebuild_max_segment
* zfs_rebuild_vdev_limit
* zfs_unflushed_log_txg_max
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
* zfs_vnops_read_chunk_size
* zvol_max_discard_blocks
Rather than clutter the lists with commentary, the module parameters
that need comments are repeated below.
A few parameters were defined in Linux/FreeBSD specific code, where the
use of ulong/long is not an issue for portability, so we leave them
alone:
* zfs_delete_blocks
* zfs_key_max_salt_uses
* zvol_max_discard_blocks
The documentation for a few parameters was found to be incorrect:
* zfs_deadman_checktime_ms - incorrectly documented as int
* zfs_delete_blocks - not documented as Linux only
* zfs_history_output_max - incorrectly documented as int
* zfs_vnops_read_chunk_size - incorrectly documented as long
* zvol_max_discard_blocks - incorrectly documented as ulong
The documentation for these has been fixed, alongside the changes to
document the switch to fixed width types.
In addition, several kernel module parameters were percentages or held
ashift values, so being 64-bit never made sense for them. They have been
downgraded to 32-bit:
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_per_txg_dirty_frees_percent
* zfs_unflushed_log_block_pct
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
Of special note are `zfs_vdev_max_auto_ashift` and
`zfs_vdev_min_auto_ashift`, which were already defined as `uint64_t`,
and passed to the kernel as `ulong`. This is inherently buggy on big
endian 32-bit Linux, since the values would not be written to the
correct locations. 32-bit FreeBSD was unaffected because its sysctl code
correctly treated this as a `uint64_t`.
Lastly, a code comment suggests that `zfs_arc_sys_free` is
Linux-specific, but there is nothing to indicate to me that it is
Linux-specific. Nothing was done about that.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Original-patch-by: Andrew Innes <andrew.c12@gmail.com>
Original-patch-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13984
Closes #14004
2022-10-03 22:06:54 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, max_async_dedup_frees, U64, ZMOD_RW,
|
Remove limit on number of async zio_frees of non-dedup blocks
The module parameter zfs_async_block_max_blocks limits the number of
blocks that can be freed by the background freeing of filesystems and
snapshots (from "zfs destroy"), in one TXG. This is useful when freeing
dedup blocks, becuase each zio_free() of a dedup block can require an
i/o to read the relevant part of the dedup table (DDT), and will also
dirty that block.
zfs_async_block_max_blocks is set to 100,000 by default. For the more
typical case where dedup is not used, this can have a negative
performance impact on the rate of background freeing (from "zfs
destroy"). For example, with recordsize=8k, and TXG's syncing once
every 5 seconds, we can free only 160MB of data per second, which may be
much less than the rate we can write data.
This change increases zfs_async_block_max_blocks to be unlimited by
default. To address the dedup freeing issue, a new tunable is
introduced, zfs_max_async_dedup_frees, which limits the number of
zio_free()'s of dedup blocks done by background destroys, per txg. The
default is 100,000 free's (same as the old zfs_async_block_max_blocks
default).
Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #10000
2020-02-14 19:39:46 +03:00
|
|
|
"Max number of dedup blocks freed in one txg");
|
|
|
|
|
2019-09-06 00:49:49 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, free_bpobj_enabled, INT, ZMOD_RW,
|
|
|
|
"Enable processing of the free_bpobj");
|
2017-11-16 04:27:01 +03:00
|
|
|
|
2022-06-28 21:23:31 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_blkstats, INT, ZMOD_RW,
|
|
|
|
"Enable block statistics calculation during scrub");
|
|
|
|
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_mem_lim_fact, UINT, ZMOD_RW,
|
2019-09-06 00:49:49 +03:00
|
|
|
"Fraction of RAM for scan hard limit");
|
2017-11-16 04:27:01 +03:00
|
|
|
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_issue_strategy, UINT, ZMOD_RW,
|
2022-01-21 19:07:15 +03:00
|
|
|
"IO issuing strategy during scrubbing. 0 = default, 1 = LBA, 2 = size");
|
2017-11-16 04:27:01 +03:00
|
|
|
|
2019-09-06 00:49:49 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_legacy, INT, ZMOD_RW,
|
|
|
|
"Scrub using legacy non-sequential method");
|
2017-11-16 04:27:01 +03:00
|
|
|
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_checkpoint_intval, UINT, ZMOD_RW,
|
2017-11-16 04:27:01 +03:00
|
|
|
"Scan progress on-disk checkpointing interval");
|
|
|
|
|
Cleanup: 64-bit kernel module parameters should use fixed width types
Various module parameters such as `zfs_arc_max` were originally
`uint64_t` on OpenSolaris/Illumos, but were changed to `unsigned long`
for Linux compatibility because Linux's kernel default module parameter
implementation did not support 64-bit types on 32-bit platforms. This
caused problems when porting OpenZFS to Windows because its LLP64 memory
model made `unsigned long` a 32-bit type on 64-bit, which created the
undesireable situation that parameters that should accept 64-bit values
could not on 64-bit Windows.
Upon inspection, it turns out that the Linux kernel module parameter
interface is extensible, such that we are allowed to define our own
types. Rather than maintaining the original type change via hacks to to
continue shrinking module parameters on 32-bit Linux, we implement
support for 64-bit module parameters on Linux.
After doing a review of all 64-bit kernel parameters (found via the man
page and also proposed changes by Andrew Innes), the kernel module
parameters fell into a few groups:
Parameters that were originally 64-bit on Illumos:
* dbuf_cache_max_bytes
* dbuf_metadata_cache_max_bytes
* l2arc_feed_min_ms
* l2arc_feed_secs
* l2arc_headroom
* l2arc_headroom_boost
* l2arc_write_boost
* l2arc_write_max
* metaslab_aliquot
* metaslab_force_ganging
* zfetch_array_rd_sz
* zfs_arc_max
* zfs_arc_meta_limit
* zfs_arc_meta_min
* zfs_arc_min
* zfs_async_block_max_blocks
* zfs_condense_max_obsolete_bytes
* zfs_condense_min_mapping_bytes
* zfs_deadman_checktime_ms
* zfs_deadman_synctime_ms
* zfs_initialize_chunk_size
* zfs_initialize_value
* zfs_lua_max_instrlimit
* zfs_lua_max_memlimit
* zil_slog_bulk
Parameters that were originally 32-bit on Illumos:
* zfs_per_txg_dirty_frees_percent
Parameters that were originally `ssize_t` on Illumos:
* zfs_immediate_write_sz
Note that `ssize_t` is `int32_t` on 32-bit and `int64_t` on 64-bit. It
has been upgraded to 64-bit.
Parameters that were `long`/`unsigned long` because of Linux/FreeBSD
influence:
* l2arc_rebuild_blocks_min_l2size
* zfs_key_max_salt_uses
* zfs_max_log_walking
* zfs_max_logsm_summary_length
* zfs_metaslab_max_size_cache_sec
* zfs_min_metaslabs_to_flush
* zfs_multihost_interval
* zfs_unflushed_log_block_max
* zfs_unflushed_log_block_min
* zfs_unflushed_log_block_pct
* zfs_unflushed_max_mem_amt
* zfs_unflushed_max_mem_ppm
New parameters that do not exist in Illumos:
* l2arc_trim_ahead
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_arc_sys_free
* zfs_deadman_ziotime_ms
* zfs_delete_blocks
* zfs_history_output_max
* zfs_livelist_max_entries
* zfs_max_async_dedup_frees
* zfs_max_nvlist_src_size
* zfs_rebuild_max_segment
* zfs_rebuild_vdev_limit
* zfs_unflushed_log_txg_max
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
* zfs_vnops_read_chunk_size
* zvol_max_discard_blocks
Rather than clutter the lists with commentary, the module parameters
that need comments are repeated below.
A few parameters were defined in Linux/FreeBSD specific code, where the
use of ulong/long is not an issue for portability, so we leave them
alone:
* zfs_delete_blocks
* zfs_key_max_salt_uses
* zvol_max_discard_blocks
The documentation for a few parameters was found to be incorrect:
* zfs_deadman_checktime_ms - incorrectly documented as int
* zfs_delete_blocks - not documented as Linux only
* zfs_history_output_max - incorrectly documented as int
* zfs_vnops_read_chunk_size - incorrectly documented as long
* zvol_max_discard_blocks - incorrectly documented as ulong
The documentation for these has been fixed, alongside the changes to
document the switch to fixed width types.
In addition, several kernel module parameters were percentages or held
ashift values, so being 64-bit never made sense for them. They have been
downgraded to 32-bit:
* vdev_file_logical_ashift
* vdev_file_physical_ashift
* zfs_arc_dnode_limit_percent
* zfs_arc_dnode_reduce_percent
* zfs_arc_meta_limit_percent
* zfs_per_txg_dirty_frees_percent
* zfs_unflushed_log_block_pct
* zfs_vdev_max_auto_ashift
* zfs_vdev_min_auto_ashift
Of special note are `zfs_vdev_max_auto_ashift` and
`zfs_vdev_min_auto_ashift`, which were already defined as `uint64_t`,
and passed to the kernel as `ulong`. This is inherently buggy on big
endian 32-bit Linux, since the values would not be written to the
correct locations. 32-bit FreeBSD was unaffected because its sysctl code
correctly treated this as a `uint64_t`.
Lastly, a code comment suggests that `zfs_arc_sys_free` is
Linux-specific, but there is nothing to indicate to me that it is
Linux-specific. Nothing was done about that.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Jorgen Lundman <lundman@lundman.net>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Original-patch-by: Andrew Innes <andrew.c12@gmail.com>
Original-patch-by: Jorgen Lundman <lundman@lundman.net>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13984
Closes #14004
2022-10-03 22:06:54 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_max_ext_gap, U64, ZMOD_RW,
|
2018-01-30 02:05:03 +03:00
|
|
|
"Max gap in bytes between sequential scrub / resilver I/Os");
|
|
|
|
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_mem_lim_soft_fact, UINT, ZMOD_RW,
|
2017-11-16 04:27:01 +03:00
|
|
|
"Fraction of hard limit used as soft limit");
|
|
|
|
|
2019-09-06 00:49:49 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_strict_mem_lim, INT, ZMOD_RW,
|
2017-11-16 04:27:01 +03:00
|
|
|
"Tunable to attempt to reduce lock contention");
|
|
|
|
|
Cleanup: Specify unsignedness on things that should not be signed
In #13871, zfs_vdev_aggregation_limit_non_rotating and
zfs_vdev_aggregation_limit being signed was pointed out as a possible
reason not to eliminate an unnecessary MAX(unsigned, 0) since the
unsigned value was assigned from them.
There is no reason for these module parameters to be signed and upon
inspection, it was found that there are a number of other module
parameters that are signed, but should not be, so we make them unsigned.
Making them unsigned made it clear that some other variables in the code
should also be unsigned, so we also make those unsigned. This prevents
users from setting negative values that could potentially cause bad
behaviors. It also makes the code slightly easier to understand.
Mostly module parameters that deal with timeouts, limits, bitshifts and
percentages are made unsigned by this. Any that are boolean are left
signed, since whether booleans should be considered signed or unsigned
does not matter.
Making zfs_arc_lotsfree_percent unsigned caused a
`zfs_arc_lotsfree_percent >= 0` check to become redundant, so it was
removed. Removing the check was also necessary to prevent a compiler
error from -Werror=type-limits.
Several end of line comments had to be moved to their own lines because
replacing int with uint_t caused us to exceed the 80 character limit
enforced by cstyle.pl.
The following were kept signed because they are passed to
taskq_create(), which expects signed values and modifying the
OpenSolaris/Illumos DDI is out of scope of this patch:
* metaslab_load_pct
* zfs_sync_taskq_batch_pct
* zfs_zil_clean_taskq_nthr_pct
* zfs_zil_clean_taskq_minalloc
* zfs_zil_clean_taskq_maxalloc
* zfs_arc_prune_task_threads
Also, negative values in those parameters was found to be harmless.
The following were left signed because either negative values make
sense, or more analysis was needed to determine whether negative values
should be disallowed:
* zfs_metaslab_switch_threshold
* zfs_pd_bytes_max
* zfs_livelist_min_percent_shared
zfs_multihost_history was made static to be consistent with other
parameters.
A number of module parameters were marked as signed, but in reality
referenced unsigned variables. upgrade_errlog_limit is one of the
numerous examples. In the case of zfs_vdev_async_read_max_active, it was
already uint32_t, but zdb had an extern int declaration for it.
Interestingly, the documentation in zfs.4 was right for
upgrade_errlog_limit despite the module parameter being wrongly marked,
while the documentation for zfs_vdev_async_read_max_active (and friends)
was wrong. It was also wrong for zstd_abort_size, which was unsigned,
but was documented as signed.
Also, the documentation in zfs.4 incorrectly described the following
parameters as ulong when they were int:
* zfs_arc_meta_adjust_restarts
* zfs_override_estimate_recordsize
They are now uint_t as of this patch and thus the man page has been
updated to describe them as uint.
dbuf_state_index was left alone since it does nothing and perhaps should
be removed in another patch.
If any module parameters were missed, they were not found by `grep -r
'ZFS_MODULE_PARAM' | grep ', INT'`. I did find a few that grep missed,
but only because they were in files that had hits.
This patch intentionally did not attempt to address whether some of
these module parameters should be elevated to 64-bit parameters, because
the length of a long on 32-bit is 32-bit.
Lastly, it was pointed out during review that uint_t is a better match
for these variables than uint32_t because FreeBSD kernel parameter
definitions are designed for uint_t, whose bit width can change in
future memory models. As a result, we change the existing parameters
that are uint32_t to use uint_t.
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13875
2022-09-28 02:42:41 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_fill_weight, UINT, ZMOD_RW,
|
2017-11-16 04:27:01 +03:00
|
|
|
"Tunable to adjust bias towards more filled segments during scans");
|
2018-10-19 07:06:18 +03:00
|
|
|
|
2023-01-25 22:28:54 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scan_report_txgs, UINT, ZMOD_RW,
|
|
|
|
"Tunable to report resilver performance over the last N txgs");
|
|
|
|
|
2019-09-06 00:49:49 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, resilver_disable_defer, INT, ZMOD_RW,
|
2018-10-19 07:06:18 +03:00
|
|
|
"Process all resilvers immediately");
|
2021-12-17 23:35:28 +03:00
|
|
|
|
2023-05-26 19:53:00 +03:00
|
|
|
ZFS_MODULE_PARAM(zfs, zfs_, scrub_error_blocks_per_txg, UINT, ZMOD_RW,
|
2021-12-17 23:35:28 +03:00
|
|
|
"Error blocks to be scrubbed in one txg");
|
|
|
|
/* END CSTYLED */
|